Updates the job run details page to add the transfer counters information.

Updates the job run details page to add the transfer counters information. Moves the "Bandwith control" link to below the jobs.

[thobrla, 2018-04-13 23:09:51]

Do you have a screenshot I can look at?

https://codereview.appspot.com/344810043/diff/1/webconsole/frontend/src/app/j...
File
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html
(right):

https://codereview.appspot.com/344810043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:33:
<dd> {{ job.latestOperation.transferCounters.objectsCopiedToSink }} </dd>
objectsCopiedToSink is used repeatedly here and below to represent objects
failed to copy, directories found, and directories listed

[alanmorales, 2018-04-16 16:52:42]

PTAL


Screenshot:

https://screenshot.googleplex.com/HzRsAVqqEDx

[thobrla, 2018-04-16 18:21:43]

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
File
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html
(right):

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32:
<dt> Objects found on-premises: </dt>
I think we should call these files instead of objects, since they are files at
the source.

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32:
<dt> Objects found on-premises: </dt>
Suggest dropping "on-premises" here and below, files and directories should be
sufficiently descriptive

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32:
<dt> Objects found on-premises: </dt>
Nit: Since dirs come before files in our process, I think it makes sense to put
those counters at the top.

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:33:
<dd> {{ job.latestOperation.counters.objectsFoundFromSource }} </dd>
Super nit: I think: found, failed, succeeded

is a more intuitive order than found, succeeded, failed

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:34:
<dt> Objects copied to GCS: </dt>
Here and below , s/GCS/Google Cloud Storage/

[alanmorales, 2018-04-16 22:27:09]

Thanks for the review! PTAL

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
File
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html
(right):

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32:
<dt> Objects found on-premises: </dt>
On 2018/04/16 18:21:43, thobrla wrote:
> Suggest dropping "on-premises" here and below, files and directories should be
> sufficiently descriptive

Done.

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:33:
<dd> {{ job.latestOperation.counters.objectsFoundFromSource }} </dd>
On 2018/04/16 18:21:43, thobrla wrote:
> Super nit: I think: found, failed, succeeded
> 
> is a more intuitive order than found, succeeded, failed

Hahaha, do we give the bad news or good news first? I will leave succeeded first
for now, but open to change it.

https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:34:
<dt> Objects copied to GCS: </dt>
On 2018/04/16 18:21:43, thobrla wrote:
> Here and below , s/GCS/Google Cloud Storage/

Done.

[thobrla, 2018-04-16 22:36:37]

LGTM