Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1383)

Issue 344810043: Updates the job run details page to add the transfer counters information. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by alanmorales
Modified:
3 months ago
Reviewers:
thobrla
CC:
opi-crs_google.com
Visibility:
Public.

Description

Updates the job run details page to add the transfer counters information. Moves the "Bandwith control" link to below the jobs.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed CL, now ready for proper review. #

Total comments: 8

Patch Set 3 : Addressed patch 2 comments. #

Messages

Total messages: 6
alanmorales
3 months ago (2018-04-13 23:06:35 UTC) #1
thobrla
Do you have a screenshot I can look at? https://codereview.appspot.com/344810043/diff/1/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html File webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html (right): https://codereview.appspot.com/344810043/diff/1/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html#newcode33 webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:33: ...
3 months ago (2018-04-13 23:09:51 UTC) #2
alanmorales
PTAL Screenshot: https://screenshot.googleplex.com/HzRsAVqqEDx
3 months ago (2018-04-16 16:52:42 UTC) #3
thobrla
https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html File webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html (right): https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html#newcode32 webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32: <dt> Objects found on-premises: </dt> I think we should ...
3 months ago (2018-04-16 18:21:43 UTC) #4
alanmorales
Thanks for the review! PTAL https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html File webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html (right): https://codereview.appspot.com/344810043/diff/20001/webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html#newcode32 webconsole/frontend/src/app/jobs/job-run-details/job-run-details.component.html:32: <dt> Objects found on-premises: ...
3 months ago (2018-04-16 22:27:09 UTC) #5
thobrla
3 months ago (2018-04-16 22:36:37 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b