Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1228)

Issue 344770043: Let \tweak on event chords manipulate its elements

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by dak
Modified:
3 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let \tweak on event chords manipulate its elements This makes \tweak on event chords actually get heeded and creates reasonably predictable behavior by tweaking the rhythmic elements (but not chord-wide articulations). It also passes tweaks transparently through music wrapper expressions (like transpositions, context changes and other). To achieve this, it creates and uses a get-tweakable-music function that will deliver a list of primary music expressions tweaks should be applied to. This function is also used in the definition of \once to decide when a warning for misapplication of \once might be called for. Also contains commits: Refactor \once Separates the warning action of \once and its effect on overrides in order to reduce the number of surprises. Let \single use \tweak internally This is less efficient than directly manipulating the @samp{tweaks} property but closer follows the semantics of @code{\tweak}, facilitating extensions to it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -46 lines) Patch
M ly/music-functions-init.ly View 3 chunks +52 lines, -46 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1
thomasmorley651
3 months ago (2018-04-12 21:04:28 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b