ticket:13766: Make UnicodeMapTest#TestUnicodeMapGeneralCategory smaller.

ticket:13766: Make UnicodeMapTest#TestUnicodeMapGeneralCategory smaller.

There are 0x10FFFF code points and this test allocates memory for every
code point tested. Testing every single one of them is therefore memory
intensive and slow, without adding any real value to the test.

Instead an equivalent test coverage can be achieved by testing a much
smaller set of ranges of code points that cover all categories.

[roubert (google), 2018-06-18 17:12:25]

Do these ranges seem reasonable to you, or  can you suggest improvements?

[mark.edward.davis, 2018-06-21 15:02:54]

Code looks good. Just a few refinements to catch certain other characters.

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
File
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java
(right):

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java:365:
cp = 0xD7A3;              // Hangul Syllable, Last.
suggest D700

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java:366:
} else if (cp == 0xFFFF) {    // End of Plane 0.
Suggest:
08FF => D700 // round down
100FF => 1F000 // to pick up a few just above 10000
200FF => 10FF00 // to pick up a few just above 20000
10FFFF => break

[roubert (google), 2018-06-21 18:42:31]

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
File
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java
(right):

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java:365:
cp = 0xD7A3;              // Hangul Syllable, Last.
On 2018/06/21 15:02:54, mark.edward.davis wrote:
> suggest D700

Done.

https://codereview.appspot.com/344030043/diff/1/icu4j/main/tests/translit/src...
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java:366:
} else if (cp == 0xFFFF) {    // End of Plane 0.
On 2018/06/21 15:02:54, mark.edward.davis wrote:
> Suggest:
> 08FF => D700 // round down
> 100FF => 1F000 // to pick up a few just above 10000
> 200FF => 10FF00 // to pick up a few just above 20000
> 10FFFF => break

Done.

[mark.edward.davis, 2018-06-21 18:46:06]

LTGM