Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1100)

Issue 343460043: Add glog log_dir creation to agentmain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by thobrla
Modified:
5 years ago
Reviewers:
akaiser
CC:
opt-crs_google.com
Visibility:
Public.

Description

Add glog log_dir creation to agentmain

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment fixes (with rebase accidentally mixed in) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M agent/agentmain/agentmain.go View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3
thobrla
PTAL
5 years, 4 months ago (2018-11-21 18:22:24 UTC) #1
akaiser
LGTM https://codereview.appspot.com/343460043/diff/1/agent/agentmain/agentmain.go File agent/agentmain/agentmain.go (right): https://codereview.appspot.com/343460043/diff/1/agent/agentmain/agentmain.go#newcode113 agent/agentmain/agentmain.go:113: // getAndCreateLogDirIfNeeded returns the value of the directory ...
5 years, 4 months ago (2018-11-21 18:34:45 UTC) #2
thobrla
5 years, 4 months ago (2018-11-21 18:59:24 UTC) #3
https://codereview.appspot.com/343460043/diff/1/agent/agentmain/agentmain.go
File agent/agentmain/agentmain.go (right):

https://codereview.appspot.com/343460043/diff/1/agent/agentmain/agentmain.go#...
agent/agentmain/agentmain.go:113: // getAndCreateLogDirIfNeeded returns the
value of the directory
On 2018/11/21 18:34:45, akaiser wrote:
> This comment wrapping seems a bit tight (less than 70 chars?).

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b