Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 343170043: Renaming numparse_unisets.h to static_unicode_sets.h and refactoring to guarantee safety in no-data… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by sffc
Modified:
6 days, 10 hours ago
Reviewers:
markus.icu
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13697 Renaming numparse_unisets.h to static_unicode_sets.h and refactoring to guarantee safety in no-data builds.

Patch Set 1 #

Patch Set 2 : More file renaming and porting emptyness test to Java. #

Total comments: 12

Patch Set 3 : Replying to Markus feedback. #

Patch Set 4 : Fixing APIdocs. #

Total comments: 8

Patch Set 5 : Replying to Markus feedback round2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -769 lines) Patch
M icu4c/source/common/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/common/common.vcxproj View 2 chunks +2 lines, -2 lines 0 comments Download
M icu4c/source/common/common.vcxproj.filters View 2 chunks +2 lines, -2 lines 0 comments Download
M icu4c/source/common/common_uwp.vcxproj View 2 chunks +2 lines, -2 lines 0 comments Download
D icu4c/source/common/numparse_unisets.h View 1 chunk +0 lines, -94 lines 0 comments Download
D icu4c/source/common/numparse_unisets.cpp View 1 chunk +0 lines, -203 lines 0 comments Download
A + icu4c/source/common/static_unicode_sets.h View 1 2 3 3 chunks +39 lines, -12 lines 0 comments Download
A + icu4c/source/common/static_unicode_sets.cpp View 1 2 3 4 9 chunks +40 lines, -19 lines 0 comments Download
M icu4c/source/common/ucurr.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M icu4c/source/i18n/numparse_decimal.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M icu4c/source/i18n/numparse_impl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_scientific.cpp View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_validators.h View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_validators.cpp View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/scientificnumberformatter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/test/intltest/Makefile.in View 1 1 chunk +3 lines, -2 lines 0 comments Download
M icu4c/source/test/intltest/intltest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M icu4c/source/test/intltest/intltest.cpp View 2 chunks +10 lines, -6 lines 0 comments Download
M icu4c/source/test/intltest/intltest.vcxproj View 1 2 chunks +2 lines, -2 lines 0 comments Download
M icu4c/source/test/intltest/intltest.vcxproj.filters View 1 2 chunks +3 lines, -3 lines 0 comments Download
M icu4c/source/test/intltest/itutil.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download
M icu4c/source/test/intltest/numbertest.h View 1 2 chunks +2 lines, -16 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_parse.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_unisets.cpp View 1 1 chunk +0 lines, -91 lines 0 comments Download
A + icu4c/source/test/intltest/static_unisets_test.cpp View 1 3 chunks +37 lines, -7 lines 0 comments Download
A + icu4j/main/classes/core/src/com/ibm/icu/impl/StaticUnicodeSets.java View 4 chunks +48 lines, -12 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/DecimalMatcher.java View 3 chunks +6 lines, -5 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/IgnorablesMatcher.java View 2 chunks +3 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/InfinityMatcher.java View 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/MinusSignMatcher.java View 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PercentMatcher.java View 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PermilleMatcher.java View 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/PlusSignMatcher.java View 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ScientificMatcher.java View 2 chunks +3 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/SymbolMatcher.java View 2 chunks +3 lines, -2 lines 0 comments Download
D icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/UnicodeSetStaticCache.java View 1 chunk +0 lines, -223 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/ScientificNumberFormatter.java View 3 chunks +3 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java View 2 chunks +3 lines, -3 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/UnicodeSetStaticCacheTest.java View 1 1 chunk +0 lines, -26 lines 0 comments Download
A + icu4j/main/tests/core/src/com/ibm/icu/dev/test/util/StaticUnicodeSetsTest.java View 1 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 13
sffc
More file renaming and porting emptyness test to Java.
1 week, 1 day ago (2018-05-15 03:11:37 UTC) #1
sffc
1 week, 1 day ago (2018-05-15 03:15:03 UTC) #2
markus.icu
https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp File icu4c/source/common/static_unicode_sets.cpp (right): https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp#newcode28 icu4c/source/common/static_unicode_sets.cpp:28: // Save the empty instance in static memory to ...
1 week ago (2018-05-15 21:32:50 UTC) #3
markus.icu
Looking at the ticket comment now. I commented on the assertions assuming that you still ...
1 week ago (2018-05-15 21:34:56 UTC) #4
sffc
Replying to Markus feedback.
1 week ago (2018-05-15 21:53:30 UTC) #5
sffc
Fixing APIdocs.
1 week ago (2018-05-15 21:54:23 UTC) #6
sffc
https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp File icu4c/source/common/static_unicode_sets.cpp (right): https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp#newcode28 icu4c/source/common/static_unicode_sets.cpp:28: // Save the empty instance in static memory to ...
1 week ago (2018-05-15 21:56:00 UTC) #7
sffc
https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp File icu4c/source/common/static_unicode_sets.cpp (right): https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp#newcode28 icu4c/source/common/static_unicode_sets.cpp:28: // Save the empty instance in static memory to ...
1 week ago (2018-05-15 22:05:17 UTC) #8
markus.icu
On 2018/05/15 22:05:17, sffc wrote: > I missed the comment about UAlignedMemory. Do I just ...
1 week ago (2018-05-16 02:25:35 UTC) #9
markus.icu
https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp File icu4c/source/common/static_unicode_sets.cpp (right): https://codereview.appspot.com/343170043/diff/20001/icu4c/source/common/static_unicode_sets.cpp#newcode28 icu4c/source/common/static_unicode_sets.cpp:28: // Save the empty instance in static memory to ...
1 week ago (2018-05-16 02:36:34 UTC) #10
sffc
https://codereview.appspot.com/343170043/diff/60001/icu4c/source/common/static_unicode_sets.cpp File icu4c/source/common/static_unicode_sets.cpp (right): https://codereview.appspot.com/343170043/diff/60001/icu4c/source/common/static_unicode_sets.cpp#newcode122 icu4c/source/common/static_unicode_sets.cpp:122: gEmptyUnicodeSetInitialized = false; On 2018/05/16 02:36:34, markus.icu wrote: > ...
6 days, 10 hours ago (2018-05-16 22:05:45 UTC) #11
sffc
Replying to Markus feedback round2
6 days, 10 hours ago (2018-05-16 22:05:45 UTC) #12
markus.icu
6 days, 10 hours ago (2018-05-16 22:26:51 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b