Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(757)

Issue 342230043: Extending UI to show Agents

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by jamaalbwells
Modified:
4 months ago
CC:
opi-crs_google.com
Visibility:
Public.

Description

Extending UI to show Agents

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing First Round of Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -2 lines) Patch
M webconsole/frontend/src/app/app-routing.module.ts View 2 chunks +5 lines, -0 lines 0 comments Download
M webconsole/frontend/src/app/app.component.html View 1 chunk +6 lines, -1 line 0 comments Download
M webconsole/frontend/src/app/app.module.ts View 1 chunk +3 lines, -1 line 0 comments Download
A + webconsole/frontend/src/app/pulse/pulse.component.css View 1 1 chunk +1 line, -0 lines 0 comments Download
A webconsole/frontend/src/app/pulse/pulse.component.html View 1 1 chunk +47 lines, -0 lines 0 comments Download
A webconsole/frontend/src/app/pulse/pulse.component.ts View 1 1 chunk +85 lines, -0 lines 0 comments Download
A webconsole/frontend/src/app/pulse/pulse.component.spec.ts View 1 1 chunk +63 lines, -0 lines 0 comments Download
A webconsole/frontend/src/app/pulse/pulse.resources.ts View 1 1 chunk +40 lines, -0 lines 0 comments Download
A webconsole/frontend/src/app/pulse/pulse.service.ts View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jamaalbwells
4 months ago (2018-08-08 00:42:45 UTC) #1
thobrla
https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.ts File webconsole/frontend/src/app/pulse/pulse.component.ts (right): https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.ts#newcode28 webconsole/frontend/src/app/pulse/pulse.component.ts:28: Unnecessary whitespace here, is there an autoformatter you can ...
4 months ago (2018-08-08 00:46:12 UTC) #2
alanmorales
Do you have a screenshot? https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.html File webconsole/frontend/src/app/pulse/pulse.component.html (right): https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.html#newcode37 webconsole/frontend/src/app/pulse/pulse.component.html:37: {{ agent.lastPulseReceived }} Why ...
4 months ago (2018-08-08 01:05:19 UTC) #3
jamaalbwells
https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.html File webconsole/frontend/src/app/pulse/pulse.component.html (right): https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/pulse/pulse.component.html#newcode37 webconsole/frontend/src/app/pulse/pulse.component.html:37: {{ agent.lastPulseReceived }} On 2018/08/08 01:05:19, alanmorales wrote: > ...
4 months ago (2018-08-09 16:23:46 UTC) #4
alanmorales
4 months ago (2018-08-09 17:31:35 UTC) #5
https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/p...
File webconsole/frontend/src/app/pulse/pulse.component.html (right):

https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/p...
webconsole/frontend/src/app/pulse/pulse.component.html:37: {{
agent.lastPulseReceived }}
On 2018/08/09 16:23:46, jamaalbwells wrote:
> On 2018/08/08 01:05:19, alanmorales wrote:
> > Why not display the local time instead?
> 
> The end user could be running agents in databases across time zones. UTC will
> bypass confusion by establishing a uniform time zone for every pulse message. 

Sounds good!

https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/p...
File webconsole/frontend/src/app/pulse/pulse.component.ts (right):

https://codereview.appspot.com/342230043/diff/1/webconsole/frontend/src/app/p...
webconsole/frontend/src/app/pulse/pulse.component.ts:28: 
On 2018/08/09 16:23:46, jamaalbwells wrote:
> On 2018/08/08 00:46:12, thobrla wrote:
> > Unnecessary whitespace here, is there an autoformatter you can run?
> 
> I ran the 'Make Clean' build option sublime has, it seemed to fix some things
> but I still had to format imports and spacing.

ng lint --fix will automatically format the files in your angular project
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b