Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 342170043: Issue 5350: Avoid unnecessary copying of Paper_score vectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Dan Eble
Modified:
5 years, 9 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5350/

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M lily/axis-group-interface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/constrained-breaking.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M lily/include/paper-score.hh View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/paper-book.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/paper-score.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/spacing-determine-loose-columns.cc View 1 chunk +1 line, -1 line 1 comment Download
M lily/system.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6
dak
https://codereview.appspot.com/342170043/diff/1/lily/spacing-determine-loose-columns.cc File lily/spacing-determine-loose-columns.cc (right): https://codereview.appspot.com/342170043/diff/1/lily/spacing-determine-loose-columns.cc#newcode255 lily/spacing-determine-loose-columns.cc:255: cols->swap(newcols); Does this actually generate better code when optimizing?
5 years, 9 months ago (2018-06-19 06:32:55 UTC) #1
Dan Eble
On 2018/06/19 06:32:55, dak wrote: > https://codereview.appspot.com/342170043/diff/1/lily/spacing-determine-loose-columns.cc > File lily/spacing-determine-loose-columns.cc (right): > > https://codereview.appspot.com/342170043/diff/1/lily/spacing-determine-loose-columns.cc#newcode255 > ...
5 years, 9 months ago (2018-06-19 11:37:46 UTC) #2
dak
On 2018/06/19 11:37:46, Dan Eble wrote: > On 2018/06/19 06:32:55, dak wrote: > > > ...
5 years, 9 months ago (2018-06-19 12:51:46 UTC) #3
Dan Eble
On 2018/06/19 12:51:46, dak wrote: > If you are interested in solving this mystery, be ...
5 years, 9 months ago (2018-06-19 22:05:24 UTC) #4
dak
On 2018/06/19 22:05:24, Dan Eble wrote: > On 2018/06/19 12:51:46, dak wrote: > > If ...
5 years, 9 months ago (2018-06-19 23:05:18 UTC) #5
Dan Eble
5 years, 9 months ago (2018-06-19 23:35:52 UTC) #6
On 2018/06/19 23:05:18, dak wrote:
> Well, don't bother with the swap, it will just cause a merge conflict with
issue
> 5351...

OK, I've reverted it locally.  I won't update this review unless someone asks
for it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b