Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(861)

Unified Diff: src/core/model/traced-value.h

Issue 342120043: New patch for core module changes (Closed)
Patch Set: Updated core patch Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/model/traced-value.h
===================================================================
--- a/src/core/model/traced-value.h
+++ b/src/core/model/traced-value.h
@@ -148,6 +148,11 @@
* \tparam U \deduced The underlying type of the other TracedValue.
* \param [in] other The other TracedValuet to copy.
*/
+#ifdef _WIN32
+#pragma warning(push)
+// warning C4244: 'initializing': conversion from 'int32_t' to xxx, possible loss of data
+#pragma warning(disable : 4244)
+#endif
template <typename U>
TracedValue (const TracedValue<U> &other)
: m_v (other.Get ())
Peter Barnes 2018/05/23 19:45:41 Should this be instead : m_v ( (T)other.Get ()
ammo6818-vandals.uidaho.edu 2018/06/01 05:16:24 Added (T) and removed the #pragma. Good catch!!
@@ -161,6 +166,9 @@
TracedValue (const U &other)
: m_v ((T)other)
{}
+#ifdef _WIN32
+#pragma warning(pop)
+#endif
/**
* Connect a Callback (without context.)
*

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b