Issue 341980043: ticket:13135 Fixing and optimizing PluralFormat call site into NumberFormat in order to execute the…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by sffc

Modified:
5 years, 12 months ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat4/

Visibility:
Public.

ticket:13135 Fixing and optimizing PluralFormat call site into NumberFormat in order to execute the formatting pipeline only once.

Total comments: 3

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -52 lines)			Patch
M	icu4c/source/i18n/fmtable.cpp	View	2 chunks	+29 lines, -22 lines	1 comment	Download
M	icu4c/source/i18n/plurfmt.cpp	View	2 chunks	+21 lines, -20 lines	1 comment	Download
M	icu4c/source/i18n/unicode/fmtable.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/plurfmts.cpp	View	3 chunks	+7 lines, -4 lines	1 comment	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity_DualStorageBCD.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/text/NumberFormat.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/text/PluralFormat.java	View	2 chunks	+19 lines, -6 lines	0 comments	Download

Total messages: 3

sffc

Context: PluralFormat was previously calling the number formatting pipeline twice, once to get the string ...

6 years ago (2018-04-17 10:17:19 UTC) #2

LGTM