Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1741)

Issue 341450043: Issue 5324: \abs-fontsize and set-global-staff-size in books

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by Be-3
Modified:
10 months, 1 week ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5324: \abs-fontsize and set-global-staff-size in books The font buffering hashtable will provide an outdated LilyPond scale factor after changing global staff size between books. Mainly \abs-fontsize concerned, because \fontsize will usually not match a Pango font-size used in a differently scaled book and fresh fonts will have to be loaded anyway. The straight-forward solution is to simply apply #ly:restet-all-fonts from within #set-global-staff-size.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correction of single-word sentence in regtest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
A input/regression/book-change-global-staffsize-abs-fonts.ly View 1 1 chunk +37 lines, -0 lines 0 comments Download
M scm/paper.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
dak
Does not help with the other problems we had with fontsize mismatches (out of multiple ...
10 months, 2 weeks ago (2018-08-13 12:17:29 UTC) #1
Be-3
On 2018/08/13 12:17:29, dak wrote: > Does not help with the other problems we had ...
10 months, 2 weeks ago (2018-08-13 12:58:34 UTC) #2
lemzwerg
LGTM, thanks! https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly File input/regression/book-change-global-staffsize-abs-fonts.ly (right): https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly#newcode6 input/regression/book-change-global-staffsize-abs-fonts.ly:6: @code{\\abs-fontsize}. A single-word sentence looks strange...
10 months, 2 weeks ago (2018-08-13 16:21:10 UTC) #3
Be-3
On 2018/08/13 16:21:10, lemzwerg wrote: > LGTM, thanks! > > https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly > File input/regression/book-change-global-staffsize-abs-fonts.ly (right): ...
10 months, 2 weeks ago (2018-08-13 16:46:59 UTC) #4
dak
On 2018/08/13 16:46:59, Be-3 wrote: > On 2018/08/13 16:21:10, lemzwerg wrote: > > LGTM, thanks! ...
10 months, 2 weeks ago (2018-08-13 16:56:51 UTC) #5
Be-3
On 2018/08/13 16:56:51, dak wrote: > […] Hi David, Thanks for the hints, I'll look ...
10 months, 2 weeks ago (2018-08-13 17:16:45 UTC) #6
Be-3
10 months, 1 week ago (2018-08-16 10:43:41 UTC) #7
Correction of single-word sentence in regtest.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b