Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(37)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
341360043
: [plaso] Migrated utmpx construct-based parser to use dtfabric #1893 (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by
Joachim Metz
Modified:
5 years, 10 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing
Visibility:
Public.
More Reviews
Description
[plaso] Migrated utmpx construct-based parser to use dtfabric #1893
Patch Set 1
#
Patch Set 2 : Migrated utmpx construct-based parser to use dtfabric #1893
#
Created:
5 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+253 lines, -169 lines
)
Patch
M
plaso/formatters/utmp.py
View
2 chunks
+5 lines, -2 lines
0 comments
Download
M
plaso/formatters/utmpx.py
View
2 chunks
+15 lines, -9 lines
0 comments
Download
M
plaso/parsers/utmp.py
View
1
7 chunks
+16 lines, -15 lines
0 comments
Download
M
plaso/parsers/utmp.yaml
View
2 chunks
+35 lines, -1 line
0 comments
Download
M
plaso/parsers/utmpx.py
View
4 chunks
+125 lines, -110 lines
0 comments
Download
M
tests/formatters/utmp.py
View
1 chunk
+1 line, -1 line
0 comments
Download
M
tests/formatters/utmpx.py
View
1 chunk
+5 lines, -3 lines
0 comments
Download
M
tests/parsers/utmp.py
View
1
6 chunks
+18 lines, -9 lines
0 comments
Download
M
tests/parsers/utmpx.py
View
3 chunks
+33 lines, -19 lines
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
Joachim Metz
5 years, 10 months ago (2018-06-12 05:58:12 UTC)
#1
Sign in
to reply to this message.
Joachim Metz
Code updated.
5 years, 10 months ago (2018-06-14 04:07:08 UTC)
#2
Code updated.
Sign in
to reply to this message.
onager
On 2018/06/14 04:07:08, Joachim Metz wrote: > Code updated. Reviewed on github
5 years, 10 months ago (2018-06-24 06:20:03 UTC)
#3
On 2018/06/14 04:07:08, Joachim Metz wrote: > Code updated. Reviewed on github
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 341360043: [plaso] Migrated utmpx construct-based parser to use dtfabric #1893 (Closed)
Created 5 years, 10 months ago by Joachim Metz
Modified 5 years, 10 months ago
Reviewers: onager
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b