On 2018/04/02 07:01:36, Joachim Metz wrote: non-blocking comment, otherwise LGTM
https://codereview.appspot.com/341030043/diff/1/data/templates/macos_make_dis... File data/templates/macos_make_dist.sh (right): https://codereview.appspot.com/341030043/diff/1/data/templates/macos_make_dis... data/templates/macos_make_dist.sh:13: MACOS_VERSION=`sw_vers -productVersion | awk -F '.' '{print $$1 "." $$2}'`; I prefer "$()" instead of backticks, but totally up to you :)
https://codereview.appspot.com/341030043/diff/1/data/templates/macos_make_dis... File data/templates/macos_make_dist.sh (right): https://codereview.appspot.com/341030043/diff/1/data/templates/macos_make_dis... data/templates/macos_make_dist.sh:13: MACOS_VERSION=`sw_vers -productVersion | awk -F '.' '{print $$1 "." $$2}'`; the backticks are there because of backwards compatibility, have been dealing with older versions of bash for too long ;)
Changes have been merged with master branch. To close the review and clean up the feature branch you can run: review.py close deptools4