Issue 340910043: Changing getLeadCodePoints() to smokeTest(), C++ and Java

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340910043: Changing getLeadCodePoints() to smokeTest(), C++ and Java

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by sffc

Modified:
6 years, 1 month ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat4/

Visibility:
Public.

More Reviews

Description

Changing getLeadCodePoints() to smokeTest(), C++ and Java

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+266 lines, -408 lines)			Patch
M	icu4c/source/i18n/numparse_affixes.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	icu4c/source/i18n/numparse_affixes.cpp	View	3 chunks	+6 lines, -22 lines	0 comments	Download
M	icu4c/source/i18n/numparse_compositions.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	icu4c/source/i18n/numparse_compositions.cpp	View	3 chunks	+22 lines, -7 lines	0 comments	Download
M	icu4c/source/i18n/numparse_currency.h	View	5 chunks	+4 lines, -4 lines	0 comments	Download
M	icu4c/source/i18n/numparse_currency.cpp	View	4 chunks	+10 lines, -32 lines	0 comments	Download
M	icu4c/source/i18n/numparse_decimal.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icu4c/source/i18n/numparse_decimal.cpp	View	1 chunk	+13 lines, -15 lines	0 comments	Download
M	icu4c/source/i18n/numparse_impl.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	icu4c/source/i18n/numparse_impl.cpp	View	6 chunks	+9 lines, -38 lines	0 comments	Download
M	icu4c/source/i18n/numparse_scientific.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icu4c/source/i18n/numparse_scientific.cpp	View	2 chunks	+4 lines, -16 lines	0 comments	Download
M	icu4c/source/i18n/numparse_stringsegment.cpp	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	icu4c/source/i18n/numparse_symbols.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	icu4c/source/i18n/numparse_symbols.cpp	View	2 chunks	+2 lines, -25 lines	0 comments	Download
M	icu4c/source/i18n/numparse_types.h	View	5 chunks	+20 lines, -15 lines	0 comments	Download
M	icu4c/source/i18n/numparse_unisets.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	icu4c/source/i18n/numparse_unisets.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	icu4c/source/i18n/numparse_validators.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	icu4c/source/test/intltest/numbertest_parse.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	icu4c/source/test/intltest/numbertest_unisets.cpp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/StringSegment.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/AffixMatcher.java	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/AnyMatcher.java	View	2 chunks	+6 lines, -11 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CodePointMatcher.java	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CurrencyCustomMatcher.java	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CurrencyNamesMatcher.java	View	3 chunks	+13 lines, -7 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/DecimalMatcher.java	View	1 chunk	+13 lines, -11 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NanMatcher.java	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParseMatcher.java	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java	View	6 chunks	+5 lines, -30 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ScientificMatcher.java	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/SeriesMatcher.java	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/SymbolMatcher.java	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/UnicodeSetStaticCache.java	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ValidationMatcher.java	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java	View	3 chunks	+60 lines, -0 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberParserTest.java	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/PropertiesTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/UnicodeSetStaticCacheTest.java	View	1 chunk	+1 line, -66 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

sffc

6 years, 1 month ago (2018-03-21 06:26:59 UTC) #1

This review isn't required, but it touches a lot (most) of the number parsing
files in the same way, so it could be a way to explore the code.

Expand All Messages | Collapse All Messages