Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 340820043: [plaso] Add tests for parser and plugins imports. #1740 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by onager
Modified:
6 months ago
Reviewers:
Joachim Metz
CC:
Joachim Metz, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Add tests for parser and plugins imports. #1740

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes after review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M plaso/parsers/sqlite_plugins/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M plaso/parsers/winreg_plugins/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A tests/parsers/parser_import_test.py View 1 1 chunk +65 lines, -0 lines 1 comment Download

Messages

Total messages: 7
onager
6 months, 2 weeks ago (2018-03-08 14:05:26 UTC) #1
onager
On 2018/03/08 14:05:26, onager wrote: Putting this out there for feedback. We could also have ...
6 months, 2 weeks ago (2018-03-08 14:24:28 UTC) #2
Joachim Metz
Like the idea https://codereview.appspot.com/340820043/diff/1/tests/parsers/parser_import_test.py File tests/parsers/parser_import_test.py (right): https://codereview.appspot.com/340820043/diff/1/tests/parsers/parser_import_test.py#newcode23 tests/parsers/parser_import_test.py:23: def _testFilesImportedInInit(self, path, ignorable_files): + nit: ...
6 months, 2 weeks ago (2018-03-09 00:46:42 UTC) #3
onager
Code updated.
6 months, 2 weeks ago (2018-03-09 11:48:10 UTC) #4
onager
https://codereview.appspot.com/340820043/diff/1/tests/parsers/parser_import_test.py File tests/parsers/parser_import_test.py (right): https://codereview.appspot.com/340820043/diff/1/tests/parsers/parser_import_test.py#newcode23 tests/parsers/parser_import_test.py:23: def _testFilesImportedInInit(self, path, ignorable_files): On 2018/03/09 00:46:42, Joachim Metz ...
6 months, 2 weeks ago (2018-03-09 14:30:53 UTC) #5
Joachim Metz
LGTM, small docstring nit https://codereview.appspot.com/340820043/diff/20001/tests/parsers/parser_import_test.py File tests/parsers/parser_import_test.py (right): https://codereview.appspot.com/340820043/diff/20001/tests/parsers/parser_import_test.py#newcode30 tests/parsers/parser_import_test.py:30: ignorable_files (list[str]): list of file ...
6 months, 1 week ago (2018-03-10 02:59:17 UTC) #6
onager
6 months, 1 week ago (2018-03-12 09:38:10 UTC) #7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close import_tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b