Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5980)

Issue 340800043: ui/gtk3: Implement Page_Down, Page_Up on Unicode name list (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by fujiwara
Modified:
6 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Implement Page_Down, Page_Up on Unicode name list Page_Down and Page_Up are useful on Unicode name list since the names are many. Also add Ctrl-Shift-[n|p] for the same purpose. R=Shawn.P.Huang@gmail.com Committed: afe60c12a0e5bf70344930c6769675a439dc82d2

Patch Set 1 #

Patch Set 2 : Fixed a typo #

Patch Set 3 : Consolidated the common function #

Patch Set 4 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -24 lines) Patch
M ui/gtk3/emojier.vala View 1 5 chunks +67 lines, -22 lines 0 comments Download
M ui/gtk3/ibus-emoji.7.in View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 1 month ago (2018-02-27 23:52:34 UTC) #1
Peng
On 2018/02/27 23:52:34, fujiwara wrote: lgtm
6 years, 1 month ago (2018-02-28 16:48:37 UTC) #2
fujiwara
6 years, 1 month ago (2018-03-01 06:42:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
afe60c12a0e5bf70344930c6769675a439dc82d2 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b