Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1598)

Issue 340760043: [plaso] Added deprecated decorator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by Joachim Metz
Modified:
8 months, 2 weeks ago
Reviewers:
romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added deprecated decorator

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A plaso/lib/decorators.py View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Joachim Metz
9 months, 3 weeks ago (2018-02-19 17:56:35 UTC) #1
romaing
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) I'm not well versed into warnings module, ...
9 months, 3 weeks ago (2018-02-20 16:56:57 UTC) #2
Joachim Metz
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) DeprecationWarning is ignored by default, see: https://docs.python.org/3/library/warnings.html ...
9 months, 3 weeks ago (2018-02-22 13:41:39 UTC) #3
romaing
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) On 2018/02/22 13:41:39, Joachim Metz wrote: > ...
9 months, 3 weeks ago (2018-02-22 15:04:25 UTC) #4
Joachim Metz
ack, though the warning needs to be shown once per call
9 months, 3 weeks ago (2018-02-22 15:30:43 UTC) #5
Joachim Metz
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) ack, though the warning needs to be ...
9 months, 3 weeks ago (2018-02-22 15:39:36 UTC) #6
onager
9 months, 2 weeks ago (2018-02-28 23:46:29 UTC) #7
onager
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) On 2018/02/22 15:39:36, Joachim Metz wrote: > ...
9 months, 2 weeks ago (2018-02-28 23:46:29 UTC) #8
Joachim Metz
only the "first time per call", so that you know where in the code the ...
9 months, 1 week ago (2018-03-02 00:55:09 UTC) #9
Joachim Metz
https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py File plaso/lib/decorators.py (right): https://codereview.appspot.com/340760043/diff/1/plaso/lib/decorators.py#newcode19 plaso/lib/decorators.py:19: warnings.simplefilter('default', DeprecationWarning) only the "first time per call", so ...
9 months, 1 week ago (2018-03-02 00:55:48 UTC) #10
Joachim Metz
the main reason I could find is the filter order matters: http://blog.zsoldosp.eu/2016/02/01/warnings-warn-some-deprecationwarning-gotchas/ however for our ...
9 months ago (2018-03-13 15:55:54 UTC) #11
Joachim Metz
Code updated.
9 months ago (2018-03-14 05:19:58 UTC) #12
onager
LGTM
8 months, 2 weeks ago (2018-03-28 20:20:45 UTC) #13
Joachim Metz
8 months, 2 weeks ago (2018-03-29 05:23:44 UTC) #14
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close decorators
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b