Issue 340640043: [dfdatetime] Updated dependency information

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340640043: [dfdatetime] Updated dependency information (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

More Reviews

Description

[dfdatetime] Updated dependency information Generated from: https://codereview.appspot.com/345780043/

Patch Set 2 : Updated dependency information #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -13 lines)			Patch
M	.travis.yml	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	appveyor.yml	View		1 chunk	+8 lines, -1 line	0 comments	Download
A	config/travis/run_with_timeout.sh	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	config/travis/runtests.sh	View		1 chunk	+1 line, -1 line	2 comments	Download
M	setup.py	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	utils/dependencies.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jberggren

Non blocking comment, otherswise LGTM https://codereview.appspot.com/340640043/diff/20001/config/travis/runtests.sh File config/travis/runtests.sh (right): https://codereview.appspot.com/340640043/diff/20001/config/travis/runtests.sh#newcode15 config/travis/runtests.sh:15: for FILE in `find ...

6 years ago (2018-04-05 08:16:14 UTC) #3

Joachim Metz

https://codereview.appspot.com/340640043/diff/20001/config/travis/runtests.sh File config/travis/runtests.sh (right): https://codereview.appspot.com/340640043/diff/20001/config/travis/runtests.sh#newcode15 config/travis/runtests.sh:15: for FILE in `find setup.py config dfdatetime tests -name ...

6 years ago (2018-04-05 20:57:36 UTC) #4

Joachim Metz

6 years ago (2018-04-05 20:58:23 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close deps

Expand All Messages | Collapse All Messages