Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(475)

Issue 340610043: [plaso] SQLite merge reader added zlib support and clean up

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by Joachim Metz
Modified:
2 days, 4 hours ago
Reviewers:
jberggren, onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing
Visibility:
Public.

Description

[plaso] SQLite merge reader added zlib support and clean up

Patch Set 1 : Small textual changes #

Total comments: 24

Patch Set 2 : Changes after review #

Total comments: 4

Patch Set 3 : Changes after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -113 lines) Patch
M plaso/multi_processing/task_engine.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/storage/fake/writer.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M plaso/storage/interface.py View 1 2 8 chunks +34 lines, -53 lines 0 comments Download
M plaso/storage/sqlite/merge_reader.py View 1 2 7 chunks +147 lines, -59 lines 0 comments Download
A tests/storage/sqlite/merge_reader.py View 1 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
3 weeks ago (2018-04-01 12:32:38 UTC) #1
Joachim Metz
Code updated.
3 weeks ago (2018-04-01 17:38:33 UTC) #2
onager
https://codereview.appspot.com/340610043/diff/20001/plaso/storage/interface.py File plaso/storage/interface.py (right): https://codereview.appspot.com/340610043/diff/20001/plaso/storage/interface.py#newcode1081 plaso/storage/interface.py:1081: def _GetMergeTaskStorageFilePath(self, task): Rather than doing this, how about ...
3 weeks ago (2018-04-01 19:18:05 UTC) #3
Joachim Metz
https://codereview.appspot.com/340610043/diff/20001/plaso/storage/interface.py File plaso/storage/interface.py (right): https://codereview.appspot.com/340610043/diff/20001/plaso/storage/interface.py#newcode1081 plaso/storage/interface.py:1081: def _GetMergeTaskStorageFilePath(self, task): Let's do one (optimization) step at ...
3 weeks ago (2018-04-01 20:39:27 UTC) #4
Joachim Metz
Code updated.
3 weeks ago (2018-04-01 21:24:50 UTC) #5
onager
https://codereview.appspot.com/340610043/diff/40001/plaso/storage/sqlite/merge_reader.py File plaso/storage/sqlite/merge_reader.py (right): https://codereview.appspot.com/340610043/diff/40001/plaso/storage/sqlite/merge_reader.py#newcode165 plaso/storage/sqlite/merge_reader.py:165: as event referencing event data. To resulting names are ...
2 weeks, 1 day ago (2018-04-07 13:24:17 UTC) #6
Joachim Metz
https://codereview.appspot.com/340610043/diff/40001/plaso/storage/sqlite/merge_reader.py File plaso/storage/sqlite/merge_reader.py (right): https://codereview.appspot.com/340610043/diff/40001/plaso/storage/sqlite/merge_reader.py#newcode165 plaso/storage/sqlite/merge_reader.py:165: as event referencing event data. To resulting names are ...
2 weeks, 1 day ago (2018-04-07 17:23:30 UTC) #7
Joachim Metz
Code updated.
2 weeks, 1 day ago (2018-04-07 17:28:58 UTC) #8
Joachim Metz
2 days, 4 hours ago (2018-04-21 06:53:52 UTC) #9
Code updated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b