Issue 340600043: [plaso] Improved profiling support in psort

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340600043: [plaso] Improved profiling support in psort (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, onager

Visibility:
Public.

More Reviews

Description

[plaso] Improved profiling support in psort Depends on: https://codereview.appspot.com/340590043/

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -141 lines)			Patch
M	plaso/cli/psort_tool.py	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	plaso/cli/psteal_tool.py	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	plaso/multi_processing/analysis_process.py	View	10 chunks	+43 lines, -8 lines	0 comments	Download
M	plaso/multi_processing/base_process.py	View	5 chunks	+93 lines, -3 lines	2 comments	Download
M	plaso/multi_processing/psort.py	View	12 chunks	+24 lines, -23 lines	0 comments	Download
M	plaso/multi_processing/worker_process.py	View	3 chunks	+1 line, -89 lines	0 comments	Download
M	tests/multi_processing/analysis_process.py	View	4 chunks	+13 lines, -4 lines	0 comments	Download
M	tests/multi_processing/base_process.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/multi_processing/psort.py	View	5 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jberggren

Small suggestion, otherwise LGTM https://codereview.appspot.com/340600043/diff/1/plaso/multi_processing/base_process.py File plaso/multi_processing/base_process.py (right): https://codereview.appspot.com/340600043/diff/1/plaso/multi_processing/base_process.py#newcode177 plaso/multi_processing/base_process.py:177: if not configuration: Maybe check ...

6 years ago (2018-04-05 08:31:07 UTC) #2

Joachim Metz

https://codereview.appspot.com/340600043/diff/1/plaso/multi_processing/base_process.py File plaso/multi_processing/base_process.py (right): https://codereview.appspot.com/340600043/diff/1/plaso/multi_processing/base_process.py#newcode177 plaso/multi_processing/base_process.py:177: if not configuration: we don't do this elsewhere in ...

6 years ago (2018-04-05 21:00:31 UTC) #3

Joachim Metz

6 years ago (2018-04-05 21:07:49 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close profilers2

Expand All Messages | Collapse All Messages