Issue 340280043: [plaso] Replaced dfvfs.GetStat with equivalent in CalculateNTFSTimeHash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340280043: [plaso] Replaced dfvfs.GetStat with equivalent in CalculateNTFSTimeHash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by Joachim Metz

Modified:
6 years, 1 month ago

Reviewers:
onager

CC:
romaing, jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Replaced dfvfs.GetStat with equivalent in CalculateNTFSTimeHash

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -33 lines)			Patch
	M	plaso/engine/extractors.py	View		3 chunks	+34 lines, -32 lines	2 comments	Download
	M	tests/engine/extractors.py	View		2 chunks	+58 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

onager

LGTM https://codereview.appspot.com/340280043/diff/1/plaso/engine/extractors.py File plaso/engine/extractors.py (right): https://codereview.appspot.com/340280043/diff/1/plaso/engine/extractors.py#newcode380 plaso/engine/extractors.py:380: """Calculates a MD5 from the date and time ...

6 years, 2 months ago (2018-02-23 10:03:32 UTC) #2

Joachim Metz

Changes have been merged with master branch. To close the review and clean up the ...

6 years, 2 months ago (2018-02-23 19:43:27 UTC) #3

Joachim Metz

6 years, 2 months ago (2018-02-23 19:45:13 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/340280043/diff/1/plaso/engine/extractors.py
File plaso/engine/extractors.py (right):

https://codereview.appspot.com/340280043/diff/1/plaso/engine/extractors.py#ne...
plaso/engine/extractors.py:380: """Calculates a MD5 from the date and time value
of a NTFS file entry.
On 2018/02/23 10:03:32, onager wrote:
> an MD5

Done.

Expand All Messages | Collapse All Messages