plot RTT(with jitters) and scores of 1 node

minior error
and fix the timestamp precision in x axis
BUG=

[xinyue, 2017-12-08 23:52:26]

in order to explain the score we got better, take one node as an example to plot
score and rtt in one plot.

[tonythomas, 2017-12-09 10:14:05]

Can you reply here with a sample plot you got ?

--
Tony Thomas
https://mediawiki.org/wiki/User:01tonythomas
--

On Sat, Dec 9, 2017 at 12:52 AM, <CynthiaMao122@gmail.com> wrote:

> Reviewers: ,
>
> Message:
> in order to explain the score we got better, take one node as an example
> to plot score and rtt in one plot.
>
> Description:
> minior error
> and fix the timestamp precision in x axis
> BUG=
>
> Please review this at https://codereview.appspot.com/339950043/
>
> Affected files (+121, -26 lines):
>   M launch_lx3.py
>   M utils/ds_score_plots/extract_data_from_log_file.py
>   A utils/ds_score_plots/plot_both_score_jitter.py
>   M utils/ds_score_plots/plot_jitter_host_to_host.py
>
>
>

[tonythomas, 2017-12-09 10:21:43]

Alright. its taking good shape. I saw the result yesterday already, but adjust
these things and we are good to go.

https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
File launch_lx3.py (right):

https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
launch_lx3.py:495: # plot_host_to_host_jitter(conf, save_dir=unique_exp_folder)
why do you have commented code here ? If its not required, just remove it.

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
File utils/ds_score_plots/extract_data_from_log_file.py (right):

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms =
float(timestamp_ms)
in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
File utils/ds_score_plots/plot_both_score_jitter.py (right):

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
utils/ds_score_plots/plot_both_score_jitter.py:10: # parsed_t =
datetime.strptime(utc_dt, '%Y-%m-%dT%H:%M:%S.%f')
so you are not parsing time using this anymore ?

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
utils/ds_score_plots/plot_both_score_jitter.py:82: #      
"y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
remove all commented code please.

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
File utils/ds_score_plots/plot_jitter_host_to_host.py (left):

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
utils/ds_score_plots/plot_jitter_host_to_host.py:45: x_2, y_2 =
read_data_to_list(os.path.join(ping_result_dir, "h1.2-s1-data.txt"))
these entire rest of code can be removed by using a for loop and one instance.
Like this. 

for i in range (1, 4):
    x, y = read_data_to_list(os.path.join(ping_result_dir,
'h1.{0}-data.txt'.format(i))
    plot_data(x, y, os.path.join(save_dir,'h1.{0}_to_s1_jitter.png'.format(i)),
'jitter level from h1.{0} to s1'.format(i))


simple.

[xinyue, 2017-12-09 19:01:31]

https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
File launch_lx3.py (right):

https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
launch_lx3.py:495: # plot_host_to_host_jitter(conf, save_dir=unique_exp_folder)
On 2017/12/09 10:21:43, tonythomas wrote:
> why do you have commented code here ? If its not required, just remove it. 

There are different functions, want to test only one function so commented
others. They will be back when all other things are done.

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
File utils/ds_score_plots/extract_data_from_log_file.py (right):

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms =
float(timestamp_ms)
On 2017/12/09 10:21:43, tonythomas wrote:
> in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])

Acknowledged.

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
File utils/ds_score_plots/plot_both_score_jitter.py (right):

https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
utils/ds_score_plots/plot_both_score_jitter.py:82: #      
"y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
On 2017/12/09 10:21:43, tonythomas wrote:
> remove all commented code please. 

Done.

[david.tomic11, 2017-12-09 19:07:03]

On 2017/12/09 19:01:31, xinyue wrote:
> https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py
> File launch_lx3.py (right):
> 
> https://codereview.appspot.com/339950043/diff/20001/launch_lx3.py#newcode495
> launch_lx3.py:495: # plot_host_to_host_jitter(conf,
save_dir=unique_exp_folder)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > why do you have commented code here ? If its not required, just remove it. 
> 
> There are different functions, want to test only one function so commented
> others. They will be back when all other things are done.
> 
>
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
> File utils/ds_score_plots/extract_data_from_log_file.py (right):
> 
>
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/extr...
> utils/ds_score_plots/extract_data_from_log_file.py:23: timestamp_ms =
> float(timestamp_ms)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > in fact, you can skip this line by float(timestamp_sec + '.' + time[-3:])
> 
> Acknowledged.
> 
>
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
> File utils/ds_score_plots/plot_both_score_jitter.py (right):
> 
>
https://codereview.appspot.com/339950043/diff/20001/utils/ds_score_plots/plot...
> utils/ds_score_plots/plot_both_score_jitter.py:82: #      
> "y_score:{3}",x_time_ping,x_time_score,y_ping,y_score)
> On 2017/12/09 10:21:43, tonythomas wrote:
> > remove all commented code please. 
> 
> Done.

Looks pretty good. I see that its building on Zijies code no?

[Liangzijie1437, 2017-12-10 22:50:09]

https://codereview.appspot.com/339950043/diff/40001/utils/ds_score_plots/plot...
File utils/ds_score_plots/plot_jitter_host_to_host.py (left):

https://codereview.appspot.com/339950043/diff/40001/utils/ds_score_plots/plot...
utils/ds_score_plots/plot_jitter_host_to_host.py:51: 
from h1.2 to s1, h1.2 and  to h1.3 should be in the same plot.
the same for from h1.1 and h1.3

[david.tomic11, 2017-12-12 14:41:27]

On 2017/12/12 13:26:25, xinyue wrote:

You can create a loop for this instead of manually changing the nodes you read
from.