Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 339710043: Issue 5337: Create Bottom contexts in a more general way (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by Dan Eble
Modified:
2 months ago
Reviewers:
carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5337/ Moving special treatment of "Bottom" into path_to_acceptable_context () makes it effective during calls to create_unique_context (), which is the basis of \new and (now) get_default_interpreter ().

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -50 lines) Patch
A input/regression/context-defaultchild-cycle.ly View 1 chunk +27 lines, -0 lines 0 comments Download
M lily/context.cc View 4 chunks +23 lines, -30 lines 0 comments Download
M lily/context-def.cc View 4 chunks +56 lines, -9 lines 0 comments Download
M lily/global-context.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M lily/include/context.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/context-def.hh View 2 chunks +7 lines, -0 lines 0 comments Download
M lily/include/global-context.hh View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1
Carl
2 months, 1 week ago (2018-06-13 15:49:20 UTC) #1
This looks to me like a nice job of making the code more understandable and
predictable.

LGTM

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b