Issue 339710043: Issue 5337: Create Bottom contexts in a more general way

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 339710043: Issue 5337: Create Bottom contexts in a more general way (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 10 months ago by Dan Eble

Modified:
5 years, 10 months ago

Reviewers:
carl.d.sorensen, Carl

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5337/ Moving special treatment of "Bottom" into path_to_acceptable_context () makes it effective during calls to create_unique_context (), which is the basis of \new and (now) get_default_interpreter ().

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -50 lines)			Patch
A	input/regression/context-defaultchild-cycle.ly	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	lily/context.cc	View	4 chunks	+23 lines, -30 lines	0 comments	Download
M	lily/context-def.cc	View	4 chunks	+56 lines, -9 lines	0 comments	Download
M	lily/global-context.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	lily/include/context.hh	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/include/context-def.hh	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	lily/include/global-context.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Carl

5 years, 10 months ago (2018-06-13 15:49:20 UTC) #1

This looks to me like a nice job of making the code more understandable and
predictable.

LGTM

Carl

Expand All Messages | Collapse All Messages