Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 339630043: ticket:13736 Change number parsing to require locale currency when using non-currency parse functio… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by sffc
Modified:
2 months, 3 weeks ago
Reviewers:
markus.icu
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13736 Change number parsing to require locale currency when using non-currency parse function.

Patch Set 1 #

Patch Set 2 : Porting to ICU4C and adding locale long name parsing as alternative to currency data parsing. #

Patch Set 3 : Adding back test that was erroneously disabled. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -155 lines) Patch
M icu4c/source/i18n/numparse_affixes.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/i18n/numparse_affixes.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M icu4c/source/i18n/numparse_currency.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M icu4c/source/i18n/numparse_currency.cpp View 1 2 2 chunks +60 lines, -24 lines 0 comments Download
M icu4c/source/i18n/numparse_impl.cpp View 1 2 5 chunks +7 lines, -4 lines 0 comments Download
M icu4c/source/i18n/numparse_types.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/cintltst/cnumtst.c View 1 2 6 chunks +28 lines, -32 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_parse.cpp View 1 2 2 chunks +41 lines, -19 lines 0 comments Download
M icu4c/source/test/intltest/numfmtst.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M icu4c/source/test/testdata/numberformattestspecification.txt View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/AffixTokenMatcherFactory.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/CombinedCurrencyMatcher.java View 1 2 7 chunks +62 lines, -17 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/NumberParserImpl.java View 1 2 5 chunks +7 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/ParsingUtils.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 6 chunks +34 lines, -25 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberParserTest.java View 1 2 2 chunks +38 lines, -18 lines 0 comments Download

Messages

Total messages: 4
sffc
Porting to ICU4C and adding locale long name parsing as alternative to currency data parsing.
3 months ago (2018-05-16 22:58:42 UTC) #1
sffc
3 months ago (2018-05-16 22:58:58 UTC) #2
sffc
Adding back test that was erroneously disabled.
2 months, 3 weeks ago (2018-05-23 22:10:24 UTC) #3
markus.icu
2 months, 3 weeks ago (2018-05-23 23:37:15 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b