Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(385)

Issue 339590043: ticket:13333 Adding combining dot spoof check. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by sffc
Modified:
1 day, 6 hours ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13333 Adding combining dot spoof check.

Patch Set 1 #

Patch Set 2 : Adding one more test case. #

Patch Set 3 : Adding more docs. #

Total comments: 10

Patch Set 4 : Replying to Andy code review feedback #

Patch Set 5 : Updating Java name and documentation #

Patch Set 6 : Adding Java implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -5 lines) Patch
M icu4c/source/i18n/unicode/uspoof.h View 1 2 3 4 2 chunks +22 lines, -1 line 0 comments Download
M icu4c/source/i18n/uspoof.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M icu4c/source/i18n/uspoof_impl.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M icu4c/source/i18n/uspoof_impl.cpp View 1 2 3 3 chunks +42 lines, -4 lines 0 comments Download
M icu4c/source/test/intltest/itspoof.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/itspoof.cpp View 1 2 3 2 chunks +42 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/SpoofChecker.java View 1 2 3 4 5 3 chunks +67 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/text/SpoofCheckerTest.java View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 9
sffc
2 weeks, 4 days ago (2018-05-05 03:44:20 UTC) #1
sffc
Adding one more test case.
2 weeks, 4 days ago (2018-05-05 03:48:35 UTC) #2
sffc
Adding more docs.
2 weeks, 4 days ago (2018-05-05 03:53:55 UTC) #3
andy.heninger
https://codereview.appspot.com/339590043/diff/40001/icu4c/source/i18n/unicode/uspoof.h File icu4c/source/i18n/unicode/uspoof.h (right): https://codereview.appspot.com/339590043/diff/40001/icu4c/source/i18n/unicode/uspoof.h#newcode498 icu4c/source/i18n/unicode/uspoof.h:498: USPOOF_COMBINING_DOT = 256, Updated name & description to USPOOF_HIDDEN_OVERLAY ...
1 week, 5 days ago (2018-05-10 21:56:40 UTC) #4
sffc
Replying to Andy code review feedback
1 week, 5 days ago (2018-05-10 23:20:17 UTC) #5
sffc
Updating Java name and documentation
1 week, 5 days ago (2018-05-10 23:23:20 UTC) #6
sffc
Adding Java implementation.
1 week, 4 days ago (2018-05-11 20:01:13 UTC) #7
sffc
https://codereview.appspot.com/339590043/diff/40001/icu4c/source/i18n/unicode/uspoof.h File icu4c/source/i18n/unicode/uspoof.h (right): https://codereview.appspot.com/339590043/diff/40001/icu4c/source/i18n/unicode/uspoof.h#newcode498 icu4c/source/i18n/unicode/uspoof.h:498: USPOOF_COMBINING_DOT = 256, On 2018/05/10 21:56:35, andy.heninger wrote: > ...
1 week, 4 days ago (2018-05-11 20:01:44 UTC) #8
andy.heninger
2 days, 9 hours ago (2018-05-20 23:42:03 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b