Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(403)

Issue 339540043: Optimizing and adding a basic fastpath for small ints. Greatly increases the performance of DateFo… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by sffc
Modified:
5 years, 11 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat4/icu4c/source/
Visibility:
Public.

Description

Optimizing and adding a basic fastpath for small ints. Greatly increases the performance of DateFormat.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing lazy-compute call site and other minor changes. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -94 lines) Patch
M i18n/currunit.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M i18n/decimfmt.cpp View 1 58 chunks +264 lines, -90 lines 4 comments Download
M i18n/number_patternstring.h View 1 1 chunk +1 line, -1 line 0 comments Download
M i18n/number_patternstring.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
sffc
5 years, 11 months ago (2018-04-19 09:27:54 UTC) #1
sffc
Fixing lazy-compute call site and other minor changes.
5 years, 11 months ago (2018-04-20 01:28:59 UTC) #2
andy.heninger
https://codereview.appspot.com/339540043/diff/1/i18n/decimfmt.cpp File i18n/decimfmt.cpp (right): https://codereview.appspot.com/339540043/diff/1/i18n/decimfmt.cpp#newcode1139 i18n/decimfmt.cpp:1139: auto* nonConstThis = const_cast<DecimalFormat*>(this); doesn't work, as discussed in ...
5 years, 11 months ago (2018-04-20 17:40:03 UTC) #3
sffc
5 years, 11 months ago (2018-05-02 00:52:47 UTC) #4
https://codereview.appspot.com/339540043/diff/20001/i18n/decimfmt.cpp
File i18n/decimfmt.cpp (right):

https://codereview.appspot.com/339540043/diff/20001/i18n/decimfmt.cpp#newcode...
i18n/decimfmt.cpp:1112: 
On 2018/04/20 17:40:02, andy.heninger wrote:
> should check incoming status first & bail out immediately on an error. The
> following create function can reasonably return nullptr in this case, and we
> shouldn't clobber the original error if that happens.

Done.

https://codereview.appspot.com/339540043/diff/20001/i18n/decimfmt.cpp#newcode...
i18n/decimfmt.cpp:1121: // atomic, which may me temp or may be another object
computed by a different thread.
On 2018/04/20 17:40:02, andy.heninger wrote:
> Typo, me => be

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b