LEFT | RIGHT |
1 2018-05-31 Ali Juma <ajuma@chromium.org> | 1 2018-06-11 Ali Juma <ajuma@chromium.org> |
2 | 2 |
3 Use SafeBrowsing in WKWebView | 3 Use SafeBrowsing in WKWebView |
4 https://bugs.webkit.org/show_bug.cgi?id=181804 | 4 https://bugs.webkit.org/show_bug.cgi?id=181804 |
5 | 5 |
6 Reviewed by NOBODY (OOPS!). | 6 Reviewed by NOBODY (OOPS!). |
7 | 7 |
8 Enable SafeBrowsing in MiniBrowser. | 8 Enable SafeBrowsing in MiniBrowser. |
| 9 |
| 10 Add API tests for SafeBrowsing. |
9 | 11 |
10 * MiniBrowser/MiniBrowser.entitlements: | 12 * MiniBrowser/MiniBrowser.entitlements: |
11 * MiniBrowser/mac/AppDelegate.m: | 13 * MiniBrowser/mac/AppDelegate.m: |
12 (defaultConfiguration): | 14 (defaultConfiguration): |
13 * MiniBrowser/mac/WK2BrowserWindowController.m: | 15 * MiniBrowser/mac/WK2BrowserWindowController.m: |
14 (-[WK2BrowserWindowController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): | 16 (-[WK2BrowserWindowController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): |
| 17 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 18 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added. |
| 19 (-[SBScheme webView:startURLSchemeTask:]): |
| 20 (-[SBScheme webView:stopURLSchemeTask:]): |
| 21 (-[SafeBrowsingTestController webView:decidePolicyForNavigationAction:de
cisionHandler:]): |
| 22 (-[SafeBrowsingTestController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): |
| 23 (-[SafeBrowsingTestController webView:didFinishNavigation:]): |
| 24 (TEST): |
| 25 * TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html: Added. |
| 26 * TestWebKitAPI/Tests/WebKitCocoa/unsafe-iframe.html: Added. |
| 27 |
| 28 2018-06-12 Tim Horton <timothy_horton@apple.com> |
| 29 |
| 30 Add a API test for r232601 |
| 31 https://bugs.webkit.org/show_bug.cgi?id=186417 |
| 32 |
| 33 Reviewed by Wenson Hsieh. |
| 34 |
| 35 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm: |
| 36 (immediateSubviewOfClass): |
| 37 (TEST): |
| 38 Ensure that we put the view hierarchy back together (move WKContentView |
| 39 out of the animated resize view) and unhide WKContentView after a |
| 40 resize-with-hidden-content. |
| 41 |
| 42 2018-06-12 Valerie R Young <valerie@bocoup.com> |
| 43 |
| 44 test262/Runner.pm: add unit tests |
| 45 https://bugs.webkit.org/show_bug.cgi?id=185783 |
| 46 |
| 47 Reviewed by Michael Saboff. |
| 48 |
| 49 * Scripts/webkitperl/test262_unittest/README: Added. |
| 50 * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml
: Added. |
| 51 * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added. |
| 52 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail-new-error.p
l: Added. |
| 53 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail.pl: Added. |
| 54 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-pass.pl: Added. |
| 55 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing-with-new-error.js: Added. |
| 56 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing.js: Added. |
| 57 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-passing.js: Added. |
| 58 (f): |
| 59 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now
-failing.js: Added. |
| 60 * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added. |
| 61 * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added. |
| 62 (f): |
| 63 * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added. |
| 64 |
| 65 2018-06-12 Valerie R Young <valerie@bocoup.com> |
| 66 |
| 67 test262/Runner.pm: minor updates |
| 68 https://bugs.webkit.org/show_bug.cgi?id=186399 |
| 69 |
| 70 - If harness files cannot be found in a CLI supplied |
| 71 test262 path, then default to webkit's test262 harness files. |
| 72 - Lazily create the test262-results directory (only right before |
| 73 writing to it) |
| 74 - If an expectation file is supplied via the CLI, save to the |
| 75 supplied location instead of the default webkit location |
| 76 (JSTest/test262/expectation.yaml). |
| 77 |
| 78 Reviewed by Michael Saboff. |
| 79 |
| 80 * Scripts/test262/Runner.pm: |
| 81 (processCLI): |
| 82 (main): |
| 83 (compileTest): |
| 84 (processResult): |
| 85 (getHarness): |
| 86 (summarizeResults): |
| 87 |
| 88 2018-06-11 Carlos Alberto Lopez Perez <clopez@igalia.com> |
| 89 |
| 90 [JSCOnly] Add a MIPS32el JSCOnly EWS |
| 91 https://bugs.webkit.org/show_bug.cgi?id=186523 |
| 92 |
| 93 Reviewed by Michael Catanzaro. |
| 94 |
| 95 Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-onl
y (Linux) port. |
| 96 The worker(s) on this queue should be pre-configured to cross-build JSC
for MIPS32el. |
| 97 |
| 98 * QueueStatusServer/config/queues.py: |
| 99 * QueueStatusServer/model/queues.py: |
| 100 (Queue.display_name): |
| 101 * Scripts/webkitpy/common/config/ews.json: |
| 102 * Scripts/webkitpy/common/config/ports.py: |
| 103 (DeprecatedPort.port): |
| 104 (WpePort.run_webkit_tests_command): |
| 105 (JscOnlyPort): |
| 106 (JscOnlyPort.build_jsc_command): |
| 107 * Scripts/webkitpy/common/config/ports_unittest.py: |
| 108 (DeprecatedPortTest.test_wincairo_port): |
| 109 (DeprecatedPortTest): |
| 110 (DeprecatedPortTest.test_jsconly_port): |
| 111 * Scripts/webkitpy/port/factory.py: |
| 112 (PortFactory): |
| 113 * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition.
Required by the EWS tooling. |
| 114 (JscOnlyPort): |
| 115 (JscOnlyPort.__init__): |
| 116 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: |
| 117 (test_ews_name): |
| 118 |
| 119 2018-06-12 Zan Dobersek <zdobersek@igalia.com> |
| 120 |
| 121 Add run-web-platform-tests script |
| 122 https://bugs.webkit.org/show_bug.cgi?id=183356 |
| 123 |
| 124 Reviewed by Carlos Alberto Lopez Perez. |
| 125 |
| 126 Add the run-web-platform-tests script that allows running WebKit builds |
| 127 against the external web-platform-tests project. |
| 128 |
| 129 The script sets up all the port-specific information, including the |
| 130 display driver. If no web-platform-tests repository location is |
| 131 specified, the TestDownloader utility is used to clone the repository, |
| 132 and path to that clone is leveraged instead. |
| 133 |
| 134 Port-specific TestManifest.ini and TestExpectations.json file paths are |
| 135 then constructed, bailing if any of the files is missing. The JSON file |
| 136 is then used to construct the metadata file tree, creating an .ini file |
| 137 for each test that is disabled, has a certain expectation, or has |
| 138 subtests that themselves have certain expectations. This metadata tree |
| 139 is built under the build directory, and is purged and reconstructed for |
| 140 each separate run. |
| 141 |
| 142 Lastly, the WPT python module is imported from the web-platform-tests |
| 143 source location, and wpt.main() is invoked along with all the necessary |
| 144 arguments that set up a web-platform-tests suite run using the WebKit |
| 145 product. |
| 146 |
| 147 * Scripts/run-web-platform-tests: Added. |
| 148 * Scripts/webkitpy/common/config/ports_mock.py: |
| 149 (MockPort.run_bindings_tests_command): |
| 150 (MockPort): |
| 151 (MockPort.wpt_metadata_directory): |
| 152 (MockPort.wpt_manifest_file): |
| 153 * Scripts/webkitpy/port/base.py: |
| 154 (Port.wpt_metadata_directory): |
| 155 (Port): |
| 156 (Port.wpt_manifest_file): |
| 157 * Scripts/webkitpy/w3c/common.py: |
| 158 (is_file_exportable): |
| 159 (WPTPaths): |
| 160 (WPTPaths.checkout_directory): |
| 161 (WPTPaths.wpt_checkout_path): |
| 162 * Scripts/webkitpy/w3c/test_downloader.py: |
| 163 (TestDownloader.clone_tests): |
| 164 (TestDownloader): |
| 165 (TestDownloader.download_tests): |
| 166 * Scripts/webkitpy/w3c/test_exporter.py: |
| 167 (WebPlatformTestExporter.__init__): |
| 168 * Scripts/webkitpy/w3c/wpt_runner.py: Added. |
| 169 (main): |
| 170 (parse_args): |
| 171 (create_webdriver): |
| 172 (spawn_wpt): |
| 173 (WPTRunner): |
| 174 (WPTRunner.__init__): |
| 175 (WPTRunner._prepare_wpt_checkout): |
| 176 (WPTRunner._generate_metadata_directory): |
| 177 (WPTRunner.run): |
| 178 * Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added. |
| 179 (WPTRunnerTest): |
| 180 (WPTRunnerTest.MockTestDownloader): |
| 181 (WPTRunnerTest.MockTestDownloader.default_options): |
| 182 (WPTRunnerTest.MockTestDownloader.__init__): |
| 183 (WPTRunnerTest.MockTestDownloader.clone_tests): |
| 184 (WPTRunnerTest.MockWebDriver): |
| 185 (WPTRunnerTest.MockWebDriver.create): |
| 186 (WPTRunnerTest.MockWebDriver.binary_path): |
| 187 (WPTRunnerTest.MockWebDriver.browser_path): |
| 188 (WPTRunnerTest.MockWebDriver.browser_args): |
| 189 (WPTRunnerTest.MockSpawnWPT): |
| 190 (WPTRunnerTest.MockSpawnWPT.__init__): |
| 191 (WPTRunnerTest.MockSpawnWPT.__call__): |
| 192 (WPTRunnerTest.TestInstance): |
| 193 (WPTRunnerTest.TestInstance.__init__): |
| 194 (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): |
| 195 (WPTRunnerTest.test_prepare_wpt_checkout): |
| 196 (WPTRunnerTest.test_prepare_wpt_checkout_specified_path): |
| 197 (WPTRunnerTest.test_generate_metadata_directory): |
| 198 (WPTRunnerTest.test_run): |
| 199 (WPTRunnerTest.test_run_with_specified_options): |
| 200 (WPTRunnerTest.test_run_with_args): |
| 201 |
| 202 2018-06-11 Mark Lam <mark.lam@apple.com> |
| 203 |
| 204 Add support for webkit-test-runner jscOptions in DumpRenderTree and WebK
itTestRunner. |
| 205 https://bugs.webkit.org/show_bug.cgi?id=186451 |
| 206 <rdar://problem/40875792> |
| 207 |
| 208 Reviewed by Tim Horton. |
| 209 |
| 210 This jscOptions option can be used by a layout test to specify some JSC
runtime |
| 211 options needed by the test e.g. by adding something like this to the top
of the |
| 212 html file after the DOCTYPE tag: |
| 213 <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true ] --> |
| 214 |
| 215 If more than one option is needed, the options can be specified as a com
ma |
| 216 separated string e.g. |
| 217 <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true,--use
ZombieMode=true ] --> |
| 218 |
| 219 This only works with JSC options that can be changed at runtime. Not al
l JSC |
| 220 options can be changed this way as some options are only checked and set
once at |
| 221 VM / process initialization time: changing this type of options may have
no |
| 222 effect. It's the test writer's responsibility to determine which option
s are |
| 223 appropriate for with this webkit-test-runner jscOptions option. |
| 224 |
| 225 This implementation is a workaround until we can change the run-webkit-t
ests |
| 226 scripts to parse the option and apply it to a new launch of DRT or WKTR: |
| 227 https://bugs.webkit.org/show_bug.cgi?id=186452 |
| 228 |
| 229 * DumpRenderTree/TestOptions.cpp: |
| 230 (TestOptions::TestOptions): |
| 231 (TestOptions::webViewIsCompatibleWithOptions const): |
| 232 * DumpRenderTree/TestOptions.h: |
| 233 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 234 (setJSCOptions): |
| 235 (resetWebViewToConsistentStateBeforeTesting): |
| 236 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: |
| 237 (WTR::InjectedBundle::didReceiveMessageToPage): |
| 238 * WebKitTestRunner/TestController.cpp: |
| 239 (WTR::TestController::resetStateToConsistentValues): |
| 240 (WTR::updateTestOptionsFromTestHeader): |
| 241 * WebKitTestRunner/TestOptions.h: |
| 242 (WTR::TestOptions::hasSameInitializationOptions const): |
| 243 |
| 244 2018-06-11 Brady Eidson <beidson@apple.com> |
| 245 |
| 246 Add a command line default to force WebKitTestRunner to turn on process
swap on navigation. |
| 247 https://bugs.webkit.org/show_bug.cgi?id=186534 |
| 248 |
| 249 Reviewed by Chris Dumez. |
| 250 |
| 251 Right now Process Swap On Navigation is enabled on a per-test basis. |
| 252 The future is to enable it by default. |
| 253 |
| 254 Adding a 'defaults write' helps us get to that future. |
| 255 |
| 256 * WebKitTestRunner/TestController.cpp: |
| 257 (WTR::TestController::testOptionsForTest const): |
| 258 (WTR::TestController::platformAddTestOptions const): |
| 259 * WebKitTestRunner/TestController.h: |
| 260 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 261 (WTR::TestController::platformAddTestOptions const): |
| 262 |
| 263 2018-06-11 Chris Dumez <cdumez@apple.com> |
| 264 |
| 265 Allow enabling PSON in layout tests without window.open support |
| 266 https://bugs.webkit.org/show_bug.cgi?id=186537 |
| 267 |
| 268 Reviewed by Geoffrey Garen. |
| 269 |
| 270 Allow enabling PSON in layout tests without window.open support since wi
ndow.open support |
| 271 is far from being ready and we plan to enable PSON in layout tests soon. |
| 272 |
| 273 * WebKitTestRunner/TestController.cpp: |
| 274 (WTR::TestController::createWebViewWithOptions): |
| 275 (WTR::updateTestOptionsFromTestHeader): |
| 276 * WebKitTestRunner/TestOptions.h: |
| 277 (WTR::TestOptions::hasSameInitializationOptions const): |
| 278 |
| 279 2018-06-11 Brady Eidson <beidson@apple.com> |
| 280 |
| 281 Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of prep
aration for ARC |
| 282 https://bugs.webkit.org/show_bug.cgi?id=186436 |
| 283 |
| 284 Patch by Darin Adler |
| 285 Reviewed by Brady Eidson. |
| 286 |
| 287 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: |
| 288 (TestWebKitAPI::TEST): |
| 289 |
| 290 2018-06-11 Mark Lam <mark.lam@apple.com> |
| 291 |
| 292 Gardening: skip BigInt tests on iOS until the feature is stable. |
| 293 <rdar://problem/40331121> |
| 294 |
| 295 Not reviewed. |
| 296 |
| 297 * Scripts/run-jsc-stress-tests: |
| 298 |
| 299 2018-06-11 Fujii Hironori <Hironori.Fujii@sony.com> |
| 300 |
| 301 [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API |
| 302 https://bugs.webkit.org/show_bug.cgi?id=186478 |
| 303 |
| 304 Reviewed by Alex Christensen. |
| 305 |
| 306 Added "New WebKit Window" and "New WebKitLegacy Window" menu |
| 307 items. Disabled the menu item "New WebKit Window" if |
| 308 !ENABLE(WEBKIT). |
| 309 |
| 310 * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp |
| 311 source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT. |
| 312 * MiniBrowser/win/MainWindow.cpp: |
| 313 (MainWindow::MainWindow): |
| 314 (MainWindow::create): |
| 315 (MainWindow::init): |
| 316 (MainWindow::WndProc): |
| 317 * MiniBrowser/win/MainWindow.h: |
| 318 * MiniBrowser/win/MiniBrowserLib.rc: |
| 319 * MiniBrowser/win/MiniBrowserLibResource.h: |
| 320 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 321 (PrintWebUIDelegate::createWebViewWithRequest): |
| 322 * MiniBrowser/win/WebKitBrowserWindow.cpp: Added. |
| 323 (createString): |
| 324 (toUtf8): |
| 325 (createWKString): |
| 326 (createWKURL): |
| 327 (WebKitBrowserWindow::create): |
| 328 (WebKitBrowserWindow::WebKitBrowserWindow): |
| 329 (WebKitBrowserWindow::init): |
| 330 (WebKitBrowserWindow::hwnd): |
| 331 (WebKitBrowserWindow::loadURL): |
| 332 (WebKitBrowserWindow::loadHTMLString): |
| 333 (WebKitBrowserWindow::navigateForwardOrBackward): |
| 334 (WebKitBrowserWindow::navigateToHistory): |
| 335 (WebKitBrowserWindow::setPreference): |
| 336 (WebKitBrowserWindow::print): |
| 337 (WebKitBrowserWindow::launchInspector): |
| 338 (WebKitBrowserWindow::setUserAgent): |
| 339 (WebKitBrowserWindow::userAgent): |
| 340 (WebKitBrowserWindow::showLayerTree): |
| 341 (WebKitBrowserWindow::updateStatistics): |
| 342 (WebKitBrowserWindow::resetZoom): |
| 343 (WebKitBrowserWindow::zoomIn): |
| 344 (WebKitBrowserWindow::zoomOut): |
| 345 (toWebKitBrowserWindow): |
| 346 (WebKitBrowserWindow::didReceiveTitleForFrame): |
| 347 (WebKitBrowserWindow::didCommitLoadForFrame): |
| 348 * MiniBrowser/win/WebKitBrowserWindow.h: |
| 349 * MiniBrowser/win/WinMain.cpp: |
| 350 (wWinMain): |
| 351 |
| 352 2018-06-11 Keith Miller <keith_miller@apple.com> |
| 353 |
| 354 Add missing whitespace to run-jsc command |
| 355 https://bugs.webkit.org/show_bug.cgi?id=186528 |
| 356 |
| 357 Reviewed by Mark Lam. |
| 358 |
| 359 * Scripts/run-jsc: |
| 360 |
| 361 2018-06-11 Philippe Normand <pnormand@igalia.com> |
| 362 |
| 363 [webkitpy] PHP7.2 support on Debian platforms |
| 364 https://bugs.webkit.org/show_bug.cgi?id=186521 |
| 365 |
| 366 Reviewed by Michael Catanzaro. |
| 367 |
| 368 * Scripts/webkitpy/port/base.py: |
| 369 (Port._debian_php_version): Refactor and add PHP 7.2 version support. |
| 370 |
| 371 2018-06-11 Carlos Garcia Campos <cgarcia@igalia.com> |
| 372 |
| 373 Unreviewed. Fix WPE API and layout tests after r232670. |
| 374 |
| 375 Now that dyz is not installed, there's not -default.so symlink for the W
PE backend, so we need to use |
| 376 WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fd
o backend. |
| 377 |
| 378 * Scripts/run-wpe-tests: |
| 379 (WPETestRunner.__init__): |
| 380 (WPETestRunner): |
| 381 (WPETestRunner.setup_testing_environment): |
| 382 * Scripts/webkitpy/port/wpe.py: |
| 383 (WPEPort.setup_environ_for_server): |
| 384 * glib/api_test_runner.py: |
| 385 (TestRunner.setup_testing_environment): |
| 386 (TestRunner.run_tests): |
| 387 (TestRunner._setup_testing_environment): Deleted. |
| 388 |
| 389 2018-06-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 390 |
| 391 [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolate
d world |
| 392 https://bugs.webkit.org/show_bug.cgi?id=186192 |
| 393 |
| 394 Reviewed by Michael Catanzaro. |
| 395 |
| 396 Add tests cases for the new API. |
| 397 |
| 398 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: |
| 399 (testWebViewRunJavaScript): |
| 400 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: |
| 401 (methodCallCallback): |
| 402 (webkit_web_extension_initialize_with_user_data): |
| 403 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: |
| 404 (runJavaScriptInWorldReadyCallback): |
| 405 (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished): |
| 406 (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished): |
| 407 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: |
| 408 |
| 409 2018-06-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 410 |
| 411 [WPE] Add a MiniBrowser and use it to run WebDriver tests |
| 412 https://bugs.webkit.org/show_bug.cgi?id=186345 |
| 413 |
| 414 Reviewed by Žan Doberšek. |
| 415 |
| 416 Most of the code is based on dyz and gtk MiniBrowser. This patch adds a
new internal library WPEToolingBackends, |
| 417 including the headless view backend and a new window backend to be used
by the MiniBrowser. MiniBrowser can also |
| 418 run in headless mode, by using the headless backend instead of the windo
w one, which will allow us to run the |
| 419 WebDriver tests in the bots. |
| 420 |
| 421 * CMakeLists.txt: |
| 422 * MiniBrowser/wpe/CMakeLists.txt: Added. |
| 423 * MiniBrowser/wpe/main.cpp: Added. |
| 424 (automationStartedCallback): |
| 425 (createViewBackend): |
| 426 (main): |
| 427 * Scripts/run-minibrowser: Remove WPE specific code. |
| 428 * Scripts/run-webdriver-tests: Add headless display-server option. |
| 429 * Scripts/webkitdirs.pm: |
| 430 (launcherName): Remove WPE specific code. |
| 431 * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: |
| 432 (WebDriverWPE.browser_name): Return MiniBrowser. |
| 433 (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build
dir. |
| 434 (WebDriverWPE.browser_args): Add --headless when running in headless mod
e. |
| 435 (WebDriverWPE.capabilities): Use the full browser path. |
| 436 * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py: |
| 437 (WebDriverTestRunnerSelenium.collect_tests): Fix early return value. |
| 438 * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of Hea
dlessViewBackend. |
| 439 * TestWebKitAPI/PlatformWebView.h: Ditto. |
| 440 * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto |
| 441 * TestWebKitAPI/glib/WebKitGLib/TestMain.h: |
| 442 (Test::createWebViewBackend): Ditto. |
| 443 * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: |
| 444 (TestWebKitAPI::PlatformWebView::initialize): Ditto. |
| 445 * WebKitTestRunner/PlatformWPE.cmake: Ditto. |
| 446 * WebKitTestRunner/PlatformWebView.h: Ditto. |
| 447 * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: |
| 448 (WTR::PlatformWebView::PlatformWebView): Ditto. |
| 449 * wpe/HeadlessViewBackend/CMakeLists.txt: Removed. |
| 450 * wpe/backends/CMakeLists.txt: Added. |
| 451 * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessV
iewBackend/HeadlessViewBackend.cpp. |
| 452 (WPEToolingBackends::getEGLDisplay): |
| 453 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): |
| 454 (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend): |
| 455 (WPEToolingBackends::HeadlessViewBackend::createSnapshot): |
| 456 (WPEToolingBackends::HeadlessViewBackend::performUpdate): |
| 457 (WPEToolingBackends::HeadlessViewBackend::displayBuffer): |
| 458 * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessVie
wBackend/HeadlessViewBackend.h. |
| 459 * wpe/backends/ViewBackend.cpp: Added. |
| 460 (WPEToolingBackends::ViewBackend::ViewBackend): |
| 461 (WPEToolingBackends::ViewBackend::~ViewBackend): |
| 462 (WPEToolingBackends::ViewBackend::initialize): |
| 463 (WPEToolingBackends::ViewBackend::setInputClient): |
| 464 (WPEToolingBackends::ViewBackend::backend const): |
| 465 (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent): |
| 466 (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent): |
| 467 (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent): |
| 468 * wpe/backends/ViewBackend.h: Added. |
| 469 * wpe/backends/WindowViewBackend.cpp: Added. |
| 470 (WPEToolingBackends::WindowViewBackend::WindowViewBackend): |
| 471 (WPEToolingBackends::WindowViewBackend::~WindowViewBackend): |
| 472 (WPEToolingBackends::WindowViewBackend::displayBuffer): |
| 473 (WPEToolingBackends::WindowViewBackend::handleKeyEvent): |
| 474 * wpe/backends/WindowViewBackend.h: Added. |
| 475 * wpe/jhbuild.modules: Remove dyz and add wayland-protocols. |
| 476 |
| 477 2018-06-10 Fujii Hironori <Hironori.Fujii@sony.com> |
| 478 |
| 479 [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBr
owserWindow |
| 480 https://bugs.webkit.org/show_bug.cgi?id=186427 |
| 481 |
| 482 Reviewed by Ryosuke Niwa. |
| 483 |
| 484 * MiniBrowser/win/AccessibilityDelegate.cpp: |
| 485 * MiniBrowser/win/AccessibilityDelegate.h: |
| 486 (AccessibilityDelegate::AccessibilityDelegate): |
| 487 * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitL
egacyBrowserWindow.cpp. |
| 488 * MiniBrowser/win/Common.h: |
| 489 * MiniBrowser/win/MainWindow.cpp: |
| 490 (MainWindow::init): |
| 491 * MiniBrowser/win/MainWindow.h: |
| 492 * MiniBrowser/win/MiniBrowserWebHost.cpp: |
| 493 * MiniBrowser/win/MiniBrowserWebHost.h: |
| 494 (MiniBrowserWebHost::MiniBrowserWebHost): |
| 495 * MiniBrowser/win/PageLoadTestClient.cpp: |
| 496 (PageLoadTestClient::PageLoadTestClient): |
| 497 * MiniBrowser/win/PageLoadTestClient.h: |
| 498 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 499 (PrintWebUIDelegate::createWebViewWithRequest): |
| 500 * MiniBrowser/win/PrintWebUIDelegate.h: |
| 501 (PrintWebUIDelegate::PrintWebUIDelegate): |
| 502 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 503 * MiniBrowser/win/ResourceLoadDelegate.h: |
| 504 (ResourceLoadDelegate::ResourceLoadDelegate): |
| 505 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/Mini
Browser/win/MiniBrowser.cpp. |
| 506 * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBr
owser/win/MiniBrowser.h. |
| 507 * MiniBrowser/win/WebDownloadDelegate.cpp: |
| 508 (WebDownloadDelegate::WebDownloadDelegate): |
| 509 * MiniBrowser/win/WebDownloadDelegate.h: |
| 510 |
| 511 2018-06-10 Chris Dumez <cdumez@apple.com> |
| 512 |
| 513 Reload the Web view in case of crash if the client does not implement we
bViewWebContentProcessDidTerminate delegate |
| 514 https://bugs.webkit.org/show_bug.cgi?id=186468 |
| 515 |
| 516 Reviewed by Geoffrey Garen. |
| 517 |
| 518 Add API test coverage. |
| 519 |
| 520 * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: |
| 521 (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisiona
lNavigation:]): |
| 522 (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigatio
n:]): |
| 523 (TEST): |
| 524 |
| 525 2018-06-10 Michael Catanzaro <mcatanzaro@igalia.com> |
| 526 |
| 527 [WPE][GTK] paypal.com requires user agent quirk |
| 528 https://bugs.webkit.org/show_bug.cgi?id=186466 |
| 529 |
| 530 Reviewed by Carlos Garcia Campos. |
| 531 |
| 532 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: |
| 533 (TestWebKitAPI::TEST): |
| 534 |
| 535 2018-06-09 Dan Bernstein <mitz@apple.com> |
| 536 |
| 537 [Xcode] Clean up and modernize some build setting definitions |
| 538 https://bugs.webkit.org/show_bug.cgi?id=186463 |
| 539 |
| 540 Reviewed by Sam Weinig. |
| 541 |
| 542 * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition fo
r macOS 10.11. |
| 543 Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that |
| 544 WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode ver
sions. |
| 545 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed defin
ition for macOS |
| 546 10.11. |
| 547 * MiniBrowser/Configurations/Base.xcconfig: Ditto. |
| 548 * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto. |
| 549 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. |
| 550 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto. |
| 551 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the d
efinitions of |
| 552 ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is
the earliest |
| 553 supported version. |
| 554 * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Remove
d definitions for |
| 555 macOS 10.11. |
| 556 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified
the definition of |
| 557 WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_S
TUBS is true for all |
| 558 supported Xcode versions |
| 559 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definit
ion for macOS 10.11. |
| 560 |
| 561 2018-06-09 Dan Bernstein <mitz@apple.com> |
| 562 |
| 563 Added missing file references to the Configuration group. |
| 564 |
| 565 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 566 |
| 567 2018-06-08 Darin Adler <darin@apple.com> |
| 568 |
| 569 [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for
ARC |
| 570 https://bugs.webkit.org/show_bug.cgi?id=186436 |
| 571 |
| 572 Reviewed by Anders Carlsson. |
| 573 |
| 574 * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm: |
| 575 (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoa
ding): |
| 576 Use @autoreleasepool. |
| 577 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: |
| 578 (TestWebKitAPI::buildAndPerformTest): Ditto. |
| 579 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: |
| 580 (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto. |
| 581 |
| 582 2018-06-08 Wenson Hsieh <wenson_hsieh@apple.com> |
| 583 |
| 584 [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Par
t 1) |
| 585 https://bugs.webkit.org/show_bug.cgi?id=186442 |
| 586 <rdar://problem/40879364> |
| 587 |
| 588 Reviewed by Tim Horton. |
| 589 |
| 590 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: |
| 591 |
| 592 2018-06-08 Alicia Boya GarcÃa <aboya@igalia.com> |
| 593 |
| 594 [GTK] Update to libva-2.1.0 in jhbuild |
| 595 https://bugs.webkit.org/show_bug.cgi?id=186434 |
| 596 |
| 597 Reviewed by Philippe Normand. |
| 598 |
| 599 * gstreamer/jhbuild.modules: |
| 600 |
| 601 2018-06-07 Yusuke Suzuki <utatane.tea@gmail.com> |
| 602 |
| 603 [WTF] Add WorkerPool |
| 604 https://bugs.webkit.org/show_bug.cgi?id=174569 |
| 605 |
| 606 Reviewed by Carlos Garcia Campos. |
| 607 |
| 608 * TestWebKitAPI/CMakeLists.txt: |
| 609 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 610 * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added. |
| 611 (TestWebKitAPI::TEST): |
| 612 |
| 613 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 614 |
| 615 [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and
WK2 BrowserWindow |
| 616 https://bugs.webkit.org/show_bug.cgi?id=186421 |
| 617 |
| 618 Reviewed by Ryosuke Niwa. |
| 619 |
| 620 This is the core patch to make MiniBrowser to support WK1 and WK2 |
| 621 windows (Bug 184770). |
| 622 |
| 623 I will rename MiniBrowser class to WK1BrowserWindow in a follow-up |
| 624 patch (Bug 184770 Comment 12). |
| 625 |
| 626 * MiniBrowser/win/BrowserWindow.h: Added. |
| 627 * MiniBrowser/win/MainWindow.cpp: |
| 628 (MainWindow::WndProc): |
| 629 * MiniBrowser/win/MainWindow.h: |
| 630 (MainWindow::browserWindow const): |
| 631 * MiniBrowser/win/MiniBrowser.cpp: |
| 632 (MiniBrowser::create): |
| 633 (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argume
nt hWnd. |
| 634 (MiniBrowser::navigateToHistory): Ditto. |
| 635 * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface. |
| 636 Make all other methods private and make delegates classes friends. |
| 637 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 638 (PrintWebUIDelegate::createWebViewWithRequest): |
| 639 |
| 640 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 641 |
| 642 [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a Main
Window's method |
| 643 https://bugs.webkit.org/show_bug.cgi?id=186387 |
| 644 |
| 645 Reviewed by Ryosuke Niwa. |
| 646 |
| 647 MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser. |
| 648 It should be a MainWindow's method. |
| 649 |
| 650 * MiniBrowser/win/MainWindow.cpp: |
| 651 (MainWindow::init): Call MainWindow::updateDeviceScaleFactor. |
| 652 (MainWindow::resizeSubViews): Do not set a font every time window size i
s changed. |
| 653 (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DP
ICHANGED. |
| 654 (MainWindow::updateDeviceScaleFactor): Converted from |
| 655 MiniBrowser::updateDeviceScaleFactor and |
| 656 MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is
changed. |
| 657 * MiniBrowser/win/MainWindow.h: |
| 658 * MiniBrowser/win/MiniBrowser.cpp: |
| 659 (MiniBrowser::init): |
| 660 (MiniBrowser::generateFontForScaleFactor): Deleted. |
| 661 (MiniBrowser::updateDeviceScaleFactor): Deleted. |
| 662 * MiniBrowser/win/MiniBrowser.h: |
| 663 (MiniBrowser::deviceScaleFactor): Deleted. |
| 664 (MiniBrowser::urlBarFont): Deleted. |
| 665 |
| 666 2018-06-07 Jonathan Bedard <jbedard@apple.com> |
| 667 |
| 668 [webkitpy] Treat svn versions as Version objects |
| 669 https://bugs.webkit.org/show_bug.cgi?id=186403 |
| 670 <rdar://problem/40904860> |
| 671 |
| 672 Reviewed by Dan Bernstein. |
| 673 |
| 674 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: |
| 675 * Scripts/webkitpy/common/checkout/scm/svn.py: |
| 676 (SVN.svn_version): Return Version object instead of string. |
| 677 (SVN._status_regexp): Convert version string to Version object. |
| 678 (SVN.add_list): Ditto. |
| 679 |
| 680 2018-06-07 Tadeu Zagallo <tzagallo@apple.com> |
| 681 |
| 682 Don't try to allocate JIT memory if we don't have the JIT entitlement |
| 683 https://bugs.webkit.org/show_bug.cgi?id=182605 |
| 684 <rdar://problem/38271229> |
| 685 |
| 686 Reviewed by Mark Lam. |
| 687 |
| 688 Add the Security framework to the TestWTF target, since it's required by
the new function to check the entitlements. |
| 689 |
| 690 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 691 |
| 692 2018-06-07 Mark Lam <mark.lam@apple.com> |
| 693 |
| 694 Enhance run-jsc-stress-tests to allow a test to specify test specific op
tions required for it to run. |
| 695 https://bugs.webkit.org/show_bug.cgi?id=186409 |
| 696 <rdar://problem/40909007> |
| 697 |
| 698 Reviewed by Saam Barati. |
| 699 |
| 700 This is needed because some tests are written with specific features in
mind, and |
| 701 we may not necessarily want to enable that option for all tests. |
| 702 |
| 703 We can now specify something like this at the top of a test file: |
| 704 //@ requireOptions("--useIntlPluralRules=true") |
| 705 |
| 706 ... and ensure that that test will be run with the --useIntlPluralRules=
true |
| 707 option for all test configurations that run the test. |
| 708 |
| 709 * Scripts/run-jsc-stress-tests: |
| 710 |
| 711 2018-06-07 Tim Horton <timothy_horton@apple.com> |
| 712 |
| 713 REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChang
esDuringAnimatedResizeSucceed is failing |
| 714 https://bugs.webkit.org/show_bug.cgi?id=186395 |
| 715 <rdar://problem/40902427> |
| 716 |
| 717 Reviewed by Wenson Hsieh. |
| 718 |
| 719 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm: |
| 720 (TEST): |
| 721 endAnimatedResize no longer synchronizes, so we have to wait for the nex
t presentation update. |
| 722 |
| 723 2018-06-07 Thibault Saunier <tsaunier@igalia.com> |
| 724 |
| 725 [GTK][WPE] Start implementing MediaStream API |
| 726 https://bugs.webkit.org/show_bug.cgi?id=185787 |
| 727 |
| 728 Reviewed by Philippe Normand. |
| 729 |
| 730 * Scripts/webkitpy/style/checker.py: Apply special formatting rules for
new GObject subclasses. |
| 731 * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base. |
| 732 * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTIO
N-on-EVENT_STREAM_COLL.patch: |
| 733 Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d
0e9cc92a86aa0227ee87406737b6d31670aea |
| 734 |
| 735 2018-06-07 Brendan McLoughlin <brendan@bocoup.com> |
| 736 |
| 737 Update web-platform-tests github location in webkitpy.w3c.test_importer |
| 738 https://bugs.webkit.org/show_bug.cgi?id=186392 |
| 739 |
| 740 Reviewed by Youenn Fablet. |
| 741 |
| 742 * Scripts/webkitpy/w3c/test_importer.py: |
| 743 (TestImporter.write_import_log): |
| 744 |
| 745 2018-06-07 Jonathan Bedard <jbedard@apple.com> |
| 746 |
| 747 webkitperl: Generalize .internal SDK suffix |
| 748 https://bugs.webkit.org/show_bug.cgi?id=186352 |
| 749 <rdar://problem/40853947> |
| 750 |
| 751 Reviewed by Alexey Proskuryakov. |
| 752 |
| 753 * Scripts/build-webkit: |
| 754 * Scripts/package-root: |
| 755 (usage): |
| 756 * Scripts/webkitdirs.pm: |
| 757 (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output. |
| 758 (availableXcodeSDKS): Generate a list of all available Xcode SDKs on thi
s machine. |
| 759 (determineXcodeSDK): Always prefer .internal SDKs if available. |
| 760 * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl: |
| 761 |
| 762 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 763 |
| 764 [Win][MiniBrowser] Support multiple windows properly |
| 765 https://bugs.webkit.org/show_bug.cgi?id=186263 |
| 766 |
| 767 Reviewed by Ryosuke Niwa. |
| 768 |
| 769 The current implementation of |
| 770 PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using |
| 771 CreateProcess to open a new window, and doesn't return the new |
| 772 instance of IWebView. As the result, for example, window.close |
| 773 doesn't work as expected. |
| 774 |
| 775 In this change, a new MainWindow is created and return the |
| 776 IWebView in PrintWebUIDelegate::createWebViewWithRequest. |
| 777 |
| 778 In addition to it, this change unifies the lifetime of MiniBrowser |
| 779 and its delegates AccessibilityDelegate, PrintWebUIDelegate, |
| 780 ResourceLoadDelegate and WebDownloadDelegate in order to keep |
| 781 MiniBrowser alive as long as the delegates live. Because the |
| 782 window of webview keeps references of such delegates and accesses |
| 783 those after MiniBrowser destruction. |
| 784 |
| 785 * MiniBrowser/win/MainWindow.h: Added s_numInstances class member |
| 786 to count the number of instance to close the application. Do not |
| 787 use unique_ptr for m_browserWindow because it has ref count now. |
| 788 * MiniBrowser/win/MainWindow.cpp: |
| 789 (MainWindow::MainWindow): Increment s_numInstances. |
| 790 (MainWindow::~MainWindow): Decrement s_numInstances. |
| 791 (MainWindow::create): |
| 792 (MainWindow::init): |
| 793 (MainWindow::WndProc): Rename thiz to thisWindow. Keep this |
| 794 instance alive during this function by using RefPtr<MainWindow>. |
| 795 Deref the MainWindow instance on WM_DESTROY. Quit the application |
| 796 when the last MainWindow is closed. |
| 797 (MainWindow::cachesDialogProc): Rename thiz to thisWindow. |
| 798 (MainWindow::customUserAgentDialogProc): Ditto. |
| 799 * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release. |
| 800 * MiniBrowser/win/MiniBrowser.cpp: |
| 801 (MiniBrowser::create): |
| 802 (MiniBrowser::AddRef): |
| 803 (MiniBrowser::Release): |
| 804 (MiniBrowser::init): Passes this to the constructors of delegates. |
| 805 * MiniBrowser/win/AccessibilityDelegate.cpp: |
| 806 (AccessibilityDelegate::AddRef): Delegate to MiniBrowser. |
| 807 (AccessibilityDelegate::Release): Ditto. |
| 808 * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount. |
| 809 (AccessibilityDelegate::AccessibilityDelegate): |
| 810 * MiniBrowser/win/MiniBrowserWebHost.cpp: |
| 811 (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser. |
| 812 (MiniBrowserWebHost::Release): Ditto. |
| 813 * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount. |
| 814 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 815 (PrintWebUIDelegate::createWebViewWithRequest): Create a new |
| 816 MainWindow and return the IWebView. |
| 817 (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser. |
| 818 (PrintWebUIDelegate::Release): Ditto. |
| 819 * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount. |
| 820 (PrintWebUIDelegate::PrintWebUIDelegate): |
| 821 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 822 (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser. |
| 823 (ResourceLoadDelegate::Release): Ditto. |
| 824 * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount. |
| 825 * MiniBrowser/win/WebDownloadDelegate.cpp: |
| 826 (WebDownloadDelegate::WebDownloadDelegate): |
| 827 (WebDownloadDelegate::AddRef): Delegate to MiniBrowser. |
| 828 (WebDownloadDelegate::Release): Ditto. |
| 829 * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount. |
| 830 |
| 831 2018-06-06 Fujii Hironori <Hironori.Fujii@sony.com> |
| 832 |
| 833 [Win][MiniBrowser] Remove gMainWindow global variable |
| 834 https://bugs.webkit.org/show_bug.cgi?id=186378 |
| 835 |
| 836 Reviewed by Ryosuke Niwa. |
| 837 |
| 838 I'm going to support multiple MainWindow in Bug 186263. It should |
| 839 not be assumed that MainWindow has only one instance. gMainWindow |
| 840 is used only in DisplayAuthDialog. |
| 841 |
| 842 * MiniBrowser/win/Common.cpp: |
| 843 (authDialogProc): Use DWLP_USER to store the dialog data. |
| 844 (displayAuthDialog): Moved and renamed from |
| 845 MainWindow::displayAuthDialog. Use DialogBoxParam instead of |
| 846 DialogBox to pass a data pointer. Do not return S_OK if |
| 847 DialogBoxParam returns -1. Take a HWND argument as the parent |
| 848 window. |
| 849 (DisplayAuthDialog): Deleted. |
| 850 * MiniBrowser/win/Common.h: |
| 851 * MiniBrowser/win/MainWindow.cpp: |
| 852 (authDialogProc): Moved to Common.cpp. |
| 853 (MainWindow::displayAuthDialog): Ditto. |
| 854 * MiniBrowser/win/MainWindow.h: |
| 855 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 856 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): |
| 857 * MiniBrowser/win/WinMain.cpp: |
| 858 (wWinMain): Added a local variable mainWindow instead of using |
| 859 gMainWindow. |
| 860 |
| 861 2018-06-06 Dan Bernstein <mitz@apple.com> |
| 862 |
| 863 [Xcode] Opt out of the New Build System |
| 864 https://bugs.webkit.org/show_bug.cgi?id=186380 |
| 865 |
| 866 Reviewed by Alexey Proskuryakov. |
| 867 |
| 868 * Scripts/webkitdirs.pm: |
| 869 (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild. |
| 870 |
| 871 2018-06-06 Antoine Quint <graouts@apple.com> |
| 872 |
| 873 Rename color-filter to -apple-color-filter and do not expose it to Web c
ontent |
| 874 https://bugs.webkit.org/show_bug.cgi?id=186306 |
| 875 <rdar://problem/39874167> |
| 876 |
| 877 Reviewed by Simon Fraser. |
| 878 |
| 879 Adding an option to turn support for the -apple-color-filter property on
via an HTML comment. |
| 880 |
| 881 * DumpRenderTree/TestOptions.cpp: |
| 882 (TestOptions::TestOptions): |
| 883 * DumpRenderTree/TestOptions.h: |
| 884 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 885 (setWebPreferencesForTestOptions): |
| 886 * WebKitTestRunner/TestController.cpp: |
| 887 (WTR::TestController::resetPreferencesToConsistentValues): |
| 888 (WTR::updateTestOptionsFromTestHeader): |
| 889 * WebKitTestRunner/TestOptions.h: |
| 890 (WTR::TestOptions::hasSameInitializationOptions const): |
| 891 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 892 (WTR::TestController::platformCreateWebView): |
| 893 |
| 894 2018-06-06 Brent Fulgham <bfulgham@apple.com> |
| 895 |
| 896 Adjust compile and runtime flags to match shippable state of features (P
art 2) |
| 897 https://bugs.webkit.org/show_bug.cgi?id=186319 |
| 898 <rdar://problem/40352045> |
| 899 |
| 900 Unreviewed test fix. |
| 901 |
| 902 TestWebKitAPI was timing out because 'color' input types are no longer s
upport. I also discovered that the |
| 903 ASSERT_STREQ macro returns on error, which causes tests to time out when
ever a 'done = true' call (needed to |
| 904 end the test) is done after ASSERT_STREQ, which might fail and return ea
rly, preventing the flag from being |
| 905 set. |
| 906 |
| 907 * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm
: |
| 908 (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowser
ContextController:]): Make testing of |
| 909 the 'color' input type conditional on the feature being part of the buil
d. |
| 910 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 911 (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set
the 'done=true' state before performing |
| 912 string equality assertions, since they do an early return and bypass the
end state of the test. |
| 913 (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didRes
ignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto. |
| 914 (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:
initiatedByFrame:completionHandler:]): Ditto. |
| 915 (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAler
tPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto. |
| 916 |
| 917 2018-06-05 Chris Dumez <cdumez@apple.com> |
| 918 |
| 919 Regression(r232082): Websites get loaded inside of Messages App chat tra
nscript |
| 920 https://bugs.webkit.org/show_bug.cgi?id=186331 |
| 921 <rdar://problem/40735446> |
| 922 |
| 923 Reviewed by Darin Adler. |
| 924 |
| 925 Add API test coverage. |
| 926 |
| 927 * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: |
| 928 (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolic
yForNavigationAction:request:frame:decisionListener:]): |
| 929 (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartPro
visionalLoadForFrame:]): |
| 930 (TestWebKitAPI::TEST): |
| 931 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAct
ion:request:frame:decisionListener:]): Deleted. |
| 932 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:requ
est:frame:decisionListener:]): Deleted. |
| 933 (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): De
leted. |
| 934 |
| 935 2018-06-05 Wenson Hsieh <wenson_hsieh@apple.com> |
| 936 |
| 937 DataInteractionTests ContentEditableToTextarea and ContentEditableToCont
entEditable are failing on recent iOS 12 |
| 938 https://bugs.webkit.org/show_bug.cgi?id=186325 |
| 939 <rdar://problem/40527850> |
| 940 |
| 941 Reviewed by Tim Horton. |
| 942 |
| 943 Tweak these API tests so that they're robust against changes to how NSAt
tributedStrings are serialized in item |
| 944 providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions
of iOS, just verify that either rich |
| 945 text type is present in the list of dragged type identifiers, and that t
he rich text type is placed at a higher |
| 946 fidelity than plain text. |
| 947 |
| 948 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: |
| 949 (checkRichTextTypePrecedesPlainTextType): |
| 950 (TestWebKitAPI::TEST): |
| 951 (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted. |
| 952 |
| 953 2018-06-05 Brent Fulgham <bfulgham@apple.com> |
| 954 |
| 955 Adjust compile and runtime flags to match shippable state of features |
| 956 https://bugs.webkit.org/show_bug.cgi?id=186319 |
| 957 <rdar://problem/40352045> |
| 958 |
| 959 Reviewed by Maciej Stachowiak, Jon Lee, and others. |
| 960 |
| 961 This patch revises the compile time and runtime state for various featur
es to match their |
| 962 suitability for end-user releases. |
| 963 |
| 964 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match We
bKit definition of |
| 965 WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defin
ed properly for |
| 966 Cocoa builds. |
| 967 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENAB
LE_INPUT_TYPE_COLOR |
| 968 or ENABLE_INPUT_TYPE_COLOR_POPOVER. |
| 969 |
| 970 2018-06-05 Saam Barati <sbarati@apple.com> |
| 971 |
| 972 run-testmem should have a dry run option and an option to parse the stdo
ut of executing the dry run |
| 973 https://bugs.webkit.org/show_bug.cgi?id=186293 |
| 974 |
| 975 Reviewed by Mark Lam. |
| 976 |
| 977 This makes it easier to execute run-testmem on a device that doesn't hav
e ruby |
| 978 on it. run-testmem now has a --dry option that will output commands to e
xecute |
| 979 in bash. To run on a device that doesn't have ruby, just put its output
into |
| 980 a bash script, and copy the PerformanceTests/testmem directory onto that
device, |
| 981 and execute the bash script. Running that bash script will give you raw
output. |
| 982 Make a file with that output and pass it into run-testmem using the --pa
rse option. |
| 983 run-testmem will parse the raw output and compute the benchmark score. |
| 984 |
| 985 * Scripts/run-testmem: |
| 986 |
| 987 2018-06-05 Youenn Fablet <youenn@apple.com> |
| 988 |
| 989 ServiceWorker registration should store any script fetched through impor
tScripts |
| 990 https://bugs.webkit.org/show_bug.cgi?id=182444 |
| 991 <rdar://problem/37164835> |
| 992 |
| 993 Reviewed by Chris Dumez. |
| 994 |
| 995 Add support to crash the storage process from Internals. |
| 996 |
| 997 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: |
| 998 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: |
| 999 (WTR::TestRunner::terminateStorageProcess): |
| 1000 * WebKitTestRunner/InjectedBundle/TestRunner.h: |
| 1001 * WebKitTestRunner/TestController.cpp: |
| 1002 (WTR::TestController::terminateStorageProcess): |
| 1003 * WebKitTestRunner/TestController.h: |
| 1004 * WebKitTestRunner/TestInvocation.cpp: |
| 1005 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): |
| 1006 |
| 1007 2018-06-05 Brent Fulgham <bfulgham@apple.com> |
| 1008 |
| 1009 Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple b
uilds |
| 1010 https://bugs.webkit.org/show_bug.cgi?id=186286 |
| 1011 <rdar://problem/40782992> |
| 1012 |
| 1013 Reviewed by Dan Bernstein. |
| 1014 |
| 1015 Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-
production builds) |
| 1016 to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manual
ly |
| 1017 change this flag when preparing for a production release. |
| 1018 |
| 1019 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATAB
LE_FRAMEWORKS to |
| 1020 determine whether experimental features should be enabled, and use it to
properly define |
| 1021 the feature flag. |
| 1022 |
| 1023 2018-06-05 Robin Morisset <rmorisset@apple.com> |
| 1024 |
| 1025 Add a grammar (in antlr4 format) to the WSL spec. |
| 1026 https://bugs.webkit.org/show_bug.cgi?id=186310 |
| 1027 |
| 1028 Rubberstamped by Filip Pizlo |
| 1029 |
| 1030 It is just the raw rules, without much comments and no typesetting. |
| 1031 Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK) |
| 1032 |
| 1033 It does not exactly match the parser of the current js implementation of
WSL, it: |
| 1034 - Accepts negative literals |
| 1035 - Reserves keywords fallthrough/auto |
| 1036 - Refuses '_' as a valid identifier |
| 1037 - Accepts several capitalizations for Null/True/False |
| 1038 - Accepts variable declarations at the top-level |
| 1039 - Correctly parses ternary expressions |
| 1040 - Forbids empty extension list for protocols |
| 1041 - Does not allow a space between '[' and ']' in type suffixes |
| 1042 - Correctly parses nested generics |
| 1043 - Accepts a 'fallthrough;' statement (for switches) |
| 1044 - Refuses chained relational operator (e.g. x < y < z) |
| 1045 - Generally a completely different structure for parsing effectful expre
ssions, although it probably accepts about the same language |
| 1046 - Currently only accepts literals and identifiers as constexpr (while th
e js parser accepts way too much, including '(x += 42)') |
| 1047 There are probably more differences that I missed. The js parser will pr
obably have to be mostly rewritten to follow the spec more closely (and fix all
the bugs). |
| 1048 I will try to see if it can be automatically derived from the antlr4 gra
mmar. |
| 1049 |
| 1050 * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added. |
| 1051 |
| 1052 2018-06-04 Frederic Wang <fwang@igalia.com> |
| 1053 |
| 1054 import-w3c-tests should rely on <meta name="flags"> to detect CSS manual
tests |
| 1055 https://bugs.webkit.org/show_bug.cgi?id=186261 |
| 1056 |
| 1057 Reviewed by Youenn Fablet. |
| 1058 |
| 1059 * Scripts/webkitpy/w3c/test_parser.py: |
| 1060 (TestParser.is_wpt_manualtest): Add code to detect whether a file is a m
anual test |
| 1061 from its <meta name="flags"> tags. This is based on SourceFile::content_
is_css_manual from |
| 1062 the WPT repository. |
| 1063 * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whe
ther files with |
| 1064 <meta name="flags"> are manual or non-manual according to CSS WG rules. |
| 1065 |
| 1066 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1067 |
| 1068 Fixed building ImageDiff with the default build system in the Xcode 10 d
eveloper beta. |
| 1069 |
| 1070 * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include |
| 1071 HaveInternalSDK.xcconfig, since it may not be preent. |
| 1072 |
| 1073 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1074 |
| 1075 Fixed building TestWebKitAPI with a shared build directory with XCBuild,
which is the |
| 1076 default build system in the Xcode 10 developer beta. |
| 1077 |
| 1078 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the ref
erence to the |
| 1079 built libWTF.a to be relative to the built products directory. |
| 1080 |
| 1081 2018-06-04 Chris Dumez <cdumez@apple.com> |
| 1082 |
| 1083 Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy
" |
| 1084 https://bugs.webkit.org/show_bug.cgi?id=186287 |
| 1085 <rdar://problem/40783352> |
| 1086 |
| 1087 Reviewed by Youenn Fablet. |
| 1088 |
| 1089 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 1090 (enableExperimentalFeatures): |
| 1091 * DumpRenderTree/win/DumpRenderTree.cpp: |
| 1092 (enableExperimentalFeatures): |
| 1093 |
| 1094 2018-06-04 Daniel Bates <dabates@apple.com> |
| 1095 |
| 1096 Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() |
| 1097 https://bugs.webkit.org/show_bug.cgi?id=186290 |
| 1098 |
| 1099 Reviewed by Aakash Jain. |
| 1100 |
| 1101 Although the usefulness of the code in MockBugzillaQueries.fetch_attachm
ent_ids_from_review_queue() is |
| 1102 questionable we should fix a typo when calling this mocked function with
argument since. |
| 1103 |
| 1104 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: |
| 1105 (MockBugzillaQueries.fetch_attachment_ids_from_review_queue): |
| 1106 |
| 1107 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1108 |
| 1109 Fixed building with the macOS Mojave seed SDK. |
| 1110 |
| 1111 * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: |
| 1112 |
| 1113 2018-06-04 Alexey Proskuryakov <ap@apple.com> |
| 1114 |
| 1115 Add Mojave support to WebKit tools |
| 1116 https://bugs.webkit.org/show_bug.cgi?id=186282 |
| 1117 |
| 1118 Reviewed by Daniel Bates. |
| 1119 |
| 1120 Nightly build support will be added separately. |
| 1121 |
| 1122 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images
/Mojave.png: Added. |
| 1123 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images
/Mojave@2x.png: Added. |
| 1124 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Script
s/Dashboard.js: |
| 1125 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles
/Main.css: |
| 1126 Added dashboard support. |
| 1127 |
| 1128 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: |
| 1129 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: |
| 1130 Trigger the right build queues on check-in. |
| 1131 |
| 1132 * Scripts/webkitpy/common/version_name_map.py: |
| 1133 * Scripts/webkitpy/common/version_name_map_unittest.py: |
| 1134 The main version mapping class updated. |
| 1135 |
| 1136 * Scripts/webkitpy/layout_tests/models/test_expectations.py: |
| 1137 * Scripts/webkitpy/port/mac_unittest.py: |
| 1138 Updated for more platforms in unit tests. |
| 1139 |
| 1140 * TestResultServer/static-dashboards/flakiness_dashboard.js: |
| 1141 Added the new platform to flakiness dashboard. |
| 1142 |
| 1143 2018-06-04 Wenson Hsieh <wenson_hsieh@apple.com> |
| 1144 |
| 1145 [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag |
| 1146 https://bugs.webkit.org/show_bug.cgi?id=186279 |
| 1147 |
| 1148 Reviewed by Tim Horton. |
| 1149 |
| 1150 Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS). |
| 1151 |
| 1152 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: |
| 1153 |
| 1154 2018-06-03 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1155 |
| 1156 [Win][MiniBrowser] Remove gMiniBrowser global variable |
| 1157 https://bugs.webkit.org/show_bug.cgi?id=186134 |
| 1158 |
| 1159 Reviewed by Brent Fulgham. |
| 1160 |
| 1161 It should not be assumed there is only one main window and one browser |
| 1162 window to support multiple windows properly. gMainWindow and |
| 1163 gMiniBrowser global variables should be removed. This change |
| 1164 removes gMiniBrowser. |
| 1165 |
| 1166 * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable. |
| 1167 * MiniBrowser/win/Common.h: Ditto. |
| 1168 * MiniBrowser/win/MainWindow.cpp: |
| 1169 (MainWindow::init): |
| 1170 (MainWindow::WndProc): |
| 1171 (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar. |
| 1172 (MainWindow::cachesDialogProc): Renamed from Caches. |
| 1173 (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent. |
| 1174 (MainWindow::onURLBarEnter): Extracted from EditProc. |
| 1175 (BackButtonProc): Deleted. |
| 1176 (ForwardButtonProc): Deleted. |
| 1177 (Caches): Renamed to MainWindow::cachesDialogProc. |
| 1178 (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc. |
| 1179 * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a m
ember variable of MainWindow. |
| 1180 * MiniBrowser/win/MiniBrowserLibResource.h: |
| 1181 * MiniBrowser/win/WinMain.cpp: |
| 1182 (wWinMain): |
| 1183 |
| 1184 2018-06-02 Darin Adler <darin@apple.com> |
| 1185 |
| 1186 [Cocoa] Update some code to be more ARC-compatible to prepare for future
ARC adoption |
| 1187 https://bugs.webkit.org/show_bug.cgi?id=186227 |
| 1188 |
| 1189 Reviewed by Dan Bernstein. |
| 1190 |
| 1191 * DumpRenderTree/mac/AccessibilityCommonMac.mm: |
| 1192 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1193 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1194 |
| 1195 * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing includ
e. |
| 1196 |
| 1197 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: |
| 1198 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1199 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: |
| 1200 (AccessibilityTextMarker::isEqual): Ditto. |
| 1201 (AccessibilityTextMarkerRange::isEqual): Ditto. |
| 1202 |
| 1203 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 1204 (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of N
SAutoreleasePool. |
| 1205 (DumpRenderTreeMain): Ditto. |
| 1206 (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto. |
| 1207 (runTest): Ditto. |
| 1208 |
| 1209 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: |
| 1210 (copyFile): Use a std::pair to return both a URL and an error rather tha
n using an |
| 1211 out argument for the NSError. |
| 1212 (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:o
ptions:operationQueue:reader:]): |
| 1213 Updated for the above change. |
| 1214 |
| 1215 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: |
| 1216 (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging
typecast. |
| 1217 (-[DumpRenderTreeWindow close]): Ditto. |
| 1218 * DumpRenderTree/mac/LayoutTestHelper.m: |
| 1219 (setDisplayColorProfile): Ditto. |
| 1220 |
| 1221 * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include. |
| 1222 |
| 1223 * DumpRenderTree/mac/ResourceLoadDelegate.mm: |
| 1224 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectRespons
e:fromDataSource:]): |
| 1225 Add __bridge to a bridging typecast. |
| 1226 * DumpRenderTree/mac/TestRunnerMac.mm: |
| 1227 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto. |
| 1228 (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool inst
ead of NSAutoreleasePool. |
| 1229 |
| 1230 * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment. |
| 1231 |
| 1232 * DumpRenderTree/mac/UIScriptControllerMac.mm: |
| 1233 (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridgin
g typecast. |
| 1234 (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto. |
| 1235 (WTR::UIScriptController::overridePreference): Ditto. |
| 1236 * DumpRenderTree/mac/WorkQueueItemMac.mm: |
| 1237 (LoadItem::invoke const): Ditto. |
| 1238 (LoadHTMLStringItem::invoke const): Ditto. |
| 1239 (ScriptItem::invoke const): Ditto. |
| 1240 |
| 1241 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: |
| 1242 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1243 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1244 |
| 1245 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: |
| 1246 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1247 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1248 |
| 1249 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: |
| 1250 (WTR::AccessibilityController::accessibleElementById): Add __bridge to a
bridging typecast. |
| 1251 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.m
m: |
| 1252 (-[NSString createJSStringRef]): Ditto. |
| 1253 * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: |
| 1254 (WTR::AccessibilityTextMarker::isEqual): Ditto. |
| 1255 * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm
: |
| 1256 (WTR::AccessibilityTextMarkerRange::isEqual): Ditto. |
| 1257 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: |
| 1258 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto. |
| 1259 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto. |
| 1260 (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto. |
| 1261 (WTR::AccessibilityUIElement::previousTextMarker): Ditto. |
| 1262 (WTR::AccessibilityUIElement::nextTextMarker): Ditto. |
| 1263 (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto. |
| 1264 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto. |
| 1265 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto. |
| 1266 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto. |
| 1267 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto. |
| 1268 (WTR::createJSStringRef): Ditto. |
| 1269 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto
. |
| 1270 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOpti
ons): Ditto. |
| 1271 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContains
Attribute): Ditto. |
| 1272 (WTR::AccessibilityUIElement::indexForTextMarker): Ditto. |
| 1273 (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto. |
| 1274 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Dit
to. |
| 1275 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Di
tto. |
| 1276 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
Ditto. |
| 1277 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto
. |
| 1278 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Di
tto. |
| 1279 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMar
ker): Ditto. |
| 1280 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
Ditto. |
| 1281 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Dit
to. |
| 1282 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMark
er): Ditto. |
| 1283 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): D
itto. |
| 1284 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 1285 (WTR::initializeWebViewConfiguration): Ditto. |
| 1286 (WTR::TestController::platformContext): Ditto. |
| 1287 (WTR::TestController::platformPreferences): Ditto. |
| 1288 (WTR::TestController::platformAdjustContext): Ditto. |
| 1289 * WebKitTestRunner/mac/PlatformWebViewMac.mm: |
| 1290 (WTR::PlatformWebView::PlatformWebView): Ditto. |
| 1291 * WebKitTestRunner/mac/TestControllerMac.mm: |
| 1292 (WTR::TestController::initializeInjectedBundlePath): Ditto. |
| 1293 (WTR::TestController::initializeTestPluginDirectory): Ditto. |
| 1294 (WTR::TestController::platformConfigureViewForTest): Ditto. |
| 1295 |
| 1296 * WebKitTestRunner/mac/UIScriptControllerMac.mm: |
| 1297 (WTR::nsString): Use CFBridgingRelease instead of autorelease. |
| 1298 (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to
a bridging |
| 1299 typecast. |
| 1300 |
| 1301 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing in
clude. |
| 1302 |
| 1303 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: |
| 1304 (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging
typecast. |
| 1305 (-[LocalPasteboard setString:forType:]): Ditto. |
| 1306 |
| 1307 * WebKitTestRunner/mac/main.mm: |
| 1308 (main): Use @autoreleasepool instead of NSAutoreleasePool. |
| 1309 |
| 1310 2018-06-02 Keith Miller <keith_miller@apple.com> |
| 1311 |
| 1312 run-jsc should pass the option to use dollar vm by default |
| 1313 https://bugs.webkit.org/show_bug.cgi?id=186170 |
| 1314 |
| 1315 Reviewed by Yusuke Suzuki. |
| 1316 |
| 1317 * Scripts/run-jsc: |
| 1318 |
| 1319 2018-06-02 Commit Queue <commit-queue@webkit.org> |
| 1320 |
| 1321 Unreviewed, rolling out r232421. |
| 1322 https://bugs.webkit.org/show_bug.cgi?id=186240 |
| 1323 |
| 1324 Breaks webkitpy tests (Requested by aakashjain on #webkit). |
| 1325 |
| 1326 Reverted changeset: |
| 1327 |
| 1328 "Add some tests for lldb_webkit.py" |
| 1329 https://bugs.webkit.org/show_bug.cgi?id=183744 |
| 1330 https://trac.webkit.org/changeset/232421 |
| 1331 |
| 1332 2018-06-01 Daniel Bates <dabates@apple.com> |
| 1333 |
| 1334 Add some tests for lldb_webkit.py |
| 1335 https://bugs.webkit.org/show_bug.cgi?id=183744 |
| 1336 |
| 1337 Reviewed by Alexey Proskuryakov. |
| 1338 |
| 1339 Adds some tests to ensure we do not regress LLDB pretty-printing of WTF:
:StringImpl |
| 1340 and WTF::String objects. |
| 1341 |
| 1342 The tests make use of the LLDB Python API (lldb.py) and a simple debug-b
uilt test |
| 1343 program, lldbWebKitTester, to run. For now, we only support building lld
bWebKitTester |
| 1344 on Mac. |
| 1345 |
| 1346 * Makefile: Build the simple test tool lldbWebKitTester on Mac. |
| 1347 * Scripts/build-lldbwebkittester: Added. |
| 1348 (buildProjectOrDie): |
| 1349 * Scripts/dump-class-layout: Extract logic to compute the path to the LL
DB Python module |
| 1350 from here to Scripts/webkitpy/common/system/systemhost.py so that it can
used by both |
| 1351 this script and lldb/lldb_webkit_unittest.py. Also import the lldb modul
e at the top of |
| 1352 the file and take advantage of Python's default error semantics to throw
an exception |
| 1353 if the import fails instead of handling it ourself. This has the side ef
fect that we |
| 1354 now always import the LLDB Python module even if this script is invoked
with --help. |
| 1355 If this turns out to be a significant annoyance then we can look to dyna
mically import |
| 1356 the module as we did before this change. |
| 1357 (webkit_build_dir): |
| 1358 (main): |
| 1359 (developer_dir): Deleted. |
| 1360 (import_lldb): Deleted. |
| 1361 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME com
ment to reflect |
| 1362 that fact that test-webkitpy does not support class and module fixtures.
This is because |
| 1363 test-webkitpy currently implements parallelism by breaking down existing
test classes |
| 1364 into individual test methods itself and having each worker run exactly o
ne test method (via |
| 1365 unittest.TestLoader.loadTestsFromName()) at a time. As a result of this
reorganization, |
| 1366 setUpModule()/setUpClass() are called for each test method as opposed to
once per test |
| 1367 class/test module. |
| 1368 (remove_dir): Ditto. |
| 1369 * Scripts/webkitpy/common/system/systemhost.py: |
| 1370 (SystemHost): |
| 1371 (SystemHost.path_to_lldb_python_directory): Added. |
| 1372 * Scripts/webkitpy/test/main.py: |
| 1373 (_find_lldb_webkit_tester): Returns whether there exists a Debug or Rele
ase-built lldbWebKitTester. |
| 1374 (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only s
upport building |
| 1375 lldbWebKitTester on Mac. |
| 1376 (main): Add Tools/lldb to the test search path if the platform has lldb.
py. |
| 1377 (Tester.run): Pass a boolean as to whether we will run the lldb_webkit u
nit tests. |
| 1378 (Tester._run_tests): Modified to take a boolean as to whether to run the
lldb_webkit unit tests. |
| 1379 If we will run these tests then build lldbWebKitTester if it has not alr
eady been built as the |
| 1380 unit tests depend on this program. |
| 1381 * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added. |
| 1382 * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added. |
| 1383 * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added. |
| 1384 * lldb/lldbWebKitTester/Makefile: Added. |
| 1385 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Adde
d. |
| 1386 * lldb/lldbWebKitTester/main.cpp: Added. |
| 1387 (breakForTestingSummaryProviders): |
| 1388 (utf16String): |
| 1389 (testSummaryProviders): |
| 1390 (main): |
| 1391 * lldb/lldb_webkit_unittest.py: Added. |
| 1392 (destroy_cached_debug_session): |
| 1393 (LLDBDebugSession): |
| 1394 (LLDBDebugSession.setup): |
| 1395 (LLDBDebugSession.tearDown): |
| 1396 (TestSummaryProviders): |
| 1397 (TestSummaryProviders.setUpClass): |
| 1398 (TestSummaryProviders._sbFrame): |
| 1399 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_str
ing): |
| 1400 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_st
ring): |
| 1401 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_str
ing): |
| 1402 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_st
ring): |
| 1403 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string)
: |
| 1404 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string
): |
| 1405 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string)
: |
| 1406 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string
): |
| 1407 |
| 1408 2018-06-01 Frederic Wang <fwang@igalia.com> |
| 1409 |
| 1410 export-w3c-test-changes cannot apply patches when some w3c-import.log fi
les are changed |
| 1411 https://bugs.webkit.org/show_bug.cgi?id=186133 |
| 1412 |
| 1413 Reviewed by Youenn Fablet. |
| 1414 |
| 1415 * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the
diff. |
| 1416 * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test. |
| 1417 |
| 1418 2018-05-31 Frederic Wang <fwang@igalia.com> |
| 1419 |
| 1420 export-w3c-test-changes should use the new location & name of the WPT re
po |
| 1421 https://bugs.webkit.org/show_bug.cgi?id=186135 |
| 1422 |
| 1423 Reviewed by Youenn Fablet. |
| 1424 |
| 1425 Web platform tests have been moved to GitHub's web-platform-tests/wpt. T
his patch updates the |
| 1426 corresponding variables to use the new organization and repository name.
It also refactors a |
| 1427 bit the code to reduce the amount of hardcoded strings. |
| 1428 |
| 1429 * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name
wpt. Also removes the |
| 1430 final slash to WPT_GH_URL, so it can be used for repo URL too. |
| 1431 * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define
WPT_PR_URL from |
| 1432 WPT_GH_URL. |
| 1433 (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_N
AME. |
| 1434 (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME. |
| 1435 (WebPlatformTestExporter._git): Use WPT_GH_URL. |
| 1436 (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WP
T_GH_REPO_NAME. |
| 1437 (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO
_NAME. |
| 1438 (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL. |
| 1439 * Scripts/webkitpy/w3c/test_exporter_unittest.py: |
| 1440 (TestExporterTest.test_export): Update organization and repository names
for the remote |
| 1441 branch and pull request. |
| 1442 (TestExporterTest.test_export_with_specific_branch): Update repository n
ame. |
| 1443 |
| 1444 2018-05-31 Ryan Haddad <ryanhaddad@apple.com> |
| 1445 |
| 1446 Update expected results for BuildStepsConstructorTest |
| 1447 https://bugs.webkit.org/show_bug.cgi?id=186119 |
| 1448 |
| 1449 Reviewed by Alex Christensen. |
| 1450 |
| 1451 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missi
ng entries for 'WinCairo 64-bit' bots. |
| 1452 |
| 1453 2018-05-31 Sihui Liu <sihui_liu@apple.com> |
| 1454 |
| 1455 [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails bec
ause cookies use different files with/without processpool |
| 1456 https://bugs.webkit.org/show_bug.cgi?id=185831 |
| 1457 <rdar://problem/40468716> |
| 1458 |
| 1459 Reviewed by David Kilzer. |
| 1460 |
| 1461 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 1462 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiated
ByFrame:completionHandler:]): |
| 1463 (TEST): |
| 1464 |
| 1465 2018-05-31 Chris Dumez <cdumez@apple.com> |
| 1466 |
| 1467 [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset
is a flaky failure |
| 1468 https://bugs.webkit.org/show_bug.cgi?id=184893 |
| 1469 <rdar://problem/39747271> |
| 1470 |
| 1471 Reviewed by Wenson Hsieh. |
| 1472 |
| 1473 Update test to wait until the view is the expected height instead of |
| 1474 calling waitForNextPresentationUpdate once and expect the view to |
| 1475 have the right height. This fixes the flakiness. |
| 1476 |
| 1477 * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm: |
| 1478 (TestWebKitAPI::waitUntilInnerHeightIs): |
| 1479 (TestWebKitAPI::TEST): |
15 | 1480 |
16 2018-05-31 Leo Balter <leonardo.balter@gmail.com> | 1481 2018-05-31 Leo Balter <leonardo.balter@gmail.com> |
17 | 1482 |
18 test262-runner should run in verbose mode in automation | 1483 test262-runner should run in verbose mode in automation |
19 https://bugs.webkit.org/show_bug.cgi?id=186115 | 1484 https://bugs.webkit.org/show_bug.cgi?id=186115 |
20 | 1485 |
21 Reviewed by Yusuke Suzuki. | 1486 Reviewed by Yusuke Suzuki. |
22 | 1487 |
23 This patch toggles the verbose mode in the build bot and reports every t
est file | 1488 This patch toggles the verbose mode in the build bot and reports every t
est file |
24 in order to avoid the '1200 seconds without output' issue. | 1489 in order to avoid the '1200 seconds without output' issue. |
(...skipping 13494 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
13519 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. | 14984 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. |
13520 | 14985 |
13521 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: | 14986 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: |
13522 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): | 14987 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): |
13523 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: | 14988 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: |
13524 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): | 14989 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): |
13525 (websiteDataStoreTestWebView): | 14990 (websiteDataStoreTestWebView): |
13526 (TEST): | 14991 (TEST): |
13527 | 14992 |
13528 == Rolled over to ChangeLog-2018-01-01 == | 14993 == Rolled over to ChangeLog-2018-01-01 == |
LEFT | RIGHT |