LEFT | RIGHT |
1 2018-05-04 Ali Juma <ajuma@chromium.org> | 1 2018-06-11 Ali Juma <ajuma@chromium.org> |
2 | 2 |
3 Use SafeBrowsing in WKWebView | 3 Use SafeBrowsing in WKWebView |
4 https://bugs.webkit.org/show_bug.cgi?id=181804 | 4 https://bugs.webkit.org/show_bug.cgi?id=181804 |
5 | 5 |
6 Reviewed by NOBODY (OOPS!). | 6 Reviewed by NOBODY (OOPS!). |
7 | 7 |
8 Enable SafeBrowsing in MiniBrowser. | 8 Enable SafeBrowsing in MiniBrowser. |
| 9 |
| 10 Add API tests for SafeBrowsing. |
9 | 11 |
10 * MiniBrowser/MiniBrowser.entitlements: | 12 * MiniBrowser/MiniBrowser.entitlements: |
11 * MiniBrowser/mac/AppDelegate.m: | 13 * MiniBrowser/mac/AppDelegate.m: |
12 (defaultConfiguration): | 14 (defaultConfiguration): |
13 * MiniBrowser/mac/WK2BrowserWindowController.m: | 15 * MiniBrowser/mac/WK2BrowserWindowController.m: |
14 (-[WK2BrowserWindowController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): | 16 (-[WK2BrowserWindowController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): |
| 17 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 18 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added. |
| 19 (-[SBScheme webView:startURLSchemeTask:]): |
| 20 (-[SBScheme webView:stopURLSchemeTask:]): |
| 21 (-[SafeBrowsingTestController webView:decidePolicyForNavigationAction:de
cisionHandler:]): |
| 22 (-[SafeBrowsingTestController webView:decidePolicyForSafeBrowsingResultF
orNavigationAction:decisionHandler:]): |
| 23 (-[SafeBrowsingTestController webView:didFinishNavigation:]): |
| 24 (TEST): |
| 25 * TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html: Added. |
| 26 * TestWebKitAPI/Tests/WebKitCocoa/unsafe-iframe.html: Added. |
| 27 |
| 28 2018-06-12 Tim Horton <timothy_horton@apple.com> |
| 29 |
| 30 Add a API test for r232601 |
| 31 https://bugs.webkit.org/show_bug.cgi?id=186417 |
| 32 |
| 33 Reviewed by Wenson Hsieh. |
| 34 |
| 35 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm: |
| 36 (immediateSubviewOfClass): |
| 37 (TEST): |
| 38 Ensure that we put the view hierarchy back together (move WKContentView |
| 39 out of the animated resize view) and unhide WKContentView after a |
| 40 resize-with-hidden-content. |
| 41 |
| 42 2018-06-12 Valerie R Young <valerie@bocoup.com> |
| 43 |
| 44 test262/Runner.pm: add unit tests |
| 45 https://bugs.webkit.org/show_bug.cgi?id=185783 |
| 46 |
| 47 Reviewed by Michael Saboff. |
| 48 |
| 49 * Scripts/webkitperl/test262_unittest/README: Added. |
| 50 * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml
: Added. |
| 51 * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added. |
| 52 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail-new-error.p
l: Added. |
| 53 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail.pl: Added. |
| 54 * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-pass.pl: Added. |
| 55 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing-with-new-error.js: Added. |
| 56 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing.js: Added. |
| 57 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-passing.js: Added. |
| 58 (f): |
| 59 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now
-failing.js: Added. |
| 60 * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added. |
| 61 * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added. |
| 62 (f): |
| 63 * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added. |
| 64 |
| 65 2018-06-12 Valerie R Young <valerie@bocoup.com> |
| 66 |
| 67 test262/Runner.pm: minor updates |
| 68 https://bugs.webkit.org/show_bug.cgi?id=186399 |
| 69 |
| 70 - If harness files cannot be found in a CLI supplied |
| 71 test262 path, then default to webkit's test262 harness files. |
| 72 - Lazily create the test262-results directory (only right before |
| 73 writing to it) |
| 74 - If an expectation file is supplied via the CLI, save to the |
| 75 supplied location instead of the default webkit location |
| 76 (JSTest/test262/expectation.yaml). |
| 77 |
| 78 Reviewed by Michael Saboff. |
| 79 |
| 80 * Scripts/test262/Runner.pm: |
| 81 (processCLI): |
| 82 (main): |
| 83 (compileTest): |
| 84 (processResult): |
| 85 (getHarness): |
| 86 (summarizeResults): |
| 87 |
| 88 2018-06-11 Carlos Alberto Lopez Perez <clopez@igalia.com> |
| 89 |
| 90 [JSCOnly] Add a MIPS32el JSCOnly EWS |
| 91 https://bugs.webkit.org/show_bug.cgi?id=186523 |
| 92 |
| 93 Reviewed by Michael Catanzaro. |
| 94 |
| 95 Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-onl
y (Linux) port. |
| 96 The worker(s) on this queue should be pre-configured to cross-build JSC
for MIPS32el. |
| 97 |
| 98 * QueueStatusServer/config/queues.py: |
| 99 * QueueStatusServer/model/queues.py: |
| 100 (Queue.display_name): |
| 101 * Scripts/webkitpy/common/config/ews.json: |
| 102 * Scripts/webkitpy/common/config/ports.py: |
| 103 (DeprecatedPort.port): |
| 104 (WpePort.run_webkit_tests_command): |
| 105 (JscOnlyPort): |
| 106 (JscOnlyPort.build_jsc_command): |
| 107 * Scripts/webkitpy/common/config/ports_unittest.py: |
| 108 (DeprecatedPortTest.test_wincairo_port): |
| 109 (DeprecatedPortTest): |
| 110 (DeprecatedPortTest.test_jsconly_port): |
| 111 * Scripts/webkitpy/port/factory.py: |
| 112 (PortFactory): |
| 113 * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition.
Required by the EWS tooling. |
| 114 (JscOnlyPort): |
| 115 (JscOnlyPort.__init__): |
| 116 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: |
| 117 (test_ews_name): |
| 118 |
| 119 2018-06-12 Zan Dobersek <zdobersek@igalia.com> |
| 120 |
| 121 Add run-web-platform-tests script |
| 122 https://bugs.webkit.org/show_bug.cgi?id=183356 |
| 123 |
| 124 Reviewed by Carlos Alberto Lopez Perez. |
| 125 |
| 126 Add the run-web-platform-tests script that allows running WebKit builds |
| 127 against the external web-platform-tests project. |
| 128 |
| 129 The script sets up all the port-specific information, including the |
| 130 display driver. If no web-platform-tests repository location is |
| 131 specified, the TestDownloader utility is used to clone the repository, |
| 132 and path to that clone is leveraged instead. |
| 133 |
| 134 Port-specific TestManifest.ini and TestExpectations.json file paths are |
| 135 then constructed, bailing if any of the files is missing. The JSON file |
| 136 is then used to construct the metadata file tree, creating an .ini file |
| 137 for each test that is disabled, has a certain expectation, or has |
| 138 subtests that themselves have certain expectations. This metadata tree |
| 139 is built under the build directory, and is purged and reconstructed for |
| 140 each separate run. |
| 141 |
| 142 Lastly, the WPT python module is imported from the web-platform-tests |
| 143 source location, and wpt.main() is invoked along with all the necessary |
| 144 arguments that set up a web-platform-tests suite run using the WebKit |
| 145 product. |
| 146 |
| 147 * Scripts/run-web-platform-tests: Added. |
| 148 * Scripts/webkitpy/common/config/ports_mock.py: |
| 149 (MockPort.run_bindings_tests_command): |
| 150 (MockPort): |
| 151 (MockPort.wpt_metadata_directory): |
| 152 (MockPort.wpt_manifest_file): |
| 153 * Scripts/webkitpy/port/base.py: |
| 154 (Port.wpt_metadata_directory): |
| 155 (Port): |
| 156 (Port.wpt_manifest_file): |
| 157 * Scripts/webkitpy/w3c/common.py: |
| 158 (is_file_exportable): |
| 159 (WPTPaths): |
| 160 (WPTPaths.checkout_directory): |
| 161 (WPTPaths.wpt_checkout_path): |
| 162 * Scripts/webkitpy/w3c/test_downloader.py: |
| 163 (TestDownloader.clone_tests): |
| 164 (TestDownloader): |
| 165 (TestDownloader.download_tests): |
| 166 * Scripts/webkitpy/w3c/test_exporter.py: |
| 167 (WebPlatformTestExporter.__init__): |
| 168 * Scripts/webkitpy/w3c/wpt_runner.py: Added. |
| 169 (main): |
| 170 (parse_args): |
| 171 (create_webdriver): |
| 172 (spawn_wpt): |
| 173 (WPTRunner): |
| 174 (WPTRunner.__init__): |
| 175 (WPTRunner._prepare_wpt_checkout): |
| 176 (WPTRunner._generate_metadata_directory): |
| 177 (WPTRunner.run): |
| 178 * Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added. |
| 179 (WPTRunnerTest): |
| 180 (WPTRunnerTest.MockTestDownloader): |
| 181 (WPTRunnerTest.MockTestDownloader.default_options): |
| 182 (WPTRunnerTest.MockTestDownloader.__init__): |
| 183 (WPTRunnerTest.MockTestDownloader.clone_tests): |
| 184 (WPTRunnerTest.MockWebDriver): |
| 185 (WPTRunnerTest.MockWebDriver.create): |
| 186 (WPTRunnerTest.MockWebDriver.binary_path): |
| 187 (WPTRunnerTest.MockWebDriver.browser_path): |
| 188 (WPTRunnerTest.MockWebDriver.browser_args): |
| 189 (WPTRunnerTest.MockSpawnWPT): |
| 190 (WPTRunnerTest.MockSpawnWPT.__init__): |
| 191 (WPTRunnerTest.MockSpawnWPT.__call__): |
| 192 (WPTRunnerTest.TestInstance): |
| 193 (WPTRunnerTest.TestInstance.__init__): |
| 194 (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): |
| 195 (WPTRunnerTest.test_prepare_wpt_checkout): |
| 196 (WPTRunnerTest.test_prepare_wpt_checkout_specified_path): |
| 197 (WPTRunnerTest.test_generate_metadata_directory): |
| 198 (WPTRunnerTest.test_run): |
| 199 (WPTRunnerTest.test_run_with_specified_options): |
| 200 (WPTRunnerTest.test_run_with_args): |
| 201 |
| 202 2018-06-11 Mark Lam <mark.lam@apple.com> |
| 203 |
| 204 Add support for webkit-test-runner jscOptions in DumpRenderTree and WebK
itTestRunner. |
| 205 https://bugs.webkit.org/show_bug.cgi?id=186451 |
| 206 <rdar://problem/40875792> |
| 207 |
| 208 Reviewed by Tim Horton. |
| 209 |
| 210 This jscOptions option can be used by a layout test to specify some JSC
runtime |
| 211 options needed by the test e.g. by adding something like this to the top
of the |
| 212 html file after the DOCTYPE tag: |
| 213 <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true ] --> |
| 214 |
| 215 If more than one option is needed, the options can be specified as a com
ma |
| 216 separated string e.g. |
| 217 <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true,--use
ZombieMode=true ] --> |
| 218 |
| 219 This only works with JSC options that can be changed at runtime. Not al
l JSC |
| 220 options can be changed this way as some options are only checked and set
once at |
| 221 VM / process initialization time: changing this type of options may have
no |
| 222 effect. It's the test writer's responsibility to determine which option
s are |
| 223 appropriate for with this webkit-test-runner jscOptions option. |
| 224 |
| 225 This implementation is a workaround until we can change the run-webkit-t
ests |
| 226 scripts to parse the option and apply it to a new launch of DRT or WKTR: |
| 227 https://bugs.webkit.org/show_bug.cgi?id=186452 |
| 228 |
| 229 * DumpRenderTree/TestOptions.cpp: |
| 230 (TestOptions::TestOptions): |
| 231 (TestOptions::webViewIsCompatibleWithOptions const): |
| 232 * DumpRenderTree/TestOptions.h: |
| 233 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 234 (setJSCOptions): |
| 235 (resetWebViewToConsistentStateBeforeTesting): |
| 236 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: |
| 237 (WTR::InjectedBundle::didReceiveMessageToPage): |
| 238 * WebKitTestRunner/TestController.cpp: |
| 239 (WTR::TestController::resetStateToConsistentValues): |
| 240 (WTR::updateTestOptionsFromTestHeader): |
| 241 * WebKitTestRunner/TestOptions.h: |
| 242 (WTR::TestOptions::hasSameInitializationOptions const): |
| 243 |
| 244 2018-06-11 Brady Eidson <beidson@apple.com> |
| 245 |
| 246 Add a command line default to force WebKitTestRunner to turn on process
swap on navigation. |
| 247 https://bugs.webkit.org/show_bug.cgi?id=186534 |
| 248 |
| 249 Reviewed by Chris Dumez. |
| 250 |
| 251 Right now Process Swap On Navigation is enabled on a per-test basis. |
| 252 The future is to enable it by default. |
| 253 |
| 254 Adding a 'defaults write' helps us get to that future. |
| 255 |
| 256 * WebKitTestRunner/TestController.cpp: |
| 257 (WTR::TestController::testOptionsForTest const): |
| 258 (WTR::TestController::platformAddTestOptions const): |
| 259 * WebKitTestRunner/TestController.h: |
| 260 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 261 (WTR::TestController::platformAddTestOptions const): |
| 262 |
| 263 2018-06-11 Chris Dumez <cdumez@apple.com> |
| 264 |
| 265 Allow enabling PSON in layout tests without window.open support |
| 266 https://bugs.webkit.org/show_bug.cgi?id=186537 |
| 267 |
| 268 Reviewed by Geoffrey Garen. |
| 269 |
| 270 Allow enabling PSON in layout tests without window.open support since wi
ndow.open support |
| 271 is far from being ready and we plan to enable PSON in layout tests soon. |
| 272 |
| 273 * WebKitTestRunner/TestController.cpp: |
| 274 (WTR::TestController::createWebViewWithOptions): |
| 275 (WTR::updateTestOptionsFromTestHeader): |
| 276 * WebKitTestRunner/TestOptions.h: |
| 277 (WTR::TestOptions::hasSameInitializationOptions const): |
| 278 |
| 279 2018-06-11 Brady Eidson <beidson@apple.com> |
| 280 |
| 281 Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of prep
aration for ARC |
| 282 https://bugs.webkit.org/show_bug.cgi?id=186436 |
| 283 |
| 284 Patch by Darin Adler |
| 285 Reviewed by Brady Eidson. |
| 286 |
| 287 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: |
| 288 (TestWebKitAPI::TEST): |
| 289 |
| 290 2018-06-11 Mark Lam <mark.lam@apple.com> |
| 291 |
| 292 Gardening: skip BigInt tests on iOS until the feature is stable. |
| 293 <rdar://problem/40331121> |
| 294 |
| 295 Not reviewed. |
| 296 |
| 297 * Scripts/run-jsc-stress-tests: |
| 298 |
| 299 2018-06-11 Fujii Hironori <Hironori.Fujii@sony.com> |
| 300 |
| 301 [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API |
| 302 https://bugs.webkit.org/show_bug.cgi?id=186478 |
| 303 |
| 304 Reviewed by Alex Christensen. |
| 305 |
| 306 Added "New WebKit Window" and "New WebKitLegacy Window" menu |
| 307 items. Disabled the menu item "New WebKit Window" if |
| 308 !ENABLE(WEBKIT). |
| 309 |
| 310 * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp |
| 311 source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT. |
| 312 * MiniBrowser/win/MainWindow.cpp: |
| 313 (MainWindow::MainWindow): |
| 314 (MainWindow::create): |
| 315 (MainWindow::init): |
| 316 (MainWindow::WndProc): |
| 317 * MiniBrowser/win/MainWindow.h: |
| 318 * MiniBrowser/win/MiniBrowserLib.rc: |
| 319 * MiniBrowser/win/MiniBrowserLibResource.h: |
| 320 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 321 (PrintWebUIDelegate::createWebViewWithRequest): |
| 322 * MiniBrowser/win/WebKitBrowserWindow.cpp: Added. |
| 323 (createString): |
| 324 (toUtf8): |
| 325 (createWKString): |
| 326 (createWKURL): |
| 327 (WebKitBrowserWindow::create): |
| 328 (WebKitBrowserWindow::WebKitBrowserWindow): |
| 329 (WebKitBrowserWindow::init): |
| 330 (WebKitBrowserWindow::hwnd): |
| 331 (WebKitBrowserWindow::loadURL): |
| 332 (WebKitBrowserWindow::loadHTMLString): |
| 333 (WebKitBrowserWindow::navigateForwardOrBackward): |
| 334 (WebKitBrowserWindow::navigateToHistory): |
| 335 (WebKitBrowserWindow::setPreference): |
| 336 (WebKitBrowserWindow::print): |
| 337 (WebKitBrowserWindow::launchInspector): |
| 338 (WebKitBrowserWindow::setUserAgent): |
| 339 (WebKitBrowserWindow::userAgent): |
| 340 (WebKitBrowserWindow::showLayerTree): |
| 341 (WebKitBrowserWindow::updateStatistics): |
| 342 (WebKitBrowserWindow::resetZoom): |
| 343 (WebKitBrowserWindow::zoomIn): |
| 344 (WebKitBrowserWindow::zoomOut): |
| 345 (toWebKitBrowserWindow): |
| 346 (WebKitBrowserWindow::didReceiveTitleForFrame): |
| 347 (WebKitBrowserWindow::didCommitLoadForFrame): |
| 348 * MiniBrowser/win/WebKitBrowserWindow.h: |
| 349 * MiniBrowser/win/WinMain.cpp: |
| 350 (wWinMain): |
| 351 |
| 352 2018-06-11 Keith Miller <keith_miller@apple.com> |
| 353 |
| 354 Add missing whitespace to run-jsc command |
| 355 https://bugs.webkit.org/show_bug.cgi?id=186528 |
| 356 |
| 357 Reviewed by Mark Lam. |
| 358 |
| 359 * Scripts/run-jsc: |
| 360 |
| 361 2018-06-11 Philippe Normand <pnormand@igalia.com> |
| 362 |
| 363 [webkitpy] PHP7.2 support on Debian platforms |
| 364 https://bugs.webkit.org/show_bug.cgi?id=186521 |
| 365 |
| 366 Reviewed by Michael Catanzaro. |
| 367 |
| 368 * Scripts/webkitpy/port/base.py: |
| 369 (Port._debian_php_version): Refactor and add PHP 7.2 version support. |
| 370 |
| 371 2018-06-11 Carlos Garcia Campos <cgarcia@igalia.com> |
| 372 |
| 373 Unreviewed. Fix WPE API and layout tests after r232670. |
| 374 |
| 375 Now that dyz is not installed, there's not -default.so symlink for the W
PE backend, so we need to use |
| 376 WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fd
o backend. |
| 377 |
| 378 * Scripts/run-wpe-tests: |
| 379 (WPETestRunner.__init__): |
| 380 (WPETestRunner): |
| 381 (WPETestRunner.setup_testing_environment): |
| 382 * Scripts/webkitpy/port/wpe.py: |
| 383 (WPEPort.setup_environ_for_server): |
| 384 * glib/api_test_runner.py: |
| 385 (TestRunner.setup_testing_environment): |
| 386 (TestRunner.run_tests): |
| 387 (TestRunner._setup_testing_environment): Deleted. |
| 388 |
| 389 2018-06-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 390 |
| 391 [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolate
d world |
| 392 https://bugs.webkit.org/show_bug.cgi?id=186192 |
| 393 |
| 394 Reviewed by Michael Catanzaro. |
| 395 |
| 396 Add tests cases for the new API. |
| 397 |
| 398 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: |
| 399 (testWebViewRunJavaScript): |
| 400 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: |
| 401 (methodCallCallback): |
| 402 (webkit_web_extension_initialize_with_user_data): |
| 403 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: |
| 404 (runJavaScriptInWorldReadyCallback): |
| 405 (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished): |
| 406 (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished): |
| 407 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: |
| 408 |
| 409 2018-06-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 410 |
| 411 [WPE] Add a MiniBrowser and use it to run WebDriver tests |
| 412 https://bugs.webkit.org/show_bug.cgi?id=186345 |
| 413 |
| 414 Reviewed by Žan Doberšek. |
| 415 |
| 416 Most of the code is based on dyz and gtk MiniBrowser. This patch adds a
new internal library WPEToolingBackends, |
| 417 including the headless view backend and a new window backend to be used
by the MiniBrowser. MiniBrowser can also |
| 418 run in headless mode, by using the headless backend instead of the windo
w one, which will allow us to run the |
| 419 WebDriver tests in the bots. |
| 420 |
| 421 * CMakeLists.txt: |
| 422 * MiniBrowser/wpe/CMakeLists.txt: Added. |
| 423 * MiniBrowser/wpe/main.cpp: Added. |
| 424 (automationStartedCallback): |
| 425 (createViewBackend): |
| 426 (main): |
| 427 * Scripts/run-minibrowser: Remove WPE specific code. |
| 428 * Scripts/run-webdriver-tests: Add headless display-server option. |
| 429 * Scripts/webkitdirs.pm: |
| 430 (launcherName): Remove WPE specific code. |
| 431 * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: |
| 432 (WebDriverWPE.browser_name): Return MiniBrowser. |
| 433 (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build
dir. |
| 434 (WebDriverWPE.browser_args): Add --headless when running in headless mod
e. |
| 435 (WebDriverWPE.capabilities): Use the full browser path. |
| 436 * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py: |
| 437 (WebDriverTestRunnerSelenium.collect_tests): Fix early return value. |
| 438 * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of Hea
dlessViewBackend. |
| 439 * TestWebKitAPI/PlatformWebView.h: Ditto. |
| 440 * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto |
| 441 * TestWebKitAPI/glib/WebKitGLib/TestMain.h: |
| 442 (Test::createWebViewBackend): Ditto. |
| 443 * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: |
| 444 (TestWebKitAPI::PlatformWebView::initialize): Ditto. |
| 445 * WebKitTestRunner/PlatformWPE.cmake: Ditto. |
| 446 * WebKitTestRunner/PlatformWebView.h: Ditto. |
| 447 * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: |
| 448 (WTR::PlatformWebView::PlatformWebView): Ditto. |
| 449 * wpe/HeadlessViewBackend/CMakeLists.txt: Removed. |
| 450 * wpe/backends/CMakeLists.txt: Added. |
| 451 * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessV
iewBackend/HeadlessViewBackend.cpp. |
| 452 (WPEToolingBackends::getEGLDisplay): |
| 453 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): |
| 454 (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend): |
| 455 (WPEToolingBackends::HeadlessViewBackend::createSnapshot): |
| 456 (WPEToolingBackends::HeadlessViewBackend::performUpdate): |
| 457 (WPEToolingBackends::HeadlessViewBackend::displayBuffer): |
| 458 * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessVie
wBackend/HeadlessViewBackend.h. |
| 459 * wpe/backends/ViewBackend.cpp: Added. |
| 460 (WPEToolingBackends::ViewBackend::ViewBackend): |
| 461 (WPEToolingBackends::ViewBackend::~ViewBackend): |
| 462 (WPEToolingBackends::ViewBackend::initialize): |
| 463 (WPEToolingBackends::ViewBackend::setInputClient): |
| 464 (WPEToolingBackends::ViewBackend::backend const): |
| 465 (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent): |
| 466 (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent): |
| 467 (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent): |
| 468 * wpe/backends/ViewBackend.h: Added. |
| 469 * wpe/backends/WindowViewBackend.cpp: Added. |
| 470 (WPEToolingBackends::WindowViewBackend::WindowViewBackend): |
| 471 (WPEToolingBackends::WindowViewBackend::~WindowViewBackend): |
| 472 (WPEToolingBackends::WindowViewBackend::displayBuffer): |
| 473 (WPEToolingBackends::WindowViewBackend::handleKeyEvent): |
| 474 * wpe/backends/WindowViewBackend.h: Added. |
| 475 * wpe/jhbuild.modules: Remove dyz and add wayland-protocols. |
| 476 |
| 477 2018-06-10 Fujii Hironori <Hironori.Fujii@sony.com> |
| 478 |
| 479 [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBr
owserWindow |
| 480 https://bugs.webkit.org/show_bug.cgi?id=186427 |
| 481 |
| 482 Reviewed by Ryosuke Niwa. |
| 483 |
| 484 * MiniBrowser/win/AccessibilityDelegate.cpp: |
| 485 * MiniBrowser/win/AccessibilityDelegate.h: |
| 486 (AccessibilityDelegate::AccessibilityDelegate): |
| 487 * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitL
egacyBrowserWindow.cpp. |
| 488 * MiniBrowser/win/Common.h: |
| 489 * MiniBrowser/win/MainWindow.cpp: |
| 490 (MainWindow::init): |
| 491 * MiniBrowser/win/MainWindow.h: |
| 492 * MiniBrowser/win/MiniBrowserWebHost.cpp: |
| 493 * MiniBrowser/win/MiniBrowserWebHost.h: |
| 494 (MiniBrowserWebHost::MiniBrowserWebHost): |
| 495 * MiniBrowser/win/PageLoadTestClient.cpp: |
| 496 (PageLoadTestClient::PageLoadTestClient): |
| 497 * MiniBrowser/win/PageLoadTestClient.h: |
| 498 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 499 (PrintWebUIDelegate::createWebViewWithRequest): |
| 500 * MiniBrowser/win/PrintWebUIDelegate.h: |
| 501 (PrintWebUIDelegate::PrintWebUIDelegate): |
| 502 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 503 * MiniBrowser/win/ResourceLoadDelegate.h: |
| 504 (ResourceLoadDelegate::ResourceLoadDelegate): |
| 505 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/Mini
Browser/win/MiniBrowser.cpp. |
| 506 * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBr
owser/win/MiniBrowser.h. |
| 507 * MiniBrowser/win/WebDownloadDelegate.cpp: |
| 508 (WebDownloadDelegate::WebDownloadDelegate): |
| 509 * MiniBrowser/win/WebDownloadDelegate.h: |
| 510 |
| 511 2018-06-10 Chris Dumez <cdumez@apple.com> |
| 512 |
| 513 Reload the Web view in case of crash if the client does not implement we
bViewWebContentProcessDidTerminate delegate |
| 514 https://bugs.webkit.org/show_bug.cgi?id=186468 |
| 515 |
| 516 Reviewed by Geoffrey Garen. |
| 517 |
| 518 Add API test coverage. |
| 519 |
| 520 * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: |
| 521 (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisiona
lNavigation:]): |
| 522 (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigatio
n:]): |
| 523 (TEST): |
| 524 |
| 525 2018-06-10 Michael Catanzaro <mcatanzaro@igalia.com> |
| 526 |
| 527 [WPE][GTK] paypal.com requires user agent quirk |
| 528 https://bugs.webkit.org/show_bug.cgi?id=186466 |
| 529 |
| 530 Reviewed by Carlos Garcia Campos. |
| 531 |
| 532 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: |
| 533 (TestWebKitAPI::TEST): |
| 534 |
| 535 2018-06-09 Dan Bernstein <mitz@apple.com> |
| 536 |
| 537 [Xcode] Clean up and modernize some build setting definitions |
| 538 https://bugs.webkit.org/show_bug.cgi?id=186463 |
| 539 |
| 540 Reviewed by Sam Weinig. |
| 541 |
| 542 * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition fo
r macOS 10.11. |
| 543 Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that |
| 544 WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode ver
sions. |
| 545 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed defin
ition for macOS |
| 546 10.11. |
| 547 * MiniBrowser/Configurations/Base.xcconfig: Ditto. |
| 548 * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto. |
| 549 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto. |
| 550 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto. |
| 551 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the d
efinitions of |
| 552 ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is
the earliest |
| 553 supported version. |
| 554 * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Remove
d definitions for |
| 555 macOS 10.11. |
| 556 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified
the definition of |
| 557 WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_S
TUBS is true for all |
| 558 supported Xcode versions |
| 559 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definit
ion for macOS 10.11. |
| 560 |
| 561 2018-06-09 Dan Bernstein <mitz@apple.com> |
| 562 |
| 563 Added missing file references to the Configuration group. |
| 564 |
| 565 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 566 |
| 567 2018-06-08 Darin Adler <darin@apple.com> |
| 568 |
| 569 [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for
ARC |
| 570 https://bugs.webkit.org/show_bug.cgi?id=186436 |
| 571 |
| 572 Reviewed by Anders Carlsson. |
| 573 |
| 574 * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm: |
| 575 (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoa
ding): |
| 576 Use @autoreleasepool. |
| 577 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: |
| 578 (TestWebKitAPI::buildAndPerformTest): Ditto. |
| 579 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: |
| 580 (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto. |
| 581 |
| 582 2018-06-08 Wenson Hsieh <wenson_hsieh@apple.com> |
| 583 |
| 584 [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Par
t 1) |
| 585 https://bugs.webkit.org/show_bug.cgi?id=186442 |
| 586 <rdar://problem/40879364> |
| 587 |
| 588 Reviewed by Tim Horton. |
| 589 |
| 590 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: |
| 591 |
| 592 2018-06-08 Alicia Boya GarcÃa <aboya@igalia.com> |
| 593 |
| 594 [GTK] Update to libva-2.1.0 in jhbuild |
| 595 https://bugs.webkit.org/show_bug.cgi?id=186434 |
| 596 |
| 597 Reviewed by Philippe Normand. |
| 598 |
| 599 * gstreamer/jhbuild.modules: |
| 600 |
| 601 2018-06-07 Yusuke Suzuki <utatane.tea@gmail.com> |
| 602 |
| 603 [WTF] Add WorkerPool |
| 604 https://bugs.webkit.org/show_bug.cgi?id=174569 |
| 605 |
| 606 Reviewed by Carlos Garcia Campos. |
| 607 |
| 608 * TestWebKitAPI/CMakeLists.txt: |
| 609 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 610 * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added. |
| 611 (TestWebKitAPI::TEST): |
| 612 |
| 613 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 614 |
| 615 [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and
WK2 BrowserWindow |
| 616 https://bugs.webkit.org/show_bug.cgi?id=186421 |
| 617 |
| 618 Reviewed by Ryosuke Niwa. |
| 619 |
| 620 This is the core patch to make MiniBrowser to support WK1 and WK2 |
| 621 windows (Bug 184770). |
| 622 |
| 623 I will rename MiniBrowser class to WK1BrowserWindow in a follow-up |
| 624 patch (Bug 184770 Comment 12). |
| 625 |
| 626 * MiniBrowser/win/BrowserWindow.h: Added. |
| 627 * MiniBrowser/win/MainWindow.cpp: |
| 628 (MainWindow::WndProc): |
| 629 * MiniBrowser/win/MainWindow.h: |
| 630 (MainWindow::browserWindow const): |
| 631 * MiniBrowser/win/MiniBrowser.cpp: |
| 632 (MiniBrowser::create): |
| 633 (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argume
nt hWnd. |
| 634 (MiniBrowser::navigateToHistory): Ditto. |
| 635 * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface. |
| 636 Make all other methods private and make delegates classes friends. |
| 637 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 638 (PrintWebUIDelegate::createWebViewWithRequest): |
| 639 |
| 640 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 641 |
| 642 [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a Main
Window's method |
| 643 https://bugs.webkit.org/show_bug.cgi?id=186387 |
| 644 |
| 645 Reviewed by Ryosuke Niwa. |
| 646 |
| 647 MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser. |
| 648 It should be a MainWindow's method. |
| 649 |
| 650 * MiniBrowser/win/MainWindow.cpp: |
| 651 (MainWindow::init): Call MainWindow::updateDeviceScaleFactor. |
| 652 (MainWindow::resizeSubViews): Do not set a font every time window size i
s changed. |
| 653 (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DP
ICHANGED. |
| 654 (MainWindow::updateDeviceScaleFactor): Converted from |
| 655 MiniBrowser::updateDeviceScaleFactor and |
| 656 MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is
changed. |
| 657 * MiniBrowser/win/MainWindow.h: |
| 658 * MiniBrowser/win/MiniBrowser.cpp: |
| 659 (MiniBrowser::init): |
| 660 (MiniBrowser::generateFontForScaleFactor): Deleted. |
| 661 (MiniBrowser::updateDeviceScaleFactor): Deleted. |
| 662 * MiniBrowser/win/MiniBrowser.h: |
| 663 (MiniBrowser::deviceScaleFactor): Deleted. |
| 664 (MiniBrowser::urlBarFont): Deleted. |
| 665 |
| 666 2018-06-07 Jonathan Bedard <jbedard@apple.com> |
| 667 |
| 668 [webkitpy] Treat svn versions as Version objects |
| 669 https://bugs.webkit.org/show_bug.cgi?id=186403 |
| 670 <rdar://problem/40904860> |
| 671 |
| 672 Reviewed by Dan Bernstein. |
| 673 |
| 674 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: |
| 675 * Scripts/webkitpy/common/checkout/scm/svn.py: |
| 676 (SVN.svn_version): Return Version object instead of string. |
| 677 (SVN._status_regexp): Convert version string to Version object. |
| 678 (SVN.add_list): Ditto. |
| 679 |
| 680 2018-06-07 Tadeu Zagallo <tzagallo@apple.com> |
| 681 |
| 682 Don't try to allocate JIT memory if we don't have the JIT entitlement |
| 683 https://bugs.webkit.org/show_bug.cgi?id=182605 |
| 684 <rdar://problem/38271229> |
| 685 |
| 686 Reviewed by Mark Lam. |
| 687 |
| 688 Add the Security framework to the TestWTF target, since it's required by
the new function to check the entitlements. |
| 689 |
| 690 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 691 |
| 692 2018-06-07 Mark Lam <mark.lam@apple.com> |
| 693 |
| 694 Enhance run-jsc-stress-tests to allow a test to specify test specific op
tions required for it to run. |
| 695 https://bugs.webkit.org/show_bug.cgi?id=186409 |
| 696 <rdar://problem/40909007> |
| 697 |
| 698 Reviewed by Saam Barati. |
| 699 |
| 700 This is needed because some tests are written with specific features in
mind, and |
| 701 we may not necessarily want to enable that option for all tests. |
| 702 |
| 703 We can now specify something like this at the top of a test file: |
| 704 //@ requireOptions("--useIntlPluralRules=true") |
| 705 |
| 706 ... and ensure that that test will be run with the --useIntlPluralRules=
true |
| 707 option for all test configurations that run the test. |
| 708 |
| 709 * Scripts/run-jsc-stress-tests: |
| 710 |
| 711 2018-06-07 Tim Horton <timothy_horton@apple.com> |
| 712 |
| 713 REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChang
esDuringAnimatedResizeSucceed is failing |
| 714 https://bugs.webkit.org/show_bug.cgi?id=186395 |
| 715 <rdar://problem/40902427> |
| 716 |
| 717 Reviewed by Wenson Hsieh. |
| 718 |
| 719 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm: |
| 720 (TEST): |
| 721 endAnimatedResize no longer synchronizes, so we have to wait for the nex
t presentation update. |
| 722 |
| 723 2018-06-07 Thibault Saunier <tsaunier@igalia.com> |
| 724 |
| 725 [GTK][WPE] Start implementing MediaStream API |
| 726 https://bugs.webkit.org/show_bug.cgi?id=185787 |
| 727 |
| 728 Reviewed by Philippe Normand. |
| 729 |
| 730 * Scripts/webkitpy/style/checker.py: Apply special formatting rules for
new GObject subclasses. |
| 731 * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base. |
| 732 * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTIO
N-on-EVENT_STREAM_COLL.patch: |
| 733 Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d
0e9cc92a86aa0227ee87406737b6d31670aea |
| 734 |
| 735 2018-06-07 Brendan McLoughlin <brendan@bocoup.com> |
| 736 |
| 737 Update web-platform-tests github location in webkitpy.w3c.test_importer |
| 738 https://bugs.webkit.org/show_bug.cgi?id=186392 |
| 739 |
| 740 Reviewed by Youenn Fablet. |
| 741 |
| 742 * Scripts/webkitpy/w3c/test_importer.py: |
| 743 (TestImporter.write_import_log): |
| 744 |
| 745 2018-06-07 Jonathan Bedard <jbedard@apple.com> |
| 746 |
| 747 webkitperl: Generalize .internal SDK suffix |
| 748 https://bugs.webkit.org/show_bug.cgi?id=186352 |
| 749 <rdar://problem/40853947> |
| 750 |
| 751 Reviewed by Alexey Proskuryakov. |
| 752 |
| 753 * Scripts/build-webkit: |
| 754 * Scripts/package-root: |
| 755 (usage): |
| 756 * Scripts/webkitdirs.pm: |
| 757 (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output. |
| 758 (availableXcodeSDKS): Generate a list of all available Xcode SDKs on thi
s machine. |
| 759 (determineXcodeSDK): Always prefer .internal SDKs if available. |
| 760 * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl: |
| 761 |
| 762 2018-06-07 Fujii Hironori <Hironori.Fujii@sony.com> |
| 763 |
| 764 [Win][MiniBrowser] Support multiple windows properly |
| 765 https://bugs.webkit.org/show_bug.cgi?id=186263 |
| 766 |
| 767 Reviewed by Ryosuke Niwa. |
| 768 |
| 769 The current implementation of |
| 770 PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using |
| 771 CreateProcess to open a new window, and doesn't return the new |
| 772 instance of IWebView. As the result, for example, window.close |
| 773 doesn't work as expected. |
| 774 |
| 775 In this change, a new MainWindow is created and return the |
| 776 IWebView in PrintWebUIDelegate::createWebViewWithRequest. |
| 777 |
| 778 In addition to it, this change unifies the lifetime of MiniBrowser |
| 779 and its delegates AccessibilityDelegate, PrintWebUIDelegate, |
| 780 ResourceLoadDelegate and WebDownloadDelegate in order to keep |
| 781 MiniBrowser alive as long as the delegates live. Because the |
| 782 window of webview keeps references of such delegates and accesses |
| 783 those after MiniBrowser destruction. |
| 784 |
| 785 * MiniBrowser/win/MainWindow.h: Added s_numInstances class member |
| 786 to count the number of instance to close the application. Do not |
| 787 use unique_ptr for m_browserWindow because it has ref count now. |
| 788 * MiniBrowser/win/MainWindow.cpp: |
| 789 (MainWindow::MainWindow): Increment s_numInstances. |
| 790 (MainWindow::~MainWindow): Decrement s_numInstances. |
| 791 (MainWindow::create): |
| 792 (MainWindow::init): |
| 793 (MainWindow::WndProc): Rename thiz to thisWindow. Keep this |
| 794 instance alive during this function by using RefPtr<MainWindow>. |
| 795 Deref the MainWindow instance on WM_DESTROY. Quit the application |
| 796 when the last MainWindow is closed. |
| 797 (MainWindow::cachesDialogProc): Rename thiz to thisWindow. |
| 798 (MainWindow::customUserAgentDialogProc): Ditto. |
| 799 * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release. |
| 800 * MiniBrowser/win/MiniBrowser.cpp: |
| 801 (MiniBrowser::create): |
| 802 (MiniBrowser::AddRef): |
| 803 (MiniBrowser::Release): |
| 804 (MiniBrowser::init): Passes this to the constructors of delegates. |
| 805 * MiniBrowser/win/AccessibilityDelegate.cpp: |
| 806 (AccessibilityDelegate::AddRef): Delegate to MiniBrowser. |
| 807 (AccessibilityDelegate::Release): Ditto. |
| 808 * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount. |
| 809 (AccessibilityDelegate::AccessibilityDelegate): |
| 810 * MiniBrowser/win/MiniBrowserWebHost.cpp: |
| 811 (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser. |
| 812 (MiniBrowserWebHost::Release): Ditto. |
| 813 * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount. |
| 814 * MiniBrowser/win/PrintWebUIDelegate.cpp: |
| 815 (PrintWebUIDelegate::createWebViewWithRequest): Create a new |
| 816 MainWindow and return the IWebView. |
| 817 (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser. |
| 818 (PrintWebUIDelegate::Release): Ditto. |
| 819 * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount. |
| 820 (PrintWebUIDelegate::PrintWebUIDelegate): |
| 821 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 822 (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser. |
| 823 (ResourceLoadDelegate::Release): Ditto. |
| 824 * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount. |
| 825 * MiniBrowser/win/WebDownloadDelegate.cpp: |
| 826 (WebDownloadDelegate::WebDownloadDelegate): |
| 827 (WebDownloadDelegate::AddRef): Delegate to MiniBrowser. |
| 828 (WebDownloadDelegate::Release): Ditto. |
| 829 * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount. |
| 830 |
| 831 2018-06-06 Fujii Hironori <Hironori.Fujii@sony.com> |
| 832 |
| 833 [Win][MiniBrowser] Remove gMainWindow global variable |
| 834 https://bugs.webkit.org/show_bug.cgi?id=186378 |
| 835 |
| 836 Reviewed by Ryosuke Niwa. |
| 837 |
| 838 I'm going to support multiple MainWindow in Bug 186263. It should |
| 839 not be assumed that MainWindow has only one instance. gMainWindow |
| 840 is used only in DisplayAuthDialog. |
| 841 |
| 842 * MiniBrowser/win/Common.cpp: |
| 843 (authDialogProc): Use DWLP_USER to store the dialog data. |
| 844 (displayAuthDialog): Moved and renamed from |
| 845 MainWindow::displayAuthDialog. Use DialogBoxParam instead of |
| 846 DialogBox to pass a data pointer. Do not return S_OK if |
| 847 DialogBoxParam returns -1. Take a HWND argument as the parent |
| 848 window. |
| 849 (DisplayAuthDialog): Deleted. |
| 850 * MiniBrowser/win/Common.h: |
| 851 * MiniBrowser/win/MainWindow.cpp: |
| 852 (authDialogProc): Moved to Common.cpp. |
| 853 (MainWindow::displayAuthDialog): Ditto. |
| 854 * MiniBrowser/win/MainWindow.h: |
| 855 * MiniBrowser/win/ResourceLoadDelegate.cpp: |
| 856 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): |
| 857 * MiniBrowser/win/WinMain.cpp: |
| 858 (wWinMain): Added a local variable mainWindow instead of using |
| 859 gMainWindow. |
| 860 |
| 861 2018-06-06 Dan Bernstein <mitz@apple.com> |
| 862 |
| 863 [Xcode] Opt out of the New Build System |
| 864 https://bugs.webkit.org/show_bug.cgi?id=186380 |
| 865 |
| 866 Reviewed by Alexey Proskuryakov. |
| 867 |
| 868 * Scripts/webkitdirs.pm: |
| 869 (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild. |
| 870 |
| 871 2018-06-06 Antoine Quint <graouts@apple.com> |
| 872 |
| 873 Rename color-filter to -apple-color-filter and do not expose it to Web c
ontent |
| 874 https://bugs.webkit.org/show_bug.cgi?id=186306 |
| 875 <rdar://problem/39874167> |
| 876 |
| 877 Reviewed by Simon Fraser. |
| 878 |
| 879 Adding an option to turn support for the -apple-color-filter property on
via an HTML comment. |
| 880 |
| 881 * DumpRenderTree/TestOptions.cpp: |
| 882 (TestOptions::TestOptions): |
| 883 * DumpRenderTree/TestOptions.h: |
| 884 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 885 (setWebPreferencesForTestOptions): |
| 886 * WebKitTestRunner/TestController.cpp: |
| 887 (WTR::TestController::resetPreferencesToConsistentValues): |
| 888 (WTR::updateTestOptionsFromTestHeader): |
| 889 * WebKitTestRunner/TestOptions.h: |
| 890 (WTR::TestOptions::hasSameInitializationOptions const): |
| 891 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 892 (WTR::TestController::platformCreateWebView): |
| 893 |
| 894 2018-06-06 Brent Fulgham <bfulgham@apple.com> |
| 895 |
| 896 Adjust compile and runtime flags to match shippable state of features (P
art 2) |
| 897 https://bugs.webkit.org/show_bug.cgi?id=186319 |
| 898 <rdar://problem/40352045> |
| 899 |
| 900 Unreviewed test fix. |
| 901 |
| 902 TestWebKitAPI was timing out because 'color' input types are no longer s
upport. I also discovered that the |
| 903 ASSERT_STREQ macro returns on error, which causes tests to time out when
ever a 'done = true' call (needed to |
| 904 end the test) is done after ASSERT_STREQ, which might fail and return ea
rly, preventing the flag from being |
| 905 set. |
| 906 |
| 907 * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm
: |
| 908 (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowser
ContextController:]): Make testing of |
| 909 the 'color' input type conditional on the feature being part of the buil
d. |
| 910 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 911 (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set
the 'done=true' state before performing |
| 912 string equality assertions, since they do an early return and bypass the
end state of the test. |
| 913 (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didRes
ignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto. |
| 914 (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:
initiatedByFrame:completionHandler:]): Ditto. |
| 915 (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAler
tPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto. |
| 916 |
| 917 2018-06-05 Chris Dumez <cdumez@apple.com> |
| 918 |
| 919 Regression(r232082): Websites get loaded inside of Messages App chat tra
nscript |
| 920 https://bugs.webkit.org/show_bug.cgi?id=186331 |
| 921 <rdar://problem/40735446> |
| 922 |
| 923 Reviewed by Darin Adler. |
| 924 |
| 925 Add API test coverage. |
| 926 |
| 927 * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: |
| 928 (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolic
yForNavigationAction:request:frame:decisionListener:]): |
| 929 (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartPro
visionalLoadForFrame:]): |
| 930 (TestWebKitAPI::TEST): |
| 931 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAct
ion:request:frame:decisionListener:]): Deleted. |
| 932 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:requ
est:frame:decisionListener:]): Deleted. |
| 933 (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): De
leted. |
| 934 |
| 935 2018-06-05 Wenson Hsieh <wenson_hsieh@apple.com> |
| 936 |
| 937 DataInteractionTests ContentEditableToTextarea and ContentEditableToCont
entEditable are failing on recent iOS 12 |
| 938 https://bugs.webkit.org/show_bug.cgi?id=186325 |
| 939 <rdar://problem/40527850> |
| 940 |
| 941 Reviewed by Tim Horton. |
| 942 |
| 943 Tweak these API tests so that they're robust against changes to how NSAt
tributedStrings are serialized in item |
| 944 providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions
of iOS, just verify that either rich |
| 945 text type is present in the list of dragged type identifiers, and that t
he rich text type is placed at a higher |
| 946 fidelity than plain text. |
| 947 |
| 948 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: |
| 949 (checkRichTextTypePrecedesPlainTextType): |
| 950 (TestWebKitAPI::TEST): |
| 951 (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted. |
| 952 |
| 953 2018-06-05 Brent Fulgham <bfulgham@apple.com> |
| 954 |
| 955 Adjust compile and runtime flags to match shippable state of features |
| 956 https://bugs.webkit.org/show_bug.cgi?id=186319 |
| 957 <rdar://problem/40352045> |
| 958 |
| 959 Reviewed by Maciej Stachowiak, Jon Lee, and others. |
| 960 |
| 961 This patch revises the compile time and runtime state for various featur
es to match their |
| 962 suitability for end-user releases. |
| 963 |
| 964 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match We
bKit definition of |
| 965 WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defin
ed properly for |
| 966 Cocoa builds. |
| 967 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENAB
LE_INPUT_TYPE_COLOR |
| 968 or ENABLE_INPUT_TYPE_COLOR_POPOVER. |
| 969 |
| 970 2018-06-05 Saam Barati <sbarati@apple.com> |
| 971 |
| 972 run-testmem should have a dry run option and an option to parse the stdo
ut of executing the dry run |
| 973 https://bugs.webkit.org/show_bug.cgi?id=186293 |
| 974 |
| 975 Reviewed by Mark Lam. |
| 976 |
| 977 This makes it easier to execute run-testmem on a device that doesn't hav
e ruby |
| 978 on it. run-testmem now has a --dry option that will output commands to e
xecute |
| 979 in bash. To run on a device that doesn't have ruby, just put its output
into |
| 980 a bash script, and copy the PerformanceTests/testmem directory onto that
device, |
| 981 and execute the bash script. Running that bash script will give you raw
output. |
| 982 Make a file with that output and pass it into run-testmem using the --pa
rse option. |
| 983 run-testmem will parse the raw output and compute the benchmark score. |
| 984 |
| 985 * Scripts/run-testmem: |
| 986 |
| 987 2018-06-05 Youenn Fablet <youenn@apple.com> |
| 988 |
| 989 ServiceWorker registration should store any script fetched through impor
tScripts |
| 990 https://bugs.webkit.org/show_bug.cgi?id=182444 |
| 991 <rdar://problem/37164835> |
| 992 |
| 993 Reviewed by Chris Dumez. |
| 994 |
| 995 Add support to crash the storage process from Internals. |
| 996 |
| 997 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: |
| 998 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: |
| 999 (WTR::TestRunner::terminateStorageProcess): |
| 1000 * WebKitTestRunner/InjectedBundle/TestRunner.h: |
| 1001 * WebKitTestRunner/TestController.cpp: |
| 1002 (WTR::TestController::terminateStorageProcess): |
| 1003 * WebKitTestRunner/TestController.h: |
| 1004 * WebKitTestRunner/TestInvocation.cpp: |
| 1005 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): |
| 1006 |
| 1007 2018-06-05 Brent Fulgham <bfulgham@apple.com> |
| 1008 |
| 1009 Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple b
uilds |
| 1010 https://bugs.webkit.org/show_bug.cgi?id=186286 |
| 1011 <rdar://problem/40782992> |
| 1012 |
| 1013 Reviewed by Dan Bernstein. |
| 1014 |
| 1015 Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-
production builds) |
| 1016 to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manual
ly |
| 1017 change this flag when preparing for a production release. |
| 1018 |
| 1019 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATAB
LE_FRAMEWORKS to |
| 1020 determine whether experimental features should be enabled, and use it to
properly define |
| 1021 the feature flag. |
| 1022 |
| 1023 2018-06-05 Robin Morisset <rmorisset@apple.com> |
| 1024 |
| 1025 Add a grammar (in antlr4 format) to the WSL spec. |
| 1026 https://bugs.webkit.org/show_bug.cgi?id=186310 |
| 1027 |
| 1028 Rubberstamped by Filip Pizlo |
| 1029 |
| 1030 It is just the raw rules, without much comments and no typesetting. |
| 1031 Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK) |
| 1032 |
| 1033 It does not exactly match the parser of the current js implementation of
WSL, it: |
| 1034 - Accepts negative literals |
| 1035 - Reserves keywords fallthrough/auto |
| 1036 - Refuses '_' as a valid identifier |
| 1037 - Accepts several capitalizations for Null/True/False |
| 1038 - Accepts variable declarations at the top-level |
| 1039 - Correctly parses ternary expressions |
| 1040 - Forbids empty extension list for protocols |
| 1041 - Does not allow a space between '[' and ']' in type suffixes |
| 1042 - Correctly parses nested generics |
| 1043 - Accepts a 'fallthrough;' statement (for switches) |
| 1044 - Refuses chained relational operator (e.g. x < y < z) |
| 1045 - Generally a completely different structure for parsing effectful expre
ssions, although it probably accepts about the same language |
| 1046 - Currently only accepts literals and identifiers as constexpr (while th
e js parser accepts way too much, including '(x += 42)') |
| 1047 There are probably more differences that I missed. The js parser will pr
obably have to be mostly rewritten to follow the spec more closely (and fix all
the bugs). |
| 1048 I will try to see if it can be automatically derived from the antlr4 gra
mmar. |
| 1049 |
| 1050 * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added. |
| 1051 |
| 1052 2018-06-04 Frederic Wang <fwang@igalia.com> |
| 1053 |
| 1054 import-w3c-tests should rely on <meta name="flags"> to detect CSS manual
tests |
| 1055 https://bugs.webkit.org/show_bug.cgi?id=186261 |
| 1056 |
| 1057 Reviewed by Youenn Fablet. |
| 1058 |
| 1059 * Scripts/webkitpy/w3c/test_parser.py: |
| 1060 (TestParser.is_wpt_manualtest): Add code to detect whether a file is a m
anual test |
| 1061 from its <meta name="flags"> tags. This is based on SourceFile::content_
is_css_manual from |
| 1062 the WPT repository. |
| 1063 * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whe
ther files with |
| 1064 <meta name="flags"> are manual or non-manual according to CSS WG rules. |
| 1065 |
| 1066 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1067 |
| 1068 Fixed building ImageDiff with the default build system in the Xcode 10 d
eveloper beta. |
| 1069 |
| 1070 * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include |
| 1071 HaveInternalSDK.xcconfig, since it may not be preent. |
| 1072 |
| 1073 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1074 |
| 1075 Fixed building TestWebKitAPI with a shared build directory with XCBuild,
which is the |
| 1076 default build system in the Xcode 10 developer beta. |
| 1077 |
| 1078 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the ref
erence to the |
| 1079 built libWTF.a to be relative to the built products directory. |
| 1080 |
| 1081 2018-06-04 Chris Dumez <cdumez@apple.com> |
| 1082 |
| 1083 Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy
" |
| 1084 https://bugs.webkit.org/show_bug.cgi?id=186287 |
| 1085 <rdar://problem/40783352> |
| 1086 |
| 1087 Reviewed by Youenn Fablet. |
| 1088 |
| 1089 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 1090 (enableExperimentalFeatures): |
| 1091 * DumpRenderTree/win/DumpRenderTree.cpp: |
| 1092 (enableExperimentalFeatures): |
| 1093 |
| 1094 2018-06-04 Daniel Bates <dabates@apple.com> |
| 1095 |
| 1096 Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() |
| 1097 https://bugs.webkit.org/show_bug.cgi?id=186290 |
| 1098 |
| 1099 Reviewed by Aakash Jain. |
| 1100 |
| 1101 Although the usefulness of the code in MockBugzillaQueries.fetch_attachm
ent_ids_from_review_queue() is |
| 1102 questionable we should fix a typo when calling this mocked function with
argument since. |
| 1103 |
| 1104 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: |
| 1105 (MockBugzillaQueries.fetch_attachment_ids_from_review_queue): |
| 1106 |
| 1107 2018-06-04 Dan Bernstein <mitz@apple.com> |
| 1108 |
| 1109 Fixed building with the macOS Mojave seed SDK. |
| 1110 |
| 1111 * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: |
| 1112 |
| 1113 2018-06-04 Alexey Proskuryakov <ap@apple.com> |
| 1114 |
| 1115 Add Mojave support to WebKit tools |
| 1116 https://bugs.webkit.org/show_bug.cgi?id=186282 |
| 1117 |
| 1118 Reviewed by Daniel Bates. |
| 1119 |
| 1120 Nightly build support will be added separately. |
| 1121 |
| 1122 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images
/Mojave.png: Added. |
| 1123 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images
/Mojave@2x.png: Added. |
| 1124 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Script
s/Dashboard.js: |
| 1125 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles
/Main.css: |
| 1126 Added dashboard support. |
| 1127 |
| 1128 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: |
| 1129 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: |
| 1130 Trigger the right build queues on check-in. |
| 1131 |
| 1132 * Scripts/webkitpy/common/version_name_map.py: |
| 1133 * Scripts/webkitpy/common/version_name_map_unittest.py: |
| 1134 The main version mapping class updated. |
| 1135 |
| 1136 * Scripts/webkitpy/layout_tests/models/test_expectations.py: |
| 1137 * Scripts/webkitpy/port/mac_unittest.py: |
| 1138 Updated for more platforms in unit tests. |
| 1139 |
| 1140 * TestResultServer/static-dashboards/flakiness_dashboard.js: |
| 1141 Added the new platform to flakiness dashboard. |
| 1142 |
| 1143 2018-06-04 Wenson Hsieh <wenson_hsieh@apple.com> |
| 1144 |
| 1145 [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag |
| 1146 https://bugs.webkit.org/show_bug.cgi?id=186279 |
| 1147 |
| 1148 Reviewed by Tim Horton. |
| 1149 |
| 1150 Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS). |
| 1151 |
| 1152 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: |
| 1153 |
| 1154 2018-06-03 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1155 |
| 1156 [Win][MiniBrowser] Remove gMiniBrowser global variable |
| 1157 https://bugs.webkit.org/show_bug.cgi?id=186134 |
| 1158 |
| 1159 Reviewed by Brent Fulgham. |
| 1160 |
| 1161 It should not be assumed there is only one main window and one browser |
| 1162 window to support multiple windows properly. gMainWindow and |
| 1163 gMiniBrowser global variables should be removed. This change |
| 1164 removes gMiniBrowser. |
| 1165 |
| 1166 * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable. |
| 1167 * MiniBrowser/win/Common.h: Ditto. |
| 1168 * MiniBrowser/win/MainWindow.cpp: |
| 1169 (MainWindow::init): |
| 1170 (MainWindow::WndProc): |
| 1171 (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar. |
| 1172 (MainWindow::cachesDialogProc): Renamed from Caches. |
| 1173 (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent. |
| 1174 (MainWindow::onURLBarEnter): Extracted from EditProc. |
| 1175 (BackButtonProc): Deleted. |
| 1176 (ForwardButtonProc): Deleted. |
| 1177 (Caches): Renamed to MainWindow::cachesDialogProc. |
| 1178 (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc. |
| 1179 * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a m
ember variable of MainWindow. |
| 1180 * MiniBrowser/win/MiniBrowserLibResource.h: |
| 1181 * MiniBrowser/win/WinMain.cpp: |
| 1182 (wWinMain): |
| 1183 |
| 1184 2018-06-02 Darin Adler <darin@apple.com> |
| 1185 |
| 1186 [Cocoa] Update some code to be more ARC-compatible to prepare for future
ARC adoption |
| 1187 https://bugs.webkit.org/show_bug.cgi?id=186227 |
| 1188 |
| 1189 Reviewed by Dan Bernstein. |
| 1190 |
| 1191 * DumpRenderTree/mac/AccessibilityCommonMac.mm: |
| 1192 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1193 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1194 |
| 1195 * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing includ
e. |
| 1196 |
| 1197 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: |
| 1198 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1199 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: |
| 1200 (AccessibilityTextMarker::isEqual): Ditto. |
| 1201 (AccessibilityTextMarkerRange::isEqual): Ditto. |
| 1202 |
| 1203 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 1204 (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of N
SAutoreleasePool. |
| 1205 (DumpRenderTreeMain): Ditto. |
| 1206 (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto. |
| 1207 (runTest): Ditto. |
| 1208 |
| 1209 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: |
| 1210 (copyFile): Use a std::pair to return both a URL and an error rather tha
n using an |
| 1211 out argument for the NSError. |
| 1212 (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:o
ptions:operationQueue:reader:]): |
| 1213 Updated for the above change. |
| 1214 |
| 1215 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: |
| 1216 (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging
typecast. |
| 1217 (-[DumpRenderTreeWindow close]): Ditto. |
| 1218 * DumpRenderTree/mac/LayoutTestHelper.m: |
| 1219 (setDisplayColorProfile): Ditto. |
| 1220 |
| 1221 * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include. |
| 1222 |
| 1223 * DumpRenderTree/mac/ResourceLoadDelegate.mm: |
| 1224 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectRespons
e:fromDataSource:]): |
| 1225 Add __bridge to a bridging typecast. |
| 1226 * DumpRenderTree/mac/TestRunnerMac.mm: |
| 1227 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto. |
| 1228 (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool inst
ead of NSAutoreleasePool. |
| 1229 |
| 1230 * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment. |
| 1231 |
| 1232 * DumpRenderTree/mac/UIScriptControllerMac.mm: |
| 1233 (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridgin
g typecast. |
| 1234 (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto. |
| 1235 (WTR::UIScriptController::overridePreference): Ditto. |
| 1236 * DumpRenderTree/mac/WorkQueueItemMac.mm: |
| 1237 (LoadItem::invoke const): Ditto. |
| 1238 (LoadHTMLStringItem::invoke const): Ditto. |
| 1239 (ScriptItem::invoke const): Ditto. |
| 1240 |
| 1241 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: |
| 1242 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1243 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1244 |
| 1245 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: |
| 1246 (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of a
utorelease. |
| 1247 (-[NSString createJSStringRef]): Add __bridge to a bridging typecast. |
| 1248 |
| 1249 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: |
| 1250 (WTR::AccessibilityController::accessibleElementById): Add __bridge to a
bridging typecast. |
| 1251 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.m
m: |
| 1252 (-[NSString createJSStringRef]): Ditto. |
| 1253 * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: |
| 1254 (WTR::AccessibilityTextMarker::isEqual): Ditto. |
| 1255 * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm
: |
| 1256 (WTR::AccessibilityTextMarkerRange::isEqual): Ditto. |
| 1257 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: |
| 1258 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto. |
| 1259 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto. |
| 1260 (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto. |
| 1261 (WTR::AccessibilityUIElement::previousTextMarker): Ditto. |
| 1262 (WTR::AccessibilityUIElement::nextTextMarker): Ditto. |
| 1263 (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto. |
| 1264 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto. |
| 1265 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto. |
| 1266 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto. |
| 1267 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto. |
| 1268 (WTR::createJSStringRef): Ditto. |
| 1269 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto
. |
| 1270 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOpti
ons): Ditto. |
| 1271 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContains
Attribute): Ditto. |
| 1272 (WTR::AccessibilityUIElement::indexForTextMarker): Ditto. |
| 1273 (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto. |
| 1274 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Dit
to. |
| 1275 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Di
tto. |
| 1276 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
Ditto. |
| 1277 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto
. |
| 1278 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Di
tto. |
| 1279 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMar
ker): Ditto. |
| 1280 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
Ditto. |
| 1281 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Dit
to. |
| 1282 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMark
er): Ditto. |
| 1283 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): D
itto. |
| 1284 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: |
| 1285 (WTR::initializeWebViewConfiguration): Ditto. |
| 1286 (WTR::TestController::platformContext): Ditto. |
| 1287 (WTR::TestController::platformPreferences): Ditto. |
| 1288 (WTR::TestController::platformAdjustContext): Ditto. |
| 1289 * WebKitTestRunner/mac/PlatformWebViewMac.mm: |
| 1290 (WTR::PlatformWebView::PlatformWebView): Ditto. |
| 1291 * WebKitTestRunner/mac/TestControllerMac.mm: |
| 1292 (WTR::TestController::initializeInjectedBundlePath): Ditto. |
| 1293 (WTR::TestController::initializeTestPluginDirectory): Ditto. |
| 1294 (WTR::TestController::platformConfigureViewForTest): Ditto. |
| 1295 |
| 1296 * WebKitTestRunner/mac/UIScriptControllerMac.mm: |
| 1297 (WTR::nsString): Use CFBridgingRelease instead of autorelease. |
| 1298 (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to
a bridging |
| 1299 typecast. |
| 1300 |
| 1301 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing in
clude. |
| 1302 |
| 1303 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: |
| 1304 (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging
typecast. |
| 1305 (-[LocalPasteboard setString:forType:]): Ditto. |
| 1306 |
| 1307 * WebKitTestRunner/mac/main.mm: |
| 1308 (main): Use @autoreleasepool instead of NSAutoreleasePool. |
| 1309 |
| 1310 2018-06-02 Keith Miller <keith_miller@apple.com> |
| 1311 |
| 1312 run-jsc should pass the option to use dollar vm by default |
| 1313 https://bugs.webkit.org/show_bug.cgi?id=186170 |
| 1314 |
| 1315 Reviewed by Yusuke Suzuki. |
| 1316 |
| 1317 * Scripts/run-jsc: |
| 1318 |
| 1319 2018-06-02 Commit Queue <commit-queue@webkit.org> |
| 1320 |
| 1321 Unreviewed, rolling out r232421. |
| 1322 https://bugs.webkit.org/show_bug.cgi?id=186240 |
| 1323 |
| 1324 Breaks webkitpy tests (Requested by aakashjain on #webkit). |
| 1325 |
| 1326 Reverted changeset: |
| 1327 |
| 1328 "Add some tests for lldb_webkit.py" |
| 1329 https://bugs.webkit.org/show_bug.cgi?id=183744 |
| 1330 https://trac.webkit.org/changeset/232421 |
| 1331 |
| 1332 2018-06-01 Daniel Bates <dabates@apple.com> |
| 1333 |
| 1334 Add some tests for lldb_webkit.py |
| 1335 https://bugs.webkit.org/show_bug.cgi?id=183744 |
| 1336 |
| 1337 Reviewed by Alexey Proskuryakov. |
| 1338 |
| 1339 Adds some tests to ensure we do not regress LLDB pretty-printing of WTF:
:StringImpl |
| 1340 and WTF::String objects. |
| 1341 |
| 1342 The tests make use of the LLDB Python API (lldb.py) and a simple debug-b
uilt test |
| 1343 program, lldbWebKitTester, to run. For now, we only support building lld
bWebKitTester |
| 1344 on Mac. |
| 1345 |
| 1346 * Makefile: Build the simple test tool lldbWebKitTester on Mac. |
| 1347 * Scripts/build-lldbwebkittester: Added. |
| 1348 (buildProjectOrDie): |
| 1349 * Scripts/dump-class-layout: Extract logic to compute the path to the LL
DB Python module |
| 1350 from here to Scripts/webkitpy/common/system/systemhost.py so that it can
used by both |
| 1351 this script and lldb/lldb_webkit_unittest.py. Also import the lldb modul
e at the top of |
| 1352 the file and take advantage of Python's default error semantics to throw
an exception |
| 1353 if the import fails instead of handling it ourself. This has the side ef
fect that we |
| 1354 now always import the LLDB Python module even if this script is invoked
with --help. |
| 1355 If this turns out to be a significant annoyance then we can look to dyna
mically import |
| 1356 the module as we did before this change. |
| 1357 (webkit_build_dir): |
| 1358 (main): |
| 1359 (developer_dir): Deleted. |
| 1360 (import_lldb): Deleted. |
| 1361 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME com
ment to reflect |
| 1362 that fact that test-webkitpy does not support class and module fixtures.
This is because |
| 1363 test-webkitpy currently implements parallelism by breaking down existing
test classes |
| 1364 into individual test methods itself and having each worker run exactly o
ne test method (via |
| 1365 unittest.TestLoader.loadTestsFromName()) at a time. As a result of this
reorganization, |
| 1366 setUpModule()/setUpClass() are called for each test method as opposed to
once per test |
| 1367 class/test module. |
| 1368 (remove_dir): Ditto. |
| 1369 * Scripts/webkitpy/common/system/systemhost.py: |
| 1370 (SystemHost): |
| 1371 (SystemHost.path_to_lldb_python_directory): Added. |
| 1372 * Scripts/webkitpy/test/main.py: |
| 1373 (_find_lldb_webkit_tester): Returns whether there exists a Debug or Rele
ase-built lldbWebKitTester. |
| 1374 (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only s
upport building |
| 1375 lldbWebKitTester on Mac. |
| 1376 (main): Add Tools/lldb to the test search path if the platform has lldb.
py. |
| 1377 (Tester.run): Pass a boolean as to whether we will run the lldb_webkit u
nit tests. |
| 1378 (Tester._run_tests): Modified to take a boolean as to whether to run the
lldb_webkit unit tests. |
| 1379 If we will run these tests then build lldbWebKitTester if it has not alr
eady been built as the |
| 1380 unit tests depend on this program. |
| 1381 * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added. |
| 1382 * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added. |
| 1383 * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added. |
| 1384 * lldb/lldbWebKitTester/Makefile: Added. |
| 1385 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Adde
d. |
| 1386 * lldb/lldbWebKitTester/main.cpp: Added. |
| 1387 (breakForTestingSummaryProviders): |
| 1388 (utf16String): |
| 1389 (testSummaryProviders): |
| 1390 (main): |
| 1391 * lldb/lldb_webkit_unittest.py: Added. |
| 1392 (destroy_cached_debug_session): |
| 1393 (LLDBDebugSession): |
| 1394 (LLDBDebugSession.setup): |
| 1395 (LLDBDebugSession.tearDown): |
| 1396 (TestSummaryProviders): |
| 1397 (TestSummaryProviders.setUpClass): |
| 1398 (TestSummaryProviders._sbFrame): |
| 1399 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_str
ing): |
| 1400 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_st
ring): |
| 1401 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_str
ing): |
| 1402 (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_st
ring): |
| 1403 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string)
: |
| 1404 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string
): |
| 1405 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string)
: |
| 1406 (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string
): |
| 1407 |
| 1408 2018-06-01 Frederic Wang <fwang@igalia.com> |
| 1409 |
| 1410 export-w3c-test-changes cannot apply patches when some w3c-import.log fi
les are changed |
| 1411 https://bugs.webkit.org/show_bug.cgi?id=186133 |
| 1412 |
| 1413 Reviewed by Youenn Fablet. |
| 1414 |
| 1415 * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the
diff. |
| 1416 * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test. |
| 1417 |
| 1418 2018-05-31 Frederic Wang <fwang@igalia.com> |
| 1419 |
| 1420 export-w3c-test-changes should use the new location & name of the WPT re
po |
| 1421 https://bugs.webkit.org/show_bug.cgi?id=186135 |
| 1422 |
| 1423 Reviewed by Youenn Fablet. |
| 1424 |
| 1425 Web platform tests have been moved to GitHub's web-platform-tests/wpt. T
his patch updates the |
| 1426 corresponding variables to use the new organization and repository name.
It also refactors a |
| 1427 bit the code to reduce the amount of hardcoded strings. |
| 1428 |
| 1429 * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name
wpt. Also removes the |
| 1430 final slash to WPT_GH_URL, so it can be used for repo URL too. |
| 1431 * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define
WPT_PR_URL from |
| 1432 WPT_GH_URL. |
| 1433 (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_N
AME. |
| 1434 (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME. |
| 1435 (WebPlatformTestExporter._git): Use WPT_GH_URL. |
| 1436 (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WP
T_GH_REPO_NAME. |
| 1437 (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO
_NAME. |
| 1438 (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL. |
| 1439 * Scripts/webkitpy/w3c/test_exporter_unittest.py: |
| 1440 (TestExporterTest.test_export): Update organization and repository names
for the remote |
| 1441 branch and pull request. |
| 1442 (TestExporterTest.test_export_with_specific_branch): Update repository n
ame. |
| 1443 |
| 1444 2018-05-31 Ryan Haddad <ryanhaddad@apple.com> |
| 1445 |
| 1446 Update expected results for BuildStepsConstructorTest |
| 1447 https://bugs.webkit.org/show_bug.cgi?id=186119 |
| 1448 |
| 1449 Reviewed by Alex Christensen. |
| 1450 |
| 1451 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missi
ng entries for 'WinCairo 64-bit' bots. |
| 1452 |
| 1453 2018-05-31 Sihui Liu <sihui_liu@apple.com> |
| 1454 |
| 1455 [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails bec
ause cookies use different files with/without processpool |
| 1456 https://bugs.webkit.org/show_bug.cgi?id=185831 |
| 1457 <rdar://problem/40468716> |
| 1458 |
| 1459 Reviewed by David Kilzer. |
| 1460 |
| 1461 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 1462 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiated
ByFrame:completionHandler:]): |
| 1463 (TEST): |
| 1464 |
| 1465 2018-05-31 Chris Dumez <cdumez@apple.com> |
| 1466 |
| 1467 [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset
is a flaky failure |
| 1468 https://bugs.webkit.org/show_bug.cgi?id=184893 |
| 1469 <rdar://problem/39747271> |
| 1470 |
| 1471 Reviewed by Wenson Hsieh. |
| 1472 |
| 1473 Update test to wait until the view is the expected height instead of |
| 1474 calling waitForNextPresentationUpdate once and expect the view to |
| 1475 have the right height. This fixes the flakiness. |
| 1476 |
| 1477 * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm: |
| 1478 (TestWebKitAPI::waitUntilInnerHeightIs): |
| 1479 (TestWebKitAPI::TEST): |
| 1480 |
| 1481 2018-05-31 Leo Balter <leonardo.balter@gmail.com> |
| 1482 |
| 1483 test262-runner should run in verbose mode in automation |
| 1484 https://bugs.webkit.org/show_bug.cgi?id=186115 |
| 1485 |
| 1486 Reviewed by Yusuke Suzuki. |
| 1487 |
| 1488 This patch toggles the verbose mode in the build bot and reports every t
est file |
| 1489 in order to avoid the '1200 seconds without output' issue. |
| 1490 * BuildSlaveSupport/build.webkit.org-config/steps.py: |
| 1491 (RunTest262Tests): |
| 1492 * Scripts/test262/Runner.pm: |
| 1493 (processResult): |
| 1494 |
| 1495 2018-05-30 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1496 |
| 1497 [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainW
indow.cpp |
| 1498 https://bugs.webkit.org/show_bug.cgi?id=186079 |
| 1499 |
| 1500 Reviewed by Alex Christensen. |
| 1501 |
| 1502 This is a sub task of Bug 184770. |
| 1503 |
| 1504 This change is partial. I'm going to remove global variables |
| 1505 gMainWindow and gMiniBrowser and convert more functions to |
| 1506 MainWindow's methods in follow-up patches. |
| 1507 |
| 1508 * MiniBrowser/win/CMakeLists.txt: Added Common.cpp |
| 1509 * MiniBrowser/win/Common.cpp: |
| 1510 (menuItemIsChecked): Moved to MainWindow.cpp. |
| 1511 (turnOffOtherUserAgents): Ditto. |
| 1512 (EditProc): Ditto. |
| 1513 (BackButtonProc): Ditto. |
| 1514 (ForwardButtonProc): Ditto. |
| 1515 (About): Ditto. |
| 1516 (Caches): Ditto. |
| 1517 (CustomUserAgent): Ditto. |
| 1518 (AuthDialogProc): Ditto. |
| 1519 (DisplayAuthDialog): Converted to MainWindow's method. |
| 1520 (ToggleMenuItem): Ditto. |
| 1521 (loadURL): Ditto. |
| 1522 * MiniBrowser/win/Common.h: |
| 1523 * MiniBrowser/win/MainWindow.cpp: |
| 1524 (MainWindow::init): Call SetFocus at the end of the construction. |
| 1525 (MainWindow::WndProc): |
| 1526 (menuItemIsChecked): Moved from Common.cpp. |
| 1527 (turnOffOtherUserAgents): Ditto. |
| 1528 (EditProc): Ditto. |
| 1529 (BackButtonProc): Ditto. |
| 1530 (ForwardButtonProc): Ditto. |
| 1531 (About): Ditto. |
| 1532 (Caches): Ditto. |
| 1533 (CustomUserAgent): Ditto. |
| 1534 (authDialogProc): Ditto. |
| 1535 (MainWindow::displayAuthDialog): Converted from a function of Common.cpp
. |
| 1536 (MainWindow::toggleMenuItem): Ditto. |
| 1537 (MainWindow::loadURL): Ditto. |
| 1538 * MiniBrowser/win/MainWindow.h: Added method declarations. |
| 1539 * MiniBrowser/win/MiniBrowser.h: Added pragma once. |
| 1540 * MiniBrowser/win/WinMain.cpp: |
| 1541 (wWinMain): Include Common.h instead of Common.cpp. |
| 1542 |
| 1543 2018-05-30 Brady Eidson <beidson@apple.com> |
| 1544 |
| 1545 REGRESSION (r224684): User-agent seen by page does not change when modif
ied by the develop menu options after reloading. |
| 1546 <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=18
6111 |
| 1547 |
| 1548 Reviewed by Andy Estes. |
| 1549 |
| 1550 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: |
| 1551 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: |
| 1552 (WTR::TestRunner::setCustomUserAgent): |
| 1553 * WebKitTestRunner/InjectedBundle/TestRunner.h: |
| 1554 * WebKitTestRunner/TestController.cpp: |
| 1555 (WTR::TestController::resetStateToConsistentValues): |
| 1556 * WebKitTestRunner/TestInvocation.cpp: |
| 1557 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): |
| 1558 |
| 1559 2018-05-30 Youenn Fablet <youenn@apple.com> |
| 1560 |
| 1561 Rename CrossOriginResourcePolicy same to same-origin |
| 1562 https://bugs.webkit.org/show_bug.cgi?id=186080 |
| 1563 |
| 1564 Reviewed by Chris Dumez. |
| 1565 |
| 1566 * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: |
| 1567 (TestWebKitAPI::TEST): |
| 1568 |
| 1569 2018-05-30 Ms2ger <Ms2ger@igalia.com> |
| 1570 |
| 1571 [GTK] Unreviewed test gardening |
| 1572 https://bugs.webkit.org/show_bug.cgi?id=186098 |
| 1573 |
| 1574 Unreviewed gardening. |
| 1575 |
| 1576 * TestWebKitAPI/glib/TestExpectations.json: update expectations. |
| 1577 |
| 1578 2018-05-29 Youenn Fablet <youenn@apple.com> |
| 1579 |
| 1580 Add a consistency check between URL and CFURL |
| 1581 https://bugs.webkit.org/show_bug.cgi?id=182444 |
| 1582 <rdar://problem/37164835> |
| 1583 |
| 1584 Reviewed by Geoff Garen. |
| 1585 |
| 1586 DRT code expected a non null URL which is no longer the case now. |
| 1587 Updated DRT to remove that assumption. |
| 1588 |
| 1589 * DumpRenderTree/TestRunner.cpp: |
| 1590 (TestRunner::redirectionDestinationForURL): |
| 1591 * DumpRenderTree/TestRunner.h: |
| 1592 * DumpRenderTree/mac/ResourceLoadDelegate.mm: |
| 1593 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectRespons
e:fromDataSource:]): |
| 1594 |
| 1595 2018-05-29 Brendan McLoughlin <brendan@bocoup.com> |
| 1596 |
| 1597 Export changes to web-platform-test as part of the webkit-patch upload w
orkflow |
| 1598 https://bugs.webkit.org/show_bug.cgi?id=184914 |
| 1599 |
| 1600 Reviewed by Youenn Fablet. |
| 1601 |
| 1602 * Scripts/webkitpy/tool/commands/upload.py: |
| 1603 (Upload): |
| 1604 (CreateBug.execute): |
| 1605 (WPTChangeExport): |
| 1606 * Scripts/webkitpy/tool/steps/__init__.py: |
| 1607 * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added. |
| 1608 (WPTChangeExport): |
| 1609 (WPTChangeExport.options): |
| 1610 (WPTChangeExport.run): |
| 1611 * Scripts/webkitpy/w3c/common.py: |
| 1612 * Scripts/webkitpy/w3c/test_exporter.py: |
| 1613 (WebPlatformTestExporter): |
| 1614 (WebPlatformTestExporter.__init__): |
| 1615 (WebPlatformTestExporter.username): |
| 1616 (WebPlatformTestExporter.token): |
| 1617 (WebPlatformTestExporter._github): |
| 1618 (WebPlatformTestExporter._wpt_fork_branch_github_url): |
| 1619 (WebPlatformTestExporter._wpt_fork_remote): |
| 1620 (WebPlatformTestExporter._wpt_fork_push_url): |
| 1621 (WebPlatformTestExporter._git): |
| 1622 (WebPlatformTestExporter._branch_name): |
| 1623 (WebPlatformTestExporter._public_branch_name): |
| 1624 (WebPlatformTestExporter._wpt_patch): |
| 1625 (WebPlatformTestExporter.has_wpt_changes): |
| 1626 (WebPlatformTestExporter._find_filename): |
| 1627 (WebPlatformTestExporter._is_ignored_file): |
| 1628 (WebPlatformTestExporter._strip_ignored_files_from_diff): |
| 1629 (WebPlatformTestExporter.write_git_patch_file): |
| 1630 (WebPlatformTestExporter._prompt_for_token): |
| 1631 (WebPlatformTestExporter._prompt_for_username): |
| 1632 (WebPlatformTestExporter._ensure_username_and_token): |
| 1633 (WebPlatformTestExporter._validate_and_save_token): |
| 1634 (WebPlatformTestExporter.create_branch_with_patch): |
| 1635 (WebPlatformTestExporter.push_to_wpt_fork): |
| 1636 (WebPlatformTestExporter.make_pull_request): |
| 1637 (WebPlatformTestExporter.delete_local_branch): |
| 1638 (WebPlatformTestExporter.create_upload_remote_if_needed): |
| 1639 (WebPlatformTestExporter.do_export): |
| 1640 (parse_args): |
| 1641 (TestExporter): Deleted. |
| 1642 (TestExporter.__init__): Deleted. |
| 1643 (TestExporter._ensure_wpt_repository): Deleted. |
| 1644 (TestExporter._fetch_wpt_repository): Deleted. |
| 1645 (TestExporter._ensure_new_branch_name): Deleted. |
| 1646 (TestExporter.download_and_commit_patch): Deleted. |
| 1647 (TestExporter.clean): Deleted. |
| 1648 (TestExporter.create_branch_with_patch): Deleted. |
| 1649 (TestExporter.push_to_wpt_fork): Deleted. |
| 1650 (TestExporter.make_pull_request): Deleted. |
| 1651 (TestExporter.create_wpt_pull_request): Deleted. |
| 1652 (TestExporter.delete_local_branch): Deleted. |
| 1653 (TestExporter.create_git_patch): Deleted. |
| 1654 (TestExporter.create_upload_remote): Deleted. |
| 1655 (TestExporter.do_export): Deleted. |
| 1656 * Scripts/webkitpy/w3c/test_exporter_unittest.py: |
| 1657 (TestExporterTest.MockGit): |
| 1658 (TestExporterTest.MockGit.create_patch): |
| 1659 (TestExporterTest.test_export): |
| 1660 (TestExporterTest.test_export_with_specific_branch): |
| 1661 (TestExporterTest): |
| 1662 (TestExporterTest.test_export_interactive_mode): |
| 1663 (TestExporterTest.test_export_invalid_token): |
| 1664 (TestExporterTest.test_export_wrong_token): |
| 1665 (TestExporterTest.test_has_wpt_changes): |
| 1666 (TestExporterTest.test_has_no_wpt_changes_for_no_diff): |
| 1667 (TestExporterTest.test_ignore_changes_to_expected_file): |
| 1668 |
| 1669 2018-05-29 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1670 |
| 1671 [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser
.cpp |
| 1672 https://bugs.webkit.org/show_bug.cgi?id=186029 |
| 1673 |
| 1674 Reviewed by Alex Christensen. |
| 1675 |
| 1676 This is a sub task of Bug 184770. |
| 1677 |
| 1678 * MiniBrowser/win/Common.cpp: |
| 1679 (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPrefere
nce. |
| 1680 (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics
. |
| 1681 (AbortProc): Moved to MiniBrowser.cpp. |
| 1682 (getPrinterDC): Ditto. |
| 1683 (initDocStruct): Ditto. |
| 1684 (PrintView): Ditto. |
| 1685 (ToggleMenuFlag): Ditto. |
| 1686 (setWindowText): Ditto. |
| 1687 (updateStatistics): Ditto. |
| 1688 * MiniBrowser/win/MainWindow.cpp: |
| 1689 (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView. |
| 1690 * MiniBrowser/win/MiniBrowser.cpp: |
| 1691 (AbortProc): Moved from Common.cpp. |
| 1692 (getPrinterDC): Moved from Common.cpp. |
| 1693 (initDocStruct): Moved from Common.cpp. |
| 1694 (setWindowText): Moved from Common.cpp. |
| 1695 (MiniBrowser::print): Renamed from PrintView of Common.cpp. |
| 1696 (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common
.cpp. |
| 1697 (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cp
p. |
| 1698 * MiniBrowser/win/MiniBrowser.h: Add method declarations. |
| 1699 * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePt
r typedef. |
| 1700 |
| 1701 2018-05-29 Saam Barati <sbarati@apple.com> |
| 1702 |
| 1703 JSC should put bmalloc's scavenger into mini mode |
| 1704 https://bugs.webkit.org/show_bug.cgi?id=185988 |
| 1705 |
| 1706 Reviewed by Michael Saboff. |
| 1707 |
| 1708 This patch makes it so that we turn off the JIT when running run-testmem |
| 1709 that way we make JSC use its mini mode. |
| 1710 |
| 1711 * Scripts/run-testmem: |
| 1712 |
| 1713 2018-05-29 Sihui Liu <sihui_liu@apple.com> |
| 1714 |
| 1715 Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes |
| 1716 https://bugs.webkit.org/show_bug.cgi?id=185835 |
| 1717 <rdar://problem/39142257> |
| 1718 |
| 1719 Reviewed by Chris Dumez. |
| 1720 |
| 1721 Add API test coverage. |
| 1722 |
| 1723 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm: |
| 1724 (TEST): |
| 1725 |
| 1726 2018-05-29 Wenson Hsieh <wenson_hsieh@apple.com> |
| 1727 |
| 1728 [Extra zoom mode] "Significant area painted" rendering progress event is
rarely fired |
| 1729 https://bugs.webkit.org/show_bug.cgi?id=186042 |
| 1730 <rdar://problem/40604182> |
| 1731 |
| 1732 Reviewed by Tim Horton. |
| 1733 |
| 1734 Adds a new API test to check that the "significant area painting" render
ing milestone is dispatched when a |
| 1735 significant portion of the page has been painted before document load is
finished. |
| 1736 |
| 1737 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 1738 * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html:
Added. |
| 1739 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added. |
| 1740 (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]): |
| 1741 (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]): |
| 1742 (-[RenderingProgressHandler initWithHandler:]): |
| 1743 (-[RenderingProgressHandler _webView:renderingProgressDidChange:]): |
| 1744 (TEST): |
| 1745 |
| 1746 2018-05-29 Thibault Saunier <tsaunier@igalia.com> |
| 1747 |
| 1748 [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-
system" patch |
| 1749 https://bugs.webkit.org/show_bug.cgi?id=186040 |
| 1750 |
| 1751 The patch we merge contained a type and was merged in upstream GStreamer
fixing that |
| 1752 (s/avalaible/available/). |
| 1753 |
| 1754 Reviewed by Xabier Rodriguez-Calvar. |
| 1755 |
| 1756 * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-abo
ut-stream-encryption-s.patch: |
| 1757 |
| 1758 2018-05-28 Sihui Liu <sihui_liu@apple.com> |
| 1759 |
| 1760 Add an API test to check process privilege when using Cookie API |
| 1761 https://bugs.webkit.org/show_bug.cgi?id=185406 |
| 1762 |
| 1763 Reviewed by Geoffrey Garen. |
| 1764 |
| 1765 Add API test coverage. |
| 1766 |
| 1767 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 1768 (TEST): |
| 1769 |
| 1770 2018-05-28 Thibault Saunier <tsaunier@igalia.com> |
| 1771 |
| 1772 [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" N
EED_CONTEXT message. |
| 1773 https://bugs.webkit.org/show_bug.cgi?id=185948 |
| 1774 |
| 1775 Reviewed by Xabier Rodriguez-Calvar. |
| 1776 |
| 1777 When the patch introducing gst_protection_filter_systems_by_available_de
cryptors was merged, we changed sensibly its behaviour |
| 1778 concerning the way empty results is represented (now returning NULL inst
ead of an array of 1(NULL) element) and this change was not |
| 1779 properly taken into account in the qtdemux patch that uses it and got up
streamed. Those 3 new patches fixe that and change the |
| 1780 NEED_CONTEXT field names to clarify the meaning of "stream-encryption-sy
stems". |
| 1781 |
| 1782 * gstreamer/jhbuild.modules: |
| 1783 * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferr
ed-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f3
6c4660c583a60e93 |
| 1784 * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-st
ream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558
a3e |
| 1785 * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-abo
ut-stream-encryption-s.patch: Added. |
| 1786 |
| 1787 2018-05-27 Dan Bernstein <mitz@apple.com> |
| 1788 |
| 1789 Reverted the changes made for https://webkit.org/b/186016 |
| 1790 |
| 1791 They broke the USE(APPLE_INTERNAL_SDK) Sierra build. |
| 1792 |
| 1793 2018-05-27 Dan Bernstein <mitz@apple.com> |
| 1794 |
| 1795 [Cocoa] Avoid importing directly from subumbrella frameworks |
| 1796 https://bugs.webkit.org/show_bug.cgi?id=186016 |
| 1797 |
| 1798 Reviewed by Sam Weinig. |
| 1799 |
| 1800 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h inste
ad of a |
| 1801 LaunchServices header. |
| 1802 * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframe
work options from |
| 1803 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS. |
| 1804 * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h in
stead of ColorSync.h |
| 1805 when using SDKs earlier than 10.13. |
| 1806 * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework option
s from OTHER_CFLAGS |
| 1807 and OTHER_CPLUSPLUSFLAGS. |
| 1808 * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.
h instead of an |
| 1809 HIToolbox header. |
| 1810 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframewo
rk options from |
| 1811 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS. |
| 1812 * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h inste
ad of a |
| 1813 LaunchServices header. |
| 1814 |
| 1815 2018-05-27 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1816 |
| 1817 [Win][MiniBrowser] Add MainWindow class |
| 1818 https://bugs.webkit.org/show_bug.cgi?id=185814 |
| 1819 |
| 1820 Reviewed by Per Arne Vollan. |
| 1821 |
| 1822 This is a sub task of Bug 184770. Added a new class MainWindow to |
| 1823 represent the main window which will be shared among WK1 and WK2. |
| 1824 |
| 1825 This change is partial so that it's easy to review this patch. |
| 1826 I'll move more functions into MainWindow.cpp, and remove more |
| 1827 global variables in forthcoming patches. |
| 1828 |
| 1829 * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp. |
| 1830 * MiniBrowser/win/Common.cpp: Removed MainWindow related global |
| 1831 variables hMainWnd, hURLBarWnd, hBackButtonWnd and |
| 1832 hForwardButtonWnd. Added a new global variable gMainWindow. |
| 1833 (WndProc): Moved to MainWindow.cpp. |
| 1834 (resizeSubViews): Ditto. |
| 1835 (ToggleMenuFlag): Removed static to be called from MainWindow.cpp. |
| 1836 (ToggleMenuItem): Ditto. |
| 1837 (CustomUserAgent): Follow the global variables removal. |
| 1838 (DisplayAuthDialog): Ditto. |
| 1839 (loadURL): Ditto. |
| 1840 (WndProc): Renamed to MainWindow::WndProc. |
| 1841 * MiniBrowser/win/MainWindow.cpp: Added. |
| 1842 (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp
. |
| 1843 (MainWindow::init): Extracted MainWindow initialization code from wWinMa
in. |
| 1844 (MainWindow::resizeSubViews): Moved from Common.cpp. |
| 1845 (MainWindow::WndProc): Ditto. |
| 1846 * MiniBrowser/win/MainWindow.h: Added. |
| 1847 (MainWindow::hwnd): |
| 1848 (MainWindow::browserWindow): |
| 1849 * MiniBrowser/win/MiniBrowser.cpp: |
| 1850 (MiniBrowser::init): |
| 1851 (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDef
aultHTML. |
| 1852 (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews
. |
| 1853 * MiniBrowser/win/MiniBrowser.h: |
| 1854 * MiniBrowser/win/WinMain.cpp: |
| 1855 (wWinMain): Extracted MainWindow initialization code into MainWindow::in
it. |
| 1856 (MyRegisterClass): Moved to MainWindow.cpp. |
| 1857 |
| 1858 2018-05-27 Fujii Hironori <Hironori.Fujii@sony.com> |
| 1859 |
| 1860 [Win][MiniBrowser] Remove URL argument of MiniBrowser::init |
| 1861 https://bugs.webkit.org/show_bug.cgi?id=185969 |
| 1862 |
| 1863 Reviewed by Alex Christensen. |
| 1864 |
| 1865 MiniBrowser::init takes URL argument, but it's used only for |
| 1866 loading default HTML if URL is not given. |
| 1867 |
| 1868 - Add a new method MiniBrowser::loadHTMLString |
| 1869 - Remove loadHTMLString process from MiniBrowser::prepareViews |
| 1870 |
| 1871 * MiniBrowser/win/MiniBrowser.cpp: |
| 1872 (MiniBrowser::init): Removed `requestedURL` argument. |
| 1873 (MiniBrowser::prepareViews): Ditto. |
| 1874 (MiniBrowser::loadHTMLString): New. |
| 1875 (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead
of calling loadHTMLString. |
| 1876 * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLStr
ing. |
| 1877 * MiniBrowser/win/WinMain.cpp: |
| 1878 (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given. |
| 1879 |
| 1880 2018-05-27 David Kilzer <ddkilzer@apple.com> |
| 1881 |
| 1882 svn-apply fails when a patch has an empty file |
| 1883 <https://webkit.org/b/29684> |
| 1884 |
| 1885 Reviewed by Daniel Bates. |
| 1886 |
| 1887 Prior to this change, applying the following patches resulted in: |
| 1888 - svn: add empty file (failure) |
| 1889 - svn: delete empty file (failure) |
| 1890 - svn: rename empty file (failure) |
| 1891 - git: add empty file (false-positive success) |
| 1892 - git: delete empty file (success) |
| 1893 - git: rename empty file (failure) |
| 1894 |
| 1895 * Scripts/VCSUtils.pm: |
| 1896 (parseSvnDiffHeader): Handle the case when there is no patch |
| 1897 following the header. If the file exists and is empty, that |
| 1898 means it's a deletion. If the file does not exist, that means |
| 1899 it's an addition. Everything else is a fatal error. |
| 1900 * Scripts/svn-apply: |
| 1901 (patch): |
| 1902 - Only apply a patch for deletion if it has one or more text |
| 1903 chunks. |
| 1904 - Add a case to handle adding an empty file (an addition with no |
| 1905 text chunks), and verify the file doesn't exist yet. |
| 1906 - Any unhandled patch is a fatal error. |
| 1907 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: |
| 1908 Add tests for adding an empty file and deleting an empty file. |
| 1909 * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add. |
| 1910 Used by parseSvnDiffHeader.pl unit test for "add an empty file" |
| 1911 test case. |
| 1912 |
| 1913 2018-05-25 Aakash Jain <aakash_jain@apple.com> |
| 1914 |
| 1915 Display detailed error logs when a script fails in EWS |
| 1916 https://bugs.webkit.org/show_bug.cgi?id=175696 |
| 1917 <rdar://problem/34841885> |
| 1918 |
| 1919 Reviewed by Darin Adler. |
| 1920 |
| 1921 * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 cha
racters instead of default 500 characters. |
| 1922 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto. |
| 1923 * Scripts/webkitpy/tool/commands/download.py: Ditto. |
| 1924 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto. |
| 1925 * Scripts/webkitpy/tool/commands/queues.py: Ditto. |
| 1926 * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto. |
| 1927 |
| 1928 2018-05-25 Daniel Bates <dabates@apple.com> |
| 1929 |
| 1930 test-webkitpy messages logged using __main__ logger are not displayed |
| 1931 https://bugs.webkit.org/show_bug.cgi?id=185823 |
| 1932 |
| 1933 Rubber-stamped by Aakash Jain. |
| 1934 |
| 1935 Configure the logger for __main__ so that messages that are logged befor
e it parses its |
| 1936 command line arguments are printed to standard error. |
| 1937 |
| 1938 Currently test-webkitpy creates a named logger (__main__) for its loggin
g. However it does |
| 1939 not configure a stream to use for printing until after it parses its com
mand line arguments |
| 1940 via webkitpy.test.printer.Printer.configure(). Messages logged until the
n are never written |
| 1941 to the console. We explicitly configure the __main__ logger instead of c
alling webkitpy.test.printer.Printer.configure() |
| 1942 earlier because the latter both configures a stream and filters logged m
essages based on |
| 1943 the specified verbosity. Logged messaged from code in __main__ should no
t be subject to |
| 1944 such filtering. So, we explicitly configure the __main__ logger. |
| 1945 |
| 1946 * Scripts/webkitpy/test/main.py: |
| 1947 (main): |
| 1948 |
| 1949 2018-05-25 Saam Barati <sbarati@apple.com> |
| 1950 |
| 1951 Make JSC have a mini mode that kicks in when the JIT is disabled |
| 1952 https://bugs.webkit.org/show_bug.cgi?id=185931 |
| 1953 |
| 1954 Reviewed by Mark Lam. |
| 1955 |
| 1956 This renames a variable for clarity. |
| 1957 |
| 1958 * Scripts/run-testmem: |
| 1959 |
| 1960 2018-05-25 Alex Christensen <achristensen@webkit.org> |
| 1961 |
| 1962 URL::host should return a StringView to reduce allocations |
| 1963 https://bugs.webkit.org/show_bug.cgi?id=185986 |
| 1964 |
| 1965 Reviewed by Geoff Garen. |
| 1966 |
| 1967 * TestWebKitAPI/Tests/WebCore/URL.cpp: |
| 1968 (TestWebKitAPI::TEST_F): |
| 1969 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: |
| 1970 (TestWebKitAPI::eq): |
| 1971 * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: |
| 1972 (TestWebKitAPI::SSLKeyGeneratorTest::TearDown): |
| 1973 |
| 1974 2018-05-25 Ms2ger <Ms2ger@igalia.com> |
| 1975 |
| 1976 Minor improvements to wpt exporter. |
| 1977 https://bugs.webkit.org/show_bug.cgi?id=185978 |
| 1978 |
| 1979 Reviewed by Youenn Fablet. |
| 1980 |
| 1981 * Scripts/webkitpy/w3c/test_exporter.py: |
| 1982 (TestExporter.push_to_wpt_fork): Update call to create_upload_remote(). |
| 1983 (TestExporter.make_pull_request): Improve the description of the created
PR. |
| 1984 (TestExporter.create_upload_remote): Always update the remote to overrid
e any obsolete state. |
| 1985 |
| 1986 2018-05-25 Saam Barati <sbarati@apple.com> |
| 1987 |
| 1988 Have a memory test where we can validate JSCs mini memory mode |
| 1989 https://bugs.webkit.org/show_bug.cgi?id=185932 |
| 1990 |
| 1991 Reviewed by Mark Lam. |
| 1992 |
| 1993 This patch adds the run-testmem script. This runs the new testmem |
| 1994 CLI against the contents in the testmem benchmark. The contents of testm
em |
| 1995 contain tests from ARES-6, Sunspider, Octane, and JetStream. |
| 1996 ········ |
| 1997 One iteration of the benchmark comprises of running each testmem test fo
r |
| 1998 a certain number of iterations. We collect the peak memory usage, the me
mory |
| 1999 usage after running all the iterations, and the time it takes to run all
the |
| 2000 iterations. We then run the entire benchmark 3 times over. For each test
, we |
| 2001 compute the arithmetic mean over each iteration for time, peak memory, a
nd |
| 2002 end memory. The benchmark then computes a time score and memory score. |
| 2003 ········ |
| 2004 peak memory score = geomean({peak memory of each individual test}) |
| 2005 end memory score = geomean({end memory of each individual test}) |
| 2006 memory score = geomean({peak memory score, end memory score}) |
| 2007 time score = geomean({time score of each individual test}) |
| 2008 ········ |
| 2009 We want the memory score to weigh improvements to peak memory usage and |
| 2010 memory usage at the end equally. |
| 2011 ········ |
| 2012 We plan to tune this benchmark in JSC's mini mode by improving the memor
y |
| 2013 score while ensuring the time score is not more than 10-15% regressed. |
| 2014 |
| 2015 * Scripts/run-testmem: Added. |
| 2016 |
| 2017 2018-05-25 Sihui Liu <sihui_liu@apple.com> |
| 2018 |
| 2019 [WKHTTPCookieStore getAllCookies] returns inconsistent creation time |
| 2020 https://bugs.webkit.org/show_bug.cgi?id=185041 |
| 2021 <rdar://problem/34684214> |
| 2022 |
| 2023 Reviewed by Geoffrey Garen. |
| 2024 |
| 2025 Add API test coverage. |
| 2026 |
| 2027 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 2028 (TEST): |
| 2029 |
| 2030 2018-05-24 Chris Dumez <cdumez@apple.com> |
| 2031 |
| 2032 Reduce copying of FontCascadeDescription objects by moving them around |
| 2033 https://bugs.webkit.org/show_bug.cgi?id=185963 |
| 2034 |
| 2035 Reviewed by Simon Fraser. |
| 2036 |
| 2037 Reduce copying of FontCascadeDescription objects by moving them around w
hen possible. |
| 2038 |
| 2039 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: |
| 2040 (TestWebKitAPI::TEST_F): |
| 2041 |
| 2042 2018-05-24 Carlos Garcia Campos <cgarcia@igalia.com> |
| 2043 |
| 2044 WebDriver: implement maximize, minimize and fullscreen window commands |
| 2045 https://bugs.webkit.org/show_bug.cgi?id=180398 |
| 2046 |
| 2047 Reviewed by Brian Burg. |
| 2048 |
| 2049 * Scripts/webkitpy/port/xvfbdriver.py: |
| 2050 (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variabl
e when running under Xvfb. |
| 2051 |
| 2052 2018-05-24 Xabier Rodriguez Calvar <calvaris@igalia.com> |
| 2053 |
| 2054 [GStreamer] Save some time disabling some compile options in the depende
ncies |
| 2055 https://bugs.webkit.org/show_bug.cgi?id=185909 |
| 2056 |
| 2057 Reviewed by Philippe Normand. |
| 2058 |
| 2059 * gstreamer/jhbuild.modules: Added --disable-tests to gstreamer |
| 2060 and --disable-examples --disable-gtk-doc to gstreamer-vaapi. |
| 2061 |
| 2062 2018-05-23 Roy Reapor <rreapor@apple.com> |
| 2063 |
| 2064 Use Helvetica on build.webkit.org webpages |
| 2065 https://bugs.webkit.org/show_bug.cgi?id=185894 |
| 2066 |
| 2067 Reviewed by Aakash Jain. |
| 2068 |
| 2069 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/gar
den-o-matic.html: |
| 2070 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/sty
les/common.css: |
| 2071 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/sum
mary-mock.html: |
| 2072 |
| 2073 2018-05-23 Aakash Jain <aakash_jain@apple.com> |
| 2074 |
| 2075 Add Buildbot configuration for Opensource EWS |
| 2076 https://bugs.webkit.org/show_bug.cgi?id=185484 |
| 2077 |
| 2078 Rubber-stamped by Alexey Proskuryakov. |
| 2079 |
| 2080 * BuildSlaveSupport/ews-build/config.json: Added, config file. |
| 2081 * BuildSlaveSupport/ews-build/factories.py: Added, basic template for fa
ctories. |
| 2082 * BuildSlaveSupport/ews-build/loadConfig.py: Added. |
| 2083 (loadBuilderConfig): Loads the configuration. |
| 2084 (checkValidWorker): Checks if the worker is valid. |
| 2085 (checkValidBuilder): Checks if the builder is valid. |
| 2086 (checkWorkersAndBuildersForConsistency): Check if workers and builders a
re consistent. |
| 2087 (checkWorkersAndBuildersForConsistency._find_worker_with_name): |
| 2088 (getBlackListedTags): Returns a list of keywords which should not be lis
ted as tags. |
| 2089 (getValidTags): Returns a list of valid tags. |
| 2090 (getTagsForBuilder): Return a list of tags for given builder. |
| 2091 * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loa
dConfig.py. |
| 2092 * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot. |
| 2093 |
| 2094 2018-05-23 Michael Catanzaro <mcatanzaro@igalia.com> |
| 2095 |
| 2096 [GTK] Silence GCC 8 warnings |
| 2097 https://bugs.webkit.org/show_bug.cgi?id=185556 |
| 2098 |
| 2099 Reviewed by Žan Doberšek. |
| 2100 |
| 2101 GCC is complaining about this strncpy. It's guaranteed to be safe, becau
se the length of |
| 2102 source and destination are always identical. But switching to snprintf a
voids the warning. |
| 2103 |
| 2104 * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp: |
| 2105 (FormValue::NPP_GetValue): |
| 2106 |
| 2107 2018-05-23 Ryan Haddad <ryanhaddad@apple.com> |
| 2108 |
| 2109 Unreviewed, rolling out r232112. |
| 2110 |
| 2111 The tests added with this change are failing on the bots. |
| 2112 |
| 2113 Reverted changeset: |
| 2114 |
| 2115 "test262/Runner.pm: add unit tests" |
| 2116 https://bugs.webkit.org/show_bug.cgi?id=185783 |
| 2117 https://trac.webkit.org/changeset/232112 |
| 2118 |
| 2119 2018-05-23 Valerie R Young <valerie@bocoup.com> |
| 2120 |
| 2121 test262/Runner.pm: add unit tests |
| 2122 https://bugs.webkit.org/show_bug.cgi?id=185783 |
| 2123 |
| 2124 Reviewed by Aakash Jain. |
| 2125 |
| 2126 Add unit tests to be run by test-webkitperl |
| 2127 |
| 2128 * Scripts/test262/Runner.pm: |
| 2129 (main): |
| 2130 - If harness files cannot be found in a custom, supplies test262 path, |
| 2131 then sure the webkit test262 harness files. |
| 2132 - Lazily create the test262-results directory. |
| 2133 - If an expectation file is supplied via command line, save to the |
| 2134 supplied location instead of the detault webkit location. |
| 2135 (compileTest): |
| 2136 (processResult): |
| 2137 (getHarness): |
| 2138 * Scripts/webkitperl/test262_unittest/README: Added. |
| 2139 * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml
: Added. |
| 2140 * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added. |
| 2141 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing-with-new-error.js: Added. |
| 2142 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-failing.js: Added. |
| 2143 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now
-passing.js: Added. |
| 2144 (f): |
| 2145 * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now
-failing.js: Added. |
| 2146 * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added. |
| 2147 * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added. |
| 2148 (f): |
| 2149 * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added. |
| 2150 |
| 2151 2018-05-22 Roy Reapor <rreapor@apple.com> |
| 2152 |
| 2153 Test infrastructure websites should use jQuery and jQuery UI hosted on w
ebkit.org |
| 2154 https://bugs.webkit.org/show_bug.cgi?id=185788 |
| 2155 |
| 2156 Reviewed by Aakash Jain. |
| 2157 |
| 2158 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/gar
den-o-matic.html: |
| 2159 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ind
ex.html: |
| 2160 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/reb
aseline.html: |
| 2161 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run
-unittests.html: |
| 2162 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/sum
mary-mock.html: |
| 2163 * TestResultServer/static-dashboards/run-embedded-unittests.html: |
| 2164 * TestResultServer/static-dashboards/run-unittests.html: |
| 2165 |
| 2166 2018-05-22 Sihui Liu <sihui_liu@apple.com> |
| 2167 |
| 2168 [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashi
ng with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJava
ScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called' |
| 2169 https://bugs.webkit.org/show_bug.cgi?id=185831 |
| 2170 |
| 2171 Reviewed by Chris Dumez. |
| 2172 |
| 2173 Updated the test to prevent crash after assertion fails. |
| 2174 |
| 2175 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 2176 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiated
ByFrame:completionHandler:]): |
| 2177 |
| 2178 2018-05-22 Chris Dumez <cdumez@apple.com> |
| 2179 |
| 2180 Regression(AsyncPolicyDelegates): Box.app login Window is blank |
| 2181 https://bugs.webkit.org/show_bug.cgi?id=185832 |
| 2182 <rdar://problem/40307871> |
| 2183 |
| 2184 Reviewed by Geoffrey Garen. |
| 2185 |
| 2186 Add API test coverage. |
| 2187 |
| 2188 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 2189 * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm: |
| 2190 * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added. |
| 2191 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAct
ion:request:frame:decisionListener:]): |
| 2192 (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:requ
est:frame:decisionListener:]): |
| 2193 (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): |
| 2194 (TestWebKitAPI::TEST): |
| 2195 * TestWebKitAPI/cocoa/TestWKWebView.mm: |
| 2196 (-[WKWebView _isBackground]): |
| 2197 |
| 2198 2018-05-22 Sihui Liu <sihui_liu@apple.com> |
| 2199 |
| 2200 Conversion between SecurityOriginData and DatabaseIdentifier is asymmetr
ic when port is null |
| 2201 https://bugs.webkit.org/show_bug.cgi?id=185715 |
| 2202 |
| 2203 Reviewed by Geoffrey Garen. |
| 2204 |
| 2205 Add API test coverage. |
| 2206 |
| 2207 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 2208 * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added. |
| 2209 (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:ini
tiatedByFrame:completionHandler:]): |
| 2210 (TEST): |
| 2211 |
| 2212 2018-05-22 Sihui Liu <sihui_liu@apple.com> |
| 2213 |
| 2214 Unreviewed, added myself as a WebKit committer. |
| 2215 |
| 2216 * Scripts/webkitpy/common/config/contributors.json: |
| 2217 |
| 2218 2018-05-22 Ryan Haddad <ryanhaddad@apple.com> |
| 2219 |
| 2220 Unreviewed, rolling out r232052. |
| 2221 |
| 2222 Breaks internal builds. |
| 2223 |
| 2224 Reverted changeset: |
| 2225 |
| 2226 "Use more C++17" |
| 2227 https://bugs.webkit.org/show_bug.cgi?id=185176 |
| 2228 https://trac.webkit.org/changeset/232052 |
| 2229 |
| 2230 2018-05-22 Thibault Saunier <tsaunier@igalia.com> |
| 2231 |
| 2232 [GStreamer] Update to GStreamer 1.14.1 in jhbuild |
| 2233 https://bugs.webkit.org/show_bug.cgi?id=185689 |
| 2234 |
| 2235 Reviewed by Philippe Normand. |
| 2236 |
| 2237 And update the patches, removing the ones that have been merged upstream
. |
| 2238 |
| 2239 * gstreamer/jhbuild.modules: |
| 2240 * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretendin
g-to-decode-gifs.patch: Removed. |
| 2241 * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-con
text-query-support.patch: Removed. Not needed anymore and closed as OBSELETE ups
tream. |
| 2242 * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-pref
erred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-00
06-qtdemux-add-context-for-a-preferred-protection.patch |
| 2243 This patch has now been merged in GStreamer master and will be there in
GStreamer 1.16. |
| 2244 * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-with
out-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-g
ood-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch. |
| 2245 This patch has now been merged in GStreamer master and will be there in
GStreamer 1.16. |
| 2246 * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-c
ontains-one-sample.patch: Removed. |
| 2247 * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-s
ystem-ids.patch: Removed. |
| 2248 |
| 2249 2018-05-21 Yusuke Suzuki <utatane.tea@gmail.com> |
| 2250 |
| 2251 Use more C++17 |
| 2252 https://bugs.webkit.org/show_bug.cgi?id=185176 |
| 2253 |
| 2254 Reviewed by JF Bastien. |
| 2255 |
| 2256 * DumpRenderTree/mac/Configurations/Base.xcconfig: |
| 2257 * ImageDiff/cg/Configurations/Base.xcconfig: |
| 2258 * MiniBrowser/Configurations/Base.xcconfig: |
| 2259 * MobileMiniBrowser/Configurations/Base.xcconfig: |
| 2260 * TestWebKitAPI/Configurations/Base.xcconfig: |
| 2261 * WebKitTestRunner/Configurations/Base.xcconfig: |
| 2262 |
| 2263 2018-05-21 Fujii Hironori <Hironori.Fujii@sony.com> |
| 2264 |
| 2265 [WinCairo] Enable WebKit build by default |
| 2266 https://bugs.webkit.org/show_bug.cgi?id=185141 |
| 2267 |
| 2268 Reviewed by Per Arne Vollan. |
| 2269 |
| 2270 TestWTF, TestWebCore and TestWebKitLegacy need a dependency to |
| 2271 WebKitForwardingHeaders because config.h includes a header of WK2. |
| 2272 |
| 2273 * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and T
estWebKitLegacyLib depend on WebKitForwardingHeaders. |
| 2274 * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WI
N_CAIRO_WEBKIT. |
| 2275 |
| 2276 2018-05-21 Jer Noble <jer.noble@apple.com> |
| 2277 |
| 2278 Complete fix for enabling modern EME by default |
| 2279 https://bugs.webkit.org/show_bug.cgi?id=185770 |
| 2280 <rdar://problem/40368220> |
| 2281 |
| 2282 Reviewed by Eric Carlson. |
| 2283 |
| 2284 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: |
| 2285 |
| 2286 2018-05-18 Christopher Reid <chris.reid@sony.com> |
| 2287 |
| 2288 Unreviewed, add myself as a WebKit committer. |
| 2289 |
| 2290 * Scripts/webkitpy/common/config/contributors.json: |
| 2291 |
| 2292 2018-05-21 Carlos Garcia Campos <cgarcia@igalia.com> |
| 2293 |
| 2294 Unreviewed, rolling out r222967. |
| 2295 |
| 2296 It's not ready yet |
| 2297 |
| 2298 Reverted changeset: |
| 2299 |
| 2300 "[GTK][WPE] Add API to configure and enable resource load |
| 2301 statistics" |
| 2302 https://bugs.webkit.org/show_bug.cgi?id=177943 |
| 2303 https://trac.webkit.org/changeset/222967 |
| 2304 |
| 2305 2018-05-20 Carlos Garcia Campos <cgarcia@igalia.com> |
| 2306 |
| 2307 [GTK] MiniBrowser crashes when loading twice quickly |
| 2308 https://bugs.webkit.org/show_bug.cgi?id=185763 |
| 2309 |
| 2310 Reviewed by Michael Catanzaro. |
| 2311 |
| 2312 This is very difficult to reproduce manually, but it happens when runnin
g WebDriver tests where loads are very |
| 2313 fast and multiple loads are done quickly. The problem is that we use an
idle to reset the progress bar, but we |
| 2314 don't reset it when a new load starts. We always reset the last idle on
destroy, but if there's another one |
| 2315 leaked, it will crash when scheduled if the window has already been dest
royed. |
| 2316 |
| 2317 * MiniBrowser/gtk/BrowserWindow.c: |
| 2318 (webViewLoadProgressChanged): Stop any pending reset task when progress
!= 1. |
| 2319 |
| 2320 2018-05-19 Sihui Liu <sihui_liu@apple.com> |
| 2321 |
| 2322 Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect ord
er of cookies |
| 2323 https://bugs.webkit.org/show_bug.cgi?id=185624 |
| 2324 <rdar://problem/39111626> |
| 2325 |
| 2326 Reviewed by Chris Dumez. |
| 2327 |
| 2328 Modified expectation to make test more robust as cookies can be returned
in different orders. |
| 2329 |
| 2330 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 2331 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiated
ByFrame:completionHandler:]): |
| 2332 (TEST): |
| 2333 |
| 2334 2018-05-18 Commit Queue <commit-queue@webkit.org> |
| 2335 |
| 2336 Unreviewed, rolling out r231982. |
| 2337 https://bugs.webkit.org/show_bug.cgi?id=185793 |
| 2338 |
| 2339 Caused layout test failures (Requested by realdawei on |
| 2340 #webkit). |
| 2341 |
| 2342 Reverted changeset: |
| 2343 |
| 2344 "Complete fix for enabling modern EME by default" |
| 2345 https://bugs.webkit.org/show_bug.cgi?id=185770 |
| 2346 https://trac.webkit.org/changeset/231982 |
| 2347 |
| 2348 2018-05-18 Eric Carlson <eric.carlson@apple.com> |
| 2349 |
| 2350 Handle failure to extend sandbox gracefully |
| 2351 https://bugs.webkit.org/show_bug.cgi?id=185779 |
| 2352 <rdar://problem/40316349> |
| 2353 |
| 2354 Unreviewed, fix test results. |
| 2355 |
| 2356 * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: |
| 2357 (TEST_F): |
| 2358 |
| 2359 2018-05-18 Jer Noble <jer.noble@apple.com> |
| 2360 |
| 2361 Complete fix for enabling modern EME by default |
| 2362 https://bugs.webkit.org/show_bug.cgi?id=185770 |
| 2363 <rdar://problem/40368220> |
| 2364 |
| 2365 Reviewed by Eric Carlson. |
| 2366 |
| 2367 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: |
| 2368 |
| 2369 2018-05-18 Eric Carlson <eric.carlson@apple.com> |
| 2370 |
| 2371 Handle failure to extend sandbox gracefully |
| 2372 https://bugs.webkit.org/show_bug.cgi?id=185779 |
| 2373 <rdar://problem/40316349> |
| 2374 |
| 2375 Reviewed by Brent Fulgham. |
| 2376 |
| 2377 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 2378 * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Add
ed. |
| 2379 (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveS
criptMessage:]): |
| 2380 (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizatio
nForDevices:url:mainFrameURL:decisionHandler:]): |
| 2381 (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForU
RL:mainFrameURL:frameIdentifier:decisionHandler:]): |
| 2382 (MediaCaptureSimulateFailedSandbox::SetUp): |
| 2383 (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage): |
| 2384 (TEST_F): |
| 2385 * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html: |
| 2386 |
| 2387 2018-05-18 Daniel Bates <dabates@apple.com> |
| 2388 |
| 2389 "debug-safari --ios-simulator" creates lldb target to launch Mac Safari |
| 2390 https://bugs.webkit.org/show_bug.cgi?id=185774 |
| 2391 |
| 2392 Reviewed by Andy Estes. |
| 2393 |
| 2394 For now, the script debug-safari is not supported for WebKit for iOS. To |
| 2395 fix this we differentiate between the Apple Mac port and Apple embedded |
| 2396 ports. |
| 2397 |
| 2398 * Scripts/webkitdirs.pm: |
| 2399 (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit(). |
| 2400 (isAppleMacWebKit): Added. |
| 2401 (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbedde
dWebKit(). |
| 2402 (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit(). |
| 2403 (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit(). |
| 2404 (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit(). |
| 2405 (runSafari): Ditto. |
| 2406 (runMiniBrowser): Ditto. |
| 2407 (debugMiniBrowser): Ditto. |
| 2408 (runWebKitTestRunner): Ditto. |
| 2409 (debugWebKitTestRunner): Ditto. |
| 2410 |
| 2411 2018-05-18 Antoine Quint <graouts@apple.com> |
| 2412 |
| 2413 [Web Animations] Turn Web Animations with CSS integration on for test ru
nners |
| 2414 https://bugs.webkit.org/show_bug.cgi?id=184819 |
| 2415 <rdar://problem/39597337> |
| 2416 |
| 2417 Unreviewed. Rolling out the patch for this bug, it caused some flaky tim
eouts for animation suspension tests. |
| 2418 |
| 2419 * DumpRenderTree/TestOptions.cpp: |
| 2420 (TestOptions::TestOptions): |
| 2421 * DumpRenderTree/TestOptions.h: |
| 2422 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 2423 (runTest): |
| 2424 (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted
. |
| 2425 * WebKitTestRunner/TestController.cpp: |
| 2426 (WTR::TestController::resetPreferencesToConsistentValues): |
| 2427 (WTR::updateTestOptionsFromTestHeader): |
| 2428 * WebKitTestRunner/TestOptions.cpp: |
| 2429 (WTR::TestOptions::TestOptions): |
| 2430 (WTR::isLegacyAnimationEngineTestPath): Deleted. |
| 2431 * WebKitTestRunner/TestOptions.h: |
| 2432 |
| 2433 2018-05-18 Fujii Hironori <Hironori.Fujii@sony.com> |
| 2434 |
| 2435 [Win][MiniBrowser] Create MainWindow even in transparent mode |
| 2436 https://bugs.webkit.org/show_bug.cgi?id=185597 |
| 2437 |
| 2438 Reviewed by Per Arne Vollan. |
| 2439 |
| 2440 The current implementations doesn't create the MainWindow in |
| 2441 transparent mode. The screenshot is in Bug 58300. |
| 2442 |
| 2443 There were three problems: |
| 2444 - Can't control the WebView. ie. going backward and forward. |
| 2445 - Can't quit the program. |
| 2446 - It makes implementation complicated. |
| 2447 |
| 2448 * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views |
| 2449 even in the transparent mode. |
| 2450 * MiniBrowser/win/WinMain.cpp: |
| 2451 (wWinMain): Create the main window even in the transparent mode. |
| 2452 |
| 2453 2018-05-18 Antoine Quint <graouts@apple.com> |
| 2454 |
| 2455 [Web Animations] Turn Web Animations with CSS integration on for test ru
nners |
| 2456 https://bugs.webkit.org/show_bug.cgi?id=184819 |
| 2457 <rdar://problem/39597337> |
| 2458 |
| 2459 Reviewed by Jon Lee. |
| 2460 |
| 2461 Make the test runners turn both the main Web Animations flag and the Web
Animations CSS |
| 2462 integration flag on. |
| 2463 |
| 2464 We also remove the ability to toggle the Web Animations CSS integration
flag using an HTML |
| 2465 comment directly at the top of the file since test runners now set the f
lag on by default |
| 2466 and a dedicated directory exists for tests that need to run with this fl
ag off. |
| 2467 |
| 2468 * DumpRenderTree/TestOptions.cpp: |
| 2469 (TestOptions::TestOptions): |
| 2470 * DumpRenderTree/TestOptions.h: |
| 2471 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 2472 (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): |
| 2473 (runTest): |
| 2474 * WebKitTestRunner/TestController.cpp: |
| 2475 (WTR::TestController::resetPreferencesToConsistentValues): |
| 2476 (WTR::updateTestOptionsFromTestHeader): |
| 2477 * WebKitTestRunner/TestOptions.cpp: |
| 2478 (WTR::isLegacyAnimationEngineTestPath): |
| 2479 (WTR::TestOptions::TestOptions): |
| 2480 * WebKitTestRunner/TestOptions.h: |
| 2481 |
| 2482 2018-05-17 Nan Wang <n_wang@apple.com> |
| 2483 |
| 2484 AX: [macOS] Expose the primary screen height through AX API |
| 2485 https://bugs.webkit.org/show_bug.cgi?id=185742 |
| 2486 |
| 2487 Reviewed by Chris Fleizach. |
| 2488 |
| 2489 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: |
| 2490 (attributesOfElement): |
| 2491 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: |
| 2492 (WTR::attributesOfElement): |
| 2493 |
| 2494 2018-05-17 Commit Queue <commit-queue@webkit.org> |
| 2495 |
| 2496 Unreviewed, rolling out r231912. |
| 2497 https://bugs.webkit.org/show_bug.cgi?id=185750 |
| 2498 |
| 2499 It is prompting the user when there is no WPT changes |
| 2500 (Requested by bmac on #webkit). |
| 2501 |
| 2502 Reverted changeset: |
| 2503 |
| 2504 "Export changes to web-platform-test as part of the webkit- |
| 2505 patch upload workflow" |
| 2506 https://bugs.webkit.org/show_bug.cgi?id=184914 |
| 2507 https://trac.webkit.org/changeset/231912 |
| 2508 |
| 2509 2018-05-17 Valerie R Young <valerie@bocoup.com> |
| 2510 |
| 2511 test262/Runner.pm: expand $INC to find webkitdirs.pm |
| 2512 https://bugs.webkit.org/show_bug.cgi?id=185739 |
| 2513 |
| 2514 Reviewed by Michael Saboff. |
| 2515 |
| 2516 * Scripts/test262/Runner.pm: |
| 2517 (getBuildPath): |
| 2518 |
| 2519 2018-05-17 Carlos Alberto Lopez Perez <clopez@igalia.com> |
| 2520 |
| 2521 [WPE] Implement and enable FULLSCREEN_API |
| 2522 https://bugs.webkit.org/show_bug.cgi?id=185676 |
| 2523 |
| 2524 Reviewed by Žan Doberšek. |
| 2525 |
| 2526 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: |
| 2527 (testWebViewFullScreen): |
| 2528 |
| 2529 2018-05-17 Brendan McLoughlin <brendan@bocoup.com> |
| 2530 |
| 2531 Export changes to web-platform-test as part of the webkit-patch upload w
orkflow |
| 2532 https://bugs.webkit.org/show_bug.cgi?id=184914 |
| 2533 |
| 2534 Reviewed by Youenn Fablet. |
| 2535 |
| 2536 * Scripts/webkitpy/tool/commands/upload.py: |
| 2537 (Upload): |
| 2538 (CreateBug.execute): |
| 2539 (WPTChangeExport): |
| 2540 * Scripts/webkitpy/tool/steps/__init__.py: |
| 2541 * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added. |
| 2542 (WPTChangeExport): |
| 2543 (WPTChangeExport.options): |
| 2544 (WPTChangeExport.run): |
| 2545 * Scripts/webkitpy/w3c/common.py: |
| 2546 * Scripts/webkitpy/w3c/test_exporter.py: |
| 2547 (WebPlatformTestExporter): |
| 2548 (WebPlatformTestExporter.__init__): |
| 2549 (WebPlatformTestExporter.username): |
| 2550 (WebPlatformTestExporter.token): |
| 2551 (WebPlatformTestExporter._github): |
| 2552 (WebPlatformTestExporter._wpt_fork_branch_github_url): |
| 2553 (WebPlatformTestExporter._wpt_fork_remote): |
| 2554 (WebPlatformTestExporter._wpt_fork_push_url): |
| 2555 (WebPlatformTestExporter._git): |
| 2556 (WebPlatformTestExporter._branch_name): |
| 2557 (WebPlatformTestExporter._public_branch_name): |
| 2558 (WebPlatformTestExporter.has_wpt_changes): |
| 2559 (WebPlatformTestExporter._create_patch): |
| 2560 (WebPlatformTestExporter.create_git_patch): |
| 2561 (WebPlatformTestExporter._prompt_for_token): |
| 2562 (WebPlatformTestExporter._prompt_for_username): |
| 2563 (WebPlatformTestExporter._ensure_username_and_token): |
| 2564 (WebPlatformTestExporter._validate_and_save_token): |
| 2565 (WebPlatformTestExporter.push_to_wpt_fork): |
| 2566 (WebPlatformTestExporter.make_pull_request): |
| 2567 (WebPlatformTestExporter.delete_local_branch): |
| 2568 (parse_args): |
| 2569 (TestExporter): Deleted. |
| 2570 (TestExporter.__init__): Deleted. |
| 2571 (TestExporter._ensure_wpt_repository): Deleted. |
| 2572 (TestExporter._fetch_wpt_repository): Deleted. |
| 2573 (TestExporter._ensure_new_branch_name): Deleted. |
| 2574 (TestExporter.download_and_commit_patch): Deleted. |
| 2575 (TestExporter.clean): Deleted. |
| 2576 (TestExporter.create_branch_with_patch): Deleted. |
| 2577 (TestExporter.push_to_wpt_fork): Deleted. |
| 2578 (TestExporter.make_pull_request): Deleted. |
| 2579 (TestExporter.create_wpt_pull_request): Deleted. |
| 2580 (TestExporter.delete_local_branch): Deleted. |
| 2581 (TestExporter.create_git_patch): Deleted. |
| 2582 (TestExporter.create_upload_remote_if_needed): Deleted. |
| 2583 (TestExporter.do_export): Deleted. |
| 2584 * Scripts/webkitpy/w3c/test_exporter_unittest.py: |
| 2585 (TestExporterTest.test_export): |
| 2586 (TestExporterTest.test_export_with_specific_branch): |
| 2587 (TestExporterTest): |
| 2588 (TestExporterTest.test_export_interactive_mode): |
| 2589 (TestExporterTest.test_export_invalid_token): |
| 2590 (TestExporterTest.test_export_wrong_token): |
| 2591 |
| 2592 2018-05-17 Valerie R Young <valerie@bocoup.com> |
| 2593 |
| 2594 test262/Runner.pm: look for jsc in path if cannot call webkit-build-dire
ctory |
| 2595 https://bugs.webkit.org/show_bug.cgi?id=185650 |
| 2596 |
| 2597 Reviewed by Michael Saboff. |
| 2598 |
| 2599 First, use jsc from CLI arg, then try to use webkit-build-directory, |
| 2600 if that doesn't work, look for jsc in the $PATH |
| 2601 |
| 2602 * Scripts/test262/Runner.pm: |
| 2603 (processCLI): |
| 2604 (getBuildPath): |
| 2605 (runTest): |
| 2606 |
| 2607 2018-05-16 Leo Balter <leonardo.balter@gmail.com> |
| 2608 |
| 2609 Test262-Runner: Adds a --timeout option |
| 2610 https://bugs.webkit.org/show_bug.cgi?id=185696 |
| 2611 |
| 2612 Reviewed by Michael Saboff. |
| 2613 |
| 2614 The timeout option is used to set a timeout execution in ms for each tes
t run in JSC. |
| 2615 The passed value - if defined - will be used as the value for the JSC --
watchdog arg. |
| 2616 * Scripts/test262/Runner.pm: |
| 2617 (processCLI): |
| 2618 (runTest): |
| 2619 |
| 2620 2018-05-16 Leo Balter <leonardo.balter@gmail.com> |
| 2621 |
| 2622 Test262-Runner: Set timer for each test run |
| 2623 https://bugs.webkit.org/show_bug.cgi?id=185692 |
| 2624 |
| 2625 Reviewed by Michael Saboff. |
| 2626 |
| 2627 Sets a high resolution timer for each execution call of JSC, reporting |
| 2628 the time in the results report to allow identifying slow tests. |
| 2629 * Scripts/test262/Runner.pm: |
| 2630 (main): |
| 2631 (processFile): |
| 2632 (runTest): |
| 2633 (processResult): |
| 2634 |
| 2635 2018-05-16 Andy VanWagoner <andy@vanwagoner.family> |
| 2636 |
| 2637 Add support for Intl NumberFormat formatToParts |
| 2638 https://bugs.webkit.org/show_bug.cgi?id=185375 |
| 2639 |
| 2640 Reviewed by Yusuke Suzuki. |
| 2641 |
| 2642 Add flag for NumberFormat formatToParts. |
| 2643 |
| 2644 * Scripts/webkitperl/FeatureList.pm: |
| 2645 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: |
| 2646 |
| 2647 2018-05-14 Yusuke Suzuki <utatane.tea@gmail.com> |
| 2648 |
| 2649 [Win] Use C++17 in MSVC |
| 2650 https://bugs.webkit.org/show_bug.cgi?id=185232 |
| 2651 |
| 2652 Reviewed by Alex Christensen. |
| 2653 |
| 2654 Do not use `using namespace std;`. In C++17, we have std::byte. This "by
te" |
| 2655 conflicts with ::byte defined in Windows' header. |
| 2656 |
| 2657 * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: |
| 2658 (WindowedPluginTest::WindowedPluginTest): |
| 2659 * DumpRenderTree/win/AccessibilityControllerWin.cpp: |
| 2660 (logEventProc): |
| 2661 (stringEvent): |
| 2662 (AccessibilityController::winNotificationReceived): |
| 2663 * DumpRenderTree/win/TextInputController.cpp: |
| 2664 (markedRangeCallback): |
| 2665 (firstRectForCharacterRangeCallback): |
| 2666 (selectedRangeCallback): |
| 2667 * DumpRenderTree/win/TextInputController.h: |
| 2668 * DumpRenderTree/win/TextInputControllerWin.cpp: |
| 2669 (TextInputController::markedRange): |
| 2670 (TextInputController::firstRectForCharacterRange): |
| 2671 (TextInputController::selectedRange): |
| 2672 |
| 2673 2018-05-16 Sihui Liu <sihui_liu@apple.com> |
| 2674 |
| 2675 Session cookies aren't reliably set when using default WKWebSiteDataStor
e |
| 2676 https://bugs.webkit.org/show_bug.cgi?id=185624 |
| 2677 <rdar://problem/39111626> |
| 2678 |
| 2679 Reviewed by Geoffrey Garen. |
| 2680 |
| 2681 Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool. |
| 2682 |
| 2683 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 2684 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiated
ByFrame:completionHandler:]): |
| 2685 (TEST): |
| 2686 |
| 2687 2018-05-16 Valerie R Young <valerie@bocoup.com> |
| 2688 |
| 2689 test262/Runner.pm: save to supplied expectation file if supplied |
| 2690 https://bugs.webkit.org/show_bug.cgi?id=185660 |
| 2691 |
| 2692 Reviewed by Michael Saboff. |
| 2693 |
| 2694 * Scripts/test262/Runner.pm: |
| 2695 (processCLI): |
| 2696 (main): |
| 2697 |
| 2698 2018-05-15 Ryan Haddad <ryanhaddad@apple.com> |
| 2699 |
| 2700 Unreviewed, rolling out r231763. |
| 2701 |
| 2702 The test added with this change is failing an assertion. |
| 2703 |
| 2704 Reverted changeset: |
| 2705 |
| 2706 "NSEvent event trackers don't work from WebKitTestRunner" |
| 2707 https://bugs.webkit.org/show_bug.cgi?id=185383 |
| 2708 https://trac.webkit.org/changeset/231763 |
| 2709 |
| 2710 2018-05-15 David Kilzer <ddkilzer@apple.com> |
| 2711 |
| 2712 TestWebKitAPI: Fix warnings found by new clang compiler |
| 2713 <https://webkit.org/b/185631> |
| 2714 |
| 2715 Reviewed by Michael Catanzaro. |
| 2716 |
| 2717 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: |
| 2718 (TestWebKitAPI::TEST): |
| 2719 * TestWebKitAPI/Tests/WTF/Poisoned.cpp: |
| 2720 (TestWebKitAPI::TEST): |
| 2721 * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: |
| 2722 (TestWebKitAPI::TEST): |
| 2723 * TestWebKitAPI/Tests/WTF/RefPtr.cpp: |
| 2724 (TestWebKitAPI::TEST): |
| 2725 - Add #pragma statements to ignore the new |
| 2726 -Wself-assign-overloaded warning and to ignore |
| 2727 this as an unknown warning on older clang versions. We want |
| 2728 to keep these self assigments as this code is designed to test |
| 2729 that use case. |
| 2730 |
| 2731 * TestWebKitAPI/Tests/WebKit/FindMatches.mm: |
| 2732 (TestWebKitAPI::didFindStringMatches): |
| 2733 - Replace the "rect = rect;" statement that was used to avoid an |
| 2734 unused variable warning with two expectations. |
| 2735 |
| 2736 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 2737 (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:])
: |
| 2738 - Switch from -integerValue to -unsignedIntegerValue when |
| 2739 comparing against _WKRectEdgeAll since it's an enum declared |
| 2740 as an NSUInteger. |
| 2741 |
| 2742 2018-05-15 Michael Catanzaro <mcatanzaro@igalia.com> |
| 2743 |
| 2744 Unreviewed, rolling out r230749 |
| 2745 |
| 2746 This did not work as desired. |
| 2747 |
| 2748 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: |
| 2749 (TestWebKitAPI::TEST): |
| 2750 |
| 2751 2018-05-15 Antoine Quint <graouts@apple.com> |
| 2752 |
| 2753 [Web Animations] Expose Web Animations CSS integration as an experimenta
l feature |
| 2754 https://bugs.webkit.org/show_bug.cgi?id=185647 |
| 2755 |
| 2756 Reviewed by Dean Jackson. |
| 2757 |
| 2758 Rename the Web Animations CSS integration flag. |
| 2759 |
| 2760 * DumpRenderTree/TestOptions.cpp: |
| 2761 (TestOptions::TestOptions): |
| 2762 * DumpRenderTree/TestOptions.h: |
| 2763 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 2764 (setWebPreferencesForTestOptions): |
| 2765 * WebKitTestRunner/TestController.cpp: |
| 2766 (WTR::TestController::resetPreferencesToConsistentValues): |
| 2767 (WTR::updateTestOptionsFromTestHeader): |
| 2768 * WebKitTestRunner/TestOptions.h: |
| 2769 (WTR::TestOptions::hasSameInitializationOptions const): |
| 2770 |
| 2771 2018-05-14 Brady Eidson <beidson@apple.com> |
| 2772 |
| 2773 Add an API test to guard against regressions while re-entering setDefers
Loading:. |
| 2774 <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=18
5630 |
| 2775 |
| 2776 Reviewed by Chris Dumez. |
| 2777 |
| 2778 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 2779 * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added. |
| 2780 (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNav
igation:]): |
| 2781 (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]): |
| 2782 (-[DefersScheme initWithBytes:]): |
| 2783 (-[DefersScheme webView:startURLSchemeTask:]): |
| 2784 (-[DefersScheme webView:stopURLSchemeTask:]): |
| 2785 * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added. |
| 2786 (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextCon
troller:]): |
| 2787 (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:di
dSameDocumentNavigation:forFrame:]): |
| 2788 (-[DoubleDefersLoadingPlugIn dealloc]): |
| 2789 |
| 2790 2018-05-14 Daniel Bates <dabates@apple.com> |
| 2791 |
| 2792 [iOS] Add a test to ensure that setTimeout() does not fire more than exp
ected when using UIWebView |
| 2793 https://bugs.webkit.org/show_bug.cgi?id=185599 |
| 2794 <rdar://problem/22493890> |
| 2795 |
| 2796 Reviewed by Simon Fraser. |
| 2797 |
| 2798 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 2799 * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added. |
| 2800 (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]): |
| 2801 (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]): |
| 2802 (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:
navigationType:]): |
| 2803 (TestWebKitAPI::TEST): |
| 2804 * TestWebKitAPI/ios/set-timeout-function.html: Added. |
| 2805 |
| 2806 2018-05-14 Valerie R Young <valerie@bocoup.com> |
| 2807 |
| 2808 test262/Runner.pm: small bugs in CLI and error codes |
| 2809 https://bugs.webkit.org/show_bug.cgi?id=185629 |
| 2810 |
| 2811 Reviewed by Michael Saboff. |
| 2812 |
| 2813 Fix two commandline args with use '-f', correct |
| 2814 error code of failures. |
| 2815 |
| 2816 * Scripts/test262/Runner.pm: |
| 2817 (processCLI): |
| 2818 (main): |
| 2819 |
| 2820 2018-05-14 Ryan Haddad <ryanhaddad@apple.com> |
| 2821 |
| 2822 Disable API tests that time out after pointer poisioning was disabled. |
| 2823 https://bugs.webkit.org/show_bug.cgi?id=185586 |
| 2824 |
| 2825 Unreviewed test gardening. |
| 2826 |
| 2827 * TestWebKitAPI/Tests/WTF/Poisoned.cpp: |
| 2828 (TestWebKitAPI::TEST): |
| 2829 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: |
| 2830 (TestWebKitAPI::TEST): |
| 2831 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleAr
rays.cpp: |
| 2832 (TestWebKitAPI::TEST): |
| 2833 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArray
s.cpp: |
| 2834 (TestWebKitAPI::TEST): |
| 2835 |
| 2836 2018-05-14 Leo Balter <leonardo.balter@gmail.com> |
| 2837 |
| 2838 Test262-Runner: Fix RegExp for capturing tests metadata" |
| 2839 https://bugs.webkit.org/show_bug.cgi?id=185622 |
| 2840 |
| 2841 Reviewed by Michael Saboff. |
| 2842 |
| 2843 This patch fixes the RegExp used to capture each test metadata regarding
their EOL characters for |
| 2844 both LF and CRLF forms. |
| 2845 |
| 2846 The fix also allows the runner to capture the proper results from two sp
ecific files using CR and |
| 2847 CRLF line terminators. They are updated in the expectations file. |
| 2848 * Scripts/test262/Runner.pm: |
| 2849 (parseData): |
| 2850 |
| 2851 2018-05-14 Jeremy Jones <jeremyj@apple.com> |
| 2852 |
| 2853 NSEvent event trackers don't work from WebKitTestRunner |
| 2854 https://bugs.webkit.org/show_bug.cgi?id=185383 |
| 2855 rdar://problem/40025045 |
| 2856 |
| 2857 Reviewed by Simon Fraser. |
| 2858 |
| 2859 Post simulated wheel events to _sendEventToObservers: so they can be han
dled by NSEvent observers. |
| 2860 NSEvent swipe tracking is used for webkit swipe navigation. |
| 2861 |
| 2862 * WebKitTestRunner/mac/EventSenderProxy.mm: |
| 2863 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): |
| 2864 |
| 2865 2018-05-11 Leo Balter <leonardo.balter@gmail.com> |
| 2866 |
| 2867 Test262 Runner should search for the Debug JSC by default |
| 2868 https://bugs.webkit.org/show_bug.cgi?id=185562 |
| 2869 |
| 2870 Reviewed by Michael Saboff. |
| 2871 |
| 2872 The Test262 Runner is now searching for the Debug build of JSC by |
| 2873 default, not the Release build. |
| 2874 |
| 2875 This fix allows a similar call from the previous runner, making |
| 2876 it compatible with the current build bot configuration parameters. |
| 2877 |
| 2878 This patch also adds some minor improvements the verbose mode output. |
| 2879 |
| 2880 * Scripts/test262/Runner.pm: |
| 2881 (processCLI): |
| 2882 (main): |
| 2883 (getBuildPath): |
| 2884 (processResult): |
| 2885 |
| 2886 2018-05-11 Charles Vazac <cvazac@gmail.com> |
| 2887 |
| 2888 Runtime feature flag for Server-Timing |
| 2889 https://bugs.webkit.org/show_bug.cgi?id=184758 |
| 2890 |
| 2891 Reviewed by Youenn Fablet. |
| 2892 |
| 2893 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SER
VER_TIMING. |
| 2894 * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing |
| 2895 |
| 2896 2018-05-11 Fujii Hironori <Hironori.Fujii@sony.com> |
| 2897 |
| 2898 [Win][MiniBrowser] Move WK1 related code into MiniBrowser |
| 2899 https://bugs.webkit.org/show_bug.cgi?id=185418 |
| 2900 |
| 2901 Reviewed by Alex Christensen. |
| 2902 |
| 2903 All WK1 related code should be moved into MiniBrowser for the preparatio
n |
| 2904 of Bug 184770. |
| 2905 |
| 2906 This change moves the initilization code of MiniBrowse into MiniBrowser:
:init(). |
| 2907 |
| 2908 * MiniBrowser/win/Common.cpp: |
| 2909 (getAppDataFolder): Removed `static` keyword to be called from MiniBrows
er.cpp. |
| 2910 (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp. |
| 2911 * MiniBrowser/win/Common.h: Added. |
| 2912 * MiniBrowser/win/MiniBrowser.cpp: |
| 2913 (MiniBrowser::init): Moved the initilization code from wWinMain. |
| 2914 (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a metho
d. |
| 2915 * MiniBrowser/win/MiniBrowser.h: |
| 2916 (MiniBrowser::setCacheFolder): Changed to a private method. |
| 2917 (MiniBrowser::subclassForLayeredWindow): Changed to a private method. |
| 2918 * MiniBrowser/win/WinMain.cpp: |
| 2919 (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp. |
| 2920 |
| 2921 2018-05-11 Brady Eidson <beidson@apple.com> |
| 2922 |
| 2923 Make sure history navigations reuse the existing process when necessary. |
| 2924 <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=18
5532 |
| 2925 |
| 2926 Reviewed by Ryosuke Niwa. |
| 2927 |
| 2928 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: |
| 2929 |
| 2930 2018-05-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 2931 |
| 2932 [JSC][GLIB] Add introspectable alternatives to functions using vargars |
| 2933 https://bugs.webkit.org/show_bug.cgi?id=185508 |
| 2934 |
| 2935 Reviewed by Michael Catanzaro. |
| 2936 |
| 2937 Add test cases for the new API. |
| 2938 |
| 2939 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp: |
| 2940 (testJSCFunction): |
| 2941 (testJSCObject): |
| 2942 |
| 2943 2018-05-10 Leo Balter <leonardo.balter@gmail.com> |
| 2944 |
| 2945 [Build Bot] Restore configuration options to the Test262 Runner |
| 2946 |
| 2947 During the switch from the previous Test262 runner to the new one, |
| 2948 a call for an extra configurations options got removed. |
| 2949 |
| 2950 This call is important to inform the script to find the debug or |
| 2951 release build of JSC. It's being restored in this patch. |
| 2952 |
| 2953 https://bugs.webkit.org/show_bug.cgi?id=185513 |
| 2954 |
| 2955 Reviewed by Yusuke Suzuki. |
| 2956 |
| 2957 * BuildSlaveSupport/build.webkit.org-config/steps.py: |
| 2958 (RunTest262Tests): |
| 2959 |
| 2960 2018-05-10 Jonathan Bedard <jbedard@apple.com> |
| 2961 |
| 2962 REGRESSION (r230998): Cannot stream API test output |
| 2963 https://bugs.webkit.org/show_bug.cgi?id=185090 |
| 2964 |
| 2965 Reviewed by Ryosuke Niwa. |
| 2966 |
| 2967 Change run-api-tests so that the stdout and stderr of a test will be pri
nted |
| 2968 before it's result. If -v is passed, the output of single test runs will
be |
| 2969 streamed.· |
| 2970 |
| 2971 * Scripts/webkitpy/api_tests/run_api_tests.py: |
| 2972 (run): Use print_timestamps flag. |
| 2973 (parse_args): Add timestamps option to print timestamps in the log. |
| 2974 * Scripts/webkitpy/api_tests/runner.py: |
| 2975 (Runner): Add running status. |
| 2976 (Runner.__init__): Add number of workers and a flag to detect if a newli
ne |
| 2977 is needed at the beginning of a log line. |
| 2978 (Runner.run): Turn off most logging coming from server process since it
is |
| 2979 not constructive for API tests. |
| 2980 (Runner.handle): Add new log message to stream stdout and stderr instead
of |
| 2981 caching values until the test run finished. |
| 2982 (_Worker._run_single_test): Log stdout and stderr in real time. |
| 2983 (_Worker._run_shard_with_binary): Log stderr and stdout buffer before en
ding |
| 2984 the test. |
| 2985 (_Worker.post): Provide a post with explicitly enumerated argument names
. |
| 2986 * Scripts/webkitpy/layout_tests/views/metered_stream.py: |
| 2987 (MeteredStream.__init__): Differentiate verbose logging and logging with
timestamps. |
| 2988 (MeteredStream.write): Allow for verbose logging without timestamps. |
| 2989 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: |
| 2990 (RegularTest): Add print_timestamps flag. |
| 2991 (RegularTest.setUp): |
| 2992 (RegularTest.test_logging_not_included): |
| 2993 (VerboseTest.test_log_args): |
| 2994 (VerboseWithOutTimestamp): |
| 2995 (VerboseWithOutTimestamp.test_basic): Add test for verbose logging witho
ut timestamps. |
| 2996 |
| 2997 2018-05-10 Ryosuke Niwa <rniwa@webkit.org> |
| 2998 |
| 2999 build-webkit can erroneously warn about Xcode being too old |
| 3000 https://bugs.webkit.org/show_bug.cgi?id=185533 |
| 3001 |
| 3002 Reviewed by Dan Bernstein. |
| 3003 |
| 3004 Don't assume the version number is always a single digit. |
| 3005 |
| 3006 * Scripts/webkitdirs.pm: |
| 3007 (determineXcodeVersion): |
| 3008 |
| 3009 2018-05-10 Ross Kirsling <ross.kirsling@sony.com> |
| 3010 |
| 3011 [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements. |
| 3012 https://bugs.webkit.org/show_bug.cgi?id=185528 |
| 3013 |
| 3014 Reviewed by Lucas Forschler. |
| 3015 |
| 3016 * BuildSlaveSupport/build.webkit.org-config/factories.py: |
| 3017 (TestFactory.__init__): |
| 3018 * BuildSlaveSupport/build.webkit.org-config/steps.py: |
| 3019 (InstallWinCairoDependencies): |
| 3020 |
| 3021 2018-05-10 Michael Catanzaro <mcatanzaro@igalia.com> |
| 3022 |
| 3023 Fix some -Wstring-op-truncation warnings |
| 3024 https://bugs.webkit.org/show_bug.cgi?id=185496 |
| 3025 |
| 3026 Reviewed by Alex Christensen. |
| 3027 |
| 3028 We have an off-by-one in the use of strncpy. The strings would not be nu
ll-terminated if |
| 3029 the input was too long. Ensure the buffers are zero-initialized so we do
n't need to manually |
| 3030 set the last bucket to NUL. |
| 3031 |
| 3032 * TestWebKitAPI/Tests/WTF/AtomicString.cpp: |
| 3033 (TestWebKitAPI::testAtomicStringNumber): |
| 3034 * TestWebKitAPI/Tests/WTF/WTFString.cpp: |
| 3035 (TestWebKitAPI::testStringNumberFixedPrecision): |
| 3036 (TestWebKitAPI::testStringNumberFixedWidth): |
| 3037 (TestWebKitAPI::testStringNumber): |
| 3038 |
| 3039 2018-05-10 Fujii Hironori <Hironori.Fujii@sony.com> |
| 3040 |
| 3041 [Win][MiniBrowser] Add a separate WndProc for the layered window |
| 3042 https://bugs.webkit.org/show_bug.cgi?id=185460 |
| 3043 |
| 3044 Reviewed by Brent Fulgham. |
| 3045 |
| 3046 All WK1 related code should be moved into MiniBrowser for the |
| 3047 preparation of Bug 184770. |
| 3048 |
| 3049 The layered window was using WndProc of the main window. The |
| 3050 layered window is specific only for WK1. the main window will be |
| 3051 shared among WK1 and WK2. |
| 3052 |
| 3053 This change add a new WndProc for the layer window. |
| 3054 |
| 3055 * MiniBrowser/win/Common.cpp: |
| 3056 (WndProc): Removed code for the layered windows. |
| 3057 (subclassForLayeredWindow): Moved into MiniBrowser.cpp. |
| 3058 * MiniBrowser/win/MiniBrowser.cpp: |
| 3059 (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`. |
| 3060 (viewWndProc): New WndProc for the layered windows. |
| 3061 (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp. |
| 3062 * MiniBrowser/win/MiniBrowser.h: |
| 3063 (MiniBrowser::hwnd): |
| 3064 * MiniBrowser/win/WinMain.cpp: |
| 3065 (wWinMain): Added m_viewWnd. |
| 3066 |
| 3067 2018-05-10 Stephan Szabo <stephan.szabo@sony.com> |
| 3068 |
| 3069 Support --verbose in run-javascriptcore-tests |
| 3070 https://bugs.webkit.org/show_bug.cgi?id=185492 |
| 3071 |
| 3072 Reviewed by Daniel Bates. |
| 3073 |
| 3074 * Scripts/run-javascriptcore-tests: |
| 3075 (runJSCStressTests): |
| 3076 |
| 3077 2018-05-10 Valerie R Young <valerie@bocoup.com> |
| 3078 |
| 3079 test262/Runner.pm: --failing-files uses results file not expectations |
| 3080 https://bugs.webkit.org/show_bug.cgi?id=185395 |
| 3081 |
| 3082 Reviewed by Michael Saboff. |
| 3083 |
| 3084 --failing-files arg now uses results file to find failing tests |
| 3085 to rerun. It will look in the test262-results directory from whereever |
| 3086 the script is run, or a results.yaml file can be supplied via command |
| 3087 line argument. |
| 3088 --expectations arg added for suppling expectation file. |
| 3089 |
| 3090 * Scripts/test262/Runner.pm: |
| 3091 (processCLI): |
| 3092 (main): |
| 3093 (loadImportFile): |
| 3094 (findAllFailing): |
| 3095 |
| 3096 2018-05-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| 3097 |
| 3098 [GTK] Add support for settings cookies policy and storage type in MiniBr
owser |
| 3099 https://bugs.webkit.org/show_bug.cgi?id=185506 |
| 3100 |
| 3101 Reviewed by Philippe Normand. |
| 3102 |
| 3103 Useful for testing and debugging. |
| 3104 |
| 3105 * MiniBrowser/gtk/main.c: |
| 3106 (main): |
| 3107 |
| 3108 2018-05-09 Chris Dumez <cdumez@apple.com> |
| 3109 |
| 3110 Unreviewed Windows build fix after r231622. |
| 3111 |
| 3112 * DumpRenderTree/win/DumpRenderTree.cpp: |
| 3113 (enableExperimentalFeatures): |
| 3114 |
| 3115 2018-05-09 Sihui Liu <sihui_liu@apple.com> |
| 3116 |
| 3117 Update WebKit.WebsiteDataStoreCustomPaths after r231536 |
| 3118 https://bugs.webkit.org/show_bug.cgi?id=185486 |
| 3119 <rdar://problem/37214391> |
| 3120 |
| 3121 Reviewed by Chris Dumez. |
| 3122 |
| 3123 Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies
is async now. |
| 3124 |
| 3125 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm: |
| 3126 (TEST): |
| 3127 |
| 3128 2018-05-09 Leo Balter <leonardo.balter@gmail.com> |
| 3129 |
| 3130 Test262-Runner: Improve the verbose output |
| 3131 https://bugs.webkit.org/show_bug.cgi?id=185491 |
| 3132 |
| 3133 Reviewed by Michael Saboff. |
| 3134 |
| 3135 * Scripts/test262/Import.pm: |
| 3136 (transferFiles): |
| 3137 * Scripts/test262/Runner.pm: |
| 3138 (processResult): |
| 3139 |
| 3140 2018-05-09 Leo Balter <leonardo.balter@gmail.com> |
| 3141 |
| 3142 Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set |
| 3143 https://bugs.webkit.org/show_bug.cgi?id=185488 |
| 3144 |
| 3145 Reviewed by Michael Saboff. |
| 3146 |
| 3147 * Scripts/test262/Runner.pm: |
| 3148 (processCLI): |
| 3149 (getBuildPath): |
| 3150 (runTest): |
| 3151 |
| 3152 2018-05-09 Richard Houle <rhoule@apple.com> |
| 3153 |
| 3154 [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle
isTextField] |
| 3155 https://bugs.webkit.org/show_bug.cgi?id=185260 |
| 3156 <rdar://problem/39290394> |
| 3157 |
| 3158 Reviewed by Tim Horton. |
| 3159 |
| 3160 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 3161 * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm
: Added. |
| 3162 (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:docum
ent:jsContext:]): |
| 3163 (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowser
ContextController:]): |
| 3164 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 3165 (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAler
tPanelWithMessage:initiatedByFrame:completionHandler:]): |
| 3166 |
| 3167 2018-05-09 Thibault Saunier <tsaunier@igalia.com> |
| 3168 |
| 3169 [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess |
| 3170 https://bugs.webkit.org/show_bug.cgi?id=185481 |
| 3171 |
| 3172 Reviewed by Philippe Normand. |
| 3173 |
| 3174 [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess |
| 3175 |
| 3176 * Scripts/webkitpy/port/gtk.py: |
| 3177 (GtkPort.setup_environ_for_server): |
| 3178 |
| 3179 2018-05-09 Leo Balter <leonardo.balter@gmail.com> |
| 3180 |
| 3181 Set build.webkit.org to use the new Test262-runner |
| 3182 https://bugs.webkit.org/show_bug.cgi?id=184933 |
| 3183 |
| 3184 Reviewed by Aakash Jain. |
| 3185 |
| 3186 * BuildSlaveSupport/build.webkit.org-config/steps.py: |
| 3187 (RunTest262Tests): |
| 3188 (RunTest262Tests.countFailures): |
| 3189 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: |
| 3190 |
| 3191 2018-05-09 Carlos Eduardo Ramalho <cadubentzen@gmail.com> |
| 3192 |
| 3193 [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1 |
| 3194 https://bugs.webkit.org/show_bug.cgi?id=185461 |
| 3195 |
| 3196 Reviewed by Michael Catanzaro. |
| 3197 |
| 3198 JHBuild now compiles LLVM 6 and Mesa 18.0.3. |
| 3199 |
| 3200 * gtk/jhbuild.modules: |
| 3201 |
| 3202 2018-05-09 Michael Catanzaro <mcatanzaro@igalia.com> |
| 3203 |
| 3204 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release. |
| 3205 |
| 3206 * wpe/manifest.txt.in: Distribute the NEWS. |
| 3207 |
| 3208 2018-05-09 Michael Catanzaro <mcatanzaro@igalia.com> |
| 3209 |
| 3210 [WPE] Build cleanly with GCC 8 and ICU 60 |
| 3211 https://bugs.webkit.org/show_bug.cgi?id=185462 |
| 3212 |
| 3213 Reviewed by Carlos Alberto Lopez Perez. |
| 3214 |
| 3215 * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing
a directory. Not |
| 3216 sure why this was never noticed until now or why the bots are OK. |
| 3217 * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEF
INE_TYPE. |
| 3218 * gtk/patches/glib-cast-function-type.patch: Added. |
| 3219 * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEF
INE_TYPE. |
| 3220 * wpe/patches/glib-cast-function-type.patch: Added. |
| 3221 |
| 3222 2018-05-06 Yusuke Suzuki <utatane.tea@gmail.com> |
| 3223 |
| 3224 [JSC][GTK][JSCONLY] Use capstone disassembler |
| 3225 https://bugs.webkit.org/show_bug.cgi?id=185283 |
| 3226 |
| 3227 Reviewed by Michael Catanzaro. |
| 3228 |
| 3229 * gtk/manifest.txt.in: |
| 3230 * wpe/manifest.txt.in: |
| 3231 |
| 3232 2018-05-09 Antti Koivisto <antti@apple.com> |
| 3233 |
| 3234 Add OptionSet::operator& and operator bool |
| 3235 https://bugs.webkit.org/show_bug.cgi?id=185306 |
| 3236 |
| 3237 Reviewed by Anders Carlsson. |
| 3238 |
| 3239 * TestWebKitAPI/Tests/WTF/OptionSet.cpp: |
| 3240 (TestWebKitAPI::TEST): |
| 3241 |
| 3242 2018-05-08 Wenson Hsieh <wenson_hsieh@apple.com> |
| 3243 |
| 3244 Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentR
eaderCocoa |
| 3245 https://bugs.webkit.org/show_bug.cgi?id=185340 |
| 3246 |
| 3247 Reviewed by Tim Horton. |
| 3248 |
| 3249 Adds a new API test to verify that URLs written using -[NSPasteboard wri
teObjects:] are pasted as anchors with |
| 3250 non-empty text in a contenteditable. |
| 3251 |
| 3252 * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: |
| 3253 (TestWebKitAPI::TEST): |
| 3254 |
| 3255 2018-05-08 Valerie R Young <valerie@bocoup.com> |
| 3256 |
| 3257 test262/Runner.pm: create results dir for results of test262 run |
| 3258 https://bugs.webkit.org/show_bug.cgi?id=185392 |
| 3259 |
| 3260 Reviewed by Michael Saboff. |
| 3261 |
| 3262 New directory test262-results created from where ever script is |
| 3263 called. |
| 3264 |
| 3265 * Scripts/test262/Runner.pm: |
| 3266 (processCLI): |
| 3267 |
| 3268 2018-05-08 Valerie R Young <valerie@bocoup.com> |
| 3269 |
| 3270 test262/Runner.pm: lower number of processes per core |
| 3271 https://bugs.webkit.org/show_bug.cgi?id=185426 |
| 3272 |
| 3273 Reviewed by Michael Saboff. |
| 3274 |
| 3275 * Scripts/test262/Runner.pm: |
| 3276 (getProcesses): |
| 3277 |
| 3278 2018-05-08 Leo Balter <leonardo.balter@gmail.com> |
| 3279 |
| 3280 Test262-Runner: Add base Perl UnicodeData |
| 3281 https://bugs.webkit.org/show_bug.cgi?id=185444 |
| 3282 |
| 3283 Reviewed by Michael Saboff. |
| 3284 |
| 3285 * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added. |
| 3286 * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added. |
| 3287 |
| 3288 2018-05-08 Daniel Bates <dabates@apple.com> |
| 3289 |
| 3290 Add tests to ensure that the Strong Password appearance is removed on fo
rm reset |
| 3291 https://bugs.webkit.org/show_bug.cgi?id=185440 |
| 3292 |
| 3293 Reviewed by Ryosuke Niwa. |
| 3294 |
| 3295 * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordApp
earance.mm: |
| 3296 (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCre
ateBrowserContextController:]): |
| 3297 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 3298 (TEST): |
| 3299 |
| 3300 2018-05-08 Daniel Bates <dabates@apple.com> |
| 3301 |
| 3302 Resign Strong Password appearance when text field value changes |
| 3303 https://bugs.webkit.org/show_bug.cgi?id=185433 |
| 3304 <rdar://problem/39958508> |
| 3305 |
| 3306 Reviewed by Ryosuke Niwa. |
| 3307 |
| 3308 Add a unit test to ensure the injected bundle API and WebKit UI delegate
SPI is invoked |
| 3309 when the field has the Strong Password button and its value changes. |
| 3310 |
| 3311 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: |
| 3312 (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScr
ipt): |
| 3313 (TEST): |
| 3314 |
| 3315 2018-05-06 Filip Pizlo <fpizlo@apple.com> |
| 3316 |
| 3317 InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstra
ct values |
| 3318 https://bugs.webkit.org/show_bug.cgi?id=185365 |
| 3319 |
| 3320 Reviewed by Saam Barati. |
| 3321 ········ |
| 3322 Make it possible to measure compile times. |
| 3323 ········ |
| 3324 Rolling back in after fixing cloop builds. |
| 3325 |
| 3326 * Scripts/run-jsc-benchmarks: |
| 3327 |
| 3328 2018-05-08 Wenson Hsieh <wenson_hsieh@apple.com> |
| 3329 |
| 3330 [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after
r231396 |
| 3331 https://bugs.webkit.org/show_bug.cgi?id=185414 |
| 3332 |
| 3333 Reviewed by Tim Horton. |
| 3334 |
| 3335 Adjust a test expectation to check that the resulting DOM contains an at
tachment element, |
| 3336 anchor element, and another attachment element in that order. This ensur
es that the test |
| 3337 still passes, even after the anchor element is followed by a line break. |
| 3338 |
| 3339 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: |
| 3340 (TestWebKitAPI::TEST): |
| 3341 |
| 3342 2018-05-08 Commit Queue <commit-queue@webkit.org> |
| 3343 |
| 3344 Unreviewed, rolling out r231491. |
| 3345 https://bugs.webkit.org/show_bug.cgi?id=185434 |
| 3346 |
| 3347 Setting the Created key on a cookie does not work yet, due a |
| 3348 bug in CFNetwork (Requested by ggaren on #webkit). |
| 3349 |
| 3350 Reverted changeset: |
| 3351 |
| 3352 "[WKHTTPCookieStore getAllCookies] returns inconsistent |
| 3353 creation time" |
| 3354 https://bugs.webkit.org/show_bug.cgi?id=185041 |
| 3355 https://trac.webkit.org/changeset/231491 |
| 3356 |
| 3357 2018-05-08 Valerie R Young <valerie@bocoup.com> |
| 3358 |
| 3359 test262/Runner.pm: move input files to JSTests/test262 |
| 3360 https://bugs.webkit.org/show_bug.cgi?id=185389 |
| 3361 |
| 3362 Reviewed by Michael Saboff. |
| 3363 |
| 3364 * Scripts/test262/Runner.pm: |
| 3365 (processCLI): |
| 3366 |
| 3367 2018-05-08 Chris Dumez <cdumez@apple.com> |
| 3368 |
| 3369 Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231
474. |
| 3370 |
| 3371 * Scripts/webkitpy/performance_tests/perftest.py: |
| 3372 (PerfTest): |
| 3373 |
| 3374 2018-05-08 Ryan Haddad <ryanhaddad@apple.com> |
| 3375 |
| 3376 Unreviewed, rolling out r231468. |
| 3377 |
| 3378 Broke the CLoop build |
| 3379 |
| 3380 Reverted changeset: |
| 3381 |
| 3382 "InPlaceAbstractState::beginBasicBlock shouldn't have to clear |
| 3383 any abstract values" |
| 3384 https://bugs.webkit.org/show_bug.cgi?id=185365 |
| 3385 https://trac.webkit.org/changeset/231468 |
| 3386 |
| 3387 2018-05-08 Sihui Liu <sihui_liu@apple.com> |
| 3388 |
| 3389 [WKHTTPCookieStore getAllCookies] returns inconsistent creation time |
| 3390 https://bugs.webkit.org/show_bug.cgi?id=185041 |
| 3391 <rdar://problem/34684214> |
| 3392 |
| 3393 Reviewed by Geoffrey Garen. |
| 3394 |
| 3395 Add API test Coverage. |
| 3396 |
| 3397 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 3398 (TEST): |
| 3399 |
| 3400 2018-05-08 Chris Dumez <cdumez@apple.com> |
| 3401 |
| 3402 Unreviewed, fix issue with running Speedometer PerfTest after r231450. |
| 3403 |
| 3404 * Scripts/webkitpy/performance_tests/perftest.py: |
| 3405 (PerfTest): |
| 3406 |
| 3407 2018-05-08 Chris Dumez <cdumez@apple.com> |
| 3408 |
| 3409 Unreviewed, fix issue with running Speedometer PerfTest after r231450. |
| 3410 |
| 3411 * Scripts/webkitpy/performance_tests/perftest.py: |
| 3412 (PerfTest): |
| 3413 |
| 3414 2018-05-07 Chris Dumez <cdumez@apple.com> |
| 3415 |
| 3416 Unreviewed, fix issue with running Speedometer PerfTest after r231450. |
| 3417 |
| 3418 * Scripts/webkitpy/performance_tests/perftest.py: |
| 3419 (PerfTest): |
| 3420 |
| 3421 2018-05-06 Filip Pizlo <fpizlo@apple.com> |
| 3422 |
| 3423 InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstra
ct values |
| 3424 https://bugs.webkit.org/show_bug.cgi?id=185365 |
| 3425 |
| 3426 Reviewed by Saam Barati. |
| 3427 ········ |
| 3428 Make it possible to measure compile times. |
| 3429 |
| 3430 * Scripts/run-jsc-benchmarks: |
| 3431 |
| 3432 2018-05-07 Leo Balter <leonardo.balter@gmail.com> |
| 3433 |
| 3434 Test262-Runner: Add base module to the local deps - unicore/Exact.pl |
| 3435 https://bugs.webkit.org/show_bug.cgi?id=185390 |
| 3436 |
| 3437 Reviewed by Michael Saboff. |
| 3438 |
| 3439 * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added. |
| 3440 |
| 3441 2018-05-07 Jonathan Bedard <jbedard@apple.com> |
| 3442 |
| 3443 Check for com.apple.datamigrator before declaring simulators booted |
| 3444 https://bugs.webkit.org/show_bug.cgi?id=185315 |
| 3445 <rdar://problem/39986261> |
| 3446 |
| 3447 Reviewed by David Kilzer. |
| 3448 |
| 3449 * Scripts/webkitdirs.pm: |
| 3450 (waitUntilProcessNotRunning): Wait until a process is not found. |
| 3451 (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running
to declare |
| 3452 a simulator booted. |
| 3453 * Scripts/webkitpy/common/system/executive_mock.py: |
| 3454 (MockExecutive2.__init__): Define _running_pids. |
| 3455 * Scripts/webkitpy/xcode/simulated_device.py: |
| 3456 (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migrat
ion_is_done before |
| 3457 declaring that devices have been booted, increase the timeout since data
migration will frequently |
| 3458 take longer than 60 seconds, especially with multiple simulators booting
. |
| 3459 (SimulatedDeviceManager.swap): Ditto. |
| 3460 (SimulatedDeviceManager): |
| 3461 (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until t
here are no com.apple.datamigrator |
| 3462 processes running. |
| 3463 |
| 3464 2018-05-07 Daniel Bates <dabates@apple.com> |
| 3465 |
| 3466 REGRESSION (r229955): run-webkit-tests runs tests in skipped directories
and subdirectories of directory given on command line |
| 3467 https://bugs.webkit.org/show_bug.cgi?id=185054 |
| 3468 <rdar://problem/39773209> |
| 3469 |
| 3470 Reviewed by Ryosuke Niwa. |
| 3471 |
| 3472 Fallback to MacPort.CURRENT_VERSION if we are not using a known named ma
cOS and do not have Apple Additions. |
| 3473 |
| 3474 Darwin-based ports have OS version-specific test expectations and are ce
rtified to support running tests using |
| 3475 the currently shipping OS by way of a hardcoded class variable CURRENT_V
ERSION. The run-webkit-tests script |
| 3476 depends on the OS version to find the applicable TestExpectations files
to parse to compute the list of skipped |
| 3477 tests for the port. |
| 3478 |
| 3479 * Scripts/webkitpy/port/mac.py: |
| 3480 (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not u
sing a known named macOS and do not |
| 3481 have Apple Additions. |
| 3482 * Scripts/webkitpy/port/mac_unittest.py: |
| 3483 (MacTest.test_factory_with_future_version): Added. |
| 3484 (MacTest.test_factory_with_future_version_and_apple_additions): Renamed
from MacTest.test_factory_with_future_version() |
| 3485 and added code to use the mock Apple Additions so that running this code
with- and without- the real Apple Additions |
| 3486 produces consistent results now that the Mac port's OS version falls bac
k to MacPort.CURRENT_VERSION when Apple Additions |
| 3487 is absent. |
| 3488 |
| 3489 2018-05-07 Brian Burg <bburg@apple.com> |
| 3490 |
| 3491 Web Inspector: opt out of process swap on navigation if a Web Inspector
frontend is connected |
| 3492 https://bugs.webkit.org/show_bug.cgi?id=184861 |
| 3493 <rdar://problem/39153768> |
| 3494 |
| 3495 Reviewed by Timothy Hatcher. |
| 3496 |
| 3497 Add a new test that checks whether a new process is used for navigation
when |
| 3498 an Inspector is shown. Also check that the behavior reverts to normal af
ter |
| 3499 the Inspector has been closed. |
| 3500 |
| 3501 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: |
| 3502 |
| 3503 2018-05-04 Wenson Hsieh <wenson_hsieh@apple.com> |
| 3504 |
| 3505 [iOS] Multiple links in Mail are dropped in a single line, and are diffi
cult to tell apart |
| 3506 https://bugs.webkit.org/show_bug.cgi?id=185289 |
| 3507 <rdar://problem/35756912> |
| 3508 |
| 3509 Reviewed by Tim Horton and Darin Adler. |
| 3510 |
| 3511 Augment and rebaseline some iOS drag-and-drop API tests that handle drop
ping URLs as a part of multi-item drop |
| 3512 sessions. |
| 3513 |
| 3514 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: |
| 3515 (TestWebKitAPI::TEST): |
| 3516 |
| 3517 2018-05-04 Timothy Hatcher <timothy@apple.com> |
| 3518 |
| 3519 Deprecate legacy WebView and friends |
| 3520 https://bugs.webkit.org/show_bug.cgi?id=185279 |
| 3521 rdar://problem/33268700 |
| 3522 |
| 3523 Reviewed by Tim Horton. |
| 3524 |
| 3525 * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFIN
ITIONS |
| 3526 to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS. |
| 3527 |
| 3528 2018-05-04 Leo Balter <leonardo.balter@gmail.com> |
| 3529 |
| 3530 Test262-Runner: Add base module to the local deps - unicore/PVA.pl |
| 3531 https://bugs.webkit.org/show_bug.cgi?id=185314 |
| 3532 |
| 3533 Reviewed by Michael Saboff. |
| 3534 |
| 3535 * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added. |
| 3536 |
| 3537 2018-05-04 Wenson Hsieh <whsieh@berkeley.edu> |
| 3538 |
| 3539 REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures s
een with 11.3 SDK |
| 3540 https://bugs.webkit.org/show_bug.cgi?id=184196 |
| 3541 <rdar://problem/39054481> |
| 3542 |
| 3543 Reviewed by Tim Horton. |
| 3544 |
| 3545 Removes some unnecessary workarounds to enable running app autofill test
s against iOS versions |
| 3546 earlier than 11.3. Also re-enables these tests. |
| 3547 |
| 3548 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: |
| 3549 (TestWebKitAPI::TEST): |
| 3550 (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted. |
| 3551 (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]):
Deleted. |
| 3552 |
| 3553 2018-05-04 Myles C. Maxfield <mmaxfield@apple.com> |
| 3554 |
| 3555 Text shaping in the simple path is flipped in the y direction |
| 3556 https://bugs.webkit.org/show_bug.cgi?id=185062 |
| 3557 <rdar://problem/39778678> |
| 3558 |
| 3559 Reviewed by Simon Fraser. |
| 3560 |
| 3561 Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fon
ts!!! |
| 3562 |
| 3563 * Scripts/webkitpy/common/config/contributors.json: |
| 3564 |
| 3565 2018-05-04 Leo Balter <leonardo.balter@gmail.com> |
| 3566 |
| 3567 Test262-Runner: place the processCLI inside the main call |
| 3568 https://bugs.webkit.org/show_bug.cgi?id=185304 |
| 3569 |
| 3570 Reviewed by Michael Saboff. |
| 3571 |
| 3572 * Scripts/test262/Runner.pm: |
| 3573 (main): |
15 | 3574 |
16 2018-05-04 Carlos Garcia Campos <cgarcia@igalia.com> | 3575 2018-05-04 Carlos Garcia Campos <cgarcia@igalia.com> |
17 | 3576 |
18 [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable.
" when trying to download an image from discogs.com | 3577 [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable.
" when trying to download an image from discogs.com |
19 https://bugs.webkit.org/show_bug.cgi?id=174730 | 3578 https://bugs.webkit.org/show_bug.cgi?id=174730 |
20 | 3579 |
21 Reviewed by Michael Catanzaro. | 3580 Reviewed by Michael Catanzaro. |
22 | 3581 |
23 Update unit tests to check that User-Agent header is included in HTTP do
wnload requests. | 3582 Update unit tests to check that User-Agent header is included in HTTP do
wnload requests. |
24 | 3583 |
(...skipping 11400 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
11425 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. | 14984 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. |
11426 | 14985 |
11427 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: | 14986 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: |
11428 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): | 14987 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): |
11429 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: | 14988 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: |
11430 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): | 14989 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): |
11431 (websiteDataStoreTestWebView): | 14990 (websiteDataStoreTestWebView): |
11432 (TEST): | 14991 (TEST): |
11433 | 14992 |
11434 == Rolled over to ChangeLog-2018-01-01 == | 14993 == Rolled over to ChangeLog-2018-01-01 == |
LEFT | RIGHT |