Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(59)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Delta Between Two Patch Sets: Tools/TestWebKitAPI/Tests/WebKitCocoa/unsafe-iframe.html
Issue
339530043
:
SB prototype
Left Patch Set: Rebased
Created 5 years, 11 months ago
Right Patch Set: Fix
Created 5 years, 9 months ago
Left:
Base
Patch Set 1: None
Patch Set 2: Move logic in SafeBrowsingController
Patch Set 3: SafeBrowsingChecks now get created and used
Patch Set 4: Now shows a warning
Patch Set 5: User bypass of warning works
Patch Set 6: WIP
Patch Set 7: URLs are displayed correctly
Patch Set 8: Store NavigationAction in SafeBrowsingCheck
Patch Set 9: Notify delegate of SB failure
Patch Set 10: Remove raw pointer to completion handler
Patch Set 11: Use embedder decision
Patch Set 12: Implement persistence
Patch Set 13: Rebased
Patch Set 14: Add a WKPreference, and enable it in MiniBrowser
Patch Set 15: Guard against SafeBrowserController getting destroyed before callback
Patch Set 16: Handle redirects
Patch Set 17: Clean up
Patch Set 18: Changelogs, and style stuff
Patch Set 19: Attempt to fix back/forward navigation
Patch Set 20: More fixing of back forward nav
Patch Set 21: Update change logs
Patch Set 22: Squashed patch
Patch Set 23: Get ready to delete hacky code
Patch Set 24: Deleted hacky code
Patch Set 25: Squashed patch
Patch Set 26: Plumb client redirect status to UIProcess
Patch Set 27: Redirects work
Patch Set 28: Fix history behavior when bypassing warning after redirect
Patch Set 29: Plubmed back/forward id as part of loadAlternateHTMLString request
Patch Set 30: WIP
Patch Set 31: Warning for iframe now works properly wrt back/forward history
Patch Set 32: Rebased
Patch Set 33: Started on tests
Patch Set 34: Progress on tests
Patch Set 35: Tests
Patch Set 36: Test redirects
Patch Set 37: Test for iframe
Patch Set 38: Tested bypassing the warning page
Patch Set 39: WIP for offline tests
Patch Set 40: Test context provider works
Patch Set 41: Tests work offline
Patch Set 42: Rebased
Patch Set 43: Changelogs
Patch Set 44: Squashed patch
Patch Set 45: Remove SafeBrowsing policy decision
Patch Set 46: Removing history code and updating tests
Patch Set 47: Finihsed fixing tests
Patch Set 48: Remove change to create Navigation for loadAlternateHTML
Patch Set 49: Fix
Right:
Patch Set 1: None
Patch Set 2: Move logic in SafeBrowsingController
Patch Set 3: SafeBrowsingChecks now get created and used
Patch Set 4: Now shows a warning
Patch Set 5: User bypass of warning works
Patch Set 6: WIP
Patch Set 7: URLs are displayed correctly
Patch Set 8: Store NavigationAction in SafeBrowsingCheck
Patch Set 9: Notify delegate of SB failure
Patch Set 10: Remove raw pointer to completion handler
Patch Set 11: Use embedder decision
Patch Set 12: Implement persistence
Patch Set 13: Rebased
Patch Set 14: Add a WKPreference, and enable it in MiniBrowser
Patch Set 15: Guard against SafeBrowserController getting destroyed before callback
Patch Set 16: Handle redirects
Patch Set 17: Clean up
Patch Set 18: Changelogs, and style stuff
Patch Set 19: Attempt to fix back/forward navigation
Patch Set 20: More fixing of back forward nav
Patch Set 21: Update change logs
Patch Set 22: Squashed patch
Patch Set 23: Get ready to delete hacky code
Patch Set 24: Deleted hacky code
Patch Set 25: Squashed patch
Patch Set 26: Plumb client redirect status to UIProcess
Patch Set 27: Redirects work
Patch Set 28: Fix history behavior when bypassing warning after redirect
Patch Set 29: Plubmed back/forward id as part of loadAlternateHTMLString request
Patch Set 30: WIP
Patch Set 31: Warning for iframe now works properly wrt back/forward history
Patch Set 32: Rebased
Patch Set 33: Started on tests
Patch Set 34: Progress on tests
Patch Set 35: Tests
Patch Set 36: Test redirects
Patch Set 37: Test for iframe
Patch Set 38: Tested bypassing the warning page
Patch Set 39: WIP for offline tests
Patch Set 40: Test context provider works
Patch Set 41: Tests work offline
Patch Set 42: Rebased
Patch Set 43: Changelogs
Patch Set 44: Squashed patch
Patch Set 45: Remove SafeBrowsing policy decision
Patch Set 46: Removing history code and updating tests
Patch Set 47: Finihsed fixing tests
Patch Set 48: Remove change to create Navigation for loadAlternateHTML
Patch Set 49: Fix
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
Source/WebCore/ChangeLog
Source/WebCore/page/Settings.yaml
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
Source/WebKit/UIProcess/Cocoa/NavigationState.h
Source/WebKit/UIProcess/Cocoa/NavigationState.mm
Source/WebKit/UIProcess/Cocoa/SafeBrowsingContextProvider.h
Source/WebKit/UIProcess/Cocoa/SafeBrowsingContextProvider.mm
Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.h
Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.mm
Source/WebKit/WebKit.xcodeproj/project.pbxproj
Tools/ChangeLog
Tools/MiniBrowser/MiniBrowser.entitlements
Tools/MiniBrowser/mac/AppDelegate.m
Tools/MiniBrowser/mac/SettingsController.h
Tools/MiniBrowser/mac/SettingsController.m
Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html
Tools/TestWebKitAPI/Tests/WebKitCocoa/unsafe-iframe.html
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« Tools/TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html
('k') |
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
<!DOCTYPE html>
2
<iframe src='sb://host/phishing.html'></iframe>
LEFT
RIGHT
« Tools/TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html
('k') |
no next file »
|
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Issue 339530043: SB prototype
Created 5 years, 11 months ago by ajuma
Modified 5 years, 9 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b