Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(573)

Issue 339530043: SB prototype

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by ajuma
Modified:
2 months ago
Reviewers:
Visibility:
Public.

Description

SB prototype

Patch Set 1 #

Patch Set 2 : Move logic in SafeBrowsingController #

Patch Set 3 : SafeBrowsingChecks now get created and used #

Patch Set 4 : Now shows a warning #

Patch Set 5 : User bypass of warning works #

Patch Set 6 : WIP #

Patch Set 7 : URLs are displayed correctly #

Patch Set 8 : Store NavigationAction in SafeBrowsingCheck #

Patch Set 9 : Notify delegate of SB failure #

Patch Set 10 : Remove raw pointer to completion handler #

Patch Set 11 : Use embedder decision #

Patch Set 12 : Implement persistence #

Patch Set 13 : Rebased #

Patch Set 14 : Add a WKPreference, and enable it in MiniBrowser #

Patch Set 15 : Guard against SafeBrowserController getting destroyed before callback #

Patch Set 16 : Handle redirects #

Patch Set 17 : Clean up #

Patch Set 18 : Changelogs, and style stuff #

Patch Set 19 : Attempt to fix back/forward navigation #

Patch Set 20 : More fixing of back forward nav #

Patch Set 21 : Update change logs #

Patch Set 22 : Squashed patch #

Patch Set 23 : Get ready to delete hacky code #

Patch Set 24 : Deleted hacky code #

Patch Set 25 : Squashed patch #

Patch Set 26 : Plumb client redirect status to UIProcess #

Patch Set 27 : Redirects work #

Patch Set 28 : Fix history behavior when bypassing warning after redirect #

Patch Set 29 : Plubmed back/forward id as part of loadAlternateHTMLString request #

Patch Set 30 : WIP #

Patch Set 31 : Warning for iframe now works properly wrt back/forward history #

Patch Set 32 : Rebased #

Patch Set 33 : Started on tests #

Patch Set 34 : Progress on tests #

Patch Set 35 : Tests #

Patch Set 36 : Test redirects #

Patch Set 37 : Test for iframe #

Patch Set 38 : Tested bypassing the warning page #

Patch Set 39 : WIP for offline tests #

Patch Set 40 : Test context provider works #

Patch Set 41 : Tests work offline #

Patch Set 42 : Rebased #

Patch Set 43 : Changelogs #

Patch Set 44 : Squashed patch #

Patch Set 45 : Remove SafeBrowsing policy decision #

Patch Set 46 : Removing history code and updating tests #

Patch Set 47 : Finihsed fixing tests #

Patch Set 48 : Remove change to create Navigation for loadAlternateHTML #

Patch Set 49 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1003 lines, -38 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +52 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/ChangeLog View 1 chunk +72 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/WebPreferences.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +12 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 2 chunks +8 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/UIProcess/Cocoa/NavigationState.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 4 chunks +5 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 6 chunks +24 lines, -14 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingContextProvider.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 1 chunk +52 lines, -0 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingContextProvider.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 1 chunk +89 lines, -0 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +92 lines, -0 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +159 lines, -0 lines 0 comments Download
M Source/WebKit/WebKit.xcodeproj/project.pbxproj View 11 chunks +16 lines, -24 lines 0 comments Download
M Tools/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 1 chunk +27 lines, -0 lines 0 comments Download
M Tools/MiniBrowser/MiniBrowser.entitlements View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/AppDelegate.m View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/SettingsController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/SettingsController.m View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 4 chunks +14 lines, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -0 lines 0 comments Download
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 8 chunks +12 lines, -0 lines 0 comments Download
A Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +344 lines, -0 lines 0 comments Download
A Tools/TestWebKitAPI/Tests/WebKitCocoa/redirect-to-unsafe.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +4 lines, -0 lines 0 comments Download
A Tools/TestWebKitAPI/Tests/WebKitCocoa/unsafe-iframe.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b