Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(356)

Issue 339530043: SB prototype

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by ajuma
Modified:
6 days, 13 hours ago
Reviewers:
Visibility:
Public.

Description

SB prototype

Patch Set 1 #

Patch Set 2 : Move logic in SafeBrowsingController #

Patch Set 3 : SafeBrowsingChecks now get created and used #

Patch Set 4 : Now shows a warning #

Patch Set 5 : User bypass of warning works #

Patch Set 6 : WIP #

Patch Set 7 : URLs are displayed correctly #

Patch Set 8 : Store NavigationAction in SafeBrowsingCheck #

Patch Set 9 : Notify delegate of SB failure #

Patch Set 10 : Remove raw pointer to completion handler #

Patch Set 11 : Use embedder decision #

Patch Set 12 : Implement persistence #

Patch Set 13 : Rebased #

Patch Set 14 : Add a WKPreference, and enable it in MiniBrowser #

Patch Set 15 : Guard against SafeBrowserController getting destroyed before callback #

Patch Set 16 : Handle redirects #

Patch Set 17 : Clean up #

Patch Set 18 : Changelogs, and style stuff #

Patch Set 19 : Attempt to fix back/forward navigation #

Patch Set 20 : More fixing of back forward nav #

Patch Set 21 : Update change logs #

Patch Set 22 : Squashed patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -30 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/WebCore/loader/DocumentLoader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/loader/FrameLoadRequest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/FrameLoadRequest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +7 lines, -2 lines 0 comments Download
M Source/WebCore/loader/FrameLoaderTypes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +10 lines, -0 lines 0 comments Download
M Source/WebCore/loader/PolicyChecker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/PolicyChecker.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/ChangeLog View 1 chunk +62 lines, -0 lines 0 comments Download
M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/NetworkProcess/capture/NetworkDataTaskReplay.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/LoadParameters.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/LoadParameters.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/WebPreferences.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +12 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/Cocoa/NavigationState.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +5 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 6 chunks +24 lines, -14 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +98 lines, -0 lines 0 comments Download
A Source/WebKit/UIProcess/Cocoa/SafeBrowsingController.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +204 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/UIProcess/WebPageProxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/UIProcess/WebPageProxy.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +5 lines, -2 lines 0 comments Download
M Source/WebKit/WebKit.xcodeproj/project.pbxproj View 5 chunks +8 lines, -0 lines 0 comments Download
M Source/WebKit/WebProcess/WebPage/WebPage.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/WebProcess/WebPage/WebPage.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +6 lines, -6 lines 0 comments Download
M Tools/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +15 lines, -0 lines 0 comments Download
M Tools/MiniBrowser/MiniBrowser.entitlements View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/AppDelegate.m View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +5 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b