Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12995)

Issue 339480043: [plaso] Added Ubuntu end-to-end tests run script for Jenkins (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by Joachim Metz
Modified:
5 years, 11 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, jberggren
Visibility:
Public.

Description

[plaso] Added Ubuntu end-to-end tests run script for Jenkins

Patch Set 1 : Added Ubuntu end-to-end tests run script for Jenkins #

Total comments: 4

Patch Set 2 : Changes after review #

Total comments: 3

Patch Set 3 : Additional configuration files #

Patch Set 4 : Changes for tests #

Total comments: 8

Patch Set 5 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -2 lines) Patch
M .travis.yml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A config/jenkins/greendale/acserver.ini View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A config/jenkins/greendale/dean_mac.ini View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A config/jenkins/greendale/registrar.ini View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A config/jenkins/greendale/studentpc10.ini View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A config/jenkins/greendale/studentpc8.ini View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A config/jenkins/linux/run_end_to_end_tests.sh View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A config/jenkins/travis.ini View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M config/travis/install.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M config/travis/runtests.sh View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 25
Joachim Metz
6 years ago (2018-03-31 09:56:22 UTC) #1
Joachim Metz
Code updated.
6 years ago (2018-03-31 10:05:16 UTC) #2
onager
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh File config/jenkins/linux/run_end_to_end_tests.sh (right): https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11 config/jenkins/linux/run_end_to_end_tests.sh:11: LOGGING_OPTIONS="--debug --log-file=${RESULTS_DIRECTORY}/log2timeline.log.gz"; Please remove, these need to be set ...
6 years ago (2018-03-31 10:53:31 UTC) #3
Joachim Metz
https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh File config/jenkins/linux/run_end_to_end_tests.sh (right): https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11 config/jenkins/linux/run_end_to_end_tests.sh:11: LOGGING_OPTIONS="--debug --log-file=${RESULTS_DIRECTORY}/log2timeline.log.gz"; this way you don't need to keep ...
6 years ago (2018-03-31 10:57:17 UTC) #4
justzamir
On 2018/03/31 10:57:17, Joachim Metz wrote: > https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh > File config/jenkins/linux/run_end_to_end_tests.sh (right): > > https://codereview.appspot.com/339480043/diff/20001/config/jenkins/linux/run_end_to_end_tests.sh#newcode11 ...
6 years ago (2018-03-31 11:05:35 UTC) #5
Joachim Metz
What about having the configs (at the greendale ones) checked into git as well ? ...
6 years ago (2018-04-02 07:27:01 UTC) #6
Joachim Metz
Code updated.
6 years ago (2018-04-02 07:52:44 UTC) #7
Joachim Metz
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini File config/jenkins/greendale/dean.ini (right): https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1 config/jenkins/greendale/dean.ini:1: [dean] I opt we check in the greendale configs ...
6 years ago (2018-04-02 07:56:45 UTC) #8
Joachim Metz
Code updated.
6 years ago (2018-04-02 10:46:23 UTC) #9
Joachim Metz
Code updated.
6 years ago (2018-04-02 10:54:36 UTC) #10
Joachim Metz
Code updated.
6 years ago (2018-04-02 16:06:28 UTC) #11
Joachim Metz
Code updated.
6 years ago (2018-04-06 04:53:40 UTC) #12
onager
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini File config/jenkins/greendale/dean.ini (right): https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1 config/jenkins/greendale/dean.ini:1: [dean] On 2018/04/02 07:56:45, Joachim Metz wrote: > I ...
6 years ago (2018-04-07 13:27:00 UTC) #13
onager
6 years ago (2018-04-07 13:27:01 UTC) #14
onager
6 years ago (2018-04-07 13:27:02 UTC) #15
Joachim Metz
https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini File config/jenkins/greendale/dean.ini (right): https://codereview.appspot.com/339480043/diff/40001/config/jenkins/greendale/dean.ini#newcode1 config/jenkins/greendale/dean.ini:1: [dean] Then I'll add the rest of the configs ...
6 years ago (2018-04-07 15:53:53 UTC) #16
Joachim Metz
Code updated.
6 years ago (2018-04-07 17:21:26 UTC) #17
Joachim Metz
Code updated.
6 years ago (2018-04-19 13:52:07 UTC) #18
Joachim Metz
Code updated.
6 years ago (2018-04-20 07:44:34 UTC) #19
Joachim Metz
Code updated.
5 years, 11 months ago (2018-05-05 09:01:05 UTC) #20
onager
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini File config/jenkins/greendale/acserver.ini (right): https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini#newcode8 config/jenkins/greendale/acserver.ini:8: profiling_options=--profilers=memory,parsers,processing,serializers,storage,task_queue --profiling_directory=plaso_out/profiling Please put the the profiling files in ...
5 years, 11 months ago (2018-05-06 09:39:58 UTC) #21
Joachim Metz
https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini File config/jenkins/greendale/acserver.ini (right): https://codereview.appspot.com/339480043/diff/200001/config/jenkins/greendale/acserver.ini#newcode8 config/jenkins/greendale/acserver.ini:8: profiling_options=--profilers=memory,parsers,processing,serializers,storage,task_queue --profiling_directory=plaso_out/profiling please document this in l2tdocs or equiv, ...
5 years, 11 months ago (2018-05-07 05:36:00 UTC) #22
Joachim Metz
Code updated.
5 years, 11 months ago (2018-05-07 05:40:46 UTC) #23
onager
LGTM
5 years, 11 months ago (2018-05-10 08:16:06 UTC) #24
Joachim Metz
5 years, 11 months ago (2018-05-10 09:09:54 UTC) #25
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close jenkins
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b