Issue 339390043: Regtest for event functions from incomplete text events

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 339390043: Regtest for event functions from incomplete text events

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by dak

Modified:
6 years, 1 month ago

Reviewers:
thomasmorley651

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Regtest for event functions from incomplete text events

Patch Set 2 : Doc string syntax fix #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	A	input/regression/textetc.ly	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thomasmorley651

LGTM A nit below https://codereview.appspot.com/339390043/diff/1/input/regression/textetc.ly File input/regression/textetc.ly (right): https://codereview.appspot.com/339390043/diff/1/input/regression/textetc.ly#newcode5 input/regression/textetc.ly:5: event functions for \\samp{TextScript} events ...

6 years, 1 month ago (2018-03-20 20:27:36 UTC) #1

dak

6 years, 1 month ago (2018-03-20 20:47:49 UTC) #3

https://codereview.appspot.com/339390043/diff/1/input/regression/textetc.ly
File input/regression/textetc.ly (right):

https://codereview.appspot.com/339390043/diff/1/input/regression/textetc.ly#n...
input/regression/textetc.ly:5: event functions for \\samp{TextScript} events
with sequences
On 2018/03/20 20:27:36, thomasmorley651 wrote:
> Should that be:
> @samp{TextScript}
> ?

Acknowledged.

Same with \\code.  I'd not upload just for that triviality but I am afraid that
this will kill "make doc".

Expand All Messages | Collapse All Messages