Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 339350043: Use convert -strip

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by bmwiedemann
Modified:
3 months, 2 weeks ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use convert -strip to not add timestamps to .png output files to make build reproducible See https://reproducible-builds.org/ for why this is good. Without this patch, files in the openSUSE lilypond-doc package would differ for every build: /usr/share/doc/packages/lilypond/Documentation/pictures/baer-flat-bw.png /usr/share/doc/packages/lilypond/Documentation/pictures/baer-flat-gray.png /usr/share/doc/packages/lilypond/Documentation/pictures/henle-flat-bw.png ...

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Documentation/pictures/GNUmakefile View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 5
dulow kotic
3 months, 3 weeks ago (2018-05-29 07:20:04 UTC) #1
dulow kotic
On 2018/05/29 07:20:04, dulow kotic wrote:
3 months, 3 weeks ago (2018-05-29 07:20:14 UTC) #2
lilypond-pkx
On 2018/05/29 07:20:14, dulow kotic wrote: > On 2018/05/29 07:20:04, dulow kotic wrote: Does this ...
3 months, 2 weeks ago (2018-06-02 17:51:17 UTC) #3
Dan Eble
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile File Documentation/pictures/GNUmakefile (right): https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile#newcode29 Documentation/pictures/GNUmakefile:29: convert -strip -depth 8 -geometry 50x50% $< $@ It ...
3 months, 2 weeks ago (2018-06-02 19:29:16 UTC) #4
bmwiedemann
3 months, 2 weeks ago (2018-06-03 13:04:40 UTC) #5
On 2018/06/02 19:29:16, Dan Eble wrote:
>
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmak...
> File Documentation/pictures/GNUmakefile (right):
> 
>
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmak...
> Documentation/pictures/GNUmakefile:29: convert -strip -depth 8 -geometry
50x50%
> $< $@
> It would be wise to add a brief comment before the dependency line explaining
> why -strip is important, otherwise someone might come along later, decide that
> it is pointless, and remove it.
> 
> Are there any undesirable side effects of -strip, for example, removing a
> copyright notice?  The man page says that -strip "strip[s the] image of all
> profiles and comments" but I'm not familiar enough with convert to know what
> that means.  Are profiles also unimportant here?

Not sure why the tools didnt show it, but this was handled in
https://sourceforge.net/p/testlilyissues/issues/5290/
and merged as commit d1d5f436a190929e38145cf8be7d4fa63b077b46

IMHO, git blame is usually a good tool to find out on why something was added

and I don't think -strip removes important information in this case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b