Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6002)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 339120043: [plaso] Deprecated use of FromPythonDatetime function in favor of dfdatetime (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Joachim Metz
Modified:
6 years, 3 months ago
Reviewers:
aaronp, onager
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Deprecated use of FromPythonDatetime function in favor of dfdatetime

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes after review #

Total comments: 2

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -129 lines) Patch
M plaso/containers/time_events.py View 1 2 chunks +33 lines, -0 lines 0 comments Download
M plaso/parsers/hachoir.py View 1 5 chunks +22 lines, -20 lines 0 comments Download
M plaso/parsers/plist_plugins/airport.py View 1 2 chunks +3 lines, -7 lines 0 comments Download
M plaso/parsers/plist_plugins/appleaccount.py View 1 4 chunks +6 lines, -18 lines 0 comments Download
M plaso/parsers/plist_plugins/bluetooth.py View 1 4 chunks +9 lines, -23 lines 0 comments Download
M plaso/parsers/plist_plugins/default.py View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M plaso/parsers/plist_plugins/install_history.py View 1 2 chunks +2 lines, -8 lines 0 comments Download
M plaso/parsers/plist_plugins/ipod.py View 1 3 chunks +4 lines, -6 lines 0 comments Download
M plaso/parsers/plist_plugins/softwareupdate.py View 1 3 chunks +4 lines, -13 lines 0 comments Download
M plaso/parsers/plist_plugins/spotlight.py View 1 2 chunks +2 lines, -8 lines 0 comments Download
M plaso/parsers/plist_plugins/spotlight_volume.py View 1 2 chunks +2 lines, -8 lines 0 comments Download
M plaso/parsers/plist_plugins/timemachine.py View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8
Joachim Metz
6 years, 3 months ago (2017-12-30 11:21:53 UTC) #1
onager
https://codereview.appspot.com/339120043/diff/1/plaso/parsers/plist_plugins/airport.py File plaso/parsers/plist_plugins/airport.py (right): https://codereview.appspot.com/339120043/diff/1/plaso/parsers/plist_plugins/airport.py#newcode50 plaso/parsers/plist_plugins/airport.py:50: year, month, day_of_month, hours, minutes, seconds, _, _, _ ...
6 years, 3 months ago (2018-01-11 13:02:44 UTC) #2
Joachim Metz
https://codereview.appspot.com/339120043/diff/1/plaso/parsers/plist_plugins/airport.py File plaso/parsers/plist_plugins/airport.py (right): https://codereview.appspot.com/339120043/diff/1/plaso/parsers/plist_plugins/airport.py#newcode50 plaso/parsers/plist_plugins/airport.py:50: year, month, day_of_month, hours, minutes, seconds, _, _, _ ...
6 years, 3 months ago (2018-01-15 06:31:50 UTC) #3
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-15 06:41:06 UTC) #4
onager
Just missed one - LGTM https://codereview.appspot.com/339120043/diff/20001/plaso/parsers/plist_plugins/default.py File plaso/parsers/plist_plugins/default.py (right): https://codereview.appspot.com/339120043/diff/20001/plaso/parsers/plist_plugins/default.py#newcode41 plaso/parsers/plist_plugins/default.py:41: year, month, day_of_month, hours, ...
6 years, 3 months ago (2018-01-15 20:18:17 UTC) #5
Joachim Metz
https://codereview.appspot.com/339120043/diff/20001/plaso/parsers/plist_plugins/default.py File plaso/parsers/plist_plugins/default.py (right): https://codereview.appspot.com/339120043/diff/20001/plaso/parsers/plist_plugins/default.py#newcode41 plaso/parsers/plist_plugins/default.py:41: year, month, day_of_month, hours, minutes, seconds, _, _, _ ...
6 years, 3 months ago (2018-01-15 20:25:48 UTC) #6
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-15 20:30:41 UTC) #7
Joachim Metz
6 years, 3 months ago (2018-01-16 06:40:22 UTC) #8 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close datetime2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b