Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(392)

Issue 339010043: Created table RIB that holds all path information, regardless if used for routing or not. FIB is a …

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by Michail.Xirouchakis
Modified:
2 months, 1 week ago
CC:
sdnik2200ht17_ict.kth.se;
Visibility:
Public.

Description

Created table RIB that holds all path information, regardless if used for routing or not. FIB is a subset of RIB. The reason for this change is that finding all paths between two edge switches is too CPU intensive. So I just run it once and keep all the paths in RIB. For each pair of switches, the path with the lowest metric is copied from RIB to FIB. When trying to forward the packet, only the FIB is checked. BUG=

Patch Set 1 #

Total comments: 13

Patch Set 2 : Mininet Tests, CPM ignore pkt flood #

Patch Set 3 : Added flow rule timeout. Added HUM metric for Admission Control. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1258 lines, -178 lines) Patch
M cpm/cpm_13.py View 1 2 8 chunks +489 lines, -177 lines 0 comments Download
A cpm/cpm_13_lib.py View 1 1 chunk +81 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-1-csd View 1 chunk +19 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-11-csd View 1 1 chunk +378 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-12-csd View 1 1 chunk +188 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-2-csd View 1 chunk +16 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-3-csd View 1 chunk +9 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-4-csd View 1 chunk +16 lines, -0 lines 0 comments Download
A mininet_testing/test-topo-5-csd View 1 chunk +26 lines, -0 lines 0 comments Download
A mininet_testing/topo_eval.py View 1 chunk +33 lines, -0 lines 0 comments Download
A mininet_testing/topo_neighbors.txt.1 View 1 chunk +1 line, -0 lines 0 comments Download
M nfm/nfm_13.py View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8
Michail.Xirouchakis
2 months, 3 weeks ago (2017-12-03 16:43:03 UTC) #1
younes.tahri3
https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13_lib.py File cpm/cpm_13_lib.py (right): https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13_lib.py#newcode48 cpm/cpm_13_lib.py:48: if path[0] == sw_a and path[-1] == sw_z and ...
2 months, 3 weeks ago (2017-12-04 18:37:37 UTC) #2
younes.tahri3
https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13.py File cpm/cpm_13.py (right): https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13.py#newcode45 cpm/cpm_13.py:45: self.port_counters_snapshot = {'object_index': 1000, 'switches': []} what is this ...
2 months, 3 weeks ago (2017-12-04 20:38:27 UTC) #3
Michail.Xirouchakis
Hello Younes and thank you for your comments. Find my answers inline. On 2017/12/04 20:38:27, ...
2 months, 2 weeks ago (2017-12-05 12:46:10 UTC) #4
Vasileios Papageorgiou
Hi Michael, I made some comments on cpm_13_lib.py BR, Vasileios Papageorgiou https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13_lib.py File cpm/cpm_13_lib.py (right): ...
2 months, 2 weeks ago (2017-12-06 14:27:55 UTC) #5
Vasileios Papageorgiou
Hi, Check my comment! BR, Vasilis https://codereview.appspot.com/339010043/diff/1/mininet_testing/topo_neighbors.txt.1 File mininet_testing/topo_neighbors.txt.1 (right): https://codereview.appspot.com/339010043/diff/1/mininet_testing/topo_neighbors.txt.1#newcode1 mininet_testing/topo_neighbors.txt.1:1: {"301": [209, 204, ...
2 months, 2 weeks ago (2017-12-06 14:36:41 UTC) #6
Vasileios Papageorgiou
Hi, Some comments for test-topo-5-csd BR, Vasilis https://codereview.appspot.com/339010043/diff/1/mininet_testing/test-topo-5-csd File mininet_testing/test-topo-5-csd (right): https://codereview.appspot.com/339010043/diff/1/mininet_testing/test-topo-5-csd#newcode6 mininet_testing/test-topo-5-csd:6: py "[TEST-5] ...
2 months, 2 weeks ago (2017-12-06 14:41:28 UTC) #7
Vasileios Papageorgiou
2 months, 2 weeks ago (2017-12-06 14:48:33 UTC) #8
Hi,

Comments on cpm_13.py


BR,

Vasilis

https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13.py
File cpm/cpm_13.py (right):

https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13.py#newcode154
cpm/cpm_13.py:154: priority = 200
On 2017/12/04 20:38:27, younes.tahri3 wrote:
> These values should be changed right?
> So that they match the values that we used for admission control

I think these values have to do with ipv4 packet header and not at all with
admission control.

https://codereview.appspot.com/339010043/diff/1/cpm/cpm_13.py#newcode159
cpm/cpm_13.py:159: priority = 400
This OF priority not any connection with admission control priorities.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d