Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Unified Diff: src/lte/model/lte-ffr-soft-algorithm.cc

Issue 338840043: Eliminate Visual Studio compiler warnings (Closed)
Patch Set: Update patch with latest module changes. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/lte/model/lte-ffr-soft-algorithm.cc
===================================================================
--- a/src/lte/model/lte-ffr-soft-algorithm.cc
+++ b/src/lte/model/lte-ffr-soft-algorithm.cc
@@ -280,6 +280,7 @@
LteFfrSoftAlgorithm::SetDownlinkConfiguration (uint16_t cellId, uint8_t bandwidth)
{
NS_LOG_FUNCTION (this);
+ NS_UNUSED (bandwidth);
for (uint16_t i = 0; i < NUM_DOWNLINK_CONFS; ++i)
{
if ((g_ffrSoftDownlinkDefaultConfiguration[i].cellId == cellId)
@@ -296,6 +297,7 @@
LteFfrSoftAlgorithm::SetUplinkConfiguration (uint16_t cellId, uint8_t bandwidth)
{
NS_LOG_FUNCTION (this);
+ NS_UNUSED (bandwidth);
for (uint16_t i = 0; i < NUM_UPLINK_CONFS; ++i)
{
if ((g_ffrSoftUplinkDefaultConfiguration[i].cellId == cellId)
@@ -337,8 +339,8 @@
m_dlCenterRbgMap[i] = false;
}
- for (uint8_t i = (m_dlCommonSubBandwidth + m_dlEdgeSubBandOffset) / rbgSize;
- i < (m_dlCommonSubBandwidth + m_dlEdgeSubBandOffset + m_dlEdgeSubBandwidth) / rbgSize; i++)
+ for (uint8_t i = static_cast<uint8_t> ((m_dlCommonSubBandwidth + m_dlEdgeSubBandOffset) / rbgSize);
+ i < static_cast<uint8_t> ((m_dlCommonSubBandwidth + m_dlEdgeSubBandOffset + m_dlEdgeSubBandwidth) / rbgSize); i++)
Biljana Bojović 2018/08/22 11:35:29 If possible change all bandwidth types to uint8_t
{
m_dlEdgeRbgMap[i] = true;
m_dlCenterRbgMap[i] = false;
@@ -511,6 +513,7 @@
{
NS_LOG_FUNCTION (this);
NS_LOG_WARN ("Method should not be called, because it is empty");
+ NS_UNUSED (params);
}
void
@@ -518,6 +521,7 @@
{
NS_LOG_FUNCTION (this);
NS_LOG_WARN ("Method should not be called, because it is empty");
+ NS_UNUSED (params);
}
void

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b