Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 338840043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by ammo6818-vandals.uidaho.edu
Modified:
4 weeks ago
Reviewers:
bbojovic, mmiozzo, biljana.bojovic, manuel.requena
CC:
lorenza.giupponi_cttc.es, Tom Henderson, zorazeali
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Additional updates #

Patch Set 3 : Updates to use C++ style type casts #

Patch Set 4 : Updates to patch for latest module changes #

Patch Set 5 : Updates to patch set to eliminate some casts #

Patch Set 6 : Patch updates for x64 build #

Patch Set 7 : Update patch for coding style requirements #

Patch Set 8 : Update patch with latest module changes. #

Total comments: 33
Unified diffs Side-by-side diffs Delta from patch set Stats (+1351 lines, -1125 lines) Patch
M src/lte/examples/lena-deactivate-bearer.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-distributed-ffr.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/examples/lena-dual-stripe.cc View 1 2 3 4 5 6 4 chunks +17 lines, -17 lines 0 comments Download
M src/lte/examples/lena-profiling.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-simple-epc.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/examples/lena-simple-epc-emu.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/helper/cc-helper.h View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M src/lte/helper/cc-helper.cc View 1 2 3 4 5 6 6 chunks +10 lines, -10 lines 0 comments Download
M src/lte/helper/emu-epc-helper.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/helper/lte-global-pathloss-database.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/helper/lte-helper.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -6 lines 0 comments Download
M src/lte/helper/lte-hex-grid-enb-topology-helper.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/helper/point-to-point-epc-helper.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 1 comment Download
M src/lte/helper/radio-bearer-stats-calculator.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M src/lte/helper/radio-bearer-stats-connector.cc View 1 2 3 4 5 6 5 chunks +9 lines, -0 lines 0 comments Download
M src/lte/helper/radio-environment-map-helper.h View 1 2 3 4 1 chunk +2 lines, -2 lines 1 comment Download
M src/lte/helper/radio-environment-map-helper.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/a3-rsrp-handover-algorithm.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/component-carrier.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/component-carrier.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/cqa-ff-mac-scheduler.cc View 1 2 3 4 5 6 32 chunks +52 lines, -45 lines 1 comment Download
M src/lte/model/epc-enb-application.cc View 1 2 3 4 5 6 5 chunks +6 lines, -1 line 2 comments Download
M src/lte/model/epc-gtpu-header.cc View 1 2 3 4 5 6 2 chunks +23 lines, -23 lines 0 comments Download
M src/lte/model/epc-mme.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M src/lte/model/epc-sgw-pgw-application.cc View 1 2 3 4 5 6 5 chunks +5 lines, -4 lines 0 comments Download
M src/lte/model/epc-tft-classifier.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 1 comment Download
M src/lte/model/epc-ue-nas.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/epc-x2.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 1 comment Download
M src/lte/model/epc-x2-header.h View 1 2 3 4 5 6 7 9 chunks +32 lines, -32 lines 0 comments Download
M src/lte/model/epc-x2-header.cc View 1 2 3 4 5 6 24 chunks +76 lines, -71 lines 1 comment Download
M src/lte/model/fdbet-ff-mac-scheduler.cc View 1 2 3 4 5 6 16 chunks +25 lines, -23 lines 0 comments Download
M src/lte/model/fdmt-ff-mac-scheduler.cc View 1 2 3 4 5 6 15 chunks +20 lines, -16 lines 0 comments Download
M src/lte/model/fdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 6 26 chunks +34 lines, -30 lines 0 comments Download
M src/lte/model/lte-amc.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 1 comment Download
M src/lte/model/lte-amc.cc View 1 2 3 4 5 6 5 chunks +8 lines, -6 lines 2 comments Download
M src/lte/model/lte-asn1-header.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-asn1-header.cc View 1 2 3 4 5 6 5 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-ccm-rrc-sap.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M src/lte/model/lte-common.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/lte-enb-mac.cc View 1 2 3 4 5 6 7 chunks +14 lines, -14 lines 1 comment Download
M src/lte/model/lte-enb-net-device.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 1 comment Download
M src/lte/model/lte-enb-phy.cc View 1 2 3 4 5 6 9 chunks +13 lines, -11 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 1 2 3 4 5 6 23 chunks +39 lines, -32 lines 1 comment Download
M src/lte/model/lte-ffr-distributed-algorithm.cc View 1 2 3 4 5 6 6 chunks +18 lines, -13 lines 1 comment Download
M src/lte/model/lte-ffr-enhanced-algorithm.cc View 1 2 3 4 5 6 10 chunks +19 lines, -17 lines 0 comments Download
M src/lte/model/lte-ffr-soft-algorithm.cc View 1 2 3 4 5 6 5 chunks +6 lines, -2 lines 1 comment Download
M src/lte/model/lte-fr-hard-algorithm.cc View 1 2 3 4 5 6 8 chunks +8 lines, -1 line 0 comments Download
M src/lte/model/lte-fr-no-op-algorithm.cc View 1 2 3 4 5 6 5 chunks +7 lines, -0 lines 0 comments Download
M src/lte/model/lte-fr-soft-algorithm.cc View 1 2 3 4 5 6 5 chunks +6 lines, -2 lines 0 comments Download
M src/lte/model/lte-fr-strict-algorithm.cc View 1 2 3 4 5 6 5 chunks +6 lines, -2 lines 1 comment Download
M src/lte/model/lte-harq-phy.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/model/lte-mi-error-model.h View 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/lte/model/lte-mi-error-model.cc View 1 2 3 4 5 6 7 9 chunks +14 lines, -14 lines 0 comments Download
M src/lte/model/lte-net-device.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M src/lte/model/lte-rlc.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M src/lte/model/lte-rlc-am.cc View 1 2 3 4 5 6 9 chunks +13 lines, -6 lines 1 comment Download
M src/lte/model/lte-rlc-am-header.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-rlc-tm.cc View 1 2 3 4 5 6 3 chunks +5 lines, -1 line 0 comments Download
M src/lte/model/lte-rlc-um.cc View 1 2 3 4 5 6 4 chunks +7 lines, -3 lines 0 comments Download
M src/lte/model/lte-rrc-header.cc View 1 2 3 4 5 6 7 67 chunks +106 lines, -106 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.cc View 1 2 3 4 5 6 3 chunks +3 lines, -1 line 0 comments Download
M src/lte/model/lte-rrc-protocol-real.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-spectrum-value-helper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-spectrum-value-helper.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 1 comment Download
M src/lte/model/lte-ue-mac.cc View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 1 comment Download
M src/lte/model/lte-ue-phy.cc View 1 2 3 4 5 6 14 chunks +21 lines, -16 lines 0 comments Download
M src/lte/model/lte-ue-power-control.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 1 2 3 4 5 6 7 6 chunks +16 lines, -10 lines 0 comments Download
M src/lte/model/no-op-component-carrier-manager.cc View 1 2 3 4 5 6 9 chunks +10 lines, -7 lines 1 comment Download
M src/lte/model/pf-ff-mac-scheduler.cc View 1 2 3 4 5 6 19 chunks +24 lines, -20 lines 0 comments Download
M src/lte/model/pss-ff-mac-scheduler.cc View 1 2 3 4 5 6 26 chunks +36 lines, -34 lines 0 comments Download
M src/lte/model/rr-ff-mac-scheduler.cc View 1 2 3 4 5 6 16 chunks +19 lines, -15 lines 0 comments Download
M src/lte/model/simple-ue-component-carrier-manager.cc View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M src/lte/model/tdbet-ff-mac-scheduler.cc View 1 2 3 4 5 6 16 chunks +21 lines, -18 lines 0 comments Download
M src/lte/model/tdmt-ff-mac-scheduler.cc View 1 2 3 4 5 6 16 chunks +21 lines, -17 lines 0 comments Download
M src/lte/model/tdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 6 19 chunks +26 lines, -22 lines 0 comments Download
M src/lte/model/trace-fading-loss-model.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/tta-ff-mac-scheduler.cc View 1 2 3 4 5 6 15 chunks +20 lines, -16 lines 0 comments Download
M src/lte/test/epc-test-s1u-downlink.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/epc-test-s1u-uplink.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-ffr-simple.cc View 1 2 3 4 5 6 5 chunks +9 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-carrier-aggregation.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-carrier-aggregation.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-cell-selection.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-cqa-ff-mac-scheduler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-cqi-generation.cc View 1 2 3 4 5 6 4 chunks +10 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-deactivate-bearer.cc View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-downlink-power-control.cc View 1 2 3 4 5 6 3 chunks +8 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-downlink-sinr.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-entities.cc View 1 2 3 4 5 6 5 chunks +8 lines, -8 lines 0 comments Download
M src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-frequency-reuse.cc View 2 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-harq.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-interference.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-interference-fr.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-link-adaptation.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-mimo.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-pathloss-model.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 1 comment Download
M src/lte/test/lte-test-pf-ff-mac-scheduler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 1 comment Download
M src/lte/test/lte-test-phy-error-model.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-pss-ff-mac-scheduler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 1 comment Download
M src/lte/test/lte-test-secondary-cell-selection.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-spectrum-value-helper.cc View 2 5 6 12 chunks +257 lines, -257 lines 0 comments Download
M src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 1 comment Download
M src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 1 comment Download
M src/lte/test/lte-test-ue-measurements.cc View 1 2 3 4 5 6 8 chunks +13 lines, -3 lines 5 comments Download
M src/lte/test/lte-test-ue-phy.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-uplink-sinr.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/test/test-epc-tft-classifier.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/test-lte-epc-e2e-data.cc View 1 2 3 4 5 6 4 chunks +7 lines, -7 lines 0 comments Download
M src/lte/test/test-lte-handover-delay.cc View 1 2 3 4 5 6 4 chunks +14 lines, -0 lines 0 comments Download
M src/lte/test/test-lte-rrc.cc View 1 2 3 4 5 6 5 chunks +9 lines, -7 lines 1 comment Download
M src/lte/test/test-lte-x2-handover.cc View 1 2 3 4 5 6 4 chunks +11 lines, -11 lines 0 comments Download
M src/lte/test/test-lte-x2-handover-measures.cc View 1 2 3 4 5 6 4 chunks +10 lines, -10 lines 1 comment Download

Messages

Total messages: 2
ammo6818-vandals.uidaho.edu
Patch updated with latest module changes
6 months, 1 week ago (2018-03-15 00:12:22 UTC) #1
Biljana Bojović
4 weeks ago (2018-08-22 11:35:30 UTC) #2
Hi Robert, 

please find below my comments. You did a great work! There are some minor
details that in my opinion should be changed. 

General comments are:
1. I prefer to change variable type over static casts in code
2. When changing type, the variable that represents the same thing over
different parts of the code, e.g. bandwidth should be always of the same size,
e.g. uint8_t
3. Instead of making silent NS_ASSERTs I would convert it to analog NS_ABBORT.

If you have any doubt regarding comments please do not hesitate to contact me.

Best regards,

Biljana

https://codereview.appspot.com/338840043/diff/160001/src/lte/helper/point-to-...
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/helper/point-to-...
src/lte/helper/point-to-point-epc-helper.cc:92: (void)retval; // make compiler
happy
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/helper/radio-env...
File src/lte/helper/radio-environment-map-helper.h (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/helper/radio-env...
src/lte/helper/radio-environment-map-helper.h:64: uint16_t GetBandwidth ()
const;
I would try to stick with uint8_t, so that everywhere in the code is consistent.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/cqa-ff-mac...
File src/lte/model/cqa-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/cqa-ff-mac...
src/lte/model/cqa-ff-mac-scheduler.cc:943: uint8_t rbgId = static_cast<uint8_t>
((dciRbg.at (dciRbg.size () - 1) + 1) % numberOfRBGs);
I think that we should change type of elemtn of vector dciRbg to be uint8_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-enb-ap...
File src/lte/model/epc-enb-application.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-enb-ap...
src/lte/model/epc-enb-application.cc:270: (void)found; // make compiler happy
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-enb-ap...
src/lte/model/epc-enb-application.cc:331: (void)sentBytes; // make compiler
happy
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-tft-cl...
File src/lte/model/epc-tft-classifier.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-tft-cl...
src/lte/model/epc-tft-classifier.cc:197: 
If possible I would prefer to change type of variable then performing cast

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-x2-hea...
File src/lte/model/epc-x2-header.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-x2-hea...
src/lte/model/epc-x2-header.cc:1138: std::vector
<EpcX2Sap::CellInformationItem>::size_type sz = m_cellInformationList.size ();
In general I prefer using word if it is not too long than the abbreviation. In
this case I would put "size" intead of "sz".

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-x2.cc
File src/lte/model/epc-x2.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/epc-x2.cc#...
src/lte/model/epc-x2.cc:755: NS_LOG_INFO ("GTP-U header: " << gtpu);
Again, if possible I would prefer that we change the size of length then to
perform cast. I see it as more clean solution.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.cc
File src/lte/model/lte-amc.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.cc...
src/lte/model/lte-amc.cc:306: int
uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.cc
File src/lte/model/lte-amc.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.cc...
src/lte/model/lte-amc.cc:294: uint16_t
uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.h
File src/lte/model/lte-amc.h (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-amc.h#...
src/lte/model/lte-amc.h:84: uint16_t GetDlTbSizeFromMcs (int mcs, int nprb);
Please check if this is really necessary? I think that it should be at least
uint32_t to allow the maximum TB size by the LTE specification. The function
comment says that the TB is in bits, so I think that it should be 32...

https://www.etsi.org/deliver/etsi_ts/136200_136299/136213/12.03.00_60/ts_1362...

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-ma...
File src/lte/model/lte-enb-mac.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-ma...
src/lte/model/lte-enb-mac.cc:1142: rar.rapId = static_cast<uint8_t>
(itRapId->second);
Please, double check if this conversion from 32 to 8 is correct.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-ne...
File src/lte/model/lte-enb-net-device.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-ne...
src/lte/model/lte-enb-net-device.cc:329: LteEnbNetDevice::SetCsgId (uint32_t
csgId)
We should change input parameter to uint16_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-rr...
File src/lte/model/lte-enb-rrc.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-enb-rr...
src/lte/model/lte-enb-rrc.cc:605:
hpi.asConfig.sourceMasterInformationBlock.dlBandwidth = m_rrc->m_dlBandwidth;
Change type of m_ulBandwidth and m_dlBandwidth to uint8_t to have consistent
definitions and usage.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ffr-di...
File src/lte/model/lte-ffr-distributed-algorithm.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ffr-di...
src/lte/model/lte-ffr-distributed-algorithm.cc:490: uint16_t rbgSize =
static_cast<uint16_t> (GetRbgSize (m_dlBandwidth));
Change rbgSize to correct type instead of performing cast.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ffr-so...
File src/lte/model/lte-ffr-soft-algorithm.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ffr-so...
src/lte/model/lte-ffr-soft-algorithm.cc:343: i < static_cast<uint8_t>
((m_dlCommonSubBandwidth + m_dlEdgeSubBandOffset + m_dlEdgeSubBandwidth) /
rbgSize); i++)
If possible change all bandwidth types to uint8_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-fr-str...
File src/lte/model/lte-fr-strict-algorithm.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-fr-str...
src/lte/model/lte-fr-strict-algorithm.cc:318: + m_dlEdgeSubBandwidth / rbgSize);
i++)
change bandwidth type instead of cast

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-rlc-am.cc
File src/lte/model/lte-rlc-am.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-rlc-am...
src/lte/model/lte-rlc-am.cc:1660: (void)firstVrMs; // make compier happy
I would change NS_ASSERT_MSG to NS_ABORT_MSG_UNLESS so this line would be
available in all builds, so I do not think that compiler would complain.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-spectr...
File src/lte/model/lte-spectrum-value-helper.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-spectr...
src/lte/model/lte-spectrum-value-helper.cc:212: uint16_t  bandwidth; ///<
bandwidth
We should definitively decide and be consistent which size will have bandwidth.
This seems that is currently limited by RRC serialization messages, which assume
that the bandwidth is 8 bit integer. So, I would try to stick to this.

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ue-mac.cc
File src/lte/model/lte-ue-mac.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/lte-ue-mac...
src/lte/model/lte-ue-mac.cc:530: (void)prachMask; // make compiler happy
Again,  I would change this to NS_ABORT_MSG_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/no-op-comp...
File src/lte/model/no-op-component-carrier-manager.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/model/no-op-comp...
src/lte/model/no-op-component-carrier-manager.cc:476: (void)componentCarrierId;
// make compiler happy
NS_ABORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-pa...
File src/lte/test/lte-test-pathloss-model.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-pa...
src/lte/test/lte-test-pathloss-model.cc:163: }
I prefer that we change the parameter of LtePathlossModelStystemTestCase to
uint8_ instead of performing conversion

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-pf...
File src/lte/test/lte-test-pf-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-pf...
src/lte/test/lte-test-pf-ff-mac-scheduler.cc:374: : TestCase (BuildNameString
(static_cast<uint16_t> (dist.size ()), dist)),
I prefer that we change the type of BuildNameString to uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ps...
File src/lte/test/lte-test-pss-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ps...
src/lte/test/lte-test-pss-ff-mac-scheduler.cc:498: m_nUser
(static_cast<uint16_t> (dist.size ())),
I would rather change type of m_nUser to uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-td...
File src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-td...
src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc:359: m_nUser
(static_cast<uint16_t> (dist.size ())),
m_nUser to uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-td...
File src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-td...
src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc:497: m_nUser
(static_cast<uint16_t> (dist.size ())),
m_nUser to uint32_t

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
File src/lte/test/lte-test-ue-measurements.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
src/lte/test/lte-test-ue-measurements.cc:671: NS_ASSERT (rnti == 1);
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
src/lte/test/lte-test-ue-measurements.cc:673: 
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
src/lte/test/lte-test-ue-measurements.cc:1261: NS_ASSERT (rnti == 1);
NS_ABORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
src/lte/test/lte-test-ue-measurements.cc:1262: NS_ASSERT (cellId == 1);
NS_ABBORT_UNLESS

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/lte-test-ue...
src/lte/test/lte-test-ue-measurements.cc:1666: 
Can size be changed to uint32_t to avoid so many static  casts?

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/test-lte-rr...
File src/lte/test/test-lte-rrc.cc (right):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/test-lte-rr...
src/lte/test/test-lte-rrc.cc:443: uint8_t ueDlEarfcn = static_cast<uint8_t>
(ueRrc->GetDlEarfcn ());
Is it possible to define here ueDlEarfcn with the correct uint type to avoid
cast?

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/test-lte-x2...
File src/lte/test/test-lte-x2-handover-measures.cc (left):

https://codereview.appspot.com/338840043/diff/160001/src/lte/test/test-lte-x2...
src/lte/test/test-lte-x2-handover-measures.cc:595: uint8_t ueUlEarfcn =
ueRrc->GetUlEarfcn ();
Again, is it possible to declare these variable with the correct uint type?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b