Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(949)

Issue 338840043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by ammo6818-vandals.uidaho.edu
Modified:
1 month, 1 week ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Additional updates #

Patch Set 3 : Updates to use C++ style type casts #

Patch Set 4 : Updates to patch for latest module changes #

Patch Set 5 : Updates to patch set to eliminate some casts #

Patch Set 6 : Patch updates for x64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1624 lines, -1433 lines) Patch
M src/lte/examples/lena-deactivate-bearer.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/examples/lena-distributed-ffr.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/examples/lena-dual-stripe.cc View 1 2 3 4 5 chunks +21 lines, -19 lines 0 comments Download
M src/lte/helper/cc-helper.h View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M src/lte/helper/cc-helper.cc View 1 2 3 4 6 chunks +10 lines, -10 lines 0 comments Download
M src/lte/helper/emu-epc-helper.cc View 2 2 chunks +1 line, -2 lines 0 comments Download
M src/lte/helper/lte-global-pathloss-database.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/helper/lte-helper.cc View 1 2 3 4 5 chunks +11 lines, -11 lines 0 comments Download
M src/lte/helper/lte-hex-grid-enb-topology-helper.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/helper/point-to-point-epc-helper.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/helper/radio-bearer-stats-calculator.cc View 1 2 3 4 2 chunks +5 lines, -6 lines 0 comments Download
M src/lte/helper/radio-bearer-stats-connector.cc View 2 5 chunks +9 lines, -0 lines 0 comments Download
M src/lte/helper/radio-environment-map-helper.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/helper/radio-environment-map-helper.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/a3-rsrp-handover-algorithm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/component-carrier.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/component-carrier.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/component-carrier-ue.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/cqa-ff-mac-scheduler.cc View 1 2 3 4 5 33 chunks +52 lines, -47 lines 0 comments Download
M src/lte/model/epc-enb-application.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/epc-enb-application.cc View 1 2 5 chunks +6 lines, -1 line 0 comments Download
M src/lte/model/epc-gtpu-header.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/epc-gtpu-header.cc View 1 2 3 2 chunks +23 lines, -23 lines 0 comments Download
M src/lte/model/epc-mme.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M src/lte/model/epc-s11-sap.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/lte/model/epc-s1ap-sap.h View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
M src/lte/model/epc-sgw-pgw-application.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M src/lte/model/epc-ue-nas.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/epc-ue-nas.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/epc-x2.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/epc-x2-header.h View 1 2 3 4 9 chunks +32 lines, -32 lines 0 comments Download
M src/lte/model/epc-x2-header.cc View 1 2 3 4 5 24 chunks +76 lines, -71 lines 0 comments Download
M src/lte/model/eps-bearer-tag.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/fdbet-ff-mac-scheduler.cc View 1 2 3 4 5 17 chunks +25 lines, -25 lines 0 comments Download
M src/lte/model/fdmt-ff-mac-scheduler.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/fdmt-ff-mac-scheduler.cc View 1 2 3 4 5 15 chunks +20 lines, -16 lines 0 comments Download
M src/lte/model/fdtbfq-ff-mac-scheduler.h View 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/fdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 26 chunks +34 lines, -30 lines 0 comments Download
M src/lte/model/ff-mac-scheduler.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/lte/model/lte-amc.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/lte-amc.cc View 1 2 3 4 5 6 chunks +8 lines, -7 lines 0 comments Download
M src/lte/model/lte-anr.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-asn1-header.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-asn1-header.cc View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-ccm-rrc-sap.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M src/lte/model/lte-common.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-enb-cmac-sap.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/lte/model/lte-enb-component-carrier-manager.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-enb-mac.cc View 1 2 3 4 7 chunks +14 lines, -14 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-enb-phy.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-enb-phy.cc View 1 2 3 4 9 chunks +13 lines, -11 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 1 2 3 4 23 chunks +39 lines, -32 lines 0 comments Download
M src/lte/model/lte-ffr-distributed-algorithm.cc View 1 2 3 4 6 chunks +18 lines, -13 lines 0 comments Download
M src/lte/model/lte-ffr-enhanced-algorithm.cc View 1 2 3 4 11 chunks +20 lines, -18 lines 0 comments Download
M src/lte/model/lte-ffr-soft-algorithm.cc View 1 2 5 chunks +6 lines, -2 lines 0 comments Download
M src/lte/model/lte-fr-hard-algorithm.cc View 1 2 8 chunks +8 lines, -1 line 0 comments Download
M src/lte/model/lte-fr-no-op-algorithm.cc View 2 5 chunks +7 lines, -0 lines 0 comments Download
M src/lte/model/lte-fr-soft-algorithm.cc View 1 2 5 chunks +6 lines, -2 lines 0 comments Download
M src/lte/model/lte-fr-strict-algorithm.cc View 1 2 5 chunks +6 lines, -2 lines 0 comments Download
M src/lte/model/lte-handover-algorithm.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-harq-phy.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-harq-phy.cc View 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/model/lte-interference.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/lte/model/lte-mi-error-model.h View 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/lte/model/lte-mi-error-model.cc View 1 2 9 chunks +14 lines, -14 lines 0 comments Download
M src/lte/model/lte-net-device.cc View 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/lte/model/lte-pdcp-tag.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-phy.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-radio-bearer-tag.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-rlc.cc View 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/lte/model/lte-rlc-am.cc View 1 2 3 4 10 chunks +13 lines, -9 lines 0 comments Download
M src/lte/model/lte-rlc-am-header.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-rlc-tm.cc View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M src/lte/model/lte-rlc-um.cc View 1 2 3 4 5 4 chunks +7 lines, -3 lines 0 comments Download
M src/lte/model/lte-rrc-header.cc View 1 2 74 chunks +114 lines, -108 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.cc View 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
M src/lte/model/lte-rrc-protocol-real.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-rrc-sap.h View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-spectrum-signal-parameters.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-spectrum-value-helper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-spectrum-value-helper.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-ue-ccm-rrc-sap.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/lte-ue-cmac-sap.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-component-carrier-manager.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-ue-mac.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-net-device.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-ue-phy.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/model/lte-ue-phy.cc View 1 2 3 4 5 15 chunks +21 lines, -17 lines 0 comments Download
M src/lte/model/lte-ue-power-control.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 1 2 3 4 6 chunks +18 lines, -10 lines 0 comments Download
M src/lte/model/no-op-component-carrier-manager.cc View 1 2 3 4 9 chunks +10 lines, -7 lines 0 comments Download
M src/lte/model/pf-ff-mac-scheduler.cc View 1 2 3 4 5 19 chunks +24 lines, -20 lines 0 comments Download
M src/lte/model/pss-ff-mac-scheduler.cc View 1 2 3 4 5 27 chunks +36 lines, -36 lines 0 comments Download
M src/lte/model/rr-ff-mac-scheduler.cc View 1 2 3 4 5 16 chunks +19 lines, -15 lines 0 comments Download
M src/lte/model/simple-ue-component-carrier-manager.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/lte/model/simple-ue-component-carrier-manager.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/lte/model/tdbet-ff-mac-scheduler.cc View 1 2 3 4 5 16 chunks +21 lines, -18 lines 0 comments Download
M src/lte/model/tdmt-ff-mac-scheduler.cc View 1 2 3 4 5 16 chunks +21 lines, -17 lines 0 comments Download
M src/lte/model/tdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 19 chunks +26 lines, -22 lines 0 comments Download
M src/lte/model/trace-fading-loss-model.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/trace-fading-loss-model.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/tta-ff-mac-scheduler.cc View 1 2 3 4 5 15 chunks +20 lines, -16 lines 0 comments Download
M src/lte/test/epc-test-gtpu.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/lte/test/epc-test-s1u-downlink.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/epc-test-s1u-uplink.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-ffr-simple.cc View 1 2 3 4 5 5 chunks +11 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-carrier-aggregation.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-carrier-aggregation.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-cell-selection.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/test/lte-test-cell-selection.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-cqa-ff-mac-scheduler.cc View 1 2 3 4 4 chunks +11 lines, -6 lines 0 comments Download
M src/lte/test/lte-test-cqi-generation.cc View 1 2 3 4 5 chunks +15 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-deactivate-bearer.cc View 1 2 3 4 5 chunks +17 lines, -14 lines 0 comments Download
M src/lte/test/lte-test-downlink-power-control.cc View 1 2 3 4 5 chunks +13 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-downlink-sinr.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-earfcn.cc View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-entities.cc View 1 2 3 4 5 5 chunks +8 lines, -8 lines 0 comments Download
M src/lte/test/lte-test-fading.cc View 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-fdmt-ff-mac-scheduler.h View 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.h View 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 5 chunks +12 lines, -7 lines 0 comments Download
M src/lte/test/lte-test-frequency-reuse.cc View 1 2 3 4 5 27 chunks +34 lines, -28 lines 0 comments Download
M src/lte/test/lte-test-harq.cc View 1 2 3 4 4 chunks +43 lines, -46 lines 0 comments Download
M src/lte/test/lte-test-interference.cc View 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-interference-fr.cc View 1 2 3 4 4 chunks +7 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-link-adaptation.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-mimo.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-pathloss-model.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M src/lte/test/lte-test-pf-ff-mac-scheduler.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-phy-error-model.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-pss-ff-mac-scheduler.cc View 1 2 3 4 6 chunks +16 lines, -10 lines 0 comments Download
M src/lte/test/lte-test-rlc-am-e2e.cc View 1 2 3 4 1 chunk +14 lines, -12 lines 0 comments Download
M src/lte/test/lte-test-rlc-am-transmitter.cc View 1 2 3 4 2 chunks +12 lines, -8 lines 0 comments Download
M src/lte/test/lte-test-rlc-um-e2e.cc View 1 2 3 4 2 chunks +14 lines, -13 lines 0 comments Download
M src/lte/test/lte-test-rlc-um-transmitter.cc View 1 2 3 4 2 chunks +13 lines, -9 lines 0 comments Download
M src/lte/test/lte-test-spectrum-value-helper.cc View 1 2 3 4 13 chunks +263 lines, -264 lines 0 comments Download
M src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc View 1 2 3 4 5 chunks +12 lines, -7 lines 0 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 1 2 3 4 9 chunks +16 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-ue-phy.cc View 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-uplink-power-control.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-uplink-sinr.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M src/lte/test/test-asn1-encoding.cc View 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/test/test-epc-tft-classifier.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/test-lte-antenna.cc View 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/test/test-lte-epc-e2e-data.cc View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M src/lte/test/test-lte-handover-delay.cc View 1 2 3 4 5 chunks +19 lines, -3 lines 0 comments Download
M src/lte/test/test-lte-handover-target.cc View 1 2 3 4 1 chunk +8 lines, -6 lines 0 comments Download
M src/lte/test/test-lte-rlc-header.cc View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M src/lte/test/test-lte-rrc.cc View 1 2 3 4 6 chunks +15 lines, -11 lines 0 comments Download
M src/lte/test/test-lte-x2-handover.cc View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
M src/lte/test/test-lte-x2-handover-measures.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M src/lte/wscript View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d