Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2929)

Issue 338800043: ns-3 - LrWpanMac - Extended Addressing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by JRewienski
Modified:
12 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This small patch provides extended addressing to LrWpanMac. Now McpsDataRequest can create frames with extended (64-bit) addresses.

Patch Set 1 #

Patch Set 2 : LrWpanMac: ACK test modified to test also the extended addressing #

Total comments: 1

Patch Set 3 : lr-wpan-mac: Prevent ADDR_MODE_RESERVED use as destination address mode #

Patch Set 4 : Patched AUTHORS, RELEASE_NOTES, and CHANGES.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -15 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M CHANGES.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M RELEASE_NOTES View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/lr-wpan/examples/lr-wpan-data.cc View 4 chunks +34 lines, -6 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.cc View 1 2 2 chunks +46 lines, -9 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-ack-test.cc View 1 4 chunks +95 lines, -0 lines 0 comments Download

Messages

Total messages: 8
JRewienski
Hello everyone, This small patch provides extended addressing to LrWpanMac. Now McpsDataRequest can create frames ...
1 year, 1 month ago (2017-11-09 12:02:20 UTC) #1
Tommaso Pecorella
On 2017/11/09 12:02:20, JRewienski wrote: > Hello everyone, > > This small patch provides extended ...
1 year ago (2017-11-12 14:45:48 UTC) #2
JRewienski
On 2017/11/12 14:45:48, Tommaso Pecorella wrote: > On 2017/11/09 12:02:20, JRewienski wrote: > > Hello ...
1 year ago (2017-11-12 20:27:26 UTC) #3
Tommaso Pecorella
I added one small comment only. Other than that it's a +1 (i.e., fix the ...
1 year ago (2017-11-14 23:35:52 UTC) #4
JRewienski
On 2017/11/14 23:35:52, Tommaso Pecorella wrote: > I added one small comment only. > > ...
1 year ago (2017-11-17 20:10:29 UTC) #5
Tom Henderson
Looks fine to merge once AUTHORS, RELEASE_NOTES, and CHANGES.html are also patched.
1 year ago (2017-12-05 03:06:02 UTC) #6
JRewienski
On 2017/12/05 03:06:02, Tom Henderson wrote: > Looks fine to merge once AUTHORS, RELEASE_NOTES, and ...
1 year ago (2017-12-08 15:18:44 UTC) #7
Tommaso Pecorella
1 year ago (2017-12-09 00:14:27 UTC) #8
I pushed this in changeset:   13202:03deb728a0df

You can close the code review, and thanks again for the feature.

T.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b