Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1157)

Issue 338800043: ns-3 - LrWpanMac - Extended Addressing

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by JRewienski
Modified:
4 days, 16 hours ago
Reviewers:
Tommaso Pecorella
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This small patch provides extended addressing to LrWpanMac. Now McpsDataRequest can create frames with extended (64-bit) addresses.

Patch Set 1 #

Patch Set 2 : LrWpanMac: ACK test modified to test also the extended addressing #

Total comments: 1

Patch Set 3 : lr-wpan-mac: Prevent ADDR_MODE_RESERVED use as destination address mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -15 lines) Patch
M src/lr-wpan/examples/lr-wpan-data.cc View 4 chunks +34 lines, -6 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.cc View 1 2 2 chunks +46 lines, -9 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-ack-test.cc View 1 4 chunks +95 lines, -0 lines 0 comments Download

Messages

Total messages: 5
JRewienski
Hello everyone, This small patch provides extended addressing to LrWpanMac. Now McpsDataRequest can create frames ...
1 week, 6 days ago (2017-11-09 12:02:20 UTC) #1
Tommaso Pecorella
On 2017/11/09 12:02:20, JRewienski wrote: > Hello everyone, > > This small patch provides extended ...
1 week, 2 days ago (2017-11-12 14:45:48 UTC) #2
JRewienski
On 2017/11/12 14:45:48, Tommaso Pecorella wrote: > On 2017/11/09 12:02:20, JRewienski wrote: > > Hello ...
1 week, 2 days ago (2017-11-12 20:27:26 UTC) #3
Tommaso Pecorella
I added one small comment only. Other than that it's a +1 (i.e., fix the ...
1 week ago (2017-11-14 23:35:52 UTC) #4
JRewienski
4 days, 16 hours ago (2017-11-17 20:10:29 UTC) #5
On 2017/11/14 23:35:52, Tommaso Pecorella wrote:
> I added one small comment only.
> 
> Other than that it's a +1 (i.e., fix the comment and merge).
> 
>
https://codereview.appspot.com/338800043/diff/20001/src/lr-wpan/model/lr-wpan...
> File src/lr-wpan/model/lr-wpan-mac.cc (right):
> 
>
https://codereview.appspot.com/338800043/diff/20001/src/lr-wpan/model/lr-wpan...
> src/lr-wpan/model/lr-wpan-mac.cc:322: macHdr.SetDstAddrMode
> (params.m_dstAddrMode);
> This case is explicitly forbidden by the standard.
> Use a NS_ABORT_MSG instead of continuing.
> 
> I know that a few lines above there is a similar:
>   switch (params.m_srcAddrMode)
>     {
>     case NO_PANID_ADDR:
>       macHdr.SetSrcAddrMode (params.m_srcAddrMode);
>       macHdr.SetNoPanIdComp ();
>       break;
>     case ADDR_MODE_RESERVED:
>       macHdr.SetSrcAddrMode (params.m_srcAddrMode);
>       break;
> 
> but this is a bug too.
> I opened a bug: https://www.nsnam.org/bugzilla/show_bug.cgi?id=2822

Hey!

I've changed the line you have suggested. Thanks for catching the bug!

JR
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4