https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1#newcode32 config/windows/make_release.ps1:32: If ( $LastExitCode -ne 0 ) { On 2017/11/10 ...
6 years, 5 months ago
(2017-11-10 11:12:03 UTC)
#5
https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1
File config/windows/make_release.ps1 (right):
https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.p...
config/windows/make_release.ps1:32: If ( $LastExitCode -ne 0 ) {
On 2017/11/10 10:39:36, romaing wrote:
> On 2017/11/09 18:33:30, Joachim Metz wrote:
> > maybe add error messages?
> >
> > "Write-Host "Missing PyInstaller." -foreground Red"
> I'm just making sure the test stops here. Various errors can cause this, and
> they'll be reported by Invoke-Expression.
>
> For an example, see the 'plaso-win64-build_release' Jenkins test #64 console
> output.
Done.
Changes have been merged with master branch. To close the review and clean up the ...
6 years, 5 months ago
(2017-11-24 11:27:02 UTC)
#7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
check-error-test-windows
Issue 338790044: [plaso] Fix windows release script
(Closed)
Created 6 years, 5 months ago by romaing
Modified 6 years, 5 months ago
Reviewers: onager, Joachim Metz
Base URL:
Comments: 3