Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1035)

Issue 338790044: [plaso] Fix windows release script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by romaing
Modified:
3 months ago
Reviewers:
Joachim Metz, onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Fix windows release script

Patch Set 1 #

Total comments: 3

Patch Set 2 : better errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M config/windows/make_release.ps1 View 1 3 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 7
romaing
3 months, 2 weeks ago (2017-11-09 14:46:27 UTC) #1
Joachim Metz
https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1#newcode32 config/windows/make_release.ps1:32: If ( $LastExitCode -ne 0 ) { maybe add ...
3 months, 2 weeks ago (2017-11-09 18:33:31 UTC) #2
romaing
https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1#newcode32 config/windows/make_release.ps1:32: If ( $LastExitCode -ne 0 ) { On 2017/11/09 ...
3 months, 2 weeks ago (2017-11-10 10:39:36 UTC) #3
romaing
Code updated.
3 months, 2 weeks ago (2017-11-10 11:11:41 UTC) #4
romaing
https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/338790044/diff/1/config/windows/make_release.ps1#newcode32 config/windows/make_release.ps1:32: If ( $LastExitCode -ne 0 ) { On 2017/11/10 ...
3 months, 2 weeks ago (2017-11-10 11:12:03 UTC) #5
Joachim Metz
LGTM
3 months, 1 week ago (2017-11-13 06:07:15 UTC) #6
romaing
3 months ago (2017-11-24 11:27:02 UTC) #7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
check-error-test-windows
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d