Issue 338680043: ticket:13684 Making DecimalMatcher no longer consume trailing grouping separators, which is consist…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 338680043: ticket:13684 Making DecimalMatcher no longer consume trailing grouping separators, which is consist… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by sffc

Modified:
6 years ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat4/

Visibility:
Public.

ticket:13684 Making DecimalMatcher no longer consume trailing grouping separators, which is consistent with previous behavior.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -3 lines)			Patch
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/parse/DecimalMatcher.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 3

sffc

6 years ago (2018-04-07 00:27:58 UTC) #3

On 2018/04/06 21:20:57, andy.heninger wrote:
> LGTM

http://bugs.icu-project.org/trac/changeset/41207