Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(458)

Issue 338670043: [plaso] Added to merge directory to speed up listdir

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by Joachim Metz
Modified:
2 weeks, 1 day ago
Reviewers:
jberggren, onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing
Visibility:
Public.

Description

[plaso] Added to merge directory to speed up listdir Depends on: https://codereview.appspot.com/340610043/

Patch Set 1 #

Total comments: 14

Patch Set 2 : Changes after review and merge #

Total comments: 22

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -109 lines) Patch
M plaso/multi_processing/analysis_process.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M plaso/multi_processing/psort.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M plaso/multi_processing/task_manager.py View 1 2 3 chunks +28 lines, -14 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M plaso/storage/fake/writer.py View 1 2 chunks +21 lines, -0 lines 0 comments Download
M plaso/storage/interface.py View 1 2 12 chunks +97 lines, -63 lines 0 comments Download
M tests/multi_processing/task_manager.py View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10
Joachim Metz
3 weeks ago (2018-04-01 17:32:39 UTC) #1
onager
On 2018/04/01 17:32:39, Joachim Metz wrote: I don't think "to merge" is the name to ...
3 weeks ago (2018-04-01 19:58:18 UTC) #2
onager
https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py#newcode276 plaso/multi_processing/task_manager.py:276: """Retrieves the task when it is mergeable. You seem ...
3 weeks ago (2018-04-01 19:58:26 UTC) #3
Joachim Metz
https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py#newcode276 plaso/multi_processing/task_manager.py:276: """Retrieves the task when it is mergeable. Done. https://codereview.appspot.com/338670043/diff/1/plaso/storage/interface.py ...
3 weeks ago (2018-04-02 05:01:08 UTC) #4
Joachim Metz
Code updated.
3 weeks ago (2018-04-02 05:13:40 UTC) #5
onager
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_manager.py#newcode107 plaso/multi_processing/task_manager.py:107: * processed: a worker has completed processing the task. ...
2 weeks, 1 day ago (2018-04-07 13:15:54 UTC) #6
onager
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py#newcode208 plaso/multi_processing/task_engine.py:208: 'Unable to retrieve task: {0:s} to prepare for merge.'.format( ...
2 weeks, 1 day ago (2018-04-07 14:34:06 UTC) #7
Joachim Metz
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py#newcode208 plaso/multi_processing/task_engine.py:208: 'Unable to retrieve task: {0:s} to prepare for merge.'.format( ...
2 weeks, 1 day ago (2018-04-07 16:49:28 UTC) #8
Joachim Metz
Code updated.
2 weeks, 1 day ago (2018-04-07 16:55:40 UTC) #9
Joachim Metz
2 weeks, 1 day ago (2018-04-07 17:34:47 UTC) #10
Code updated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b