Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1549)

Issue 338670043: [plaso] Added processed directory to speed up listdir (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by Joachim Metz
Modified:
7 months, 1 week ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, jberggren
Visibility:
Public.

Description

[plaso] Added processed directory to speed up listdir

Patch Set 1 #

Total comments: 14

Patch Set 2 : Changes after review and merge #

Total comments: 22

Patch Set 3 : Changes after review #

Patch Set 4 : Changes after merge #

Patch Set 5 : Textual changes #

Total comments: 6

Patch Set 6 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -112 lines) Patch
M plaso/multi_processing/analysis_process.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M plaso/multi_processing/psort.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 1 2 3 4 5 1 chunk +12 lines, -3 lines 0 comments Download
M plaso/multi_processing/task_manager.py View 1 2 3 3 chunks +5 lines, -15 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M plaso/storage/fake/writer.py View 1 2 3 4 5 3 chunks +15 lines, -2 lines 0 comments Download
M plaso/storage/interface.py View 1 2 3 4 5 12 chunks +97 lines, -63 lines 0 comments Download
M tests/multi_processing/task_manager.py View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 17
Joachim Metz
8 months, 1 week ago (2018-04-01 17:32:39 UTC) #1
onager
On 2018/04/01 17:32:39, Joachim Metz wrote: I don't think "to merge" is the name to ...
8 months, 1 week ago (2018-04-01 19:58:18 UTC) #2
onager
https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py#newcode276 plaso/multi_processing/task_manager.py:276: """Retrieves the task when it is mergeable. You seem ...
8 months, 1 week ago (2018-04-01 19:58:26 UTC) #3
Joachim Metz
https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/1/plaso/multi_processing/task_manager.py#newcode276 plaso/multi_processing/task_manager.py:276: """Retrieves the task when it is mergeable. Done. https://codereview.appspot.com/338670043/diff/1/plaso/storage/interface.py ...
8 months, 1 week ago (2018-04-02 05:01:08 UTC) #4
Joachim Metz
Code updated.
8 months, 1 week ago (2018-04-02 05:13:40 UTC) #5
onager
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_manager.py File plaso/multi_processing/task_manager.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_manager.py#newcode107 plaso/multi_processing/task_manager.py:107: * processed: a worker has completed processing the task. ...
8 months, 1 week ago (2018-04-07 13:15:54 UTC) #6
onager
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py#newcode208 plaso/multi_processing/task_engine.py:208: 'Unable to retrieve task: {0:s} to prepare for merge.'.format( ...
8 months, 1 week ago (2018-04-07 14:34:06 UTC) #7
Joachim Metz
https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/338670043/diff/20001/plaso/multi_processing/task_engine.py#newcode208 plaso/multi_processing/task_engine.py:208: 'Unable to retrieve task: {0:s} to prepare for merge.'.format( ...
8 months, 1 week ago (2018-04-07 16:49:28 UTC) #8
Joachim Metz
Code updated.
8 months, 1 week ago (2018-04-07 16:55:40 UTC) #9
Joachim Metz
Code updated.
8 months, 1 week ago (2018-04-07 17:34:47 UTC) #10
Joachim Metz
Code updated.
7 months, 2 weeks ago (2018-04-24 04:23:58 UTC) #11
Joachim Metz
Code updated.
7 months, 2 weeks ago (2018-04-24 04:30:24 UTC) #12
onager
https://codereview.appspot.com/338670043/diff/100001/plaso/storage/fake/writer.py File plaso/storage/fake/writer.py (right): https://codereview.appspot.com/338670043/diff/100001/plaso/storage/fake/writer.py#newcode367 plaso/storage/fake/writer.py:367: """Finalized a proccessed a task storage. "Finalizes" and "processed" ...
7 months, 1 week ago (2018-05-01 08:52:51 UTC) #13
Joachim Metz
https://codereview.appspot.com/338670043/diff/100001/plaso/storage/fake/writer.py File plaso/storage/fake/writer.py (right): https://codereview.appspot.com/338670043/diff/100001/plaso/storage/fake/writer.py#newcode367 plaso/storage/fake/writer.py:367: """Finalized a proccessed a task storage. On 2018/05/01 08:52:51, ...
7 months, 1 week ago (2018-05-01 10:21:39 UTC) #14
Joachim Metz
Code updated.
7 months, 1 week ago (2018-05-01 10:26:36 UTC) #15
onager
LGTM
7 months, 1 week ago (2018-05-01 15:09:53 UTC) #16
Joachim Metz
7 months, 1 week ago (2018-05-01 16:10:17 UTC) #17
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dbmerge2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b