Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2083)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 338390043: [plaso] Moved event and event data merge into psort (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Joachim Metz
Modified:
6 years ago
Reviewers:
romaing, onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Moved event and event data merge into psort

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes after review #

Patch Set 3 : Changes after merge #

Patch Set 4 : Changes after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -87 lines) Patch
M plaso/containers/events.py View 2 chunks +2 lines, -0 lines 0 comments Download
M plaso/multi_processing/psort.py View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M plaso/output/dynamic.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M plaso/output/l2t_csv.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plaso/output/shared_4n6time.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plaso/output/tln.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/mediator.py View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
M plaso/parsers/text_parser.py View 1 2 2 chunks +2 lines, -9 lines 0 comments Download
M plaso/storage/sqlite/sqlite_file.py View 1 2 3 3 chunks +13 lines, -33 lines 0 comments Download
M tests/containers/events.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tests/parsers/sqlite_plugins/interface.py View 1 2 3 4 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
6 years, 3 months ago (2018-01-19 07:13:15 UTC) #1
onager
https://codereview.appspot.com/338390043/diff/1/plaso/output/l2t_csv.py File plaso/output/l2t_csv.py (right): https://codereview.appspot.com/338390043/diff/1/plaso/output/l2t_csv.py#newcode201 plaso/output/l2t_csv.py:201: output_values[6] = event.timestamp_desc or '-' In future, please try ...
6 years, 3 months ago (2018-01-24 07:02:55 UTC) #2
Joachim Metz
https://codereview.appspot.com/338390043/diff/1/plaso/output/l2t_csv.py File plaso/output/l2t_csv.py (right): https://codereview.appspot.com/338390043/diff/1/plaso/output/l2t_csv.py#newcode201 plaso/output/l2t_csv.py:201: output_values[6] = event.timestamp_desc or '-' Let's talk about this, ...
6 years, 3 months ago (2018-01-24 07:22:57 UTC) #3
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-24 07:26:55 UTC) #4
Joachim Metz
PTAL
6 years, 1 month ago (2018-03-20 21:59:02 UTC) #5
Joachim Metz
Code updated.
6 years, 1 month ago (2018-03-20 22:10:13 UTC) #6
onager
LGTM
6 years ago (2018-03-31 11:04:34 UTC) #7
Joachim Metz
Code updated.
6 years ago (2018-03-31 12:13:30 UTC) #8
Joachim Metz
6 years ago (2018-03-31 14:55:53 UTC) #9 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close eventdata4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b