Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(602)

Issue 338190043: ticket:13492 Fixing currency fraction length fallbacks in the DecimalFormat-to-NumberFormatter mapp… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by sffc
Modified:
6 years, 4 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/icu4j/
Visibility:
Public.

Description

ticket:13492 Fixing currency fraction length fallbacks in the DecimalFormat-to-NumberFormatter mapping function.

Patch Set 1 #

Patch Set 2 : Clarifying logic for fraction length fallbacks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberPropertyMapper.java View 1 1 chunk +15 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 5
sffc
6 years, 4 months ago (2017-11-30 03:42:24 UTC) #1
sffc
Clarifying logic for fraction length fallbacks.
6 years, 4 months ago (2017-12-01 08:41:24 UTC) #2
sffc
First found of feedback.
6 years, 4 months ago (2017-12-01 08:41:42 UTC) #3
andy.heninger
LGTM
6 years, 4 months ago (2017-12-01 18:32:45 UTC) #4
sffc
6 years, 4 months ago (2017-12-01 23:04:01 UTC) #5
On 2017/12/01 18:32:45, andy.heninger wrote:
> LGTM

Commit: Committed revision 40684 (2 entries)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b