Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(227)

Issue 337970043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ammo6818-vandals.uidaho.edu
Modified:
16 hours, 36 minutes ago
Reviewers:
Lalith Suresh
CC:
ns-3-reviews_googlegroups.com, tomh_tomh.org, gjcarneiro, ammo6818_vandals.uidaho.edu
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Total comments: 1

Patch Set 3 : Update per review comments #

Patch Set 4 : Patch set updates for x64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M src/olsr/helper/olsr-helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/olsr/model/olsr-header.cc View 1 2 3 11 chunks +18 lines, -9 lines 0 comments Download
M src/olsr/model/olsr-routing-protocol.cc View 1 2 3 7 chunks +27 lines, -17 lines 0 comments Download
M src/olsr/model/olsr-state.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/olsr/test/olsr-header-test-suite.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Lalith Suresh
Patch looks good to me. Just fix this minor change and feel free to merge. ...
2 months ago (2017-12-17 11:37:27 UTC) #1
ammo6818-vandals.uidaho.edu
On 2017/12/17 11:37:27, Lalith Suresh wrote: > Patch looks good to me. Just fix this ...
2 months ago (2017-12-19 10:15:54 UTC) #2
ammo6818-vandals.uidaho.edu
Review comments have been addressed and patch ready to upload to ns-3-dev
1 week ago (2018-02-11 19:44:40 UTC) #3
ammo6818-vandals.uidaho.edu
16 hours, 36 minutes ago (2018-02-18 05:41:25 UTC) #4
Please merge patches into ns-3-dev
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d