Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1444)

Issue 337950043: Eliminate Visual Studio compiler warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by ammo6818-vandals.uidaho.edu
Modified:
11 months, 1 week ago
Reviewers:
tomh, n.p, tpecorella
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Patch Set 3 : Updates to patch set for latest module changes #

Patch Set 4 : Updated patch set to eliminate some casts #

Patch Set 5 : Patch updates for x64 build #

Patch Set 6 : Update patch per coding style requirements #

Patch Set 7 : Update patch for latest module changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -291 lines) Patch
M src/internet/doc/tcp.rst View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M src/internet/helper/internet-stack-helper.cc View 1 2 3 4 5 4 chunks +4 lines, -0 lines 0 comments Download
M src/internet/helper/ipv4-global-routing-helper.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/helper/ipv4-interface-container.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/helper/ipv4-static-routing-helper.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/helper/ipv6-interface-container.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/internet/helper/ipv6-static-routing-helper.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/helper/rip-helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/helper/ripng-helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/model/arp-l3-protocol.cc View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M src/internet/model/candidate-queue.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/global-route-manager-impl.cc View 1 2 3 4 5 8 chunks +22 lines, -22 lines 0 comments Download
M src/internet/model/global-router-interface.cc View 1 2 3 4 5 8 chunks +12 lines, -11 lines 0 comments Download
M src/internet/model/icmpv6-header.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/internet/model/icmpv6-header.cc View 1 2 3 4 5 9 chunks +13 lines, -8 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.cc View 1 2 3 4 5 4 chunks +7 lines, -5 lines 0 comments Download
M src/internet/model/ipv4-end-point-demux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-global-routing.cc View 1 2 3 4 5 6 chunks +7 lines, -7 lines 0 comments Download
M src/internet/model/ipv4-interface.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv4-l3-protocol.h View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 1 2 3 4 5 11 chunks +23 lines, -10 lines 0 comments Download
M src/internet/model/ipv4-list-routing.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv4-raw-socket-impl.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/ipv4-routing-table-entry.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv4-static-routing.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv6-address-generator.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-extension.cc View 1 2 3 4 5 22 chunks +31 lines, -32 lines 0 comments Download
M src/internet/model/ipv6-extension-header.cc View 1 2 3 4 5 11 chunks +20 lines, -7 lines 0 comments Download
M src/internet/model/ipv6-header.h View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M src/internet/model/ipv6-header.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-interface.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv6-l3-protocol.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-l3-protocol.cc View 1 2 3 4 5 4 chunks +8 lines, -2 lines 0 comments Download
M src/internet/model/ipv6-list-routing.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv6-option.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-option-header.cc View 1 2 3 4 5 4 chunks +13 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-packet-info-tag.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv6-packet-info-tag.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/model/ipv6-raw-socket-impl.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M src/internet/model/ipv6-routing-table-entry.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv6-static-routing.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/model/nsc-tcp-l4-protocol.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/internet/model/nsc-tcp-socket-impl.cc View 1 2 3 4 5 4 chunks +5 lines, -2 lines 0 comments Download
M src/internet/model/pending-data.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/rip.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/rip.cc View 1 2 3 4 5 6 chunks +6 lines, -6 lines 0 comments Download
M src/internet/model/rip-header.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/rip-header.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/ripng.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M src/internet/model/ripng.cc View 1 2 3 4 5 4 chunks +13 lines, -3 lines 0 comments Download
M src/internet/model/ripng-header.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ripng-header.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/sim_interface.h View 1 2 3 4 5 12 chunks +33 lines, -1 line 0 comments Download
M src/internet/model/tcp-header.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 1 2 3 4 5 4 chunks +10 lines, -4 lines 0 comments Download
M src/internet/model/tcp-illinois.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/tcp-ledbat.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/udp-header.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/udp-header.cc View 1 2 3 4 5 3 chunks +8 lines, -2 lines 0 comments Download
M src/internet/model/udp-socket-impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/test/ipv4-fragmentation-test.cc View 1 2 3 4 5 7 chunks +15 lines, -11 lines 0 comments Download
M src/internet/test/ipv4-global-routing-test-suite.cc View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M src/internet/test/ipv4-header-test.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M src/internet/test/ipv4-list-routing-test-suite.cc View 1 2 3 4 5 2 chunks +14 lines, -14 lines 0 comments Download
M src/internet/test/ipv4-raw-test.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M src/internet/test/ipv6-extension-header-test-suite.cc View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M src/internet/test/ipv6-fragmentation-test.cc View 1 2 3 4 5 7 chunks +13 lines, -11 lines 0 comments Download
M src/internet/test/ipv6-list-routing-test-suite.cc View 1 2 3 4 5 2 chunks +18 lines, -18 lines 0 comments Download
M src/internet/test/ipv6-raw-test.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/internet/test/tcp-advertised-window-test.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/internet/test/tcp-bic-test.cc View 1 2 3 4 5 4 chunks +9 lines, -9 lines 0 comments Download
M src/internet/test/tcp-bytes-in-flight-test.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M src/internet/test/tcp-cong-avoid-test.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/internet/test/tcp-endpoint-bug2211.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/test/tcp-fast-retr-test.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/test/tcp-general-test.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/test/tcp-highspeed-test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/test/tcp-hybla-test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/test/tcp-illinois-test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/test/tcp-ledbat-test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/test/tcp-pkts-acked-test.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/test/tcp-rto-test.cc View 1 2 3 4 5 6 7 chunks +8 lines, -0 lines 0 comments Download
M src/internet/test/tcp-rtt-estimation.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/test/tcp-scalable-test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/test/tcp-slow-start-test.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M src/internet/test/tcp-test.cc View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M src/internet/test/tcp-timestamp-test.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M src/internet/test/tcp-vegas-test.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/internet/test/tcp-veno-test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/internet/test/tcp-yeah-test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/test/udp-test.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 1
ammo6818-vandals.uidaho.edu
1 year, 10 months ago (2018-03-15 02:27:38 UTC) #1
Patch updated with latest moduel changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b