src: Added some error handlings from a code review

src: Added some error handlings from a code review

Committed: f5e0752fe345db2033a2b49de206dc62acd00a2b

[Peng, 2017-11-08 14:43:55]

lgtm

https://codereview.appspot.com/337900043/diff/1/src/ibuscomposetable.c
File src/ibuscomposetable.c (right):

https://codereview.appspot.com/337900043/diff/1/src/ibuscomposetable.c#newcod...
src/ibuscomposetable.c:690: goto out_load_cache;
A suggestion. Maybe we can avoid using goto, and use do {} while(0); instead?

For example:

do {
   if (g_stat (compose_file, &original_buf))
       break;
   if (g_stat (path, &cache_buf)))
       break;
   // ....
} while (0);
g_free (contents);
g_free(path);
return retval;
...

https://codereview.appspot.com/337900043/diff/1/src/ibuscomposetable.c#newcod...
src/ibuscomposetable.c:697: }
A suggestion, maybe it is good to use do { } while(0); to replace gotos?

For example.

do {
  if (.... failed)
     break;
  if (..... failed)
     break;
  ...
while (0);
free(...);
return result;

[fujiwara, 2017-11-09 03:13:49]

https://codereview.appspot.com/337900043/diff/1/src/ibuscomposetable.c
File src/ibuscomposetable.c (right):

https://codereview.appspot.com/337900043/diff/1/src/ibuscomposetable.c#newcod...
src/ibuscomposetable.c:690: goto out_load_cache;
On 2017/11/08 14:43:54, Peng wrote:
> A suggestion. Maybe we can avoid using goto, and use do {} while(0); instead?
> 
> For example:
> 
> do {
>    if (g_stat (compose_file, &original_buf))
>        break;
>    if (g_stat (path, &cache_buf)))
>        break;
>    // ....
> } while (0);
> g_free (contents);
> g_free(path);
> return retval;
> ...
>    

Basically I don't like do-while since it indents one step and I think the goto
sentence is a general way.
But I don't mind in this case.

[fujiwara, 2017-11-09 03:14:19]

Committed patchset #2 (id:20001) manually as
f5e0752fe345db2033a2b49de206dc62acd00a2b (presubmit successful).