Replaced default Google Map marker by red circles

Replaced default Google Map marker by red circles

BUG= IVS/DB_interaction

[manu_chaud, 2017-10-22 01:48:57]

Made some changes on the map with 20 paths shown:
- used the custom marker (red circle) instead of the Google default marker to
represent hops
- reduced the lines weight so the map is more readable

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html
File Trace6/index.html (right):

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode43
Trace6/index.html:43: function addCircle(centerCoordinates, map,
contentInfoWindow) {
Fixed the code for the function addCircle, function that will be used to add the
red circles on the map

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode65
Trace6/index.html:65: function addInfoWindow(coords, content) {
Let's create a function for adding an infoWindow as well

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode102
Trace6/index.html:102: /* MANU: Commented that to replace the default marker
symbols by the red circles
We want to remove the default markers, to use custom ones (circles) instead

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode125
Trace6/index.html:125: strokeWeight: 1 // to be weighted according to number of
paths that go across the link
Reduced the weight of the green lines, to make the map more readable

[Wei Wang, 2017-10-22 21:16:58]

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html
File Trace6/index.html (right):

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode42
Trace6/index.html:42: */
Such good code comment here in details of every parameter meaning！

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode65
Trace6/index.html:65: function addInfoWindow(coords, content) {
Yes, we should add an InfoWindow for a point. But this function just states an
infoWindow variable. 
Should we set it on the map either?
 Like adding "infoWindow.open(map, circle);" at bottom?

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode125
Trace6/index.html:125: strokeWeight: 1 // to be weighted according to number of
paths that go across the link
Nice change here!

[manu_chaud, 2017-10-22 22:06:40]

https://codereview.appspot.com/337760043/diff/1/Sample_Points_Prototype/outpu...
File Sample_Points_Prototype/output_xml.php (right):

https://codereview.appspot.com/337760043/diff/1/Sample_Points_Prototype/outpu...
Sample_Points_Prototype/output_xml.php:38: 
This change shoudln't have occurred

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html
File Trace6/index.html (right):

https://codereview.appspot.com/337760043/diff/1/Trace6/index.html#newcode65
Trace6/index.html:65: function addInfoWindow(coords, content) {
On 2017/10/22 21:16:58, Wei Wang wrote:
> Yes, we should add an InfoWindow for a point. But this function just states an
> infoWindow variable. 
> Should we set it on the map either?
>  Like adding "infoWindow.open(map, circle);" at bottom?

Oh! How I could miss it. Fixed in the next patch.

[brahim Al-Qaysi, 2017-10-24 20:31:21]

https://codereview.appspot.com/337760043/diff/40001/Trace6/index.html
File Trace6/index.html (left):

https://codereview.appspot.com/337760043/diff/40001/Trace6/index.html#oldcode34
Trace6/index.html:34: /**
this comment made it more understandable. Thank you

[manu_chaud, 2017-10-25 11:22:44]

Patch 4 contains the last changes made to the code yesterday evening (bug
prevented me to upload the code to appspot at the time): it adds a UI to the map
with 22 paths going through submarine cables, in order to filter paths by cable
id, as shown in the today's demo

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html
File Trace6/index.html (right):

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html#newcode86
Trace6/index.html:86: var polylines = new Array();
We will store the Polyline objects here, in order to be able to make them
appear/disappear of the map.

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html#newcode99
Trace6/index.html:99: var HopObj = new Array();
Let's mention that HopObj is not being used for the time being.

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html#newcode107
Trace6/index.html:107: 3: [7,8,9,16,17,18,21]};
Here, we map path ids to cable ids, in order to know which path belong to which
cable, to be able to filter the paths being displayed by cable id.

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html#newcode230
Trace6/index.html:230: polylines.push({idPath: i, polyline: polyline});
Polyline objects are added to the polylines array here.

https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html#newcode276
Trace6/index.html:276: polylines[i].polyline.setMap(map);
When selecting a cable id to display the paths that go through it, we check for
each Polyline object if its idPath correspond to a path that belongs to that
cable (thanks to the "cables" object that maps path ids to cable ids), and then,
display it using the setMap method of the Polyline object.

[farzad2050, 2017-10-27 12:42:53]

Understandable, accurate and concrete amount of information about all
elements in the map.

On 25 Oct 2017 13:22, <manu.chaud.18@gmail.com> wrote:

Patch 4 contains the last changes made to the code yesterday evening
(bug prevented me to upload the code to appspot at the time): it adds a
UI to the map with 22 paths going through submarine cables, in order to
filter paths by cable id, as shown in the today's demo


https://codereview.appspot.com/337760043/diff/60001/Trace6/index.html
File Trace6/index.html (right):

https://codereview.appspot.com/337760043/diff/60001/Trace6/
index.html#newcode86
Trace6/index.html:86: var polylines = new Array();
We will store the Polyline objects here, in order to be able to make
them appear/disappear of the map.

https://codereview.appspot.com/337760043/diff/60001/Trace6/
index.html#newcode99
Trace6/index.html:99: var HopObj = new Array();
Let's mention that HopObj is not being used for the time being.

https://codereview.appspot.com/337760043/diff/60001/Trace6/
index.html#newcode107
Trace6/index.html:107: 3: [7,8,9,16,17,18,21]};
Here, we map path ids to cable ids, in order to know which path belong
to which cable, to be able to filter the paths being displayed by cable
id.

https://codereview.appspot.com/337760043/diff/60001/Trace6/
index.html#newcode230
Trace6/index.html:230: polylines.push({idPath: i, polyline: polyline});
Polyline objects are added to the polylines array here.

https://codereview.appspot.com/337760043/diff/60001/Trace6/
index.html#newcode276
Trace6/index.html:276: polylines[i].polyline.setMap(map);
When selecting a cable id to display the paths that go through it, we
check for each Polyline object if its idPath correspond to a path that
belongs to that cable (thanks to the "cables" object that maps path ids
to cable ids), and then, display it using the setMap method of the
Polyline object.

https://codereview.appspot.com/337760043/