Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2548)

Issue 337560043: issue #1493: Problem with horizontal beams

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by Be-3
Modified:
1 week, 1 day ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

issue #1493: Problem with horizontal beams file: lily/beam-quanting.cc In spite of infinite damping, due to numeric precision problems (rounding/adding) the resulting beams arbitrarily still had a remaining non-zero slope, sometimes even in the "wrong" direction. In good TeX manner and in line with concaveness (already implemented), we'll use a threshold value of 10000 for forcing horizontal beams.

Patch Set 1 #

Total comments: 3

Patch Set 2 : off-topic check for division by 0 added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lily/beam-quanting.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM!
1 week, 1 day ago (2018-02-10 12:40:30 UTC) #1
Dan Eble
LGTM, though I have a couple of observations. https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc File lily/beam-quanting.cc (right): https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc#newcode717 lily/beam-quanting.cc:717: if ...
1 week, 1 day ago (2018-02-10 13:26:35 UTC) #2
Be-3
https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc File lily/beam-quanting.cc (right): https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc#newcode717 lily/beam-quanting.cc:717: if ((concaveness >= 10000) || (damping >= 10000)) On ...
1 week, 1 day ago (2018-02-10 13:37:40 UTC) #3
Be-3
1 week, 1 day ago (2018-02-10 14:38:39 UTC) #4
off-topic check for division by 0 added
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d