Issue 337530043: ticket:13443 Change digit width types to int16_t and change maximum setting to 999. Adds test for t…

Issue 337530043: ticket:13443 Change digit width types to int16_t and change maximum setting to 999. Adds test for t… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by sffc

Modified:
6 years, 1 month ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/

Visibility:
Public.

More Reviews

Description

ticket:13443 Change digit width types to int16_t and change maximum setting to 999. Adds test for this behavior in ICU4C. Also adds the new error code for ticket:13577.

Patch Set 2 : Changing error code name in accordance with meeting this morning. #

Patch Set 3 : Adding missing file number_padding.cpp #

Total comments: 3

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -81 lines)			Patch
M	icu4c/source/common/unicode/utypes.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	icu4c/source/common/utypes.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	icu4c/source/i18n/number_integerwidth.cpp	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
M	icu4c/source/i18n/number_notation.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	icu4c/source/i18n/number_padding.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	icu4c/source/i18n/number_rounding.cpp	View	1	10 chunks	+26 lines, -26 lines	0 comments	Download
M	icu4c/source/i18n/number_types.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	icu4c/source/i18n/unicode/numberformatter.h	View	1	6 chunks	+26 lines, -18 lines	1 comment	Download
M	icu4c/source/test/intltest/intltest.h	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	icu4c/source/test/intltest/intltest.cpp	View	1	2 chunks	+29 lines, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/numbertest.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/numbertest_api.cpp	View	1	3 chunks	+66 lines, -9 lines	2 comments	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

sffc

Changing error code name in accordance with meeting this morning.

6 years, 2 months ago (2018-02-08 06:03:14 UTC) #2

sffc

Changing error code name in accordance with meeting this morning.

6 years, 2 months ago (2018-02-08 06:03:40 UTC) #3

sffc

Changing error code name in accordance with meeting this morning.

6 years, 2 months ago (2018-02-08 06:04:31 UTC) #4

sffc

I committed this as r40866 because I needed some of the changes for my branch, ...

6 years, 2 months ago (2018-02-08 06:06:36 UTC) #6

andy.heninger

https://codereview.appspot.com/337530043/diff/80001/icu4c/source/i18n/unicode/numberformatter.h File icu4c/source/i18n/unicode/numberformatter.h (right): https://codereview.appspot.com/337530043/diff/80001/icu4c/source/i18n/unicode/numberformatter.h#newcode1180 icu4c/source/i18n/unicode/numberformatter.h:1180: union { Using a union here doesn't save anything. ...

6 years, 2 months ago (2018-02-20 23:38:42 UTC) #7

sffc

6 years, 1 month ago (2018-03-01 01:03:10 UTC) #8

Committed the one change as r41026.

https://codereview.appspot.com/337530043/diff/80001/icu4c/source/test/intltes...
File icu4c/source/test/intltest/numbertest_api.cpp (right):

https://codereview.appspot.com/337530043/diff/80001/icu4c/source/test/intltes...
icu4c/source/test/intltest/numbertest_api.cpp:1753: (UBool) TRUE,
On 2018/02/20 23:38:40, andy.heninger wrote:
> Seems like a place to use the newly added UErrorCode overload of
assertEquals().

Done.

Expand All Messages | Collapse All Messages