Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 337400043: add a generic markFormatter function

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Malte Meyn
Modified:
6 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add a generic markFormatter function This uses a modified version of the code as seen at https://lists.gnu.org/archive/html/lilypond-user/2016-05/msg00156.html All existing markFormatter functions (like f. e. format-mark-box-letters) are redefined using format-mark-generic. Also, the markup commands markletter and markalphabet are redefined and markgeneric is added. Documentation strings should be added and it should be mentioned in the NR. Maybe a better user interface (other than 4 booleans in a row) would be nice to have.

Patch Set 1 #

Patch Set 2 : add doc string for markup command \markgeneric #

Total comments: 1

Patch Set 3 : improve user interface, remove markup command \markgeneric #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -64 lines) Patch
A input/regression/rehearsal-mark-formatters.ly View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 3 chunks +20 lines, -23 lines 0 comments Download
M scm/translation-functions.scm View 1 2 2 chunks +72 lines, -41 lines 0 comments Download

Messages

Total messages: 10
Malte Meyn
add doc string for markup command \markgeneric
6 years, 2 months ago (2018-01-04 23:13:57 UTC) #1
lemzwerg
https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm File scm/translation-functions.scm (right): https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm#newcode86 scm/translation-functions.scm:86: (define-public (format-mark-generic alphabet framed bold? uppercase? repeat?) What about ...
6 years, 2 months ago (2018-01-05 06:43:50 UTC) #2
Malte Meyn
On 2018/01/05 06:43:50, lemzwerg wrote: > https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm > File scm/translation-functions.scm (right): > > https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm#newcode86 > ...
6 years, 2 months ago (2018-01-05 08:06:17 UTC) #3
lemzwerg
> > What about using a list of keys instead of the last five arguments, ...
6 years, 2 months ago (2018-01-05 08:23:05 UTC) #4
Malte Meyn
On 2018/01/05 08:23:05, lemzwerg wrote: > > > What about using a list of keys ...
6 years, 2 months ago (2018-01-05 08:26:11 UTC) #5
Malte Meyn
On 2018/01/05 08:26:11, Malte Meyn wrote: > On 2018/01/05 08:23:05, lemzwerg wrote: > > Hmm, ...
6 years, 2 months ago (2018-01-05 08:30:08 UTC) #6
lemzwerg
> \set Score.markFormatter = \format-mark-generic alphabet,circle,repeat,mixedcase Whatever :-) Note that the advantage of a parameter ...
6 years, 2 months ago (2018-01-05 08:49:10 UTC) #7
Malte Meyn
While implementing these changes two questions came up: 1. Do we need a markup command ...
6 years, 2 months ago (2018-01-05 12:16:04 UTC) #8
Malte Meyn
improve user interface, remove markup command \markgeneric
6 years, 2 months ago (2018-01-06 13:06:51 UTC) #9
lemzwerg
6 years, 2 months ago (2018-01-06 13:27:47 UTC) #10
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b