Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1298)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 337140043: [plaso] Split event data from event (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Joachim Metz
Modified:
6 years, 3 months ago
Reviewers:
onager
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Split event data from event

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changes for splitting event data from event #

Total comments: 8

Patch Set 3 : Changes after merge #

Total comments: 4

Patch Set 4 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -132 lines) Patch
M config/end-to-end.ini View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M config/tests/generate_test_files.sh View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/containers/interface.py View 1 chunk +9 lines, -1 line 0 comments Download
M plaso/parsers/mediator.py View 1 2 8 chunks +35 lines, -8 lines 0 comments Download
M plaso/storage/fake_storage.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M plaso/storage/sqlite_file.py View 1 2 3 43 chunks +171 lines, -87 lines 0 comments Download
A + test_data/pinfo_test.plaso View 1 2 Binary file 0 comments Download
D test_data/pinfo_test.json.plaso View 1 2 Binary file 0 comments Download
A + test_data/psort_test.plaso View 1 2 Binary file 0 comments Download
D test_data/psort_test.json.plaso View 1 2 Binary file 0 comments Download
M tests/cli/pinfo_tool.py View 1 2 5 chunks +11 lines, -5 lines 0 comments Download
M tests/cli/psort_tool.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests/cli/psteal_tool.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/containers/interface.py View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/multi_processing/psort.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M tests/storage/event_tag_index.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/storage/factory.py View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M tests/storage/sqlite_file.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20
Joachim Metz
6 years, 5 months ago (2017-11-26 17:41:11 UTC) #1
Joachim Metz
For reviewer putting this out there, but needs more end-to-end testing.
6 years, 5 months ago (2017-11-26 17:42:44 UTC) #2
onager
LGTM, with one clarification https://codereview.appspot.com/337140043/diff/1/plaso/parsers/mediator.py File plaso/parsers/mediator.py (right): https://codereview.appspot.com/337140043/diff/1/plaso/parsers/mediator.py#newcode601 plaso/parsers/mediator.py:601: # contain event data for ...
6 years, 4 months ago (2017-12-27 13:24:38 UTC) #3
Joachim Metz
This CL needs some love, tests are failing as well https://ci.appveyor.com/project/joachimmetz/plaso/build/3735
6 years, 4 months ago (2017-12-27 17:24:29 UTC) #4
Joachim Metz
fixed unit test, end-to-end tests still failing.
6 years, 4 months ago (2017-12-28 06:04:01 UTC) #5
Joachim Metz
Code updated.
6 years, 3 months ago (2017-12-29 06:57:29 UTC) #6
Joachim Metz
Code updated.
6 years, 3 months ago (2017-12-30 19:13:16 UTC) #7
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-01 16:30:12 UTC) #8
Joachim Metz
PTAL
6 years, 3 months ago (2018-01-01 16:30:32 UTC) #9
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-01 16:54:40 UTC) #10
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-01 17:01:09 UTC) #11
onager
https://codereview.appspot.com/337140043/diff/100001/plaso/parsers/mediator.py File plaso/parsers/mediator.py (right): https://codereview.appspot.com/337140043/diff/100001/plaso/parsers/mediator.py#newcode420 plaso/parsers/mediator.py:420: # Note that we use getattr here since event ...
6 years, 3 months ago (2018-01-02 10:23:24 UTC) #12
Joachim Metz
https://codereview.appspot.com/337140043/diff/100001/plaso/parsers/mediator.py File plaso/parsers/mediator.py (right): https://codereview.appspot.com/337140043/diff/100001/plaso/parsers/mediator.py#newcode420 plaso/parsers/mediator.py:420: # Note that we use getattr here since event ...
6 years, 3 months ago (2018-01-02 16:20:32 UTC) #13
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-02 16:29:24 UTC) #14
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-03 07:48:37 UTC) #15
onager
https://codereview.appspot.com/337140043/diff/140001/plaso/storage/sqlite_file.py File plaso/storage/sqlite_file.py (right): https://codereview.appspot.com/337140043/diff/140001/plaso/storage/sqlite_file.py#newcode33 plaso/storage/sqlite_file.py:33: _CONTAINER_TYPE_ANALYSIS_REPORT = 'analysis_report' Please use the type as defined ...
6 years, 3 months ago (2018-01-03 19:48:09 UTC) #16
Joachim Metz
https://codereview.appspot.com/337140043/diff/140001/plaso/storage/sqlite_file.py File plaso/storage/sqlite_file.py (right): https://codereview.appspot.com/337140043/diff/140001/plaso/storage/sqlite_file.py#newcode33 plaso/storage/sqlite_file.py:33: _CONTAINER_TYPE_ANALYSIS_REPORT = 'analysis_report' On 2018/01/03 19:48:09, onager wrote: > ...
6 years, 3 months ago (2018-01-03 20:07:07 UTC) #17
Joachim Metz
Code updated.
6 years, 3 months ago (2018-01-03 20:15:30 UTC) #18
onager
On 2018/01/03 20:15:30, Joachim Metz wrote: > Code updated. LGTM
6 years, 3 months ago (2018-01-03 21:49:17 UTC) #19
Joachim Metz
6 years, 3 months ago (2018-01-04 05:16:02 UTC) #20 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close eventdata2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b